commit befc17614b54f191beabbc5f24b473ddbd7e26ca Author: Damian Johnson <atagar@torproject.org> Date: Sun May 10 13:51:40 2015 -0700 Missing assertion for test_using_ephemeral_hidden_services We're not using this test yet since I couldn't get it working. Still busted, but tweaking it a tad so our pyflakes checks are happier. --- test/integ/control/controller.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/integ/control/controller.py b/test/integ/control/controller.py index 2557dfe..7890dcc 100644 --- a/test/integ/control/controller.py +++ b/test/integ/control/controller.py @@ -700,7 +700,7 @@ class TestController(unittest.TestCase): return with test.runner.get_runner().get_tor_controller() as controller: - incoming_socket, incoming_address = None, None + incoming_address = None, None def run_server(): serversocket = socket.socket(socket.AF_INET, socket.SOCK_STREAM) @@ -721,6 +721,8 @@ class TestController(unittest.TestCase): s.connect(('%s.onion' % response.service_id, 80)) print s.read() + self.assertTrue(incoming_address is not None) + server_thread.join() @require_controller