commit 7816ba8f1a3381d28d78aa7812f1c26edd7cdd0e Author: Nick Mathewson nickm@torproject.org Date: Thu May 28 12:27:22 2015 -0400
Add assertions to crypto_dh_dup()
Without these, coverity is annoyed that aren't checking for NULL in bench.c
CID 1293335 -- found by coverity. --- src/common/crypto.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/common/crypto.c b/src/common/crypto.c index d77d5e2..afaf93a 100644 --- a/src/common/crypto.c +++ b/src/common/crypto.c @@ -1979,6 +1979,8 @@ crypto_dh_t * crypto_dh_dup(const crypto_dh_t *dh) { crypto_dh_t *dh_new = tor_malloc_zero(sizeof(crypto_dh_t)); + tor_assert(dh); + tor_assert(dh->dh); dh_new->dh = dh->dh; DH_up_ref(dh->dh); return dh_new;
tor-commits@lists.torproject.org