commit bfb900e426e5eb043bfe20a198d9451abad89644 Author: Robert Ransom rransom.8774@gmail.com Date: Mon Nov 7 15:32:43 2011 -0800

Add some XXXes --- src/or/control.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/or/control.c b/src/or/control.c index 52af4a0..7785ec5 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -1597,6 +1597,8 @@ getinfo_helper_dir(control_connection_t *control_conn, *answer = tor_strndup(body, ri->cache_info.signed_descriptor_len); } } else if (!strcmpstart(question, "desc/name/")) { + /* XXX023 Setting 'warn_if_unnamed' here is a bit silly -- the + * warning goes to the user, not to the controller. */ ri = router_get_by_nickname(question+strlen("desc/name/"),1); if (ri) { const char *body = signed_descriptor_get_body(&ri->cache_info); @@ -1649,7 +1651,10 @@ getinfo_helper_dir(control_connection_t *control_conn, *answer = tor_strndup(md->body, md->bodylen); } } else if (!strcmpstart(question, "md/name/")) { + /* XXX023 Setting 'warn_if_unnamed' here is a bit silly -- the + * warning goes to the user, not to the controller. */ const node_t *node = node_get_by_nickname(question+strlen("md/name/"), 1); + /* XXXX duplicated code */ const microdesc_t *md = NULL; if (node) md = node->md; if (md) {