commit 4581c355d64f3241d649256d4e14d839aedc9ea5 Author: Damian Johnson <atagar@torproject.org> Date: Wed Jun 13 09:27:47 2012 -0700 Adding todo notes around the stupid concessions to 2.5 I hate dirtying our code for ye old python 2.5. It's ancient and that fact isn't getting rosier very fast. However, a lot of people still use it so we should still support it for now. This won't always be the case so including TODO notes to remove these icky bits when we drop compatability for it. --- stem/control.py | 1 + stem/util/conf.py | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/stem/control.py b/stem/control.py index 09c61e4..47b08c9 100644 --- a/stem/control.py +++ b/stem/control.py @@ -309,6 +309,7 @@ class BaseController: # Any changes to our is_alive() state happen under the send lock, so we # need to have it to ensure it doesn't change beneath us. + # TODO: when we drop python 2.5 compatability we can simplify this with self._socket._get_send_lock(): with self._status_listeners_lock: change_timestamp = time.time() diff --git a/stem/util/conf.py b/stem/util/conf.py index 3f1865a..79291c0 100644 --- a/stem/util/conf.py +++ b/stem/util/conf.py @@ -280,6 +280,7 @@ class Config(): elif not self._path: raise ValueError("Unable to save configuration: no path provided") + # TODO: when we drop python 2.5 compatability we can simplify this with self._contents_lock: with open(self._path, 'w') as output_file: for entry_key in sorted(self.keys()):