commit d95678ca8f97ac6e648598af01b4394840999e72 Author: Chelsea H. Komlo chelsea.komlo@gmail.com Date: Wed Dec 21 11:42:05 2016 -0500
make distcheck should be a part of the local development process --- doc/HACKING/CodingStandards.md | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/doc/HACKING/CodingStandards.md b/doc/HACKING/CodingStandards.md index 009047d..9932c77 100644 --- a/doc/HACKING/CodingStandards.md +++ b/doc/HACKING/CodingStandards.md @@ -8,6 +8,7 @@ tl;dr: - Document your functions - Write unit tests - Run `make test-full` to test against all unit and integration tests. + - Run `make distcheck` to ensure the distribution works - Add a file in `changes` for your branch.
Patch checklist @@ -29,6 +30,7 @@ Did you remember... - To write unit tests, as possible? - To run `make test-full` to test against all unit and integration tests (or `make test-full-online` if you have a working connection to the internet)? + - To test that the distribution will actually work via `make distcheck`? - To base your code on the appropriate branch? - To include a file in the `changes` directory as appropriate?
tor-commits@lists.torproject.org