commit c9de65f96685fd54029f284a043cefd970061956 Author: Alexander Færøy ahf@torproject.org Date: Wed Jul 11 16:19:56 2018 +0200
Add checks in get_net_param_from_list() for valid output domain.
This patch adds two assertions in get_net_param_from_list() to ensure that the `res` value is correctly within the range of the output domain.
Hopefully fixes Coverity CID #1415721, #1415722, and #1415723.
See: https://bugs.torproject.org/26780 --- src/feature/nodelist/networkstatus.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/feature/nodelist/networkstatus.c b/src/feature/nodelist/networkstatus.c index e9d36cbdc..f8623f826 100644 --- a/src/feature/nodelist/networkstatus.c +++ b/src/feature/nodelist/networkstatus.c @@ -2417,6 +2417,8 @@ get_net_param_from_list(smartlist_t *net_params, const char *param_name, res = max_val; }
+ tor_assert(res >= min_val); + tor_assert(res <= max_val); return res; }
tor-commits@lists.torproject.org