commit 81e3deeb54d2f3d022655c6a51f966ef44bf6fb3 Author: Nick Mathewson nickm@torproject.org Date: Fri Sep 4 09:30:59 2015 -0400

Fix an alignment issue in our extensions to ed25519_donna

Apparently this only happens with clang (or with some particular clang versions), and only on i386.

Fixes 16970; bug not in any released Tor.

Found by Teor; fix from Yawning. --- src/ext/ed25519/donna/ed25519_tor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ext/ed25519/donna/ed25519_tor.c b/src/ext/ed25519/donna/ed25519_tor.c index 7f5894d..12493f7 100644 --- a/src/ext/ed25519/donna/ed25519_tor.c +++ b/src/ext/ed25519/donna/ed25519_tor.c @@ -323,7 +323,7 @@ int ed25519_donna_pubkey_from_curve25519_pubkey(unsigned char *out, const unsigned char *inp, int signbit) { - static const bignum25519 one = { 1 }; + static const bignum25519 ALIGN(16) one = { 1 }; bignum25519 ALIGN(16) u, uminus1, uplus1, inv_uplus1, y;

/* Prop228: y = (u-1)/(u+1) */