commit 27e870cede731af83748768db26187d003905ff2 Author: Nick Mathewson nickm@torproject.org Date: Tue Aug 2 11:31:52 2016 -0400

Fix most lintChanges warnings

(Also remove changes/bug19530 since it was a bugfix on no released version) --- changes/assert_nonfatal | 3 +-- changes/bug14334 | 2 +- changes/bug15942 | 4 ++-- changes/bug16943 | 2 +- changes/bug17688 | 2 +- changes/bug17983 | 2 +- changes/bug18604 | 6 +++--- changes/bug18704 | 6 +++--- changes/bug18840 | 2 +- changes/bug18963 | 4 ++-- changes/bug19066 | 2 +- changes/bug19153 | 2 +- changes/bug19216 | 2 +- changes/bug19421 | 2 +- changes/bug19428 | 4 ++-- changes/bug19483 | 2 +- changes/bug19530 | 6 ------ changes/bug19554 | 2 +- changes/bug19702 | 2 +- changes/feature18624 | 2 +- changes/feature18760 | 2 +- changes/feature18998 | 2 +- changes/feature19036 | 2 +- changes/feature19116 | 2 +- changes/lcov_excl | 2 +- changes/ticket18462 | 2 +- changes/ticket19323 | 4 ++-- changes/timeouts | 2 +- 28 files changed, 35 insertions(+), 42 deletions(-)

diff --git a/changes/assert_nonfatal b/changes/assert_nonfatal index 0cbee44..9cb7ade 100644 --- a/changes/assert_nonfatal +++ b/changes/assert_nonfatal @@ -1,5 +1,4 @@ o Minor features (safety, debugging): - - * Add a set of macros to check nonfatal assertions, for internal + - Add a set of macros to check nonfatal assertions, for internal use. Migrating more of our checks to these should help us avoid needless crash bugs. Closes ticket 18613. diff --git a/changes/bug14334 b/changes/bug14334 index c53781e..12b1a20 100644 --- a/changes/bug14334 +++ b/changes/bug14334 @@ -1,4 +1,4 @@ o Minor bugfixes (guards): - Don't mark guards as unreachable if connection_connect() fails. That function fails for local reasons, so it shouldn't reveal anything about - the status of the guard. Fixes bug #14334; bugfix on 0.2.3.10-alpha. + the status of the guard. Fixes bug 14334; bugfix on 0.2.3.10-alpha. diff --git a/changes/bug15942 b/changes/bug15942 index 0edc2b7..8426025 100644 --- a/changes/bug15942 +++ b/changes/bug15942 @@ -1,3 +1,3 @@ - o Bugfixes (downloading): + o Minor features (downloading): - Use random exponential backoffs when retrying downloads from the dir - servers. Fixes bug 15942; bugfix on ?????. + servers. Closes ticket 15942. diff --git a/changes/bug16943 b/changes/bug16943 index 7b96d1a..3278d7b 100644 --- a/changes/bug16943 +++ b/changes/bug16943 @@ -5,4 +5,4 @@ global randomness will be used by hidden services to select their responsible HSDirs. This release only implements the directory authority feature; the hidden service side will be implemented in the future as - part of proposal 224 . Resolves ticket #16943 and proposal 250. + part of proposal 224 . Resolves ticket 16943; implements proposal 250. diff --git a/changes/bug17688 b/changes/bug17688 index aae6008..5e5fb05 100644 --- a/changes/bug17688 +++ b/changes/bug17688 @@ -1,3 +1,3 @@ o Minor bugfixes (guard selection): - Use a single entry guard even if the NumEntryGuards consensus parameter - is not provided. Fixes bug #17688. + is not provided. Fixes bug 17688. diff --git a/changes/bug17983 b/changes/bug17983 index db52a37..a099e1c 100644 --- a/changes/bug17983 +++ b/changes/bug17983 @@ -1,4 +1,4 @@ - o Minor features (bug-finding): + o Major features (build, hardening): - Tor now builds with -ftrapv by default on compilers that support it. This option detects signed integer overflow, and turns it into a hard-failure. We do not apply this option to code that needs to run diff --git a/changes/bug18604 b/changes/bug18604 index 114c67e..7d1d37f 100644 --- a/changes/bug18604 +++ b/changes/bug18604 @@ -1,4 +1,4 @@ - o Minor bugfixes (ephemeral hidden service) + o Minor bugfixes (ephemeral hidden service): - When deleting an ephemeral hidden service, close its intro points even - if not in the open state. Resolves ticket #18604; bugfix on - tor-0.2.7.1-alpha. + if not in the open state. Fixes bug 18604; bugfix on + 0.2.7.1-alpha. diff --git a/changes/bug18704 b/changes/bug18704 index 966cc2a..4280b74 100644 --- a/changes/bug18704 +++ b/changes/bug18704 @@ -1,5 +1,5 @@ - o Major bugfixes (hidden service client) + o Major bugfixes (hidden service client): - With FetchHidServDescriptors set to 0, there is no descriptor fetch (which is intended) but also no descriptor cache lookup was done - making any Tor client not working with this option unset. Resolves - ticket #18704. Patch by "twim"; Bugfix on tor-0.2.0.20-rc. + making any Tor client not working with this option unset. Fixes + bug 18704; bugfix on 0.2.0.20-rc. Patch by "twim". diff --git a/changes/bug18840 b/changes/bug18840 index b8de1aa..653b946 100644 --- a/changes/bug18840 +++ b/changes/bug18840 @@ -1,4 +1,4 @@ - o Minor bugfixes: + o Minor bugfixes (directory authority): - Authorities now sort the "package" lines in their votes, for ease of debugging. (They are already sorted in the consensus documents.) Fixes bug 18840; bugfix on 0.2.6.3-alpha. diff --git a/changes/bug18963 b/changes/bug18963 index f122288..eb68792 100644 --- a/changes/bug18963 +++ b/changes/bug18963 @@ -1,5 +1,5 @@ - o Minor bugfix (bootstrap): + o Minor bugfixes (bootstrap): - Remember the directory we fetched the consensus or previous certificates from, and use it to fetch future authority certificates. - Resolves ticket 18963; fix on #4483 in 0.2.8.1-alpha. + Fixes bug 18963; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug19066 b/changes/bug19066 index c3d1fc7..a0f6ff3 100644 --- a/changes/bug19066 +++ b/changes/bug19066 @@ -2,4 +2,4 @@ - When parsing detached signature, make sure we use the length of the digest algorithm instead of an hardcoded DIGEST256_LEN in order to avoid comparing bytes out of bound with a smaller digest length such - as SHA1. Fixes #19066; bugfix on tor-0.2.2.6-alpha. + as SHA1. Fixes bug 19066; bugfix on 0.2.2.6-alpha. diff --git a/changes/bug19153 b/changes/bug19153 index ac235c5..e3692e4 100644 --- a/changes/bug19153 +++ b/changes/bug19153 @@ -1,3 +1,3 @@ o Documentation: - Fix spelling of "--enable-tor2web-mode" in the manpage. Closes - ticket #19153. Patch from "U+039b". + ticket 19153. Patch from "U+039b". diff --git a/changes/bug19216 b/changes/bug19216 index 0bca7d1..ffdbe6d 100644 --- a/changes/bug19216 +++ b/changes/bug19216 @@ -1,4 +1,4 @@ - o Minor bugfixes: + o Minor bugfixes (compilation): - When building with Clang, include our full array of GCC warnings. (Previously, we included only a subset, because of the way we detected them.) Fixes bug 19216; bugfix on 0.2.0.1-alpha. diff --git a/changes/bug19421 b/changes/bug19421 index c7aba26..028a754 100644 --- a/changes/bug19421 +++ b/changes/bug19421 @@ -1,4 +1,4 @@ o Minor bugfixes (testing): - Fix the test-network-all target on out-of-tree builds by using the - correct path to the test driver script. Fixes bug #19421; bugfix on + correct path to the test driver script. Fixes bug 19421; bugfix on 0.2.7.3-rc. diff --git a/changes/bug19428 b/changes/bug19428 index 32d293e..e966596 100644 --- a/changes/bug19428 +++ b/changes/bug19428 @@ -1,5 +1,5 @@ - - Minor bugfixes (timing): - o When computing the difference between two times in milliseconds, + o Minor bugfixes (timing): + - When computing the difference between two times in milliseconds, we now round to the nearest millisecond correctly. Previously, we could sometimes round in the wrong direction. Fixes bug 19428; bugfix on 0.2.2.2-alpha. diff --git a/changes/bug19483 b/changes/bug19483 index 034ff30..9879497 100644 --- a/changes/bug19483 +++ b/changes/bug19483 @@ -1,3 +1,3 @@ - o Minor fixes (time): + o Minor bugfixes (time): - Improve overflow checks in tv_udiff and tv_mdiff. Fixes bug 19483, present in all tor versions. diff --git a/changes/bug19530 b/changes/bug19530 deleted file mode 100644 index 355d778..0000000 --- a/changes/bug19530 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (directory downloads): - - Hex-encode a relay identity fingerprint before printing it. - - When downloading authority certificates, re-download from - the last successful bridge before retrying a random bridge. - Fixes bug 19530; bugfix on #18963, not in any released version - of tor. diff --git a/changes/bug19554 b/changes/bug19554 index 5855586..d67a0bd 100644 --- a/changes/bug19554 +++ b/changes/bug19554 @@ -1,4 +1,4 @@ - o Dependency changes (Libevent) + o New system requirements: - Tor requires Libevent version 2.0.10-stable or later now. Implements ticket 19554.

diff --git a/changes/bug19702 b/changes/bug19702 index 4ec2699..093511a 100644 --- a/changes/bug19702 +++ b/changes/bug19702 @@ -1,3 +1,3 @@ o Minor bugfixes (test networks): - Allow clients to retry HSDirs much faster in test networks. - Fixes bug #19702; bugfix on 0.2.7.1-alpha. Patch by teor. + Fixes bug 19702; bugfix on 0.2.7.1-alpha. Patch by teor. diff --git a/changes/feature18624 b/changes/feature18624 index a3be90f..8b4a608 100644 --- a/changes/feature18624 +++ b/changes/feature18624 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (directory authority): - Directory authorities now only give the Guard flag to a relay if they are also giving it the Stable flag. This change allows us to simplify path selection for clients, and it should have minimal diff --git a/changes/feature18760 b/changes/feature18760 index e6e8f6a..c0a9103 100644 --- a/changes/feature18760 +++ b/changes/feature18760 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (relay, usability): - When the directory authorities refuse a bad relay's descriptor, encourage the relay operator to contact us. Many relay operators won't notice this line in their logs, but it's a win if even a diff --git a/changes/feature18998 b/changes/feature18998 index a2679c0..bd0a382 100644 --- a/changes/feature18998 +++ b/changes/feature18998 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (hidden service): - Stop being so strict about the payload length of "rendezvous1" cells. We used to be locked in to the "tap" handshake length, and now we can handle better handshakes like "ntor". Resolves diff --git a/changes/feature19036 b/changes/feature19036 index 98bcfca..e2379b4 100644 --- a/changes/feature19036 +++ b/changes/feature19036 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (directory authority): - Make directory authorities write the v3-status-votes file out to disk earlier in the consensus process, so we have the votes even if we abort the consensus process below. Resolves ticket 19036. diff --git a/changes/feature19116 b/changes/feature19116 index 4f6af5f..ab0c767 100644 --- a/changes/feature19116 +++ b/changes/feature19116 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (testing): - Move the test-network.sh script to chutney, and modify tor's test-network.sh to call the (newer) chutney version when available. Resolves ticket 19116. Patch by teor. diff --git a/changes/lcov_excl b/changes/lcov_excl index 474181c..f8a01af 100644 --- a/changes/lcov_excl +++ b/changes/lcov_excl @@ -2,6 +2,6 @@ - Use the lcov convention for marking lines as unreachable, so that we don't count them when we're generating test coverage data. Update our coverage tools to understand this convention. - Closes ticket #16792. + Closes ticket 16792.

diff --git a/changes/ticket18462 b/changes/ticket18462 index 04e7e60..2f7a5f8 100644 --- a/changes/ticket18462 +++ b/changes/ticket18462 @@ -1,3 +1,3 @@ o Code simplification and refactoring: - Rename tor_dup_addr() to tor_addr_to_str_dup() to avoid confusion. - Closes ticket #18462; patch from "icanhasaccount". + Closes ticket 18462; patch from "icanhasaccount". diff --git a/changes/ticket19323 b/changes/ticket19323 index 38e5af4..022a280 100644 --- a/changes/ticket19323 +++ b/changes/ticket19323 @@ -1,3 +1,3 @@ - o Control port: + o Minor features (control port): - Implement new GETINFO queries for all downloads using download_status_t - to schedule retries. Closes ticket #19323. + to schedule retries. Closes ticket 19323. diff --git a/changes/timeouts b/changes/timeouts index dc8f724..a4efb6a 100644 --- a/changes/timeouts +++ b/changes/timeouts @@ -3,5 +3,5 @@ support tens or hundreds of thousands of concurrent timers, as will be needed for some of our planned anti-traffic-analysis work. This code is based on William Ahern's "timeout.c" project, which implements - a "tickless hierarchical timing wheel". Closes ticket #18365. + a "tickless hierarchical timing wheel". Closes ticket 18365.