commit 1d9de2948b7e40a0044dd1651b0c8cb407a8a2fd Author: Nick Mathewson nickm@torproject.org Date: Mon Jul 12 14:59:29 2021 -0400

test_hs_control: initialize pointers to NULL

This is an attempt to fix CID 1486276, where coverity warns us that, if the tests failed, we might free() an uninitialized pointer. --- src/test/test_hs_control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/test_hs_control.c b/src/test/test_hs_control.c index b036c5eada..c32803b380 100644 --- a/src/test/test_hs_control.c +++ b/src/test/test_hs_control.c @@ -798,7 +798,7 @@ test_hs_control_add_onion_helper_add_service(void *arg) hs_service_ht *global_map; hs_port_config_t *portcfg; smartlist_t *portcfgs; - char *address_out_good, *address_out_bad; + char *address_out_good = NULL, *address_out_bad = NULL; hs_service_t *service_good = NULL; hs_service_t *service_bad = NULL;