commit 7ff67d0e90d1cdf206747649df79dbb88a7467a8 Author: David Goulet dgoulet@torproject.org Date: Mon Sep 10 10:28:35 2018 -0400

test: Fix coverity CID 1439129

One HSv3 unit test used "tor_memeq()" without checking the return value. This commit changes that to use "tt_mem_op()" to actually make the test validate something :).

Signed-off-by: David Goulet dgoulet@torproject.org --- src/test/hs_test_helpers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/test/hs_test_helpers.c b/src/test/hs_test_helpers.c index 4e13ba43a..dcec1b9d4 100644 --- a/src/test/hs_test_helpers.c +++ b/src/test/hs_test_helpers.c @@ -241,11 +241,11 @@ hs_helper_desc_equal(const hs_descriptor_t *desc1, hs_desc_authorized_client_t *client1 = smartlist_get(desc1->superencrypted_data.clients, i), *client2 = smartlist_get(desc2->superencrypted_data.clients, i); - tor_memeq(client1->client_id, client2->client_id, + tt_mem_op(client1->client_id, OP_EQ, client2->client_id, sizeof(client1->client_id)); - tor_memeq(client1->iv, client2->iv, + tt_mem_op(client1->iv, OP_EQ, client2->iv, sizeof(client1->iv)); - tor_memeq(client1->encrypted_cookie, client2->encrypted_cookie, + tt_mem_op(client1->encrypted_cookie, OP_EQ, client2->encrypted_cookie, sizeof(client1->encrypted_cookie)); } }