commit dc86d7c35bd48d12d84feb6f63014904eabe0902 Author: Mike Perry mikeperry-git@fscked.org Date: Sun Nov 25 17:29:16 2012 -0800
Note more potential issues. --- src/or/circuitlist.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/or/circuitlist.c b/src/or/circuitlist.c index eb7fc75..7163c35 100644 --- a/src/or/circuitlist.c +++ b/src/or/circuitlist.c @@ -1383,6 +1383,12 @@ circuit_mark_for_close_(circuit_t *circ, int reason, int line, pathbias_count_collapse(ocirc); } } else if (circ->timestamp_dirty && !ocirc->any_streams_succeeded) { + // XXX: May open up attacks if the adversary can force connections + // on unresponsive hosts to use new circs. Vidalia displayes a "Retrying" + // state.. Can we use that? Does optimistic data change this? + // XXX: For the hidserv side, we could only care about INTRODUCING purposes + // for server+client, and REND purposes for the server... Can we + // somehow only count those? /* Any circuit where there were attempted streams but no successful * streams could be bias */ /* FIXME: This may be better handled by limiting the number of retries