commit 9d869c4f6e2fe9056f95b693092bb6d11a8a5b02 Author: Damian Johnson atagar@torproject.org Date: Sat Feb 21 18:18:22 2015 -0800
Use PROXYTYPE_SOCKS5_HOSTNAME for tutorial example
Michael points out that we leaked our DNS requests in this example. By using PROXYTYPE_SOCKS5_HOSTNAME which was added to pycurl v7.19.5.1 on 2015-01-06 uses the socks proxy for them...
https://github.com/pycurl/pycurl/issues/206 --- docs/tutorials/to_russia_with_love.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/tutorials/to_russia_with_love.rst b/docs/tutorials/to_russia_with_love.rst index 33c04d3..75f9735 100644 --- a/docs/tutorials/to_russia_with_love.rst +++ b/docs/tutorials/to_russia_with_love.rst @@ -107,7 +107,7 @@ Besides SocksiPy, you can also use `PycURL http://pycurl.sourceforge.net/`_ to query.setopt(pycurl.URL, url) query.setopt(pycurl.PROXY, 'localhost') query.setopt(pycurl.PROXYPORT, SOCKS_PORT) - query.setopt(pycurl.PROXYTYPE, pycurl.PROXYTYPE_SOCKS5) + query.setopt(pycurl.PROXYTYPE, pycurl.PROXYTYPE_SOCKS5_HOSTNAME) query.setopt(pycurl.WRITEFUNCTION, output.write)
try: