commit b1632c3fb742f94a6ce0de201653a8c4a9d2887f Author: Nick Mathewson nickm@torproject.org Date: Thu Oct 6 12:57:07 2011 -0400
Fix memory leak in retry_all_listeners: Coverity CID 485 --- src/or/connection.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/or/connection.c b/src/or/connection.c index af05729..bf39a5c 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -1988,13 +1988,13 @@ retry_all_listeners(smartlist_t *replaced_conns, options->ControlListenAddress, options->ControlPort, "127.0.0.1", new_conns, 0) < 0) - return -1; + retval = -1; if (retry_listeners(listeners, CONN_TYPE_CONTROL_LISTENER, options->ControlSocket, options->ControlSocket ? 1 : 0, NULL, new_conns, 1) < 0) - return -1; + retval = -1;
/* Any members that were still in 'listeners' don't correspond to * any configured port. Kill 'em. */