henry pushed to branch tor-browser-149.0a1-16.0-2 at The Tor Project / Applications / Tor Browser Commits: bddfb109 by Henry Wilkes at 2026-04-16T16:25:52+00:00 fixup! TB 23247: Communicating security expectations for .onion TB 43857: Drop TODO since it is "won't do". - - - - - 184592ac by Henry Wilkes at 2026-04-16T16:25:52+00:00 fixup! TB 43564: Modify ./mach bootstrap for Tor Browser TB 43857: Drop TODO since it is "won't do". - - - - - 112b814b by Henry Wilkes at 2026-04-16T16:25:52+00:00 fixup! [android] Disable features and functionality TB 43857: Drop TODO since it is "won't do". - - - - - 8956c706 by Henry Wilkes at 2026-04-16T16:25:52+00:00 fixup! TB 42247: Android helpers for the TorProvider TB 43857: Update TODO and FIXME comments. - - - - - 4 changed files: - browser/base/content/browser-siteIdentity.js - build/moz.configure/torbrowser-resources.configure - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/intent/HomeDeepLinkIntentProcessor.kt - mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorAndroidIntegration.java Changes: ===================================== browser/base/content/browser-siteIdentity.js ===================================== @@ -929,7 +929,6 @@ var gIdentityHandler = { uriIsOnionHost ? "onionMixedDisplayContent" : "mixedDisplayContent" ); } else { - // TODO: ignore weak https cipher for onionsites? this._identityBox.classList.add("weakCipher"); } } else if (this._isCertErrorPage) { ===================================== build/moz.configure/torbrowser-resources.configure ===================================== @@ -24,7 +24,6 @@ option( def tor_expert_bundle(value, mozbuild_state_path, _bootstrapped): if value: path = Path(value[0]) - # TODO: Do a more thorough check on the directory. if path.is_dir(): return value[0] else: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/intent/HomeDeepLinkIntentProcessor.kt ===================================== @@ -133,10 +133,6 @@ class HomeDeepLinkIntentProcessor( } if (BuildConfig.DEEP_LINK_SCHEME.startsWith("torbrowser")) { // tor-browser#42578 - // TODO: - // Maybe just warn users about linkability but - // give them the choice to open anyway, once - // the other deep link related issues are fixed. logger.info("Tor Browser rejects open intent deep link: $deepLink") return } ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorAndroidIntegration.java ===================================== @@ -148,7 +148,14 @@ public class TorAndroidIntegration implements BundleEventListener { } else if (EVENT_SETTINGS_CHANGED.equals(event)) { GeckoBundle newSettings = message.getBundle("settings"); if (newSettings != null) { - // TODO: Should we notify listeners? + // NOTE: We assume that we do not need to notify any consumer with the + // new state because we expect the relevant consumers to read the latest + // state regularly (e.g. each time the settings screen is opened), and + // we only expect one active consumer at any given moment (only one + // setting screen is shown) which means that the single consumer can + // reflect any *expected* individual changes in the UI prior to this + // confirmation signal, and there are no other consumers that need to be + // synchronised with this change. See tor-browser#42384. mSettings = new TorSettings(newSettings); } else { Log.w(TAG, "Ignoring a settings changed event that did not have the new settings."); @@ -345,7 +352,7 @@ public class TorAndroidIntegration implements BundleEventListener { data.putInt("status", 0xdeadbeef); } // FIXME: We usually don't reach this when the application is killed! - // So, we don't do our cleanup. + // So, we don't do our cleanup. Investigation in tor-browser#44861. Log.i(TAG, "Tor process " + mHandle + " has exited."); EventDispatcher.getInstance().dispatch(EVENT_TOR_EXITED, data); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/723952b... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/723952b... You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help