commit 2680a8b5b108ff1532b1aa59849e3156ce76f52b Author: Deepesh Pathak deepshpathak@gmail.com Date: Tue Apr 3 09:17:23 2018 +0530
ticket(25645): remove unused variable n_possible from channel_get_for_extend() --- changes/ticket25645 | 4 ++++ src/or/channel.c | 4 +--- 2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/changes/ticket25645 b/changes/ticket25645 new file mode 100644 index 000000000..ab20a5ca4 --- /dev/null +++ b/changes/ticket25645 @@ -0,0 +1,4 @@ + o Minor bugfixes (channel_get_for_extend()): + - Remove the unused variable n_possible from the function + Fixes bug 25645; bugfix on 0.2.4.4-alpha + diff --git a/src/or/channel.c b/src/or/channel.c index a9483ee02..af2558e1f 100644 --- a/src/or/channel.c +++ b/src/or/channel.c @@ -2387,7 +2387,7 @@ channel_get_for_extend(const char *rsa_id_digest, { channel_t *chan, *best = NULL; int n_inprogress_goodaddr = 0, n_old = 0; - int n_noncanonical = 0, n_possible = 0; + int n_noncanonical = 0;
tor_assert(msg_out); tor_assert(launch_out); @@ -2450,8 +2450,6 @@ channel_get_for_extend(const char *rsa_id_digest, continue; }
- ++n_possible; - if (!best) { best = chan; /* If we have no 'best' so far, this one is good enough. */ continue;