commit c15c8a5af1f7a9a85a092b932f380b4823ebe86d Author: Damian Johnson atagar@torproject.org Date: Wed Oct 31 13:01:49 2018 -0700
Tor stacktraces missing if the crash occures on the last test
Dumb me. We should check if the tor process is running *after* the test, not before. Otherwise tor segfaults that occure during our last test suite go unreported (such as with tor commit 075acf905). --- run_tests.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/run_tests.py b/run_tests.py index bd0839c9..3afc5c9a 100755 --- a/run_tests.py +++ b/run_tests.py @@ -236,11 +236,11 @@ def main(): println('Running tests...\n', STATUS)
for test_class in get_integ_tests(args.specific_test): - if integ_runner.assert_tor_is_running(): - run_result = _run_test(args, test_class, output_filters) - test.output.print_logging(logging_buffer) - skipped_tests += len(getattr(run_result, 'skipped', [])) - else: + run_result = _run_test(args, test_class, output_filters) + test.output.print_logging(logging_buffer) + skipped_tests += len(getattr(run_result, 'skipped', [])) + + if not integ_runner.assert_tor_is_running(): # our tor process died
error_tracker.register_error()