commit 18ea91ee6b3ad2a8088d6fb3361c9a598ceffe83 Author: Nick Mathewson nickm@torproject.org Date: Thu Jan 11 12:46:50 2018 -0500
Make the warnings about restarting tor in-process more scary. --- changes/bug24581 | 3 ++- src/or/tor_api.h | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/changes/bug24581 b/changes/bug24581 index d8ddce3cc..9a5daa01c 100644 --- a/changes/bug24581 +++ b/changes/bug24581 @@ -3,5 +3,6 @@ Controllers that run Tor using the "tor_api.h" interface can now restart Tor after Tor has exited. This support is incomplete, however: we have fixed the crash bugs that prevented it from working at all - before, but many bugs probably remain. Implements ticket 24581. + before, but many bugs probably remain, including the possibility of + security issues. Implements ticket 24581.
diff --git a/src/or/tor_api.h b/src/or/tor_api.h index e7d70c2a6..7e86c7fec 100644 --- a/src/or/tor_api.h +++ b/src/or/tor_api.h @@ -72,8 +72,8 @@ void tor_main_configuration_free(tor_main_configuration_t *cfg); * * BUG 23847: You can only call tor_main() once in a single process; if it * returns and you call it again, you may crash, or you may encounter other - * unexpected behavior. This is not intended long-term behavior; we are - * trying to fix it. + * unexpected behavior, including possible security issues. This is not + * intended long-term behavior; we are trying to fix it. * * LIMITATION: You cannot run more than one instance of Tor in the same * process at the same time. Concurrent calls will cause undefined behavior.