commit 5670e38efb8529d3439b8a160e9f19c4147e01ad Author: Nick Mathewson nickm@torproject.org Date: Sat Apr 19 12:47:58 2014 -0400
scan-build: close stdio FILEs on error in tor-gencert
This is harmless, since tor-gencert exits right afterwards, but it's best to clean up after ourselves. --- src/tools/tor-gencert.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/tools/tor-gencert.c b/src/tools/tor-gencert.c index d0c30b8..e799df5 100644 --- a/src/tools/tor-gencert.c +++ b/src/tools/tor-gencert.c @@ -302,6 +302,7 @@ load_identity_key(void) if (!identity_key) { log_err(LD_GENERAL, "Couldn't read identity key from %s", identity_key_file); + fclose(f); return 1; } fclose(f); @@ -322,6 +323,7 @@ load_signing_key(void) } if (!(signing_key = PEM_read_PrivateKey(f, NULL, NULL, NULL))) { log_err(LD_GENERAL, "Couldn't read siging key from %s", signing_key_file); + fclose(f); return 1; } fclose(f);