commit 4b8f4407562d55167c182b52be0f49432e5223ed Author: Arturo Filastò arturo@filasto.net Date: Tue Oct 23 10:04:35 2012 +0000
Add some notes on netalyzr test --- nettests/third_party/netalyzr.py | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/nettests/third_party/netalyzr.py b/nettests/third_party/netalyzr.py index bf94000..d73c245 100644 --- a/nettests/third_party/netalyzr.py +++ b/nettests/third_party/netalyzr.py @@ -36,6 +36,11 @@ class NetalyzrWrapperTest(nettest.TestCase): """ log.msg("Running NetalyzrWrapper (this will take some time, be patient)") log.debug("with command '%s'" % self.run_me) + # XXX we probably want to use a processprotocol here to obtain the + # stdout from Netalyzr. This would allows us to visualize progress + # (currently there is no progress because the stdout of os.system is + # trapped by twisted) and to include the link to the netalyzr report + # directly in the OONI report, perhaps even downloading it. os.system(self.run_me) self.report['netalyzr_report'] = self.output_file log.debug("finished running NetalzrWrapper")