commit a40d2123834cd55e77ed76684a6d0f536a7c2f4e Author: Nick Mathewson nickm@torproject.org Date: Fri Dec 9 08:43:09 2016 -0500
Downgrade a harmless bug warning to info.
Makes 19926 less annoying in 0.2.9. In 0.3.0, we should actually fix this. --- changes/bug19926_029_info | 3 +++ src/or/connection_edge.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/changes/bug19926_029_info b/changes/bug19926_029_info new file mode 100644 index 0000000..93fd81b --- /dev/null +++ b/changes/bug19926_029_info @@ -0,0 +1,3 @@ + o Minor bugfixes (logging): + - Downgrade a harmless log message about the pending_entry_connections + list from "warn" to "info". Mitigates bug 19926. diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index 7b9c315..3550d0e 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -865,7 +865,9 @@ connection_ap_attach_pending(int retry) continue; } if (conn->state != AP_CONN_STATE_CIRCUIT_WAIT) { - log_warn(LD_BUG, "%p is no longer in circuit_wait. Its current state " + // XXXX 030 -- this is downgraded in 0.2.9, since we apparently + // XXXX are running into it in practice. It's harmless. + log_info(LD_BUG, "%p is no longer in circuit_wait. Its current state " "is %s. Why is it on pending_entry_connections?", entry_conn, conn_state_to_string(conn->type, conn->state));