commit 211e56ad87740da1303832d900bf2943ed702526 Author: teor (Tim Wilson-Brown) teor2345@gmail.com Date: Thu Apr 28 11:36:27 2016 +1000
Remove redundant descriptor checks for OR/Dir reachability
The ORPort and DirPort must be reachable, or we won't publish a descriptor. --- src/or/router.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/src/or/router.c b/src/or/router.c index a9d992f..86fd787 100644 --- a/src/or/router.c +++ b/src/or/router.c @@ -1247,9 +1247,6 @@ decide_to_advertise_dirport(const or_options_t *options, uint16_t dir_port) return dir_port; if (net_is_disabled()) return 0; - /* redundant - if DirPort is unreachable, we don't publish a descriptor */ - if (!check_whether_dirport_reachable()) - return 0; if (!router_get_advertised_dir_port(options, dir_port)) return 0;
@@ -1280,9 +1277,6 @@ decide_to_advertise_begindir(const or_options_t *options, return 1; if (net_is_disabled()) return 0; - /* redundant - if ORPort is unreachable, we don't publish a descriptor */ - if (!check_whether_orport_reachable()) - return 0; if (!router_get_advertised_or_port(options)) return 0;