Dan Ballard pushed to branch tor-browser-153.1.0esr-16.0-1 at The Tor Project / Applications / Tor Browser Commits: 40b71286 by Dan Ballard at 2026-08-19T14:13:06-07:00 fixup! TB 40002: [android] Ensure system download manager is not used TB 44054: Remove "open" button from download snackbar; second line defense for shouldShowAppDownloaderDialog - - - - - 3 changed files: - mobile/android/android-components/components/feature/downloads/src/main/java/mozilla/components/feature/downloads/DownloadsFeature.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonPopupBaseFragment.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/snackbar/SnackbarBinding.kt Changes: ===================================== mobile/android/android-components/components/feature/downloads/src/main/java/mozilla/components/feature/downloads/DownloadsFeature.kt ===================================== @@ -148,7 +148,7 @@ class DownloadsFeature( private val promptsStyling: PromptsStyling? = null, private val onDownloadStartedListener: ((String) -> Unit) = {}, private val dismissCustomFirstPartyDownloadDialog: () -> Unit = {}, - private val shouldForwardToThirdParties: () -> Boolean = { false }, + private var shouldForwardToThirdParties: () -> Boolean = { false }, private val customFirstPartyDownloadDialog: ( ( CurrentDownloadState, @@ -173,6 +173,9 @@ class DownloadsFeature( init { this.onDownloadStopped = onDownloadStopped + // TB#44054 adding second override along with tb#40002 adding `&& false` to caught instantiations + // of this class, so that we still disable this when new instantiations are added + this.shouldForwardToThirdParties = { false } } private var scope: CoroutineScope? = null ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonPopupBaseFragment.kt ===================================== @@ -136,7 +136,7 @@ abstract class AddonPopupBaseFragment : PreferenceManager.getDefaultSharedPreferences(requireContext()).getBoolean( requireContext().getPreferenceKey(R.string.pref_key_external_download_manager), false, - ) + ) && false }, promptsStyling = DownloadsFeature.PromptsStyling( gravity = Gravity.BOTTOM, ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/snackbar/SnackbarBinding.kt ===================================== @@ -328,7 +328,7 @@ class SnackbarBinding( subText = state.downloadState.fileName, subTextOverflow = TextOverflow.MiddleEllipsis, duration = context.components.settings.getSnackbarTimeout(hasAction = true).value.toInt(), - action = context.getString(R.string.download_completed_snackbar_action_open), + action = if (state.downloadState.isPdf) context.getString(R.string.download_completed_snackbar_action_open) else null, ) { val fileWasOpened = downloadFileUtils.openFile( fileName = state.downloadState.fileName, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/40b71286... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/40b71286... You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help