commit bf28436368aea5a0cad3545de9406934434a9f1a Author: Damian Johnson atagar@torproject.org Date: Sun Dec 23 11:58:38 2012 -0800
Fixing eronious 'missing with' warning
Running our tests gave a working that network.py was missing an import of the 'with' statement. This was wrong - the with statement was in its pydocs. The checker tries to be smart about what is and isn't documentation by looking for block quotes but an unusual string confused it...
""" Base error for proxy issues. """
I avoid using block quotes unless things span multiple lines which is why I didn't account for this. We could fix the checker (... which isn't a bad idea) but for the moment I'm just dropping the odd block quotes since it'll probably introduce extra whitespace before and after the message in the sphinx docs. --- test/network.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/network.py b/test/network.py index ea15de7..a0d5ded 100644 --- a/test/network.py +++ b/test/network.py @@ -28,7 +28,7 @@ SOCKS5_CONN_BY_IPV4 = (0x05, 0x01, 0x00, 0x01) SOCKS5_CONN_BY_NAME = (0x05, 0x01, 0x00, 0x03)
class ProxyError(Exception): - """ Base error for proxy issues. """ + "Base error for proxy issues."
class SocksError(ProxyError): """