commit 79544a6fc5342605a23773ba7d6fc2d863f1dd76 Author: Yawning Angel yawning@schwanenlied.me Date: Mon Apr 6 17:53:01 2015 +0000
Fix the memory leak in `warn_if_option_path_is_relative()`.
Fixes coverity defect CID 1293337, not in any released version of tor. --- src/or/config.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/or/config.c b/src/or/config.c index d65d35d..00de0b9 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -2558,10 +2558,12 @@ static void warn_if_option_path_is_relative(const char *option, char *filepath) { - if (filepath &&path_is_relative(filepath)) + if (filepath && path_is_relative(filepath)) { + char *abs_path = make_path_absolute(filepath); COMPLAIN("Path for %s (%s) is relative and will resolve to %s." - " Is this what you wanted?",option,filepath, - make_path_absolute(filepath)); + " Is this what you wanted?", option, filepath, abs_path); + tor_free(abs_path); + } }
/** Scan <b>options</b> for occurances of relative file/directory