commit dd8eeabfd18f4a52eb85960701b914e4f89a00bf Author: Nick Mathewson nickm@torproject.org Date: Sun Sep 17 20:42:28 2017 -0400
Fix memory leak in tor-gencert.c
This was introduced in 4ff170d7b1cbe4074cb852, and is probably unreachable, but coverity complained about it (CID 1417761). Bug not in any released Tor, so no changes file. --- src/tools/tor-gencert.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/tools/tor-gencert.c b/src/tools/tor-gencert.c index 600e2252d..fb7465c0e 100644 --- a/src/tools/tor-gencert.c +++ b/src/tools/tor-gencert.c @@ -464,8 +464,6 @@ generate_certificate(void) char expires[ISO_TIME_LEN+1]; char id_digest[DIGEST_LEN]; char fingerprint[FINGERPRINT_LEN+1]; - char *ident = key_to_string(identity_key); - char *signing = key_to_string(signing_key); FILE *f; size_t signed_len; char digest[DIGEST_LEN]; @@ -478,6 +476,8 @@ generate_certificate(void) if (get_digest(identity_key, id_digest)) { return -1; } + char *ident = key_to_string(identity_key); + char *signing = key_to_string(signing_key);
tor_localtime_r(&now, &tm); tm.tm_mon += months_lifetime;