commit 783f705ddc507c082ab53b556317680447f046f6 Author: Nick Mathewson nickm@torproject.org Date: Fri Jun 15 10:05:21 2012 -0400
Document that we are unlikely to underflow session group IDs. --- src/or/connection.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/src/or/connection.c b/src/or/connection.c index 9bbab19..c22068b 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -1048,7 +1048,12 @@ connection_listener_new(const struct sockaddr *listensockaddr, if (port_cfg->session_group >= 0) { lis_conn->session_group = port_cfg->session_group; } else { - /* XXXX023 This can wrap after ~INT_MAX ports are opened. */ + /* This can wrap afuter ~INT_MAX listeners are opened. But I don't + * believe that matters, since you would need to open a ridiculous + * number of listeners while keeping the early ones open before you ever + * hit this. An OR with a dozen ports open, for example, would have to + * close and re-open its listers every second for 4 years nonstop. + */ lis_conn->session_group = global_next_session_group--; } }