commit 9ae35975402a823a420cd5efb81a1c3a76f6c4d6 Author: Nick Mathewson nickm@torproject.org Date: Fri Jul 20 11:02:05 2018 -0400
Tweak assertion in get_time_period_length() for coverity
This is another attempt to fix 1437668. The assertion here should be safe, since the rules of networkstatus_get_param() keep the value it returns in range. --- src/feature/hs/hs_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/feature/hs/hs_common.c b/src/feature/hs/hs_common.c index 328430be0..1c5dfd5e6 100644 --- a/src/feature/hs/hs_common.c +++ b/src/feature/hs/hs_common.c @@ -254,8 +254,8 @@ get_time_period_length(void) HS_TIME_PERIOD_LENGTH_MIN, HS_TIME_PERIOD_LENGTH_MAX); /* Make sure it's a positive value. */ - tor_assert(time_period_length >= 0); - /* uint64_t will always be able to contain a int32_t */ + tor_assert(time_period_length > 0); + /* uint64_t will always be able to contain a positive int32_t */ return (uint64_t) time_period_length; }