commit 523188afdb4488724da2487d86bfa2ad87f96cb2 Author: Nick Mathewson nickm@torproject.org Date: Mon Sep 18 10:24:03 2017 -0400
Use the lintChanges script to fix style issues in changes entries --- changes/{19037 => 19307} | 0 changes/bug17639 | 8 ++++---- changes/bug17750 | 2 +- changes/bug18982 | 4 ++-- changes/bug19476 | 7 ++++--- changes/bug19871 | 8 ++++---- changes/bug22006 | 6 +++--- changes/bug22410 | 4 ++-- changes/bug22461 | 2 +- changes/bug22924 | 2 +- changes/bug23091 | 2 +- changes/bug23347 | 9 --------- changes/bug23366 | 6 +++--- changes/bug23470 | 5 ++--- changes/bug23499 | 2 +- changes/bug23524 | 2 +- changes/bug23525 | 6 ------ changes/bug3056 | 6 +++--- changes/bug4019 | 2 +- changes/refactor-buffer | 2 +- changes/ticket20575 | 6 +++--- changes/ticket22215 | 2 +- 22 files changed, 39 insertions(+), 54 deletions(-)
diff --git a/changes/19037 b/changes/19307 similarity index 100% rename from changes/19037 rename to changes/19307 diff --git a/changes/bug17639 b/changes/bug17639 index 4073514fd..be69edbc7 100644 --- a/changes/bug17639 +++ b/changes/bug17639 @@ -1,4 +1,4 @@ - o Minor features: - - Add a new commandline option, --key-expiration, which prints when - the current signing key is going to expire. Implements ticket - 17639; patch by Isis Lovecruft. + o Minor features (command line): + - Add a new commandline option, --key-expiration, which prints when + the current signing key is going to expire. Implements ticket + 17639; patch by Isis Lovecruft. diff --git a/changes/bug17750 b/changes/bug17750 index eb77b77ab..c5894a971 100644 --- a/changes/bug17750 +++ b/changes/bug17750 @@ -1,4 +1,4 @@ o Minor bugfixes (directory downloads): - Make clients wait for 6 seconds before trying to download their consensus from an authority. - Fixes bug 17750, bugfix on 0.2.8.1-alpha. + Fixes bug 17750; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug18982 b/changes/bug18982 index bb0383d13..bfcae4fb5 100644 --- a/changes/bug18982 +++ b/changes/bug18982 @@ -1,6 +1,6 @@ o Minor bugfixes (circuit logging): - torspec says hop counts are 1-based, so fix two log messages that mistakenly logged 0-based hop counts. - Closes ticket 18982, bugfix on 0275b6876 in tor 0.2.6.2-alpha - and 907db008a in tor 0.2.4.5-alpha. Patch by teor. + Fixes bug 18982; bugfix on 0.2.6.2-alpha + and 0.2.4.5-alpha. Patch by teor. Credit to Xiaofan Li for reporting this issue. diff --git a/changes/bug19476 b/changes/bug19476 index 25a057868..dbde485b3 100644 --- a/changes/bug19476 +++ b/changes/bug19476 @@ -1,3 +1,4 @@ - o Minor changes: - - If we fail to write a heartbeat message, schedule a retry for the minimum - heartbeat interval number of seconds in the future. Fixes bug 19476. + o Minor bugfixes (heartbeat): + - If we fail to write a heartbeat message, schedule a retry for the minimum + heartbeat interval number of seconds in the future. Fixes bug 19476; + bugfix on 0.2.3.1-alpha. diff --git a/changes/bug19871 b/changes/bug19871 index 5f1c9dc80..4c4fbfa9e 100644 --- a/changes/bug19871 +++ b/changes/bug19871 @@ -1,4 +1,4 @@ - o Code refactoring: - - Remove dead code for largely unused statistics on the number of - times we've attempted various public key operations. Fixes bug - 19871; fix by Isis Lovecruft. Bugfix on 0.1.2.4-alpha. + o Code simplification and refactoring: + - Remove dead code for largely unused statistics on the number of + times we've attempted various public key operations. Fixes bug + 19871; bugfix on 0.1.2.4-alpha. Fix by Isis Lovecruft. diff --git a/changes/bug22006 b/changes/bug22006 index 912bdd87b..8b6f128b9 100644 --- a/changes/bug22006 +++ b/changes/bug22006 @@ -1,4 +1,4 @@ o Minor features (ed25519): - - Add validation function that checks for torsion components in ed25119 - public keys. Currently unused but will be used by prop224 client-side - code. Addresses ticket #22006. Math help by Ian Goldberg. + - Add validation function to checks for torsion components in ed25119 + public keys, used by prop224 client-side + code. Closes ticket 22006. Math help by Ian Goldberg. diff --git a/changes/bug22410 b/changes/bug22410 index 678a26dce..ee5fc68f3 100644 --- a/changes/bug22410 +++ b/changes/bug22410 @@ -1,4 +1,4 @@ - o Minor bugfixes (portability): + o Minor features (portability): - Check at configure time whether uint8_t is unsigned char. Lots of existing code already assumes this, and there could be strict - aliasing issues if they aren't the same type. Fixes #22410. + aliasing issues if they aren't the same type. Closes ticket 22410. diff --git a/changes/bug22461 b/changes/bug22461 index 545468281..3fd5e2164 100644 --- a/changes/bug22461 +++ b/changes/bug22461 @@ -4,4 +4,4 @@ enabled, as this prevents user from connecting to known IP addresses without relying on DNS for resolving. SafeSocks still rejects SOCKS connections that connect to IP addresses when those addresses are _not_ - encoded as hostnames. Fixes bug 22461, bugfix on Tor 0.2.6.2-alpha. + encoded as hostnames. Fixes bug 22461; bugfix on Tor 0.2.6.2-alpha. diff --git a/changes/bug22924 b/changes/bug22924 index e59fc724e..6d05f51cf 100644 --- a/changes/bug22924 +++ b/changes/bug22924 @@ -1,4 +1,4 @@ - o Minor bugfies (tests): + o Minor bugfixes (tests): - Fix a signed-integer overflow in the unit tests for dir/download_status_random_backoff, which was untriggered until we fixed bug 17750. Fixes bug 22924; bugfix on 0.2.9.1-alpha. diff --git a/changes/bug23091 b/changes/bug23091 index 7dfb7e418..6e2acf53c 100644 --- a/changes/bug23091 +++ b/changes/bug23091 @@ -3,4 +3,4 @@ instead of only doing it for a consensus that is more than 24 hours old (badly expired). This specific check is done in the tor main loop callback that validates if we have an expired consensus. Fixes bug - 23091; bugfix on tor-0.2.0.19-alpha. + 23091; bugfix on 0.2.0.19-alpha. diff --git a/changes/bug23347 b/changes/bug23347 deleted file mode 100644 index e73aa48f0..000000000 --- a/changes/bug23347 +++ /dev/null @@ -1,9 +0,0 @@ - o Minor fixes (bridge client bootstrap): - - Make bridge clients with no running bridges try to download - bridge descriptors immediately. But when bridge clients have - running bridges, make them wait at least 3 hours before - refreshing recently received bridge descriptors. - Download schedules used to start with an implicit 0, but the - fix for 17750 changed this undocumented behaviour, and made - bridge clients hang for 15 minutes before bootstrapping. - Fixes bug 23347, not in any released version of Tor. diff --git a/changes/bug23366 b/changes/bug23366 index 85e370f61..c7e0fdf2b 100644 --- a/changes/bug23366 +++ b/changes/bug23366 @@ -1,4 +1,4 @@ o Minor bugfixes (test): - - Fix a broken OutboundAddress option unit test because the parsing - function was never returning an error on failure. Fixes bug #23366.; - bugfix on tor-0.3.0.3-alpha. + - Fix a broken unit test for the OutboundAddress option: the parsing + function was never returning an error on failure. Fixes bug 23366; + bugfix on 0.3.0.3-alpha. diff --git a/changes/bug23470 b/changes/bug23470 index 33367b3a3..d5b345b72 100644 --- a/changes/bug23470 +++ b/changes/bug23470 @@ -1,6 +1,5 @@ o Minor bugfix (relay address resolution): - Avoid unnecessary calls to directory_fetches_from_authorities() on relays. This avoids spurious address resolutions and - descriptor rebuilds. This is a mitigation for 21789. The original - bug was introduced in commit 35bbf2e as part of prop210. - Fixes 23470 in 0.2.8.1-alpha. + descriptor rebuilds. This is a mitigation for bug 21789. + Fixes bug 23470; bugfix on in 0.2.8.1-alpha. diff --git a/changes/bug23499 b/changes/bug23499 index e53b03c34..28ae57aae 100644 --- a/changes/bug23499 +++ b/changes/bug23499 @@ -1,4 +1,4 @@ - o Minor bugfixes: + o Minor bugfixes (directories): - Directory servers now include a "Date:" http header for response codes other than 200. Clients starting with a skewed clock and a recent consensus were getting "304 Not modified" responses from diff --git a/changes/bug23524 b/changes/bug23524 index c8ece5293..500520e72 100644 --- a/changes/bug23524 +++ b/changes/bug23524 @@ -1,4 +1,4 @@ o Minor bugfixes (DoS-resistance): - If future code asks if there are any running bridges, without checking if bridges are enabled, log a BUG warning rather than crashing. - Fixes 23524 on 0.3.0.1-alpha. + Fixes bug 23524; bugfix on 0.3.0.1-alpha. diff --git a/changes/bug23525 b/changes/bug23525 deleted file mode 100644 index 3a9c766c3..000000000 --- a/changes/bug23525 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (control port): - - Make download status next attempts reported over the control port - consistent with the time used by tor. This issue only occurs if a - download status has not been reset before it is queried over the - control port. - Fixes 23525, not in any released version of tor. diff --git a/changes/bug3056 b/changes/bug3056 index 62bec20d5..1e9b9f9b4 100644 --- a/changes/bug3056 +++ b/changes/bug3056 @@ -1,3 +1,3 @@ - o Minor features (exit relay, DNS): - - Improve the clarity and safety of the log message from evdns when - receiving an apparent spoofed DNS reply. Closes ticket 3056. + o Minor features (exit relay, DNS): + - Improve the clarity and safety of the log message from evdns when + receiving an apparent spoofed DNS reply. Closes ticket 3056. diff --git a/changes/bug4019 b/changes/bug4019 index fef736ff6..559c73b70 100644 --- a/changes/bug4019 +++ b/changes/bug4019 @@ -1,4 +1,4 @@ o Minor bugfixes (logging): - Remove duplicate log messages regarding opening non-local SocksPorts upon parsing config and opening listeners at startup. Fixes bug 4019; - bugfix on tor-0.2.3.3-alpha. + bugfix on 0.2.3.3-alpha. diff --git a/changes/refactor-buffer b/changes/refactor-buffer index 36b029672..29e0bc3e8 100644 --- a/changes/refactor-buffer +++ b/changes/refactor-buffer @@ -1,3 +1,3 @@ - o Code simplifications and refactoring: + o Code simplification and refactoring: - Split the portions of the buffer.c module that handle particular protocols into separate modules. Part of ticket 23149. diff --git a/changes/ticket20575 b/changes/ticket20575 index bfbf03f6b..6d9a5fc90 100644 --- a/changes/ticket20575 +++ b/changes/ticket20575 @@ -1,4 +1,4 @@ - o Deprecation (config): - - Deprecate HTTPProxy/HTTPProxyAuthenticator config options. It only + o Deprecated features: + - Deprecate HTTPProxy/HTTPProxyAuthenticator config options. They only applies to direct unencrypted HTTP connections to your directory server, - which your Tor probably isn't using. Fixes bug 20575. + which your Tor probably isn't using. Closes ticket 20575. diff --git a/changes/ticket22215 b/changes/ticket22215 index 4abeaf2c5..3ede7ca9e 100644 --- a/changes/ticket22215 +++ b/changes/ticket22215 @@ -1,5 +1,5 @@ o Code simplification and refactoring: - Remove some of the code that once supported "Named" and "Unnamed" routers. Authorities no longer vote for these flags. Closes ticket - 23478. + 22215.