commit 178a2bbcff74b7f9df2a192f45f1f91f3a9f935d Author: George Kadianakis desnacked@riseup.net Date: Tue Sep 26 15:23:23 2017 +0300
prop224: Fix one last instance of get_time_period_num() with now.
When purging last HSDir requests, we used time(NULL) for computing the service blinded key but in all other places in our codebase we actually use the consensus times. That can cause wrong behavior if the consensus is in a different time period than time(NULL).
This commit is required for proper purging of HSDir requests. --- src/or/hs_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/or/hs_client.c b/src/or/hs_client.c index 201e80818..560ccf849 100644 --- a/src/or/hs_client.c +++ b/src/or/hs_client.c @@ -100,7 +100,7 @@ purge_hid_serv_request(const ed25519_public_key_t *identity_pk) * from the previous time period. That is fine because they will expire at * some point and we don't care about those anymore. */ hs_build_blinded_pubkey(identity_pk, NULL, 0, - hs_get_time_period_num(approx_time()), &blinded_pk); + hs_get_time_period_num(0), &blinded_pk); if (BUG(ed25519_public_to_base64(base64_blinded_pk, &blinded_pk) < 0)) { return; }