- tor-commits - lists.torproject.org

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-128.0esr-14.0-1
by Pier Angelo Vendrame (＠pierov) 16 Jul '24

16 Jul '24

Pier Angelo Vendrame pushed new branch mullvad-browser-128.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-128.0esr-14.0-1
by Pier Angelo Vendrame (＠pierov) 16 Jul '24

16 Jul '24

Pier Angelo Vendrame pushed new branch base-browser-128.0esr-14.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-128.0esr-14.0-1-build1
by Pier Angelo Vendrame (＠pierov) 16 Jul '24

16 Jul '24

Pier Angelo Vendrame pushed new tag base-browser-128.0esr-14.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.0esr-14.0-1-build1
by Pier Angelo Vendrame (＠pierov) 16 Jul '24

16 Jul '24

Pier Angelo Vendrame pushed new tag tor-browser-128.0esr-14.0-1-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41184: Update generate blog post script to use new blog header images
by richard (＠richard) 15 Jul '24

15 Jul '24

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: cd85b1d1 by Nicolas Vigier at 2024-07-12T09:51:57+02:00 Bug 41184: Update generate blog post script to use new blog header images - - - - - 1 changed file: - tools/signing/create-blog-post Changes: ===================================== tools/signing/create-blog-post ===================================== @@ -18,9 +18,9 @@ echo "Created directory $blog_dir" if test "$tbb_version_type" = "release" then - lead=../../../assets/static/images/blog/tor-browser-13.png + lead=../../../assets/static/images/blog/tor-browser-stable.png else - lead=../../../assets/static/images/blog/tor-browser_0_0.png + lead=../../../assets/static/images/blog/tor-browser-alpha.png fi ln -s "$lead" "$blog_dir/lead.png" echo "Created $blog_dir/lead.png -> $lead" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.0esr-14.0-1] 197 commits: Bug 41454: Move focus after calling openPreferences for a sub-category.
by richard (＠richard) 15 Jul '24

15 Jul '24

richard pushed to branch tor-browser-128.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: f4290cc7 by Henry Wilkes at 2024-07-11T16:29:20+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 626a84d0 by hackademix at 2024-07-11T16:29:20+02:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - 6863f504 by Henry Wilkes at 2024-07-11T16:29:21+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 989bfa48 by Marco Simonelli at 2024-07-11T16:29:21+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 9b612c18 by Marco Simonelli at 2024-07-11T16:29:21+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 4b1db495 by Marco Simonelli at 2024-07-11T16:29:21+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - ab463c6e by Marco Simonelli at 2024-07-11T16:29:22+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 047714ef by Marco Simonelli at 2024-07-11T16:29:22+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 9e3e84cb by Marco Simonelli at 2024-07-11T16:29:22+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - e7ac7730 by hackademix at 2024-07-11T16:29:22+02:00 Bug 41854: Allow overriding download spam protection. - - - - - fec030b5 by Gaba at 2024-07-11T16:29:23+02:00 Adding issue and merge request templates - - - - - d92deede by Beatriz Rizental at 2024-07-11T16:29:23+02:00 Add CI for Base Browser - - - - - e15d0ac2 by Richard Pospesel at 2024-07-11T16:29:23+02:00 fixup! Adding issue and merge request templates add jwilde to reviewer list - - - - - 8599d450 by Pier Angelo Vendrame at 2024-07-11T16:29:23+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - c37f8e75 by Pier Angelo Vendrame at 2024-07-11T16:29:24+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - e6a3b2b9 by Pier Angelo Vendrame at 2024-07-11T16:29:24+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 4b4d0a57 by Dan Ballard at 2024-07-11T16:29:24+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 116bfcc0 by Matthew Finkel at 2024-07-11T16:29:24+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 9b6351fd by Matthew Finkel at 2024-07-11T16:29:25+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 0e19b370 by Mike Perry at 2024-07-11T16:29:25+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 7987795e by Alex Catarineu at 2024-07-11T16:29:25+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 3b6a5805 by Georg Koppen at 2024-07-11T16:29:25+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - 660ced35 by Kathy Brade at 2024-07-11T16:29:26+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 599469ae by Kathy Brade at 2024-07-11T16:29:26+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 92776a84 by Alex Catarineu at 2024-07-11T16:29:26+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 6163dfb4 by Kathy Brade at 2024-07-11T16:29:26+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 6093629f by Arthur Edelstein at 2024-07-11T16:29:27+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - a6911739 by Alex Catarineu at 2024-07-11T16:31:43+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - 46a15679 by Pier Angelo Vendrame at 2024-07-11T16:31:45+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances Silence a too spammy error message until we fix this commit. - - - - - 4d39ffe0 by cypherpunks1 at 2024-07-11T16:31:45+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - 7c53f3c3 by Pier Angelo Vendrame at 2024-07-11T16:31:45+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - e189c07c by Georg Koppen at 2024-07-11T16:31:46+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - 6bcb13c7 by Pier Angelo Vendrame at 2024-07-11T16:31:46+02:00 fixup! Bug 30541: Disable WebGL readPixel() for web content ShouldResistFingerprinting-related changes. - - - - - d29c2486 by Alex Catarineu at 2024-07-11T16:31:46+02:00 Bug 28369: Stop shipping pingsender executable - - - - - 8e1dcb7c by cypherpunks1 at 2024-07-11T16:31:46+02:00 Bug 41568: Disable LaterRun - - - - - 34c6a576 by cypherpunks1 at 2024-07-11T16:31:47+02:00 Bug 40717: Hide Windows SSO in settings - - - - - cc74752c by Pier Angelo Vendrame at 2024-07-11T16:31:47+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 831393e5 by Richard Pospesel at 2024-07-11T16:31:47+02:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - b84b0443 by Richard Pospesel at 2024-07-11T16:31:47+02:00 Bug 42037: Disable about:firefoxview page - - - - - 63271f6f by Mike Perry at 2024-07-11T16:31:48+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 697965a0 by Richard Pospesel at 2024-07-11T16:31:48+02:00 fixup! Firefox preference overrides. Bug 241: Move network.proxy.failover_direct=false pref to base-browser - - - - - 0a22c243 by Pier Angelo Vendrame at 2024-07-11T16:31:48+02:00 fixup! Firefox preference overrides. Bug 41467: Do not set beacon.enabled anymore. NoScript already blocks these pings (and maybe also Firefox under certain conditions I am not sure about). - - - - - 0844d094 by Pier Angelo Vendrame at 2024-07-11T16:31:48+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - a957130c by Pier Angelo Vendrame at 2024-07-11T16:31:49+02:00 Bug 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - 45eaee50 by Pier Angelo Vendrame at 2024-07-11T16:31:49+02:00 fixup! Bug 41901: Hardcode normalized FontSubstitutes. - - - - - f4f7311f by Alex Catarineu at 2024-07-11T16:31:49+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 262d9ddb by Pier Angelo Vendrame at 2024-07-11T16:31:49+02:00 Bug 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - c18ec593 by Pier Angelo Vendrame at 2024-07-11T16:31:50+02:00 fixup! Bug 42562: Normalized the Accepted Languages on Android. Bug 42582: Use toLanguageTag() instead of toString() - - - - - 5cc097d9 by Alex Catarineu at 2024-07-11T16:31:50+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 01a346a2 by Alex Catarineu at 2024-07-11T16:31:50+02:00 Bug 26345: Hide tracking protection UI - - - - - 3b54cd07 by Pier Angelo Vendrame at 2024-07-11T16:31:50+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - 66b8cf31 by Pier Angelo Vendrame at 2024-07-11T16:31:51+02:00 fixup! Bug 9173: Change the default Firefox profile directory to be relative. Always shortcut the portable installation check on macOS after the first run of nsXREDirProvider::GetPortableDataDir. - - - - - 848168e9 by Pier Angelo Vendrame at 2024-07-11T16:31:51+02:00 fixup! Bug 9173: Change the default Firefox profile directory to be relative. Changed bool to boolean for upstream Bug 1881863. - - - - - 43b3b4fe by Alex Catarineu at 2024-07-11T16:31:51+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 6ad4813a by Mike Perry at 2024-07-11T16:31:51+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - f187818c by Pier Angelo Vendrame at 2024-07-11T16:31:52+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 98932c5b by Pier Angelo Vendrame at 2024-07-11T16:31:52+02:00 fixup! Bug 40309: Avoid using regional OS locales ShouldResistFingerprinting-related changes. - - - - - 722d64f0 by Matthew Finkel at 2024-07-11T16:31:52+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - b04b739d by cypherpunks1 at 2024-07-11T16:31:52+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 9cf1527a by cypherpunks1 at 2024-07-11T16:31:52+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 23729ed1 by hackademix at 2024-07-11T16:31:53+02:00 Bug 42288: Allow language spoofing in status messages. - - - - - ed67d072 by Richard Pospesel at 2024-07-11T16:31:53+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - e4d98044 by Pier Angelo Vendrame at 2024-07-11T16:31:53+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 4b3eb99c by Henry Wilkes at 2024-07-11T16:31:53+02:00 fixup! Base Browser strings Bug 42347: Add a notification for dropped OS version support. - - - - - 8e4bfe89 by Pier Angelo Vendrame at 2024-07-11T16:31:54+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 4bfeb236 by Henry Wilkes at 2024-07-11T16:31:54+02:00 fixup! Bug 41369: Improve Firefox language settings for multi-lingual packages Bug 42573: Avoid async l10n.formatValue. - - - - - fc2aa654 by p13dz at 2024-07-11T16:31:54+02:00 Bug 40283: Workaround for the file upload bug - - - - - 0f9892ac by Arthur Edelstein at 2024-07-11T16:31:54+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 98226391 by Pier Angelo Vendrame at 2024-07-11T16:31:55+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 060b3dc9 by hackademix at 2024-07-11T16:31:55+02:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - fc75ff45 by hackademix at 2024-07-11T16:31:55+02:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - ed1b2406 by Pier Angelo Vendrame at 2024-07-11T16:31:55+02:00 Bug 41930: Remove the UI to customize accept_languages. - - - - - 9ae41d0f by Pier Angelo Vendrame at 2024-07-11T16:31:56+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - 427cf6a6 by Pier Angelo Vendrame at 2024-07-11T16:31:56+02:00 fixup! Bug 42472: Spoof timezone in XSLT. ShouldResistFingerprinting-related changes. - - - - - 9fd6ca31 by hackademix at 2024-07-11T16:31:56+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 2517cb2b by hackademix at 2024-07-11T16:31:56+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 0a34a140 by hackademix at 2024-07-11T16:31:57+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 339304d2 by hackademix at 2024-07-11T16:31:57+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - 115ae871 by hackademix at 2024-07-11T16:31:57+02:00 Bug 42574: Letterboxing, exempt pdf.js. - - - - - 234efe17 by hackademix at 2024-07-11T16:31:57+02:00 Bug 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - ae89e509 by hackademix at 2024-07-11T16:31:58+02:00 fixup! Bug 32308: Use direct browser sizing for letterboxing. Bug 42405: Fix betterboxing + findbar horizontal bounce if the scrollbar is not an overlay. - - - - - d24d031f by hackademix at 2024-07-11T16:31:58+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - c48936d9 by hackademix at 2024-07-11T16:31:58+02:00 Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - c56fb788 by hackademix at 2024-07-11T16:31:58+02:00 Bug 41916: Letterboxing preferences UI - - - - - c18301e8 by Henry Wilkes at 2024-07-11T16:31:59+02:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42583: Use moz-support-link for the letterboxing preference. Also update the url. - - - - - f9b75ddd by hackademix at 2024-07-11T16:31:59+02:00 fixup! Bug 41916: Letterboxing preferences UI Import gLetterboxingPrefs for the linter. - - - - - e90f8582 by hackademix at 2024-07-11T16:31:59+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - 54662a46 by hackademix at 2024-07-11T16:31:59+02:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - b1bfcf32 by Henry Wilkes at 2024-07-11T16:32:00+02:00 Bug 42528: Don't leak system scrollbar size on windows. - - - - - 2a2f53fa by Pier Angelo Vendrame at 2024-07-11T16:32:00+02:00 fixup! Bug 42528: Don't leak system scrollbar size on windows. Fix the RFPTarget. - - - - - 0f1b1257 by Henry Wilkes at 2024-07-11T16:32:00+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 0e6dc1d9 by Kathy Brade at 2024-07-11T16:32:00+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - e37fd14e by Pier Angelo Vendrame at 2024-07-11T16:32:01+02:00 Bug 42061: Create an alpha update channel. - - - - - 6b6df2e3 by Nicolas Vigier at 2024-07-11T16:32:01+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 19fd63be by Pier Angelo Vendrame at 2024-07-11T16:32:01+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - 87ac169b by Pier Angelo Vendrame at 2024-07-11T16:32:01+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - dbcb7fec by Pier Angelo Vendrame at 2024-07-11T16:32:01+02:00 Bug 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - 46762e15 by Alex Catarineu at 2024-07-11T16:32:02+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - e6ea63de by Matthew Finkel at 2024-07-11T16:32:02+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 998f43c9 by Henry Wilkes at 2024-07-11T16:32:02+02:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 4af1d938 by Pier Angelo Vendrame at 2024-07-11T16:32:02+02:00 fixup! Bug 41736: Hide NoScript extension's toolbar button by default. - - - - - 88f3bd67 by Pier Angelo Vendrame at 2024-07-11T16:32:03+02:00 fixup! Bug 41736: Hide NoScript extension's toolbar button by default. - - - - - f16be17d by hackademix at 2024-07-11T16:32:03+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 94392ea9 by Pier Angelo Vendrame at 2024-07-11T16:32:03+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - db7c5811 by Henry Wilkes at 2024-07-11T16:32:03+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42583: Use moz-support-link for the security level "Learn more" links. These take you to the tor project web link in base browser. - - - - - 605849bf by Pier Angelo Vendrame at 2024-07-11T16:32:04+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42587: Remove ensureCustomElements in esr 128 - - - - - 784bcad1 by Pier Angelo Vendrame at 2024-07-11T16:32:04+02:00 Bug 40926: Implemented the New Identity feature - - - - - 713245b2 by Pier Angelo Vendrame at 2024-07-11T16:32:04+02:00 fixup! Bug 40926: Implemented the New Identity feature Move to HTML stylesheets instead of XML ones to be coherent with upstream. Also, switch from XPCOMUtils to ChromeUtils. - - - - - 4fa8a536 by Pier Angelo Vendrame at 2024-07-11T16:32:04+02:00 fixup! Bug 40926: Implemented the New Identity feature - - - - - 4ea32e1b by Henry Wilkes at 2024-07-11T16:32:05+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - d5a7e232 by Pier Angelo Vendrame at 2024-07-11T16:32:05+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - 0cad007d by Henry Wilkes at 2024-07-11T16:32:05+02:00 Bug 42583: Modify moz-support-link for Base Browser. - - - - - d39aac32 by Henry Wilkes at 2024-07-11T16:32:05+02:00 Bug 42347: Add a notification for dropped OS version support. - - - - - 96359ca4 by Henry Wilkes at 2024-07-11T16:36:26+02:00 Bug 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - 3e6fcc9b by Richard Pospesel at 2024-07-11T16:36:27+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - abebaa8b by Beatriz Rizental at 2024-07-11T16:36:27+02:00 Add CI for Tor Browser - - - - - 9167711b by Richard Pospesel at 2024-07-11T16:36:27+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - d1150ce0 by Pier Angelo Vendrame at 2024-07-11T16:36:27+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Use the correct volume name on macOS. - - - - - dc48badf by Henry Wilkes at 2024-07-11T16:36:28+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - a9d9f26b by Kathy Brade at 2024-07-11T16:36:28+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 4c989358 by Alex Catarineu at 2024-07-11T16:36:28+02:00 Add TorStrings module for localization - - - - - 1ec654fe by Henry Wilkes at 2024-07-11T16:36:28+02:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - 485691d9 by Henry Wilkes at 2024-07-11T16:36:29+02:00 Tor Browser localization migration scripts. - - - - - 97576b3f by Henry Wilkes at 2024-07-11T16:36:29+02:00 Bug 42305: Add script to combine translation files across versions. - - - - - 9da24732 by Mike Perry at 2024-07-11T16:36:29+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - 586be474 by Henry Wilkes at 2024-07-11T16:36:29+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 42583: Move moz-support-link change out of the branding commit. - - - - - 733bae29 by Henry Wilkes at 2024-07-11T16:36:30+02:00 Bug 42583: Modify moz-support-link for Tor Browser. - - - - - e536c57c by hackademix at 2024-07-11T16:36:30+02:00 Bug 41917: Tor brand-specific styles. - - - - - f19ebeee by Henry Wilkes at 2024-07-11T16:36:30+02:00 Add purple tor version of the loading APNG. - - - - - 7f79447b by sanketh at 2024-07-11T16:36:30+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - eabd7a05 by Pier Angelo Vendrame at 2024-07-11T16:36:31+02:00 fixup! Bug 40209: Implement Basic Crypto Safety Esmified. - - - - - 5e551cc7 by Mike Perry at 2024-07-11T16:36:31+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 5bb7e712 by Henry Wilkes at 2024-07-11T16:36:31+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - c53c4990 by Pier Angelo Vendrame at 2024-07-11T16:36:31+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - 675f933c by Richard Pospesel at 2024-07-11T16:36:32+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Bug 241: Move network.proxy.failover_direct=false pref to base-browser - - - - - a300f16a by Pier Angelo Vendrame at 2024-07-11T16:36:32+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js extensions.torbutton.launch_warning does not exist anymore. - - - - - 26d51910 by Pier Angelo Vendrame at 2024-07-11T16:36:32+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - 72a40e90 by Pier Angelo Vendrame at 2024-07-11T16:36:33+02:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - b7ba9088 by Pier Angelo Vendrame at 2024-07-11T16:36:33+02:00 fixup! Bug 40933: Add tor-launcher functionality Bug 42604: Log the circuit nodes when we see the CIRC BUILT event (with debug level). - - - - - 4f548b44 by Pier Angelo Vendrame at 2024-07-11T16:36:33+02:00 fixup! Bug 40933: Add tor-launcher functionality Bug 42636: A bad bridge line might get TBA stuck. A while ago I reworked the relationship between TorSettings and TorProvider. While doing so I was too strict, and a failure to push settings during initialization will stop the initialization itself, which will result in TBA stuck at the splash screen. The problem appears also on desktop (the user will get a prompt that asks to restart Tor, even though it is not perfect, see #21053). However, on desktop the user can go to the settings and deleting the bridges from there (which is not an optimal experience anyway). - - - - - 84912c95 by Pier Angelo Vendrame at 2024-07-11T16:36:33+02:00 fixup! Bug 40933: Add tor-launcher functionality Fix some comments. - - - - - 168b4ea3 by Pier Angelo Vendrame at 2024-07-15T18:14:15+02:00 fixup! Bug 40933: Add tor-launcher functionality Remove an unneeded async - - - - - 6eacfead by Cecylia Bocovich at 2024-07-15T18:14:26+02:00 Lox integration - - - - - 70c497d8 by Richard Pospesel at 2024-07-15T18:14:26+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - fe1a67d4 by Pier Angelo Vendrame at 2024-07-15T18:14:26+02:00 fixup! Bug 40597: Implement TorSettings module Updated some comments - - - - - ead1ba1d by Pier Angelo Vendrame at 2024-07-15T18:14:27+02:00 fixup! Bug 40597: Implement TorSettings module Do not freeze TorConnectError. - - - - - 49da9d2c by Arthur Edelstein at 2024-07-15T18:14:27+02:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - 336fca0d by Pier Angelo Vendrame at 2024-07-15T18:14:27+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 42604: Log a message when we update the data about a certain circuit. - - - - - eb3fbbbd by Henry Wilkes at 2024-07-15T18:14:27+02:00 Bug 41600: Add a tor circuit display panel. - - - - - 60765e0d by Henry Wilkes at 2024-07-15T18:14:28+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41859: Increase ip address font size to make them more legible on windows OS. - - - - - 6193a3a2 by Pier Angelo Vendrame at 2024-07-15T18:14:28+02:00 Bug 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - b9ad83f9 by Pier Angelo Vendrame at 2024-07-15T18:14:28+02:00 fixup! Bug 42247: Android helpers for the TorProvider Do not redeclare lazy. - - - - - 2cd07f69 by Pier Angelo Vendrame at 2024-07-15T18:14:28+02:00 fixup! Bug 42247: Android helpers for the TorProvider Documentation improvements. - - - - - caf348e0 by hackademix at 2024-07-15T18:14:29+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - bdb1b535 by Amogh Pradeep at 2024-07-15T18:14:29+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - ce804d4d by Matthew Finkel at 2024-07-15T18:14:29+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - d41e6238 by Kathy Brade at 2024-07-15T18:14:29+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - ad0c58fd by Pier Angelo Vendrame at 2024-07-15T18:14:30+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - 8216a289 by Richard Pospesel at 2024-07-15T18:14:30+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - a2eddaca by Richard Pospesel at 2024-07-15T18:14:30+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 96a80e3e by Henry Wilkes at 2024-07-15T18:14:30+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41621: Tweak about:torconnect style. - - - - - b5ccefa5 by Pier Angelo Vendrame at 2024-07-15T18:14:31+02:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - 30cd26a8 by Henry Wilkes at 2024-07-15T18:14:31+02:00 fixup! Temporary changes to about:torconnect for Android. Bug 41621: Make sure button's layout parent is .button-container when not on android. - - - - - 5d8a72d4 by Henry Wilkes at 2024-07-15T18:14:31+02:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - 1fc1cfdc by Arthur Edelstein at 2024-07-15T18:14:31+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - 610d9646 by Pier Angelo Vendrame at 2024-07-15T18:14:32+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - fac75600 by Pier Angelo Vendrame at 2024-07-15T18:14:32+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Remove the unused errorCode parameter in _shouldRegisterBootstrapObserver. Also, aligned a string to the 80 characters limit. - - - - - 2d33f4a9 by Kathy Brade at 2024-07-15T18:14:32+02:00 Bug 12647: Support symlinks in the updater. - - - - - 124abe4a by Kathy Brade at 2024-07-15T18:14:32+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - 26e35c2e by Kathy Brade at 2024-07-15T18:14:33+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - e9f52481 by Pier Angelo Vendrame at 2024-07-15T18:14:33+02:00 fixup! Bug 16940: After update, load local change notes. ESMified. - - - - - 076ca745 by Georg Koppen at 2024-07-15T18:14:33+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 801f2982 by Mike Perry at 2024-07-15T18:14:33+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - 32f13a8f by Dan Ballard at 2024-07-15T18:14:34+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing bug 42290: change duckduckgoonion to duckduckgo onion and same for startpageonion - - - - - e47dc8b1 by Pier Angelo Vendrame at 2024-07-15T18:14:34+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Switch to the new configuration objects to fix various runtime errors. Keep only DuckDuckGo for now, we will add the rest of engines when addressing tor-browser#41835. - - - - - 8311e11d by Alex Catarineu at 2024-07-15T18:14:34+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - 19778af8 by Henry Wilkes at 2024-07-15T18:14:34+02:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - ed6c1352 by Richard Pospesel at 2024-07-15T18:14:35+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - 02106ccc by Pier Angelo Vendrame at 2024-07-15T18:14:35+02:00 fixup! Bug 23247: Communicating security expectations for .onion Fix a TypeError in _hasCustomRoot. After this fix opening the identity panel will not result in a JS error anymore. However, the identity panel will not be accurate for Onion sites anyway. - - - - - 6cdf3d90 by Kathy Brade at 2024-07-15T18:14:35+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - fa80b001 by hackademix at 2024-07-15T18:14:35+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42557: Fix regression in Onion Services authentication prompt focus - - - - - 5f85a708 by Pier Angelo Vendrame at 2024-07-15T18:14:36+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt - - - - - 49f52611 by Pier Angelo Vendrame at 2024-07-15T18:14:36+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Move the default log level to the preference file to avoid a runtime error. - - - - - 3431bfeb by Pier Angelo Vendrame at 2024-07-15T18:14:36+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt - - - - - 670152d9 by Alex Catarineu at 2024-07-15T18:14:36+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 7ebc18b0 by Pier Angelo Vendrame at 2024-07-15T18:14:37+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 90694c27 by Pier Angelo Vendrame at 2024-07-15T18:14:37+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 47341114 by Pier Angelo Vendrame at 2024-07-15T18:14:37+02:00 fixup! Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser Update the comment. - - - - - 3cc81e95 by Pier Angelo Vendrame at 2024-07-15T18:14:37+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 5062cdb4 by Henry Wilkes at 2024-07-15T18:14:38+02:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - 56281733 by Dan Ballard at 2024-07-15T18:14:38+02:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - cb10d554 by Henry Wilkes at 2024-07-15T18:14:38+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 0998c5ad by hackademix at 2024-07-15T18:14:38+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 20237d48 by Henry Wilkes at 2024-07-15T18:14:38+02:00 Customize moz-toggle for tor-browser. - - - - - 55d32c25 by Richard Pospesel at 2024-07-15T18:14:39+02:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 67a9459b by Cecylia Bocovich at 2024-07-15T18:14:39+02:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - 4ce71881 by Pier Angelo Vendrame at 2024-07-15T18:14:39+02:00 Bug 42616: Remove VideoCaptureTest.kt. This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False. - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab-ci.yml - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/run_linters.py - + .gitlab/ci/update-translations.yml - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + README.md - − README.txt - + browser/actors/AboutTBUpdateChild.sys.mjs - + browser/actors/AboutTBUpdateParent.sys.mjs - + browser/actors/CryptoSafetyChild.sys.mjs - + browser/actors/CryptoSafetyParent.sys.mjs - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/309c86… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/309c86… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-128.0esr-14.0-1
by Pier Angelo Vendrame (＠pierov) 15 Jul '24

15 Jul '24

Pier Angelo Vendrame pushed new branch tor-browser-128.0esr-14.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.0b1-14.0-1] 199 commits: Bug 41454: Move focus after calling openPreferences for a sub-category.
by Pier Angelo Vendrame (＠pierov) 15 Jul '24

15 Jul '24

Pier Angelo Vendrame pushed to branch tor-browser-128.0b1-14.0-1 at The Tor Project / Applications / Tor Browser Commits: f9672ce7 by Henry Wilkes at 2024-06-11T09:11:07+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - 8f6d3794 by hackademix at 2024-06-11T09:11:07+02:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - 28eb8dda by Henry Wilkes at 2024-06-11T09:11:07+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 86a67e42 by Marco Simonelli at 2024-06-11T09:11:07+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 64d0066a by Marco Simonelli at 2024-06-11T09:11:08+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - c2813a08 by Marco Simonelli at 2024-06-11T09:11:08+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - eb83c78b by Marco Simonelli at 2024-06-11T09:11:08+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - b5acb69c by Marco Simonelli at 2024-06-11T09:11:08+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 200c7fb5 by Marco Simonelli at 2024-06-11T09:11:09+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 251dffcd by hackademix at 2024-06-11T09:11:09+02:00 Bug 41854: Allow overriding download spam protection. - - - - - 0bb396f9 by Gaba at 2024-06-11T09:11:09+02:00 Adding issue and merge request templates - - - - - 0d7c404d by Richard Pospesel at 2024-06-11T09:11:09+02:00 fixup! Adding issue and merge request templates add jwilde to reviewer list - - - - - f3d20b0c by Pier Angelo Vendrame at 2024-06-11T09:11:10+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 0e2a82bf by Pier Angelo Vendrame at 2024-06-11T09:11:10+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - cd73a594 by Pier Angelo Vendrame at 2024-06-11T09:11:10+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 248166a8 by Dan Ballard at 2024-06-11T09:11:10+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - adadf09e by Matthew Finkel at 2024-06-11T09:11:11+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 6ff4705a by Matthew Finkel at 2024-06-11T09:11:11+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 4c3d212e by Mike Perry at 2024-06-11T09:11:11+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 49062463 by Alex Catarineu at 2024-06-11T09:11:11+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 09284272 by Georg Koppen at 2024-06-11T09:11:12+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - 3786fb6b by Kathy Brade at 2024-06-11T09:11:12+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 6c62ee4a by Kathy Brade at 2024-06-11T09:11:12+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 4eb8a525 by Alex Catarineu at 2024-06-11T09:11:12+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - eecdf78f by Kathy Brade at 2024-06-11T09:11:12+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 8f438837 by Arthur Edelstein at 2024-06-11T09:11:13+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - b3ff00a0 by Alex Catarineu at 2024-06-11T09:11:13+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - f2dde5bd by cypherpunks1 at 2024-06-11T09:11:13+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - bc63e49f by Pier Angelo Vendrame at 2024-06-11T09:11:13+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 0d1640a3 by Georg Koppen at 2024-06-11T09:11:14+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - d7cb3bbe by Pier Angelo Vendrame at 2024-06-11T09:11:14+02:00 keepforreview! Bug 30541: Disable WebGL readPixel() for web content ShouldResistFingerprinting-related changes. - - - - - 687f0976 by Alex Catarineu at 2024-06-11T09:11:14+02:00 Bug 28369: Stop shipping pingsender executable - - - - - bfd9a7fe by cypherpunks1 at 2024-06-11T09:11:14+02:00 Bug 41568: Disable LaterRun - - - - - d0e7fb38 by cypherpunks1 at 2024-06-11T09:11:15+02:00 Bug 40717: Hide Windows SSO in settings - - - - - 13ef1c1f by Pier Angelo Vendrame at 2024-06-11T09:11:15+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 4a61d22b by Richard Pospesel at 2024-06-11T09:11:15+02:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - fde80723 by Richard Pospesel at 2024-06-11T09:11:15+02:00 Bug 42037: Disable about:firefoxview page - - - - - 31189103 by Mike Perry at 2024-06-11T09:11:16+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 593d72e7 by Richard Pospesel at 2024-06-11T09:11:16+02:00 fixup! Firefox preference overrides. Bug 241: Move network.proxy.failover_direct=false pref to base-browser - - - - - 37705ed7 by Pier Angelo Vendrame at 2024-06-11T09:11:16+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - 956b2208 by Pier Angelo Vendrame at 2024-06-11T09:11:16+02:00 Bug 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - 015651fe by Pier Angelo Vendrame at 2024-06-11T09:11:17+02:00 keepforreview! Bug 41901: Hardcode normalized FontSubstitutes. - - - - - 4ac63739 by Alex Catarineu at 2024-06-11T09:11:17+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 4639e6ca by Pier Angelo Vendrame at 2024-06-11T09:11:17+02:00 Bug 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - cc0bf3a3 by Pier Angelo Vendrame at 2024-06-11T09:11:17+02:00 fixup! Bug 42562: Normalized the Accepted Languages on Android. Bug 42582: Use toLanguageTag() instead of toString() - - - - - c43bf454 by Alex Catarineu at 2024-06-11T09:11:18+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 4988e8a2 by Alex Catarineu at 2024-06-11T09:11:18+02:00 Bug 26345: Hide tracking protection UI - - - - - a6d6cb78 by Pier Angelo Vendrame at 2024-06-11T09:11:18+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - 8f90ffca by Pier Angelo Vendrame at 2024-06-11T09:11:18+02:00 keepforreview! Bug 9173: Change the default Firefox profile directory to be relative. Changed bool to boolean for upstream Bug 1881863. - - - - - d9fd42d2 by Alex Catarineu at 2024-06-11T09:11:19+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 1aff0d73 by Mike Perry at 2024-06-11T09:11:19+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - 0908ad6a by Pier Angelo Vendrame at 2024-06-11T09:11:19+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 1ea2e141 by Pier Angelo Vendrame at 2024-06-11T09:11:19+02:00 keepforreview! Bug 40309: Avoid using regional OS locales ShouldResistFingerprinting-related changes. - - - - - 1d8979ac by Matthew Finkel at 2024-06-11T09:11:19+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - 5e0dadd0 by cypherpunks1 at 2024-06-11T09:11:20+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 5d54301f by cypherpunks1 at 2024-06-11T09:11:20+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - 6748f7e2 by hackademix at 2024-06-11T09:11:20+02:00 Bug 42288: Allow language spoofing in status messages. - - - - - de8d0d15 by Richard Pospesel at 2024-06-11T09:11:21+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 508d6432 by Pier Angelo Vendrame at 2024-06-11T09:11:21+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 23d1918b by Henry Wilkes at 2024-06-11T09:11:21+02:00 fixup! Base Browser strings Bug 42347: Add a notification for dropped OS version support. - - - - - 26ff6da2 by Pier Angelo Vendrame at 2024-06-11T09:11:21+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 0b905b59 by Henry Wilkes at 2024-06-11T09:11:21+02:00 fixup! Bug 41369: Improve Firefox language settings for multi-lingual packages Bug 42573: Avoid async l10n.formatValue. - - - - - c46d05da by p13dz at 2024-06-11T09:11:22+02:00 Bug 40283: Workaround for the file upload bug - - - - - 21db08e4 by Arthur Edelstein at 2024-06-11T09:11:22+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - 16185e63 by Pier Angelo Vendrame at 2024-06-11T09:11:22+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 46221bf3 by hackademix at 2024-06-11T09:11:22+02:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - e54e167e by hackademix at 2024-06-11T09:11:23+02:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - cd570bb8 by Pier Angelo Vendrame at 2024-06-11T09:11:23+02:00 Bug 41930: Remove the UI to customize accept_languages. - - - - - 36310747 by Pier Angelo Vendrame at 2024-06-11T09:11:23+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - 38b9e3bb by Pier Angelo Vendrame at 2024-06-11T09:11:23+02:00 keepforreview! Bug 42472: Spoof timezone in XSLT. ShouldResistFingerprinting-related changes. - - - - - a158f69a by hackademix at 2024-06-11T09:11:24+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 5aef30b8 by hackademix at 2024-06-11T09:11:24+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 73dd3f6e by hackademix at 2024-06-11T09:11:24+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 18c457ad by hackademix at 2024-06-11T09:11:24+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - a79671d1 by hackademix at 2024-06-11T09:11:25+02:00 Bug 42574: Letterboxing, exempt pdf.js. - - - - - c3028878 by hackademix at 2024-06-11T09:11:25+02:00 Bug 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - fcf9d041 by hackademix at 2024-06-11T09:11:25+02:00 fixup! Bug 32308: Use direct browser sizing for letterboxing. Bug 42405: Fix betterboxing + findbar horizontal bounce if the scrollbar is not an overlay. - - - - - 9081a1aa by hackademix at 2024-06-11T09:11:25+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - df75c8c9 by hackademix at 2024-06-11T09:11:26+02:00 Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - 7f8259e2 by hackademix at 2024-06-11T09:11:26+02:00 Bug 41916: Letterboxing preferences UI - - - - - 7f461635 by Henry Wilkes at 2024-06-11T09:11:26+02:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42583: Use moz-support-link for the letterboxing preference. Also update the url. - - - - - f60cc1e3 by hackademix at 2024-06-11T09:11:26+02:00 fixup! Bug 41916: Letterboxing preferences UI Import gLetterboxingPrefs for the linter. - - - - - 7433d985 by hackademix at 2024-06-11T09:11:27+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - eb0114a1 by hackademix at 2024-06-11T09:11:27+02:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - 1097d7a9 by Henry Wilkes at 2024-06-11T09:11:27+02:00 Bug 42528: Don't leak system scrollbar size on windows. - - - - - 001967fe by Pier Angelo Vendrame at 2024-06-11T09:11:27+02:00 keepforreview! Bug 42528: Don't leak system scrollbar size on windows. Fix the RFPTarget. - - - - - 041f4a60 by Henry Wilkes at 2024-06-11T09:11:28+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - ade5dddd by Kathy Brade at 2024-06-11T09:11:28+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - b5be384b by Pier Angelo Vendrame at 2024-06-11T09:11:28+02:00 Bug 42061: Create an alpha update channel. - - - - - b46472d1 by Nicolas Vigier at 2024-06-11T09:11:28+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 867e2aa7 by Pier Angelo Vendrame at 2024-06-11T09:11:29+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - e8f7f3c7 by Pier Angelo Vendrame at 2024-06-11T09:11:29+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - f82809fc by Pier Angelo Vendrame at 2024-06-11T09:11:29+02:00 Bug 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - 4975d0ba by Alex Catarineu at 2024-06-11T09:11:29+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - a4afb9b5 by Matthew Finkel at 2024-06-11T09:11:30+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 459013ab by Henry Wilkes at 2024-06-11T09:11:30+02:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - 65feb3d1 by hackademix at 2024-06-11T09:11:30+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 9157df3c by Pier Angelo Vendrame at 2024-06-11T09:11:30+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 538fb8db by Henry Wilkes at 2024-06-11T09:11:31+02:00 fixup! Bug 40925: Implemented the Security Level component Bug 42583: Use moz-support-link for the security level "Learn more" links. These take you to the tor project web link in base browser. - - - - - 4bc7ec85 by Pier Angelo Vendrame at 2024-06-11T09:11:31+02:00 Bug 40926: Implemented the New Identity feature - - - - - 716276e1 by Pier Angelo Vendrame at 2024-06-11T09:11:31+02:00 keepforreview! Bug 40926: Implemented the New Identity feature - - - - - a9b7e86f by Henry Wilkes at 2024-06-11T09:11:31+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 6c864e41 by Pier Angelo Vendrame at 2024-06-11T09:11:32+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - fceab835 by Henry Wilkes at 2024-06-11T09:11:32+02:00 Bug 42583: Modify moz-support-link for Base Browser. - - - - - 86857ca9 by Henry Wilkes at 2024-06-11T09:11:32+02:00 Bug 42347: Add a notification for dropped OS version support. - - - - - d253f856 by Pier Angelo Vendrame at 2024-06-11T09:11:32+02:00 fixup! Firefox preference overrides. Bug 41467: Do not set beacon.enabled anymore. NoScript already blocks these pings (and maybe also Firefox under certain conditions I am not sure about). - - - - - 90343841 by Henry Wilkes at 2024-06-11T09:15:32+02:00 Bug 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - 0e84f8e4 by Richard Pospesel at 2024-06-11T09:15:32+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - ec037360 by Henry Wilkes at 2024-06-11T09:15:32+02:00 Add CI for Tor Browser - - - - - ace0ebc9 by Richard Pospesel at 2024-06-11T09:15:33+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 382b8a73 by Henry Wilkes at 2024-06-11T09:15:33+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - 85bda33b by Kathy Brade at 2024-06-11T09:15:33+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 433843ec by Alex Catarineu at 2024-06-11T09:15:33+02:00 Add TorStrings module for localization - - - - - cfaaede2 by Henry Wilkes at 2024-06-11T09:15:34+02:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - f6098cce by Henry Wilkes at 2024-06-11T09:15:34+02:00 Tor Browser localization migration scripts. - - - - - 7e43587d by Henry Wilkes at 2024-06-11T09:15:34+02:00 Bug 42305: Add script to combine translation files across versions. - - - - - d83e33cb by Mike Perry at 2024-06-11T09:15:34+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - 16d5457d by Henry Wilkes at 2024-06-11T09:15:35+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser Bug 42583: Move moz-support-link change out of the branding commit. - - - - - ab5d7245 by Henry Wilkes at 2024-06-11T09:15:35+02:00 Bug 42583: Modify moz-support-link for Tor Browser. - - - - - 5f8cb22e by hackademix at 2024-06-11T09:15:35+02:00 Bug 41917: Tor brand-specific styles. - - - - - 1b6c858b by Henry Wilkes at 2024-06-11T09:15:35+02:00 Add purple tor version of the loading APNG. - - - - - c11e69aa by sanketh at 2024-06-11T09:15:36+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - a791c59b by Mike Perry at 2024-06-11T09:15:36+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - 4f55f107 by Henry Wilkes at 2024-06-11T09:15:36+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 0a89a742 by Pier Angelo Vendrame at 2024-06-11T09:15:36+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - b9a27b5a by Richard Pospesel at 2024-06-11T09:15:37+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Bug 241: Move network.proxy.failover_direct=false pref to base-browser - - - - - 9e3a72e0 by Pier Angelo Vendrame at 2024-06-11T09:15:37+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - 9997cac3 by Pier Angelo Vendrame at 2024-06-11T09:15:37+02:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - 6711a75a by Pier Angelo Vendrame at 2024-06-11T09:15:37+02:00 fixup! Bug 40933: Add tor-launcher functionality Bug 42604: Log the circuit nodes when we see the CIRC BUILT event (with debug level). - - - - - b5e6d2da by Cecylia Bocovich at 2024-06-11T09:15:38+02:00 Lox integration - - - - - 53f4f57d by Richard Pospesel at 2024-06-11T09:15:38+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - e272fdcb by Arthur Edelstein at 2024-06-11T09:15:38+02:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - 5721d475 by Pier Angelo Vendrame at 2024-06-11T09:15:38+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 42604: Log a message when we update the data about a certain circuit. - - - - - 01d6a72b by Henry Wilkes at 2024-06-11T09:15:39+02:00 Bug 41600: Add a tor circuit display panel. - - - - - 69f82e3e by Henry Wilkes at 2024-06-11T09:15:39+02:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 41859: Increase ip address font size to make them more legible on windows OS. - - - - - 4571ea46 by Pier Angelo Vendrame at 2024-06-11T09:15:39+02:00 Bug 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - 97ad8b08 by hackademix at 2024-06-11T09:15:39+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - f065aa8c by Amogh Pradeep at 2024-06-11T09:15:40+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - 727d2c5f by Matthew Finkel at 2024-06-11T09:15:40+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 6322e1a2 by Kathy Brade at 2024-06-11T09:15:40+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - 7a32ba18 by Pier Angelo Vendrame at 2024-06-11T09:15:40+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - 37b589f7 by Richard Pospesel at 2024-06-11T09:15:41+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 9ec9a2b6 by Richard Pospesel at 2024-06-11T09:15:41+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 67bd7f5c by Henry Wilkes at 2024-06-11T09:15:41+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser Bug 41621: Tweak about:torconnect style. - - - - - 4c7f3518 by Pier Angelo Vendrame at 2024-06-11T09:15:41+02:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - aea9cfc6 by Henry Wilkes at 2024-06-11T09:15:42+02:00 fixup! Temporary changes to about:torconnect for Android. Bug 41621: Make sure button's layout parent is .button-container when not on android. - - - - - e03420cd by Henry Wilkes at 2024-06-11T10:54:34+02:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - eb16683d by Arthur Edelstein at 2024-06-11T10:57:07+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - fffacc4a by Pier Angelo Vendrame at 2024-06-11T10:57:07+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - 54eacc30 by Kathy Brade at 2024-06-11T10:57:07+02:00 Bug 12647: Support symlinks in the updater. - - - - - 0f0901e9 by Kathy Brade at 2024-06-11T10:57:07+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - 2ae72f61 by Kathy Brade at 2024-06-11T10:57:08+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - b3660e0d by Georg Koppen at 2024-06-11T10:57:08+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 12888fbb by Mike Perry at 2024-06-11T10:57:08+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - f2102b26 by Dan Ballard at 2024-06-11T10:57:08+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing bug 42290: change duckduckgoonion to duckduckgo onion and same for startpageonion - - - - - 05f20057 by Alex Catarineu at 2024-06-11T10:57:09+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - fac0e6c7 by Henry Wilkes at 2024-06-11T10:57:09+02:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - f2085b60 by Richard Pospesel at 2024-06-11T10:57:09+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - c630d649 by Kathy Brade at 2024-06-11T11:44:22+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - 3628fad6 by hackademix at 2024-06-11T11:44:34+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42557: Fix regression in Onion Services authentication prompt focus - - - - - 01fd75d7 by Alex Catarineu at 2024-06-11T11:44:34+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 3849610e by Pier Angelo Vendrame at 2024-06-11T11:44:35+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 1c09dd6b by Pier Angelo Vendrame at 2024-06-11T11:44:35+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - ae75c471 by Pier Angelo Vendrame at 2024-06-11T11:44:35+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - a8145748 by Henry Wilkes at 2024-06-11T11:44:35+02:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - b8bea58b by Dan Ballard at 2024-06-11T11:44:36+02:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - b50a800b by Henry Wilkes at 2024-06-11T11:44:36+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - fcd9b1f6 by hackademix at 2024-06-11T11:44:36+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - 8773ae8a by Henry Wilkes at 2024-06-11T11:44:36+02:00 Customize moz-toggle for tor-browser. - - - - - a072539d by Richard Pospesel at 2024-06-11T11:44:36+02:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 3649e706 by Cecylia Bocovich at 2024-06-11T11:44:37+02:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - b59af9b7 by Pier Angelo Vendrame at 2024-06-11T11:44:37+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser Use the correct volume name on macOS. - - - - - 4745c22c by Pier Angelo Vendrame at 2024-06-12T12:03:53+00:00 fixup! Bug 41736: Hide NoScript extension's toolbar button by default. - - - - - 47e31947 by Pier Angelo Vendrame at 2024-06-12T12:04:31+00:00 fixup! Bug 41736: Hide NoScript extension's toolbar button by default. - - - - - 66463ec9 by Pier Angelo Vendrame at 2024-06-12T12:05:07+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt - - - - - 6b840f4f by Pier Angelo Vendrame at 2024-06-12T17:37:23+02:00 fixup! Bug 40933: Add tor-launcher functionality Bug 42636: A bad bridge line might get TBA stuck. A while ago I reworked the relationship between TorSettings and TorProvider. While doing so I was too strict, and a failure to push settings during initialization will stop the initialization itself, which will result in TBA stuck at the splash screen. The problem appears also on desktop (the user will get a prompt that asks to restart Tor, even though it is not perfect, see #21053). However, on desktop the user can go to the settings and deleting the bridges from there (which is not an optimal experience anyway). - - - - - 5c060b45 by Pier Angelo Vendrame at 2024-06-13T11:33:36+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Switch to the new configuration objects to fix various runtime errors. Keep only DuckDuckGo for now, we will add the rest of engines when addressing tor-browser#41835. - - - - - b28a5a33 by Pier Angelo Vendrame at 2024-06-13T09:36:14+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42587: Remove ensureCustomElements in esr 128 - - - - - 10d1adae by Pier Angelo Vendrame at 2024-06-13T11:40:05+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Move the default log level to the preference file to avoid a runtime error. - - - - - ed5b3a4e by Pier Angelo Vendrame at 2024-06-18T14:02:26+02:00 Bug 42616: Remove VideoCaptureTest.kt. This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False. - - - - - 126e1110 by Pier Angelo Vendrame at 2024-06-19T13:59:59+02:00 fixup! Bug 42247: Android helpers for the TorProvider Do not redeclare lazy. - - - - - 7a815c2a by Pier Angelo Vendrame at 2024-06-20T09:07:42+02:00 Bug 1903254 - Explicitly include <array> in relrhack.cpp r=glandium Differential Revision: https://phabricator.services.mozilla.com/D214097 - - - - - 051896ef by Pier Angelo Vendrame at 2024-06-20T07:09:31+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt - - - - - 11e289c3 by Pier Angelo Vendrame at 2024-06-24T18:04:21+02:00 fixup! Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser Update the comment. - - - - - 64397b7e by Pier Angelo Vendrame at 2024-06-26T11:53:45+02:00 fixup! Bug 23247: Communicating security expectations for .onion Fix a TypeError in _hasCustomRoot. After this fix opening the identity panel will not result in a JS error anymore. However, the identity panel will not be accurate for Onion sites anyway. - - - - - d3f90346 by Pier Angelo Vendrame at 2024-06-26T12:45:52+02:00 fixup! Bug 16940: After update, load local change notes. ESMified. - - - - - 1d9f569a by Pier Angelo Vendrame at 2024-06-26T15:58:26+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser Remove the unused errorCode parameter in _shouldRegisterBootstrapObserver. Also, aligned a string to the 80 characters limit. - - - - - 5993f134 by Pier Angelo Vendrame at 2024-06-27T09:18:04+02:00 fixup! Bug 42247: Android helpers for the TorProvider Documentation improvements. - - - - - 6d46c2ad by Pier Angelo Vendrame at 2024-06-27T12:23:35+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances Silence a too spammy error message until we fix this commit. - - - - - b934b41b by Pier Angelo Vendrame at 2024-07-08T15:42:59+02:00 fixup! Bug 40597: Implement TorSettings module Updated some comments - - - - - 2348214b by Pier Angelo Vendrame at 2024-07-09T09:36:21+02:00 fixup! Bug 40597: Implement TorSettings module Do not freeze TorConnectError. - - - - - 0b146565 by Pier Angelo Vendrame at 2024-07-09T11:24:09+02:00 fixup! Bug 40933: Add tor-launcher functionality Fix some comments. - - - - - 25193798 by Pier Angelo Vendrame at 2024-07-09T11:56:36+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js extensions.torbutton.launch_warning does not exist anymore. - - - - - f0956141 by Pier Angelo Vendrame at 2024-07-09T12:43:25+02:00 fixup! Bug 40209: Implement Basic Crypto Safety Esmified. - - - - - 14db2d4a by Pier Angelo Vendrame at 2024-07-09T16:27:17+02:00 fixup! Bug 40926: Implemented the New Identity feature Move to HTML stylesheets instead of XML ones to be coherent with upstream. Also, switch from XPCOMUtils to ChromeUtils. - - - - - 8ab51350 by Beatriz Rizental at 2024-07-11T11:43:54+02:00 Revert "Add CI for Tor Browser" This reverts commit ec03736019a0337b4a81f7c6566119337c2d53aa. - - - - - aacf3643 by Beatriz Rizental at 2024-07-11T11:43:55+02:00 Add CI for Base Browser - - - - - f1eee497 by Beatriz Rizental at 2024-07-11T11:43:56+02:00 Add CI for Tor Browser - - - - - fbbb577a by Pier Angelo Vendrame at 2024-07-11T14:54:03+02:00 fixup! Bug 9173: Change the default Firefox profile directory to be relative. Always shortcut the portable installation check on macOS after the first run of nsXREDirProvider::GetPortableDataDir. - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab-ci.yml - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/run_linters.py - + .gitlab/ci/update-translations.yml - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + README.md - − README.txt - + browser/actors/AboutTBUpdateChild.sys.mjs - + browser/actors/AboutTBUpdateParent.sys.mjs - + browser/actors/CryptoSafetyChild.sys.mjs - + browser/actors/CryptoSafetyParent.sys.mjs - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9352d2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9352d2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.13.0esr-13.5-1] Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 11 Jul '24

11 Jul '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.13.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 845b9843 by Beatriz Rizental at 2024-07-11T11:21:30+02:00 Add CI for Base Browser - - - - - 3 changed files: - + .gitlab-ci.yml - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/run_linters.py Changes: ===================================== .gitlab-ci.yml ===================================== @@ -0,0 +1,5 @@ +stages: + - lint + +include: + - local: '.gitlab/ci/lint.yml' ===================================== .gitlab/ci/lint.yml ===================================== @@ -0,0 +1,319 @@ +variables: + # This needs to be kept in sync with the max Python version accepted by ./mach + PYTHON_VERSION: "3.11.7" + +.base: + stage: lint + interruptible: true + variables: + PIP_CACHE_DIR: "$CI_PROJECT_DIR/.cache/pip" + cache: + paths: + - node_modules + - .cache/pip + +eslint: + extends: .base + image: cimg/python:$PYTHON_VERSION-node + script: + - .gitlab/ci/scripts/run_linters.py eslint + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + # Files that are likely audited. + - '**/*.js' + - '**/*.jsm' + - '**/*.json' + - '**/*.jsx' + - '**/*.mjs' + - '**/*.sjs' + - '**/*.html' + - '**/*.xhtml' + - '**/*.xml' + - 'tools/lint/eslint.yml' + # Run when eslint policies change. + - '**/.eslintignore' + - '**/*eslintrc*' + # The plugin implementing custom checks. + - 'tools/lint/eslint/eslint-plugin-mozilla/**' + - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +stylelint: + extends: .base + image: cimg/python:$PYTHON_VERSION-node + script: + - .gitlab/ci/scripts/run_linters.py stylelint + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + # Files that are likely audited. + - '**/*.css' + - 'tools/lint/styleint.yml' + # Run when stylelint policies change. + - '**/.stylelintignore' + - '**/*stylelintrc*' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +py-black: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py black + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + # The list of extensions should match tools/lint/black.yml + - '**/*.py' + - '**/moz.build' + - '**/*.configure' + - '**/*.mozbuild' + - 'pyproject.toml' + - 'tools/lint/black.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +py-ruff: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py ruff + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.py' + - '**/*.configure' + - '**/.ruff.toml' + - 'pyproject.toml' + - 'tools/lint/ruff.yml' + - 'tools/lint/python/ruff.py' + - 'tools/lint/python/ruff_requirements.txt' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +yaml: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py yaml + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.yml' + - '**/*.yaml' + - '**/.ymllint' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +shellcheck: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py shellcheck + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.sh' + - 'tools/lint/shellcheck.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +clang-format: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py clang-format + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.cpp' + - '**/*.c' + - '**/*.cc' + - '**/*.h' + - '**/*.m' + - '**/*.mm' + - 'tools/lint/clang-format.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +rustfmt: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py rustfmt + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.rs' + - 'tools/lint/rustfmt.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +fluent-lint: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py fluent-lint + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.ftl' + - 'tools/lint/fluent-lint.yml' + - 'tools/lint/fluent-lint/exclusions.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +localization: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py l10n + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/locales/en-US/**' + - '**/l10n.toml' + - 'third_party/python/compare-locales/**' + - 'third_party/python/fluent/**' + - 'tools/lint/l10n.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +mingw-capitalization: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py mingw-capitalization + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.cpp' + - '**/*.cc' + - '**/*.c' + - '**/*.h' + - 'tools/lint/mingw-capitalization.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +mscom-init: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py mscom-init + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.cpp' + - '**/*.cc' + - '**/*.c' + - '**/*.h' + - 'tools/lint/mscom-init.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +file-whitespace: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py file-whitespace + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.c' + - '**/*.cc' + - '**/*.cpp' + - '**/*.css' + - '**/*.dtd' + - '**/*.idl' + - '**/*.ftl' + - '**/*.h' + - '**/*.html' + - '**/*.md' + - '**/*.properties' + - '**/*.py' + - '**/*.rs' + - '**/*.rst' + - '**/*.webidl' + - '**/*.xhtml' + - 'tools/lint/file-whitespace.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +test-manifest: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py test-manifest-alpha test-manifest-disable test-manifest-skip-if + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.ini' + - 'python/mozlint/**' + - 'tools/lint/**' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +trojan-source: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py trojan-source + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.c' + - '**/*.cc' + - '**/*.cpp' + - '**/*.h' + - '**/*.py' + - '**/*.rs' + - 'tools/lint/trojan-source.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' ===================================== .gitlab/ci/scripts/run_linters.py ===================================== @@ -0,0 +1,110 @@ +#!/usr/bin/env python3 + +import argparse +import os +import re +import shlex +import subprocess +import sys + + +def git(command): + result = subprocess.run( + ["git"] + shlex.split(command), check=True, capture_output=True, text=True + ) + return result.stdout.strip() + + +def get_firefox_tag_from_branch_name(branch_name): + """Extracts the Firefox tag associated with a branch name. + + The "firefox tag" is the tag that marks + the end of the Mozilla commits and the start of the Tor Project commits. + + Know issue: If ever there is more than one tag per Firefox ESR version, + this function may return the incorrect reference number. + + Args: + branch_name: The branch name to extract the tag from. + Expected format is tor-browser-91.2.0esr-11.0-1, + where 91.2.0esr is the Firefox version. + + Returns: + The reference specifier of the matching Firefox tag. + An exception wil be raised if anything goes wrong. + """ + + # Extracts the version number from a branch name. + firefox_version = "" + match = re.search(r"(?<=browser-)([^-]+)", branch_name) + if match: + # TODO: Validate that what we got is actually a valid semver string? + firefox_version = match.group(1) + else: + raise ValueError(f"Failed to extract version from branch name '{branch_name}'.") + + tag = f"FIREFOX_{firefox_version.replace('.', '_')}_" + remote_tags = git("ls-remote --tags") + + # Each line looks like: + # 9edd658bfd03a6b4743ecb75fd4a9ad968603715 refs/tags/FIREFOX_91_9_0esr_BUILD1 + pattern = rf"(.*){re.escape(tag)}(.*)$" + match = re.search(pattern, remote_tags, flags=re.MULTILINE) + if match: + return match.group(0).split()[0] + else: + raise ValueError( + f"Failed to find reference specifier for Firefox tag in branch '{branch_name}'." + ) + + +def get_list_of_changed_files(): + """Gets a list of files changed in the working directory. + + This function is meant to be run inside the Gitlab CI environment. + + When running in a default branch, get the list of changed files since the last Firefox tag. + When running for a new MR commit, get a list of changed files in the current MR. + + Returns: + A list of filenames of changed files (excluding deleted files). + An exception wil be raised if anything goes wrong. + """ + + base_reference = "" + + if os.getenv("CI_PIPELINE_SOURCE") == "merge_request_event": + # For merge requests, the base_reference is the common ancestor between the MR and the target branch. + base_reference = os.getenv("CI_MERGE_REQUEST_DIFF_BASE_SHA") + else: + # When not in merge requests, the base reference is the Firefox tag + base_reference = get_firefox_tag_from_branch_name(os.getenv("CI_COMMIT_BRANCH")) + + if not base_reference: + raise RuntimeError("No base reference found. There might be more errors above.") + + # Fetch the tag reference + git(f"fetch origin {base_reference} --depth=1 --filter=blob:none") + # Return the list of changed files + return git(f"diff --diff-filter=d --name-only {base_reference} HEAD").split("\n") + + +if __name__ == "__main__": + parser = argparse.ArgumentParser( + description="Run ./mach linters in CI. Warning: if you run this in your local environment it might mess up your git history." + ) + parser.add_argument( + "linters", metavar="L", type=str, nargs="+", help="A list of linters to run." + ) + args = parser.parse_args() + + command = [ + "./mach", + "lint", + "-v", + *(s for l in args.linters for s in ("-l", l)), + *get_list_of_changed_files(), + ] + result = subprocess.run(command, text=True) + + sys.exit(result.returncode) View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/845… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/845… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.13.0esr-13.5-1] Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 11 Jul '24

11 Jul '24

Pier Angelo Vendrame pushed to branch base-browser-115.13.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 7b915bf9 by Beatriz Rizental at 2024-07-11T11:20:16+02:00 Add CI for Base Browser - - - - - 3 changed files: - + .gitlab-ci.yml - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/run_linters.py Changes: ===================================== .gitlab-ci.yml ===================================== @@ -0,0 +1,5 @@ +stages: + - lint + +include: + - local: '.gitlab/ci/lint.yml' ===================================== .gitlab/ci/lint.yml ===================================== @@ -0,0 +1,319 @@ +variables: + # This needs to be kept in sync with the max Python version accepted by ./mach + PYTHON_VERSION: "3.11.7" + +.base: + stage: lint + interruptible: true + variables: + PIP_CACHE_DIR: "$CI_PROJECT_DIR/.cache/pip" + cache: + paths: + - node_modules + - .cache/pip + +eslint: + extends: .base + image: cimg/python:$PYTHON_VERSION-node + script: + - .gitlab/ci/scripts/run_linters.py eslint + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + # Files that are likely audited. + - '**/*.js' + - '**/*.jsm' + - '**/*.json' + - '**/*.jsx' + - '**/*.mjs' + - '**/*.sjs' + - '**/*.html' + - '**/*.xhtml' + - '**/*.xml' + - 'tools/lint/eslint.yml' + # Run when eslint policies change. + - '**/.eslintignore' + - '**/*eslintrc*' + # The plugin implementing custom checks. + - 'tools/lint/eslint/eslint-plugin-mozilla/**' + - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +stylelint: + extends: .base + image: cimg/python:$PYTHON_VERSION-node + script: + - .gitlab/ci/scripts/run_linters.py stylelint + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + # Files that are likely audited. + - '**/*.css' + - 'tools/lint/styleint.yml' + # Run when stylelint policies change. + - '**/.stylelintignore' + - '**/*stylelintrc*' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +py-black: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py black + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + # The list of extensions should match tools/lint/black.yml + - '**/*.py' + - '**/moz.build' + - '**/*.configure' + - '**/*.mozbuild' + - 'pyproject.toml' + - 'tools/lint/black.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +py-ruff: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py ruff + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.py' + - '**/*.configure' + - '**/.ruff.toml' + - 'pyproject.toml' + - 'tools/lint/ruff.yml' + - 'tools/lint/python/ruff.py' + - 'tools/lint/python/ruff_requirements.txt' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +yaml: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py yaml + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.yml' + - '**/*.yaml' + - '**/.ymllint' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +shellcheck: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py shellcheck + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.sh' + - 'tools/lint/shellcheck.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +clang-format: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py clang-format + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.cpp' + - '**/*.c' + - '**/*.cc' + - '**/*.h' + - '**/*.m' + - '**/*.mm' + - 'tools/lint/clang-format.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +rustfmt: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py rustfmt + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.rs' + - 'tools/lint/rustfmt.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +fluent-lint: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py fluent-lint + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.ftl' + - 'tools/lint/fluent-lint.yml' + - 'tools/lint/fluent-lint/exclusions.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +localization: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py l10n + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/locales/en-US/**' + - '**/l10n.toml' + - 'third_party/python/compare-locales/**' + - 'third_party/python/fluent/**' + - 'tools/lint/l10n.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +mingw-capitalization: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py mingw-capitalization + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.cpp' + - '**/*.cc' + - '**/*.c' + - '**/*.h' + - 'tools/lint/mingw-capitalization.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +mscom-init: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py mscom-init + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.cpp' + - '**/*.cc' + - '**/*.c' + - '**/*.h' + - 'tools/lint/mscom-init.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +file-whitespace: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py file-whitespace + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.c' + - '**/*.cc' + - '**/*.cpp' + - '**/*.css' + - '**/*.dtd' + - '**/*.idl' + - '**/*.ftl' + - '**/*.h' + - '**/*.html' + - '**/*.md' + - '**/*.properties' + - '**/*.py' + - '**/*.rs' + - '**/*.rst' + - '**/*.webidl' + - '**/*.xhtml' + - 'tools/lint/file-whitespace.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +test-manifest: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py test-manifest-alpha test-manifest-disable test-manifest-skip-if + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.ini' + - 'python/mozlint/**' + - 'tools/lint/**' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' + +trojan-source: + extends: .base + image: cimg/python:$PYTHON_VERSION + script: + - .gitlab/ci/scripts/run_linters.py trojan-source + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' + changes: + # List copied from: taskcluster/ci/source-test/mozlint.yml + # + - '**/*.c' + - '**/*.cc' + - '**/*.cpp' + - '**/*.h' + - '**/*.py' + - '**/*.rs' + - 'tools/lint/trojan-source.yml' + # Run job whenever a new tag is created + # or whenever a commit is merged to a protected branch + - if: $CI_COMMIT_TAG || $CI_COMMIT_REF_PROTECTED == 'true' ===================================== .gitlab/ci/scripts/run_linters.py ===================================== @@ -0,0 +1,110 @@ +#!/usr/bin/env python3 + +import argparse +import os +import re +import shlex +import subprocess +import sys + + +def git(command): + result = subprocess.run( + ["git"] + shlex.split(command), check=True, capture_output=True, text=True + ) + return result.stdout.strip() + + +def get_firefox_tag_from_branch_name(branch_name): + """Extracts the Firefox tag associated with a branch name. + + The "firefox tag" is the tag that marks + the end of the Mozilla commits and the start of the Tor Project commits. + + Know issue: If ever there is more than one tag per Firefox ESR version, + this function may return the incorrect reference number. + + Args: + branch_name: The branch name to extract the tag from. + Expected format is tor-browser-91.2.0esr-11.0-1, + where 91.2.0esr is the Firefox version. + + Returns: + The reference specifier of the matching Firefox tag. + An exception wil be raised if anything goes wrong. + """ + + # Extracts the version number from a branch name. + firefox_version = "" + match = re.search(r"(?<=browser-)([^-]+)", branch_name) + if match: + # TODO: Validate that what we got is actually a valid semver string? + firefox_version = match.group(1) + else: + raise ValueError(f"Failed to extract version from branch name '{branch_name}'.") + + tag = f"FIREFOX_{firefox_version.replace('.', '_')}_" + remote_tags = git("ls-remote --tags") + + # Each line looks like: + # 9edd658bfd03a6b4743ecb75fd4a9ad968603715 refs/tags/FIREFOX_91_9_0esr_BUILD1 + pattern = rf"(.*){re.escape(tag)}(.*)$" + match = re.search(pattern, remote_tags, flags=re.MULTILINE) + if match: + return match.group(0).split()[0] + else: + raise ValueError( + f"Failed to find reference specifier for Firefox tag in branch '{branch_name}'." + ) + + +def get_list_of_changed_files(): + """Gets a list of files changed in the working directory. + + This function is meant to be run inside the Gitlab CI environment. + + When running in a default branch, get the list of changed files since the last Firefox tag. + When running for a new MR commit, get a list of changed files in the current MR. + + Returns: + A list of filenames of changed files (excluding deleted files). + An exception wil be raised if anything goes wrong. + """ + + base_reference = "" + + if os.getenv("CI_PIPELINE_SOURCE") == "merge_request_event": + # For merge requests, the base_reference is the common ancestor between the MR and the target branch. + base_reference = os.getenv("CI_MERGE_REQUEST_DIFF_BASE_SHA") + else: + # When not in merge requests, the base reference is the Firefox tag + base_reference = get_firefox_tag_from_branch_name(os.getenv("CI_COMMIT_BRANCH")) + + if not base_reference: + raise RuntimeError("No base reference found. There might be more errors above.") + + # Fetch the tag reference + git(f"fetch origin {base_reference} --depth=1 --filter=blob:none") + # Return the list of changed files + return git(f"diff --diff-filter=d --name-only {base_reference} HEAD").split("\n") + + +if __name__ == "__main__": + parser = argparse.ArgumentParser( + description="Run ./mach linters in CI. Warning: if you run this in your local environment it might mess up your git history." + ) + parser.add_argument( + "linters", metavar="L", type=str, nargs="+", help="A list of linters to run." + ) + args = parser.parse_args() + + command = [ + "./mach", + "lint", + "-v", + *(s for l in args.linters for s in ("-l", l)), + *get_list_of_changed_files(), + ] + result = subprocess.run(command, text=True) + + sys.exit(result.returncode) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7b915bf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7b915bf… You're receiving this email because of your account on gitlab.torproject.org.

1 0