- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-128.0esr-14.0-2-build1
by Pier Angelo Vendrame (＠pierov) 24 Jul '24

24 Jul '24

Pier Angelo Vendrame pushed new tag tor-browser-128.0esr-14.0-2-build1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.0esr-14.0-2] 197 commits: Bug 42725: Fix upstream lint issues
by Pier Angelo Vendrame (＠pierov) 24 Jul '24

24 Jul '24

Pier Angelo Vendrame pushed to branch tor-browser-128.0esr-14.0-2 at The Tor Project / Applications / Tor Browser Commits: 0c49b3f6 by Beatriz Rizental at 2024-07-23T19:41:04+02:00 Bug 42725: Fix upstream lint issues - - - - - 7796a6db by Henry Wilkes at 2024-07-23T19:41:06+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - fb1fc7f3 by hackademix at 2024-07-23T19:41:08+02:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - d07f9e82 by Henry Wilkes at 2024-07-23T19:41:10+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - aec06a56 by Marco Simonelli at 2024-07-23T19:41:12+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - c830a8d5 by Marco Simonelli at 2024-07-23T19:41:14+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - d3c33c22 by Marco Simonelli at 2024-07-23T19:41:16+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - c96beadf by Marco Simonelli at 2024-07-23T19:41:18+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - 74cf1d11 by Marco Simonelli at 2024-07-23T19:41:20+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - d8e23a88 by Beatriz Rizental at 2024-07-23T19:50:14+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 5) - - - - - 84b5c535 by Marco Simonelli at 2024-07-23T19:50:25+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 7636e980 by hackademix at 2024-07-23T19:50:25+02:00 Bug 41854: Allow overriding download spam protection. - - - - - 73625495 by Beatriz Rizental at 2024-07-23T19:50:27+02:00 fixup! Bug 41854: Allow overriding download spam protection. - - - - - 70a6a25a by Gaba at 2024-07-23T19:50:32+02:00 Adding issue and merge request templates - - - - - aa3e17a4 by Richard Pospesel at 2024-07-24T11:24:09+02:00 Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - a34db0d2 by Beatriz Rizental at 2024-07-24T11:24:09+02:00 Add CI for Base Browser - - - - - 4db7e6a5 by Pier Angelo Vendrame at 2024-07-24T11:24:09+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 56796691 by Beatriz Rizental at 2024-07-24T11:24:10+02:00 fixup! Base Browser's .mozconfigs. - - - - - 4802f03a by Pier Angelo Vendrame at 2024-07-24T11:24:10+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 634e1ec6 by Pier Angelo Vendrame at 2024-07-24T11:24:14+02:00 Bug 29320: Replace the gnu target with gnullvm for Rust. - - - - - 3941617d by Pier Angelo Vendrame at 2024-07-24T11:24:16+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - 70004a86 by Dan Ballard at 2024-07-24T11:24:18+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - dd521000 by Matthew Finkel at 2024-07-24T11:24:20+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - ef2988ba by Matthew Finkel at 2024-07-24T11:24:22+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 797c5eeb by Mike Perry at 2024-07-24T11:24:24+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 9e8b32bd by Alex Catarineu at 2024-07-24T11:24:26+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 3a5371da by Georg Koppen at 2024-07-24T11:24:28+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - 788e9d9f by Kathy Brade at 2024-07-24T11:24:30+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - 621e25f9 by Beatriz Rizental at 2024-07-24T11:24:32+02:00 fixup! Bug 21431: Clean-up system extensions shipped in Firefox - - - - - 57e22fe5 by Kathy Brade at 2024-07-24T11:24:34+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 0785d631 by Alex Catarineu at 2024-07-24T11:24:36+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 853df5e7 by Kathy Brade at 2024-07-24T11:24:38+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - 8eb08c6f by Arthur Edelstein at 2024-07-24T11:24:40+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 33f04267 by Alex Catarineu at 2024-07-24T11:24:42+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - 2f0e35c5 by Beatriz Rizental at 2024-07-24T11:24:45+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances - - - - - 80cba2b4 by cypherpunks1 at 2024-07-24T11:24:47+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - a19bffab by Pier Angelo Vendrame at 2024-07-24T11:24:48+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 65be20c5 by Georg Koppen at 2024-07-24T11:24:51+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - 9d6050f5 by Alex Catarineu at 2024-07-24T11:24:53+02:00 Bug 28369: Stop shipping pingsender executable - - - - - 7a369ad5 by cypherpunks1 at 2024-07-24T11:24:54+02:00 Bug 41568: Disable LaterRun - - - - - 4b183a52 by cypherpunks1 at 2024-07-24T11:24:57+02:00 Bug 40717: Hide Windows SSO in settings - - - - - fc6d12de by Pier Angelo Vendrame at 2024-07-24T11:24:59+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 856c716d by Richard Pospesel at 2024-07-24T11:25:01+02:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - c80e3b88 by Beatriz Rizental at 2024-07-24T11:25:03+02:00 fixup! Bug 41327: Disable UrlbarProviderInterventions - - - - - 0590405a by Richard Pospesel at 2024-07-24T11:25:05+02:00 Bug 42037: Disable about:firefoxview page - - - - - 41fb396a by Mike Perry at 2024-07-24T11:25:11+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - f160c645 by Beatriz Rizental at 2024-07-24T11:25:13+02:00 fixup! Firefox preference overrides. - - - - - 47c79f74 by Pier Angelo Vendrame at 2024-07-24T11:25:15+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - 36b4e48a by Pier Angelo Vendrame at 2024-07-24T11:25:17+02:00 Bug 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - a4c8fc8e by Alex Catarineu at 2024-07-24T11:25:19+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - e5dbea21 by Pier Angelo Vendrame at 2024-07-24T11:25:21+02:00 Bug 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - 3bf945e1 by Alex Catarineu at 2024-07-24T11:25:23+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 9c4934b4 by Alex Catarineu at 2024-07-24T11:25:25+02:00 Bug 26345: Hide tracking protection UI - - - - - 3baa1f5e by Pier Angelo Vendrame at 2024-07-24T11:25:27+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - 2aa0c097 by Beatriz Rizental at 2024-07-24T11:25:29+02:00 fixup! Bug 9173: Change the default Firefox profile directory to be relative. - - - - - 4d5b432b by Alex Catarineu at 2024-07-24T11:25:31+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - 61f05aa0 by Mike Perry at 2024-07-24T11:25:34+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - 55699d2b by Pier Angelo Vendrame at 2024-07-24T11:25:36+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 34b2ecb0 by Matthew Finkel at 2024-07-24T11:25:38+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - dc5ab1e7 by cypherpunks1 at 2024-07-24T11:25:40+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 81de6ea1 by cypherpunks1 at 2024-07-24T11:25:42+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - fd4cac03 by hackademix at 2024-07-24T11:25:44+02:00 Bug 42288: Allow language spoofing in status messages. - - - - - 3f5002b6 by Beatriz Rizental at 2024-07-24T11:25:46+02:00 fixup! Bug 42288: Allow language spoofing in status messages. - - - - - 9a010b0c by Richard Pospesel at 2024-07-24T11:25:48+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - 2e3abbd6 by Beatriz Rizental at 2024-07-24T11:25:50+02:00 fixup! Bug 41659: Add canonical color definitions to base-browser - - - - - a55bc59b by Pier Angelo Vendrame at 2024-07-24T11:25:52+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 4df0b172 by Beatriz Rizental at 2024-07-24T11:25:54+02:00 fixup! Base Browser strings - - - - - f81ec392 by Pier Angelo Vendrame at 2024-07-24T11:25:57+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 17e93b3d by p13dz at 2024-07-24T11:25:59+02:00 Bug 40283: Workaround for the file upload bug - - - - - afb86219 by Arthur Edelstein at 2024-07-24T11:26:01+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - c5e85222 by Pier Angelo Vendrame at 2024-07-24T11:26:03+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - bf641141 by hackademix at 2024-07-24T11:26:06+02:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - 9036931c by Beatriz Rizental at 2024-07-24T15:47:19+02:00 fixup! Bug 42019: Empty browser's clipboard on browser shutdown - - - - - ab7f90dd by hackademix at 2024-07-24T15:47:19+02:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - 5882e1a5 by Pier Angelo Vendrame at 2024-07-24T15:47:20+02:00 Bug 41930: Remove the UI to customize accept_languages. - - - - - 98f087a3 by Pier Angelo Vendrame at 2024-07-24T15:47:20+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - 883d8545 by hackademix at 2024-07-24T15:47:21+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - f74d37bf by hackademix at 2024-07-24T15:47:21+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 5217a47c by hackademix at 2024-07-24T15:47:21+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 147ba5fe by hackademix at 2024-07-24T15:47:22+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - 1546efcc by hackademix at 2024-07-24T15:47:22+02:00 Bug 42574: Letterboxing, exempt pdf.js. - - - - - 95401eac by hackademix at 2024-07-24T15:47:23+02:00 Bug 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 07c7e593 by hackademix at 2024-07-24T15:47:23+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - cd86d36a by hackademix at 2024-07-24T15:47:23+02:00 Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - b87ece37 by Beatriz Rizental at 2024-07-24T15:47:24+02:00 fixup! Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - 7456e05e by hackademix at 2024-07-24T15:47:24+02:00 Bug 41916: Letterboxing preferences UI - - - - - 96bec882 by hackademix at 2024-07-24T15:47:25+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - b2b67f19 by hackademix at 2024-07-24T15:47:25+02:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - 3982ff18 by Henry Wilkes at 2024-07-24T15:47:25+02:00 Bug 42528: Don't leak system scrollbar size on windows. - - - - - 660fdb3f by Henry Wilkes at 2024-07-24T15:47:26+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 3c52629f by Beatriz Rizental at 2024-07-24T15:47:26+02:00 fixup! Bug 31575: Disable Firefox Home (Activity Stream) - - - - - 50e47d86 by Kathy Brade at 2024-07-24T15:47:27+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - ce945e5d by Beatriz Rizental at 2024-07-24T15:47:27+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. - - - - - c8e7f775 by Pier Angelo Vendrame at 2024-07-24T15:47:27+02:00 Bug 42061: Create an alpha update channel. - - - - - 4489ad3b by Nicolas Vigier at 2024-07-24T15:47:28+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - bff5a436 by Pier Angelo Vendrame at 2024-07-24T15:47:28+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - dceb0d4d by Pier Angelo Vendrame at 2024-07-24T15:47:29+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 3d66f2a7 by Pier Angelo Vendrame at 2024-07-24T15:47:29+02:00 Bug 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - 1d312e5b by Beatriz Rizental at 2024-07-24T15:47:29+02:00 fixup! Bug 42438: Tweaks to the migration wizard. - - - - - 4d278333 by Alex Catarineu at 2024-07-24T15:47:30+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - bb71f502 by Matthew Finkel at 2024-07-24T15:47:30+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 7021ab66 by Henry Wilkes at 2024-07-24T15:47:30+02:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - e51da9af by hackademix at 2024-07-24T15:47:31+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 26752119 by Beatriz Rizental at 2024-07-24T15:47:31+02:00 fixup! Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 060b0f16 by Pier Angelo Vendrame at 2024-07-24T15:47:32+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 8651217b by Beatriz Rizental at 2024-07-24T15:47:32+02:00 fixup! Bug 40925: Implemented the Security Level component - - - - - a03328ea by Pier Angelo Vendrame at 2024-07-24T15:47:32+02:00 Bug 40926: Implemented the New Identity feature - - - - - 058b6b75 by Beatriz Rizental at 2024-07-24T15:47:33+02:00 fixup! Bug 40926: Implemented the New Identity feature - - - - - fd8a8ce6 by Henry Wilkes at 2024-07-24T15:47:33+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 5ebfb7d7 by Pier Angelo Vendrame at 2024-07-24T15:47:37+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - dd8769ab by Henry Wilkes at 2024-07-24T15:47:39+02:00 Bug 42583: Modify moz-support-link for Base Browser. - - - - - 7aa7c469 by Henry Wilkes at 2024-07-24T15:47:41+02:00 Bug 42347: Add a notification for dropped OS version support. - - - - - 4da9195c by Henry Wilkes at 2024-07-24T15:47:43+02:00 Bug 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - 23a71db1 by Richard Pospesel at 2024-07-24T15:47:46+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 23c6ca9e by Beatriz Rizental at 2024-07-24T15:47:48+02:00 Add CI for Tor Browser - - - - - 743f8d19 by Richard Pospesel at 2024-07-24T15:47:50+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 98bcf17d by Beatriz Rizental at 2024-07-24T15:47:52+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 36f04e83 by Henry Wilkes at 2024-07-24T15:47:54+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - d85939c7 by Kathy Brade at 2024-07-24T15:47:56+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - 89230960 by Alex Catarineu at 2024-07-24T15:47:58+02:00 Add TorStrings module for localization - - - - - 4b6d00ff by Henry Wilkes at 2024-07-24T15:48:00+02:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - ea4083de by Henry Wilkes at 2024-07-24T15:48:03+02:00 Tor Browser localization migration scripts. - - - - - d12470bf by Henry Wilkes at 2024-07-24T15:48:05+02:00 Bug 42305: Add script to combine translation files across versions. - - - - - 55ec31fe by Mike Perry at 2024-07-24T15:48:07+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - f80b8093 by Beatriz Rizental at 2024-07-24T15:48:09+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser - - - - - 95e5d7e7 by Henry Wilkes at 2024-07-24T15:48:11+02:00 Bug 42583: Modify moz-support-link for Tor Browser. - - - - - 2dfd56be by hackademix at 2024-07-24T15:48:13+02:00 Bug 41917: Tor brand-specific styles. - - - - - f1bb3fa9 by Beatriz Rizental at 2024-07-24T15:48:15+02:00 fixup! Bug 41917: Tor brand-specific styles. - - - - - 62c6d53e by Henry Wilkes at 2024-07-24T15:48:17+02:00 Add purple tor version of the loading APNG. - - - - - cc6caa98 by sanketh at 2024-07-24T15:48:20+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 4b35d4e5 by Mike Perry at 2024-07-24T15:48:20+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - e417b335 by Henry Wilkes at 2024-07-24T15:48:20+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - fce5705b by Beatriz Rizental at 2024-07-24T15:48:21+02:00 fixup! Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds - - - - - a9887f7e by Pier Angelo Vendrame at 2024-07-24T15:48:21+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - 55b40f37 by Beatriz Rizental at 2024-07-24T15:48:22+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js - - - - - e775b40a by Pier Angelo Vendrame at 2024-07-24T15:48:22+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - 843f7e59 by Pier Angelo Vendrame at 2024-07-24T15:48:22+02:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - 10231d36 by Beatriz Rizental at 2024-07-24T15:48:23+02:00 fixup! Bug 40933: Add tor-launcher functionality - - - - - 5fdf3912 by Cecylia Bocovich at 2024-07-24T15:48:23+02:00 Lox integration - - - - - 4ac53efc by Beatriz Rizental at 2024-07-24T15:48:24+02:00 fixup! Lox integration - - - - - e053fc18 by Richard Pospesel at 2024-07-24T15:48:24+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 817d72a8 by Beatriz Rizental at 2024-07-24T15:48:24+02:00 fixup! Bug 40597: Implement TorSettings module - - - - - 9fb76cfb by Arthur Edelstein at 2024-07-24T15:48:25+02:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - 663e8c64 by Beatriz Rizental at 2024-07-24T15:48:25+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. - - - - - a5840800 by Henry Wilkes at 2024-07-24T15:48:26+02:00 Bug 41600: Add a tor circuit display panel. - - - - - ad731dc6 by Beatriz Rizental at 2024-07-24T15:48:26+02:00 fixup! Bug 41600: Add a tor circuit display panel. - - - - - 10384952 by Pier Angelo Vendrame at 2024-07-24T15:48:27+02:00 Bug 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - 682fe322 by Beatriz Rizental at 2024-07-24T15:48:27+02:00 fixup! Bug 42247: Android helpers for the TorProvider - - - - - e9a55bf0 by hackademix at 2024-07-24T15:48:31+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - deba9ad1 by Beatriz Rizental at 2024-07-24T15:48:33+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop - - - - - 9d3e2dfe by Amogh Pradeep at 2024-07-24T15:48:35+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - f10721e3 by Matthew Finkel at 2024-07-24T15:48:37+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - a0064193 by Kathy Brade at 2024-07-24T15:48:39+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - e4423200 by Pier Angelo Vendrame at 2024-07-24T15:48:41+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - a7da5889 by Beatriz Rizental at 2024-07-24T15:48:43+02:00 fixup! Bug 40807: Added QRCode.js to toolkit/modules - - - - - 96debc5c by Richard Pospesel at 2024-07-24T15:48:46+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - 3f69cd54 by Beatriz Rizental at 2024-07-24T15:48:48+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection - - - - - 9cf63f6d by Richard Pospesel at 2024-07-24T15:48:50+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 7d17fc68 by Beatriz Rizental at 2024-07-24T15:48:52+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser - - - - - a8d909cd by Pier Angelo Vendrame at 2024-07-24T15:48:54+02:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - a1051f4e by Henry Wilkes at 2024-07-24T15:48:59+02:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - 4b245671 by Beatriz Rizental at 2024-07-24T15:49:01+02:00 fixup! Bug 7494: Create local home page for TBB. - - - - - 1b1cd0f5 by Arthur Edelstein at 2024-07-24T15:49:03+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - 49177f28 by Beatriz Rizental at 2024-07-24T15:49:06+02:00 fixup! Bug 12620: TorBrowser regression tests - - - - - 8f819189 by Pier Angelo Vendrame at 2024-07-24T15:49:08+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - ce8380ee by Beatriz Rizental at 2024-07-24T15:49:10+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser - - - - - 85004964 by Kathy Brade at 2024-07-24T15:49:12+02:00 Bug 12647: Support symlinks in the updater. - - - - - fd75272d by Kathy Brade at 2024-07-24T15:49:14+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - a3a8d076 by Kathy Brade at 2024-07-24T15:49:19+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - 44946889 by Beatriz Rizental at 2024-07-24T15:49:21+02:00 fixup! Bug 16940: After update, load local change notes. - - - - - db0ed6a9 by Georg Koppen at 2024-07-24T15:49:23+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - 53414b83 by Mike Perry at 2024-07-24T15:49:26+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - 64a1dff6 by Beatriz Rizental at 2024-07-24T15:49:28+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing - - - - - 0a8f7b77 by Alex Catarineu at 2024-07-24T15:49:33+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - 20f48f23 by Henry Wilkes at 2024-07-24T15:49:35+02:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - 0114193a by Richard Pospesel at 2024-07-24T15:49:37+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - e8e46660 by Beatriz Rizental at 2024-07-24T15:49:39+02:00 fixup! Bug 23247: Communicating security expectations for .onion - - - - - d564e728 by Kathy Brade at 2024-07-24T15:49:42+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - c9bc1dca by Beatriz Rizental at 2024-07-24T15:49:44+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt - - - - - 33621e33 by Alex Catarineu at 2024-07-24T15:49:46+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 988d2892 by Beatriz Rizental at 2024-07-24T15:49:46+02:00 fixup! Bug 21952: Implement Onion-Location - - - - - b4727de8 by Pier Angelo Vendrame at 2024-07-24T15:49:50+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 5e7cbbc6 by Beatriz Rizental at 2024-07-24T15:49:58+02:00 fixup! Bug 40458: Implement .tor.onion aliases - - - - - e20d43c2 by Pier Angelo Vendrame at 2024-07-24T15:50:00+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 5ca0762e by Pier Angelo Vendrame at 2024-07-24T15:50:02+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - 1e90a615 by Henry Wilkes at 2024-07-24T15:50:03+02:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - 90681c16 by Beatriz Rizental at 2024-07-24T15:50:03+02:00 fixup! Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - 4a6f464b by Dan Ballard at 2024-07-24T15:50:03+02:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 0cfed17e by Beatriz Rizental at 2024-07-24T15:50:04+02:00 fixup! Bug 40701: Add security warning when downloading a file - - - - - 5811d87c by Henry Wilkes at 2024-07-24T15:50:04+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 7ba7b8d9 by hackademix at 2024-07-24T15:50:05+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - c3fc942a by Henry Wilkes at 2024-07-24T15:50:05+02:00 Customize moz-toggle for tor-browser. - - - - - 5f44c2e7 by Richard Pospesel at 2024-07-24T15:50:05+02:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 6c25a713 by Beatriz Rizental at 2024-07-24T15:50:06+02:00 fixup! Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 7b91e394 by Cecylia Bocovich at 2024-07-24T15:50:06+02:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - abc2fa14 by Beatriz Rizental at 2024-07-24T15:50:07+02:00 fixup! Temporary commit: manually place generated wasm files - - - - - 3615be7e by Pier Angelo Vendrame at 2024-07-24T15:50:07+02:00 Bug 42616: Remove VideoCaptureTest.kt. This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False. - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab-ci.yml - + .gitlab/ci/docker/base/Dockerfile - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/run_linters.py - + .gitlab/ci/update-translations.yml - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - .prettierignore - + README.md - − README.txt - + browser/actors/AboutTBUpdateChild.sys.mjs - + browser/actors/AboutTBUpdateParent.sys.mjs - + browser/actors/CryptoSafetyChild.sys.mjs - + browser/actors/CryptoSafetyParent.sys.mjs - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/309c86… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/309c86… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.0esr-14.0-1] MB 320: Temporarily disable WebRTC and WDBA on Windows.
by Pier Angelo Vendrame (＠pierov) 23 Jul '24

23 Jul '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 93b1ad39 by Pier Angelo Vendrame at 2024-07-23T16:31:02+00:00 MB 320: Temporarily disable WebRTC and WDBA on Windows. WebRTC should be re-enabled when tor-browser#42758 is resolved, and and the default browser agent when in general we make this feature work again. - - - - - 1 changed file: - mozconfig-windows-x86_64 Changes: ===================================== mozconfig-windows-x86_64 ===================================== @@ -22,3 +22,6 @@ ac_add_options --disable-notification-server # Let's make sure no preference is enabling either Adobe's or Google's CDM. ac_add_options --disable-eme +# tor-browser#320: Temporarily disable until we resolve the mingw problems. +ac_add_options --disable-webrtc +ac_add_options --disable-default-browser-agent View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/93b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/93b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.0esr-14.0-1] fixup! Firefox preference overrides.
by ma1 (＠ma1) 23 Jul '24

23 Jul '24

ma1 pushed to branch mullvad-browser-128.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: b3bdee22 by hackademix at 2024-07-23T12:42:31+02:00 fixup! Firefox preference overrides. Bug 42687: Disable Privacy-Preserving Attribution. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -230,6 +230,9 @@ pref("privacy.annotate_channels.strict_list.enabled", false); // Disable the Pocket extension (Bug #18886 and #31602) pref("extensions.pocket.enabled", false); +// Disable Privacy-Preserving-Attribution (Bug #42687) +pref("dom.private-attribution.submission.enabled", false); + // Custom extensions preferences tor-browser#41581 pref("extensions.hideNoScript", true); pref("extensions.hideUnifiedWhenEmpty", true); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/b3b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/b3b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.0esr-14.0-1] fixup! Firefox preference overrides.
by ma1 (＠ma1) 23 Jul '24

23 Jul '24

ma1 pushed to branch base-browser-128.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 15ffea8c by hackademix at 2024-07-23T11:43:15+02:00 fixup! Firefox preference overrides. Bug 42687: Disable Privacy-Preserving Attribution. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -230,6 +230,9 @@ pref("privacy.annotate_channels.strict_list.enabled", false); // Disable the Pocket extension (Bug #18886 and #31602) pref("extensions.pocket.enabled", false); +// Disable Privacy-Preserving-Attribution (Bug #42687) +pref("dom.private-attribution.submission.enabled", false); + // Custom extensions preferences tor-browser#41581 pref("extensions.hideNoScript", true); pref("extensions.hideUnifiedWhenEmpty", true); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/15ffea8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/15ffea8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.0esr-14.0-1] fixup! Firefox preference overrides.
by ma1 (＠ma1) 23 Jul '24

23 Jul '24

ma1 pushed to branch tor-browser-128.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 21b3574f by hackademix at 2024-07-23T11:40:05+02:00 fixup! Firefox preference overrides. Bug 42687: Disable Privacy-Preserving Attribution. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -230,6 +230,9 @@ pref("privacy.annotate_channels.strict_list.enabled", false); // Disable the Pocket extension (Bug #18886 and #31602) pref("extensions.pocket.enabled", false); +// Disable Privacy-Preserving-Attribution (Bug #42687) +pref("dom.private-attribution.submission.enabled", false); + // Custom extensions preferences tor-browser#41581 pref("extensions.hideNoScript", true); pref("extensions.hideUnifiedWhenEmpty", true); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/21b3574… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/21b3574… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.0esr-14.0-1] Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs
by morgan (＠morgan) 22 Jul '24

22 Jul '24

morgan pushed to branch tor-browser-128.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: a0092907 by Richard Pospesel at 2024-07-22T21:52:45+00:00 Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs - - - - - 1 changed file: - + tools/torbrowser/generate-bugzilla-triage-csv.sh Changes: ===================================== tools/torbrowser/generate-bugzilla-triage-csv.sh ===================================== @@ -0,0 +1,237 @@ +#!/usr/bin/env bash + +# prints to stderr +function echoerr() { echo "$@" 1>&2; } + +# help dialog +if [ "$#" -lt 5 ]; then + echoerr "Usage: $0 ff-version begin-commit end-commit gitlab-audit-issue reviewers..." + echoerr "" + echoerr "Writes a CSV to stdout of Bugzilla issues to triage for a particular Firefox version. This" + echoerr "script performs a union of the labeled Bugzilla issues in Mozilla's issue tracker and the" + echoerr "labeled commits in the provided commit range" + echoerr + echoerr " ff-version rapid-release Firefox version to audit" + echoerr " begin-commit starting gecko-dev commit of this Firefox version" + echoerr " end-commit ending gecko-dev commit of this Firefox version" + echoerr " gitlab-audit-issue tor-browser-spec Gitlab issue number for this audit" + echoerr " reviewers... space-separated list of reviewers responsible for this audit" + echoerr "" + echoerr "Example:" + echoerr "" + echoerr "$0 116 FIREFOX_ESR_115_BASE FIREFOX_116_0_3_RELEASE 40064 richard pierov henry" + exit 1 +fi + +# set -x +set -e + + +# Ensure various required tools are available +function check_exists() { + local cmd=$1 + if ! which ${cmd} > /dev/null ; then + echoerr "missing ${cmd} dependency" + exit 1 + fi +} + +check_exists git +check_exists jq +check_exists mktemp +check_exists perl +check_exists printf +check_exists sed +check_exists sort +check_exists touch +check_exists uniq +check_exists wget + +# Assign arguments to named variables +firefox_version=$1 +git_begin=$2 +git_end=$3 +audit_issue=$4 +reviewers="${@:5}" + +# Check valid Firefox version +if ! [[ "${firefox_version}" =~ ^[1-9][0-9]{2}$ ]]; then + echoerr "invalid Firefox version (probably)" + exit 1 +fi + +# Check valid Gitlab issue number +if ! [[ "${audit_issue}" =~ ^[1-9][0-9]{4}$ ]]; then + echoerr "invalid gitlab audit issue number (probably)" + exit 1 +fi + +# +# Encoding/Decoding Functions +# + +# escape " and \ +function json_escape() { + local input="$1" + echo "${input}" | sed 's/["\]/\\"/g' +} + + +# un-escape \" +function jq_unescape() { + local input="$1" + echo "${input}" | sed 's/\\"/"/g' +} + +# change quotes to double-quotes +function csv_escape() { + local input="$1" + echo "${input}" | sed 's/"/""/g' +} + +# we need to urlencode the strings used in the new issue link +function url_encode() { + local input="$1" + echo "${input}" | perl -MURI::Escape -wlne 'print uri_escape $_' +} + + +# +# Create temp json files +# +git_json=$(mktemp -t git-audit-${firefox_version}-XXXXXXXXXXX.json) +bugzilla_json=$(mktemp -t bugzilla-audit-${firefox_version}-XXXXXXXXXXX.json) +union_json=$(mktemp -t union-audit-${firefox_version}-XXXXXXXXXXX.json) +touch "${git_json}" +touch "${bugzilla_json}" +touch "${union_json}" + +function json_cleanup { + rm -f "${git_json}" + rm -f "${bugzilla_json}" + rm -f "${union_json}" +} +trap json_cleanup EXIT + +# +# Generate Git Commit Triage List +# + +# Try and extract bug id and summary from git log +# Mozilla's commits are not always 100% consistently named, so this +# regex is a bit flexible to handle various inputs such as: +# "Bug 1234 -", "Bug 1234:", "Bug Bug 1234 -", "[Bug 1234] -", " bug 1234 -". +sed_extract_id_summary="s/^[[ ]*[bug –-]+ ([1-9][0-9]*)[]:\., –-]*(.*)\$/\\1 \\2/pI" + +# Generate a json array of objects in the same format as bugzilla: {id: number, summary: string} +printf "[\n" >> "${git_json}" + +first_object=true +git log --format='%s' $git_begin..$git_end \ +| sed -En "${sed_extract_id_summary}" \ +| sort -h \ +| uniq \ +| while IFS= read -r line; do + read -r id summary <<< "${line}" + summary=$(json_escape "${summary}") + + # json does not allow trailing commas + if [[ "${first_object}" = true ]]; then + first_object=false + else + printf ",\n" >> "${git_json}" + fi + + printf " { \"id\": %s, \"summary\": \"%s\" }" ${id} "${summary}" >> "${git_json}" +done +printf "\n]\n" >> "${git_json}" + +# +# Download Bugzilla Triage List +# + +# search for: +# + Product is NOT "Thunderbird,Calander,Chat Core,MailNews Core" (&f1=product&n1=1&o1=anyexact&v1=Thunderbird%2CCalendar%2CChat%20Core%2CMailNews%20Core). AND +# + Target Milestone contains "${firefox_version}" (115 Branch or Firefox 115) (&f2=target_milestone&o2=substring&v2=${firefox_version}). +# "&limit=0" shows all matching bugs. + +query_tail="&f1=product&n1=1&o1=anyexact&v1=Thunderbird%2CCalendar%2CChat%20Core%2CMailNews%20Core&f2=target_milestone&o2=substring&v2=${firefox_version}&limit=0" + +bugzilla_query="https://bugzilla.mozilla.org/buglist.cgi?${query_tail}" +bugzilla_json_query="https://bugzilla.mozilla.org/rest/bug?include_fields=id,summary${query_tail}" + +wget "${bugzilla_json_query}" -O ${bugzilla_json} + + +# +# Create Union of these two sets of issues +# + +# bugzilla array is actually on a root object: { bugs: [...] } +jq -s '[ (.[0].bugs)[], (.[1])[] ] | group_by(.id) | map(.[0])' "${bugzilla_json}" "${git_json}" > "${union_json}" + +# +# Generate Triage CSV +# + +echo "\"Review\",,\"Bugzilla Bug\"" + +jq '. | sort_by(.id)[] | "\(.id)|\(.summary)"' ${union_json} \ +| while IFS='|' read -r id summary; do + + # bugzilla info + id="${id:1}" + summary="${summary:0:-1}" + summary=$(jq_unescape "${summary}") + # short summary for gitlab issue title + [[ ${#summary} -gt 80 ]] && summary_short="${summary:0:77}..." || summary_short="${summary}" + + # filter out some issue types that we never care about + skip_issue=false + + # skip `[wpt-sync] Sync PR` + if [[ "${summary}" =~ ^\[wpt-sync\]\ Sync\ PR.*$ ]]; then + skip_issue=true + # skip `Crash in [@` and variants + elif [[ "${summary}" =~ ^Crash[esin\ ]*\ \[\@.*$ ]]; then + skip_issue=true + # skip `Assertion failuire: ` + elif [[ "${summary}" =~ ^Assertion\ failure:\ .*$ ]]; then + skip_issue=true + # skip `Hit MOZ_CRASH` + elif [[ "${summary}" =~ ^Hit\ MOZ_CRASH.*$ ]]; then + skip_issue=true + fi + + if [[ "${skip_issue}" = true ]]; then + echoerr "Skipped Bugzilla ${id}: ${summary_short}" + else + csv_summary=$(csv_escape "${summary}") + + # parent issue + bugzilla_url="https://bugzilla.mozilla.org/show_bug.cgi?id=${id}" + # review issue title + new_issue_title=$(url_encode "Review Mozilla ${id}: ${summary_short}") + # review issue description + labeling (14.0 stable, FF128-esr, Next) + new_issue_description=$(url_encode "### Bugzilla: ${bugzilla_url}")%0A$(url_encode "/label ~\"14.0 stable\" ~FF128-esr ~Next")%0A$(url_encode "/relate tpo/applications/tor-browser-spec#${audit_issue}")%0A%0A$(url_encode "")%0A + # url which create's new issue with title and description pre-populated + new_issue_url="https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/new?iss…" + + # this link will start the creation of a new gitlab issue to review + create_issue=$(csv_escape "=HYPERLINK(\"${new_issue_url}\", \"New Issue\")") + bugzilla_link=$(csv_escape "=HYPERLINK(\"${bugzilla_url}\", \"Bugzilla ${id}: ${csv_summary}\")") + + echo "FALSE,\"${create_issue}\",\"${bugzilla_link}\"," + fi +done + +echo +echo "\"Triaged by:\"" +for reviewer in $reviewers; do + reviewer=$(csv_escape "${reviewer}") + echo "\"FALSE\",\"${reviewer}\"" +done +echo + +bugzilla_query="=HYPERLINK(\"${bugzilla_query}\", \"Bugzilla query\")" +echo \"$(csv_escape "${bugzilla_query}")\" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a009290… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a009290… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41168: Check that we are not changing other channel when deploying update_responses
by richard (＠richard) 18 Jul '24

18 Jul '24

richard pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 2303997c by Nicolas Vigier at 2024-07-17T16:45:08+02:00 Bug 41168: Check that we are not changing other channel when deploying update_responses - - - - - 1 changed file: - tools/signing/upload-update_responses-to-staticiforme Changes: ===================================== tools/signing/upload-update_responses-to-staticiforme ===================================== @@ -63,6 +63,18 @@ echo "update_responses_commit: $update_responses_commit" cd "$update_dir" git fetch +changed_files="\$(git diff --name-only HEAD $update_responses_commit)" +if ! echo "\$changed_files" | grep -qv "$tbb_version_type" +then + echo >&2 "Error: checking out new update_response_commit will changes" + echo >&2 "some files outside of the $tbb_version_type directory:" + echo "\$changed_files" | grep -v "$tbb_version_type" >&2 + echo >&2 "--" + echo >&2 "If this is really what you want to do, edit this script to" + echo >&2 "remove the line 'exit 1' and run it again." + echo >&2 "See tor-browser-build#41168 for more details." + exit 1 +fi git checkout "$update_responses_commit" static-update-component aus1.torproject.org View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.0esr-14.0-1] 2 commits: fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 18 Jul '24

18 Jul '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 7e9be9ca by Beatriz Rizental at 2024-07-18T11:34:53+02:00 fixup! Add CI for Base Browser Bug 42722: Use custom Dockerfile for lint CI jobs to address missing dependencies issues with clang-format and l10n linters. - - - - - 7d8ea45c by Beatriz Rizental at 2024-07-18T11:34:54+02:00 fixup! Add CI for Base Browser Bug 42722: Cache mozbuild path instead of specifically the pip path - - - - - 4 changed files: - .gitlab-ci.yml - + .gitlab/ci/docker/base/Dockerfile - .gitlab/ci/lint.yml - .gitlab/ci/scripts/run_linters.py Changes: ===================================== .gitlab-ci.yml ===================================== @@ -1,5 +1,8 @@ stages: - lint +variables: + IMAGE_PATH: containers.torproject.org/tpo/applications/tor-browser/base:latest + include: - local: '.gitlab/ci/lint.yml' ===================================== .gitlab/ci/docker/base/Dockerfile ===================================== @@ -0,0 +1,69 @@ +FROM debian:latest + +# Base image which includes all* dependencies checked by ./mach configure. +# +# * Actually not all dependencies. WASM sandboxed depencies were left out for now. +# This installs all dependencies checked by `./mach configure --without-wasm-sandboxed-libraries`. +# +# # Building and publishing +# +# Whenever this file changes, the updated Docker image must be built and published _manually_ to +# the tor-browser container registry (https://gitlab.torproject.org/tpo/applications/tor-browser/container_regist…) +# +# This image copies a script from the taskcluster/ folder, which requires it +# to be built from a folder which is a parent of the taskcluster/ folder. +# +# To build, run: +# +# ```bash +# docker build \ +# -f <PATH_TO_DOCKERFILE> \ +# -t <REGISTRY_URL>/<IMAGE_NAME>:<IMAGE_TAG> +# . +# ``` +# +# For example, when building from the root of this repository to the main tor-browser repository +# and assuming image name to be "base" and tag "latest" -- which is the current terminology: +# +# ```bash +# docker build \ +# -f .gitlab/ci/docker/Dockerfile \ +# -t containers.torproject.org/tpo/applications/tor-browser/base:latest +# . +# ``` + +RUN apt-get update && apt-get install -y \ + clang \ + curl \ + git \ + libasound2-dev \ + libdbus-glib-1-dev \ + libgtk-3-dev \ + libpango1.0-dev \ + libpulse-dev \ + libx11-xcb-dev \ + libxcomposite-dev \ + libxcursor-dev \ + libxdamage-dev \ + libxi-dev \ + libxrandr-dev \ + libxtst-dev \ + m4 \ + mercurial \ + nasm \ + pkg-config \ + python3 \ + python3-pip \ + unzip \ + wget + +COPY taskcluster/docker/recipes/install-node.sh /scripts/install-node.sh +RUN chmod +x /scripts/install-node.sh +RUN /scripts/install-node.sh + +RUN curl https://sh.rustup.rs -sSf | sh -s -- -y +RUN $HOME/.cargo/bin/cargo install cbindgen + +WORKDIR /app + +CMD ["/bin/bash"] ===================================== .gitlab/ci/lint.yml ===================================== @@ -1,20 +1,20 @@ -variables: - # This needs to be kept in sync with the max Python version accepted by ./mach - PYTHON_VERSION: "3.11.7" - .base: stage: lint interruptible: true variables: - PIP_CACHE_DIR: "$CI_PROJECT_DIR/.cache/pip" + MOZBUILD_STATE_PATH: "$CI_PROJECT_DIR/.cache/mozbuild" cache: paths: - node_modules - - .cache/pip + - .cache/mozbuild + # Store the cache regardless on job outcome + when: 'always' + # Share the cache throughout all pipelines running for a given branch + key: $CI_COMMIT_REF_SLUG eslint: extends: .base - image: cimg/python:$PYTHON_VERSION-node + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py eslint rules: @@ -45,7 +45,7 @@ eslint: stylelint: extends: .base - image: cimg/python:$PYTHON_VERSION-node + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py stylelint rules: @@ -65,7 +65,7 @@ stylelint: py-black: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py black rules: @@ -86,7 +86,7 @@ py-black: py-ruff: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py ruff rules: @@ -107,7 +107,7 @@ py-ruff: yaml: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py yaml rules: @@ -124,7 +124,7 @@ yaml: shellcheck: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py shellcheck rules: @@ -140,8 +140,9 @@ shellcheck: clang-format: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: + - ./mach configure --without-wasm-sandboxed-libraries --with-base-browser-version=0.0.0 - .gitlab/ci/scripts/run_linters.py clang-format rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' @@ -161,7 +162,7 @@ clang-format: rustfmt: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py rustfmt rules: @@ -177,7 +178,7 @@ rustfmt: fluent-lint: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py fluent-lint rules: @@ -194,7 +195,7 @@ fluent-lint: localization: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py l10n rules: @@ -213,7 +214,7 @@ localization: mingw-capitalization: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py mingw-capitalization rules: @@ -232,7 +233,7 @@ mingw-capitalization: mscom-init: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py mscom-init rules: @@ -251,7 +252,7 @@ mscom-init: file-whitespace: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py file-whitespace rules: @@ -282,7 +283,7 @@ file-whitespace: test-manifest: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py test-manifest-alpha test-manifest-disable test-manifest-skip-if rules: @@ -299,7 +300,7 @@ test-manifest: trojan-source: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py trojan-source rules: ===================================== .gitlab/ci/scripts/run_linters.py ===================================== @@ -54,7 +54,7 @@ def get_firefox_tag_from_branch_name(branch_name): return match.group(0).split()[0] else: raise ValueError( - f"Failed to find reference specifier for Firefox tag in branch '{branch_name}'." + f"Failed to find reference specifier for Firefox tag '{tag}' in branch '{branch_name}'." ) @@ -98,13 +98,13 @@ if __name__ == "__main__": ) args = parser.parse_args() - command = [ - "./mach", - "lint", - "-v", - *(s for l in args.linters for s in ("-l", l)), - *get_list_of_changed_files(), - ] - result = subprocess.run(command, text=True) - - sys.exit(result.returncode) + changed_files = get_list_of_changed_files() + if changed_files: + command = ["./mach", "lint", "-v"] + for linter in args.linters: + command.extend(["-l", linter]) + command.extend(changed_files) + result = subprocess.run(command, text=True) + sys.exit(result.returncode) + else: + print("No files changed, skipping linting.") View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/da… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/da… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.0esr-14.0-1] 2 commits: fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 18 Jul '24

18 Jul '24

Pier Angelo Vendrame pushed to branch base-browser-128.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: ac54df57 by Beatriz Rizental at 2024-07-18T11:34:23+02:00 fixup! Add CI for Base Browser Bug 42722: Use custom Dockerfile for lint CI jobs to address missing dependencies issues with clang-format and l10n linters. - - - - - fa88a433 by Beatriz Rizental at 2024-07-18T11:34:24+02:00 fixup! Add CI for Base Browser Bug 42722: Cache mozbuild path instead of specifically the pip path - - - - - 4 changed files: - .gitlab-ci.yml - + .gitlab/ci/docker/base/Dockerfile - .gitlab/ci/lint.yml - .gitlab/ci/scripts/run_linters.py Changes: ===================================== .gitlab-ci.yml ===================================== @@ -1,5 +1,8 @@ stages: - lint +variables: + IMAGE_PATH: containers.torproject.org/tpo/applications/tor-browser/base:latest + include: - local: '.gitlab/ci/lint.yml' ===================================== .gitlab/ci/docker/base/Dockerfile ===================================== @@ -0,0 +1,69 @@ +FROM debian:latest + +# Base image which includes all* dependencies checked by ./mach configure. +# +# * Actually not all dependencies. WASM sandboxed depencies were left out for now. +# This installs all dependencies checked by `./mach configure --without-wasm-sandboxed-libraries`. +# +# # Building and publishing +# +# Whenever this file changes, the updated Docker image must be built and published _manually_ to +# the tor-browser container registry (https://gitlab.torproject.org/tpo/applications/tor-browser/container_regist…) +# +# This image copies a script from the taskcluster/ folder, which requires it +# to be built from a folder which is a parent of the taskcluster/ folder. +# +# To build, run: +# +# ```bash +# docker build \ +# -f <PATH_TO_DOCKERFILE> \ +# -t <REGISTRY_URL>/<IMAGE_NAME>:<IMAGE_TAG> +# . +# ``` +# +# For example, when building from the root of this repository to the main tor-browser repository +# and assuming image name to be "base" and tag "latest" -- which is the current terminology: +# +# ```bash +# docker build \ +# -f .gitlab/ci/docker/Dockerfile \ +# -t containers.torproject.org/tpo/applications/tor-browser/base:latest +# . +# ``` + +RUN apt-get update && apt-get install -y \ + clang \ + curl \ + git \ + libasound2-dev \ + libdbus-glib-1-dev \ + libgtk-3-dev \ + libpango1.0-dev \ + libpulse-dev \ + libx11-xcb-dev \ + libxcomposite-dev \ + libxcursor-dev \ + libxdamage-dev \ + libxi-dev \ + libxrandr-dev \ + libxtst-dev \ + m4 \ + mercurial \ + nasm \ + pkg-config \ + python3 \ + python3-pip \ + unzip \ + wget + +COPY taskcluster/docker/recipes/install-node.sh /scripts/install-node.sh +RUN chmod +x /scripts/install-node.sh +RUN /scripts/install-node.sh + +RUN curl https://sh.rustup.rs -sSf | sh -s -- -y +RUN $HOME/.cargo/bin/cargo install cbindgen + +WORKDIR /app + +CMD ["/bin/bash"] ===================================== .gitlab/ci/lint.yml ===================================== @@ -1,20 +1,20 @@ -variables: - # This needs to be kept in sync with the max Python version accepted by ./mach - PYTHON_VERSION: "3.11.7" - .base: stage: lint interruptible: true variables: - PIP_CACHE_DIR: "$CI_PROJECT_DIR/.cache/pip" + MOZBUILD_STATE_PATH: "$CI_PROJECT_DIR/.cache/mozbuild" cache: paths: - node_modules - - .cache/pip + - .cache/mozbuild + # Store the cache regardless on job outcome + when: 'always' + # Share the cache throughout all pipelines running for a given branch + key: $CI_COMMIT_REF_SLUG eslint: extends: .base - image: cimg/python:$PYTHON_VERSION-node + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py eslint rules: @@ -45,7 +45,7 @@ eslint: stylelint: extends: .base - image: cimg/python:$PYTHON_VERSION-node + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py stylelint rules: @@ -65,7 +65,7 @@ stylelint: py-black: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py black rules: @@ -86,7 +86,7 @@ py-black: py-ruff: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py ruff rules: @@ -107,7 +107,7 @@ py-ruff: yaml: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py yaml rules: @@ -124,7 +124,7 @@ yaml: shellcheck: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py shellcheck rules: @@ -140,8 +140,9 @@ shellcheck: clang-format: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: + - ./mach configure --without-wasm-sandboxed-libraries --with-base-browser-version=0.0.0 - .gitlab/ci/scripts/run_linters.py clang-format rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' @@ -161,7 +162,7 @@ clang-format: rustfmt: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py rustfmt rules: @@ -177,7 +178,7 @@ rustfmt: fluent-lint: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py fluent-lint rules: @@ -194,7 +195,7 @@ fluent-lint: localization: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py l10n rules: @@ -213,7 +214,7 @@ localization: mingw-capitalization: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py mingw-capitalization rules: @@ -232,7 +233,7 @@ mingw-capitalization: mscom-init: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py mscom-init rules: @@ -251,7 +252,7 @@ mscom-init: file-whitespace: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py file-whitespace rules: @@ -282,7 +283,7 @@ file-whitespace: test-manifest: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py test-manifest-alpha test-manifest-disable test-manifest-skip-if rules: @@ -299,7 +300,7 @@ test-manifest: trojan-source: extends: .base - image: cimg/python:$PYTHON_VERSION + image: $IMAGE_PATH script: - .gitlab/ci/scripts/run_linters.py trojan-source rules: ===================================== .gitlab/ci/scripts/run_linters.py ===================================== @@ -54,7 +54,7 @@ def get_firefox_tag_from_branch_name(branch_name): return match.group(0).split()[0] else: raise ValueError( - f"Failed to find reference specifier for Firefox tag in branch '{branch_name}'." + f"Failed to find reference specifier for Firefox tag '{tag}' in branch '{branch_name}'." ) @@ -98,13 +98,13 @@ if __name__ == "__main__": ) args = parser.parse_args() - command = [ - "./mach", - "lint", - "-v", - *(s for l in args.linters for s in ("-l", l)), - *get_list_of_changed_files(), - ] - result = subprocess.run(command, text=True) - - sys.exit(result.returncode) + changed_files = get_list_of_changed_files() + if changed_files: + command = ["./mach", "lint", "-v"] + for linter in args.linters: + command.extend(["-l", linter]) + command.extend(changed_files) + result = subprocess.run(command, text=True) + sys.exit(result.returncode) + else: + print("No files changed, skipping linting.") View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1f329b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1f329b… You're receiving this email because of your account on gitlab.torproject.org.

1 0