- tor-commits - lists.torproject.org

[tor/release-0.2.2] answer an XXX nickm asked in aa950e6c4
by arma＠torproject.org 30 May '11

30 May '11

commit 5f182ea10e25ed027cf75627f74013e7c6da2038 Author: Roger Dingledine <arma(a)torproject.org> Date: Sun May 29 18:52:37 2011 -0400 answer an XXX nickm asked in aa950e6c4 --- src/or/circuitbuild.c | 2 +- src/or/main.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 108007e..9509b5a 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -262,7 +262,7 @@ circuit_build_times_test_frequency(void) } /** - * Retrieve and bounds-check the cbtmintimeout consensus paramter. + * Retrieve and bounds-check the cbtmintimeout consensus parameter. * * Effect: This is the minimum allowed timeout value in milliseconds. * The minimum is to prevent rounding to 0 (we only check once diff --git a/src/or/main.c b/src/or/main.c index d1ceeec..4fc6437 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -1162,7 +1162,10 @@ run_scheduled_events(time_t now) * it's not comfortable with the number of available circuits. */ /* XXXX022 If our circuit build timeout is much lower than a second, maybe - we should do this more often? */ + * we should do this more often? -NM + * It can't be lower than 1.5 seconds currently; see + * circuit_build_times_min_timeout(). -RD + */ circuit_expire_building(); /** 3b. Also look at pending streams and prune the ones that 'began'

1 0

[tor/release-0.2.2] Merge branch 'maint-0.2.2' into release-0.2.2
by arma＠torproject.org 30 May '11

30 May '11

commit 688400c596c09e9a6d1a26668e4843ccd946a7be Merge: 6746293 5f182ea Author: Roger Dingledine <arma(a)torproject.org> Date: Sun May 29 19:11:22 2011 -0400 Merge branch 'maint-0.2.2' into release-0.2.2 src/or/circuitbuild.c | 2 +- src/or/main.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.2.2'
by arma＠torproject.org 30 May '11

30 May '11

commit 6917728637bdbaed86d48d394eab6a063c319269 Merge: e676db6 5f182ea Author: Roger Dingledine <arma(a)torproject.org> Date: Sun May 29 19:11:07 2011 -0400 Merge branch 'maint-0.2.2' src/or/circuitbuild.c | 2 +- src/or/main.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-)

1 0

[tor/master] answer an XXX nickm asked in aa950e6c4
by arma＠torproject.org 30 May '11

30 May '11

commit 5f182ea10e25ed027cf75627f74013e7c6da2038 Author: Roger Dingledine <arma(a)torproject.org> Date: Sun May 29 18:52:37 2011 -0400 answer an XXX nickm asked in aa950e6c4 --- src/or/circuitbuild.c | 2 +- src/or/main.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 108007e..9509b5a 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -262,7 +262,7 @@ circuit_build_times_test_frequency(void) } /** - * Retrieve and bounds-check the cbtmintimeout consensus paramter. + * Retrieve and bounds-check the cbtmintimeout consensus parameter. * * Effect: This is the minimum allowed timeout value in milliseconds. * The minimum is to prevent rounding to 0 (we only check once diff --git a/src/or/main.c b/src/or/main.c index d1ceeec..4fc6437 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -1162,7 +1162,10 @@ run_scheduled_events(time_t now) * it's not comfortable with the number of available circuits. */ /* XXXX022 If our circuit build timeout is much lower than a second, maybe - we should do this more often? */ + * we should do this more often? -NM + * It can't be lower than 1.5 seconds currently; see + * circuit_build_times_min_timeout(). -RD + */ circuit_expire_building(); /** 3b. Also look at pending streams and prune the ones that 'began'

1 0

[tor/maint-0.2.2] answer an XXX nickm asked in aa950e6c4
by arma＠torproject.org 30 May '11

30 May '11

commit 5f182ea10e25ed027cf75627f74013e7c6da2038 Author: Roger Dingledine <arma(a)torproject.org> Date: Sun May 29 18:52:37 2011 -0400 answer an XXX nickm asked in aa950e6c4 --- src/or/circuitbuild.c | 2 +- src/or/main.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 108007e..9509b5a 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -262,7 +262,7 @@ circuit_build_times_test_frequency(void) } /** - * Retrieve and bounds-check the cbtmintimeout consensus paramter. + * Retrieve and bounds-check the cbtmintimeout consensus parameter. * * Effect: This is the minimum allowed timeout value in milliseconds. * The minimum is to prevent rounding to 0 (we only check once diff --git a/src/or/main.c b/src/or/main.c index d1ceeec..4fc6437 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -1162,7 +1162,10 @@ run_scheduled_events(time_t now) * it's not comfortable with the number of available circuits. */ /* XXXX022 If our circuit build timeout is much lower than a second, maybe - we should do this more often? */ + * we should do this more often? -NM + * It can't be lower than 1.5 seconds currently; see + * circuit_build_times_min_timeout(). -RD + */ circuit_expire_building(); /** 3b. Also look at pending streams and prune the ones that 'began'

1 0

[tor/release-0.2.2] fold in recent changes entries
by arma＠torproject.org 29 May '11

29 May '11

commit 67462937a24d24c04146e2547d853b4a42c0d718 Author: Roger Dingledine <arma(a)torproject.org> Date: Sun May 29 15:34:38 2011 -0400 fold in recent changes entries --- ChangeLog | 22 +++++++++++++++++++--- changes/bug2574 | 3 --- changes/bug3208 | 6 ------ changes/exit-policy-default-is-not-a-prefix | 5 ----- changes/feature3049 | 6 ------ 5 files changed, 19 insertions(+), 23 deletions(-) diff --git a/ChangeLog b/ChangeLog index 92478b3..42d4e14 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,14 +1,30 @@ -Changes in version 0.2.2.28-beta - 2011-05-2? +Changes in version 0.2.2.28-beta - 2011-05-3? o Major bugfixes: - Don't decide to make a new descriptor when receiving a HUP signal. This bug has caused a lot of 0.2.2.x relays to disappear from the consensus periodically. Fixes the most common case of triggering bug 1810; bugfix on 0.2.2.7-alpha. + - Actually allow nameservers with IPv6 addresses. Fixes bug 2574. + + o Major features: + - Add an __OwningControllerProcess configuration option and a + TAKEOWNERSHIP control-port command. Now a Tor controller can ensure + that when it exits, Tor will shut down. Implements feature 3049. + + o Minor bugfixes: + - Fix warnings from GCC 4.6's "-Wunused-but-set-variable" option. + - Remove a trailing asterisk from "exit-policy/default" in the + output of the control port command "GETINFO info/names". Bugfix + on 0.1.2.5-alpha. o Minor features: - Relays now log the reason for publishing a new relay descriptor, - so we have a better chance of hunting down the root cause of bug - 1810. Resolves ticket 3252. + so we have a better chance of hunting down instances of bug 1810. + Resolves ticket 3252. + + o Removed options: + - Remove undocumented option "-F" from tor-resolve: it hasn't done + anything since 0.2.1.16-rc. Changes in version 0.2.2.27-beta - 2011-05-18 diff --git a/changes/bug2574 b/changes/bug2574 deleted file mode 100644 index 5cf2dae..0000000 --- a/changes/bug2574 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor features: - - Allow nameservers with IPv6 address. Fixes bug 2574. - diff --git a/changes/bug3208 b/changes/bug3208 deleted file mode 100644 index fd737ba..0000000 --- a/changes/bug3208 +++ /dev/null @@ -1,6 +0,0 @@ - o Removed options: - - Remove undocumented option "-F" from tor-resolve: it hasn't done - anything since 0.2.1.16-rc. - - o Minor bugfixes: - - Fix warnings from GCC 4.6's "-Wunused-but-set-variable" option. diff --git a/changes/exit-policy-default-is-not-a-prefix b/changes/exit-policy-default-is-not-a-prefix deleted file mode 100644 index 6eb1e8d..0000000 --- a/changes/exit-policy-default-is-not-a-prefix +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes: - - Remove a trailing asterisk from "exit-policy/default" in the - output of the control port command "GETINFO info/names". Bugfix - on 0.1.2.5-alpha. - diff --git a/changes/feature3049 b/changes/feature3049 deleted file mode 100644 index 7960a1f..0000000 --- a/changes/feature3049 +++ /dev/null @@ -1,6 +0,0 @@ - o Major features: - - Add an __OwningControllerProcess configuration option and a - TAKEOWNERSHIP control-port command, so that a Tor controller can - ensure that when it exits, Tor will shut down. Implements - feature 3049. -

1 0

[tor/release-0.2.2] The first argument for a libevent callback should be evutil_socket_t
by arma＠torproject.org 29 May '11

29 May '11

commit 1e69c60dccc358a7146c2b5e7825ea729498b41b Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon May 23 01:12:00 2011 -0400 The first argument for a libevent callback should be evutil_socket_t --- src/common/procmon.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/common/procmon.c b/src/common/procmon.c index cee956a..bd25bc1 100644 --- a/src/common/procmon.c +++ b/src/common/procmon.c @@ -34,7 +34,7 @@ typedef int pid_t; /* Currently we need to poll in some way on all systems. */ #ifdef PROCMON_POLLS -static void tor_process_monitor_poll_cb(int unused1, short unused2, +static void tor_process_monitor_poll_cb(evutil_socket_t unused1, short unused2, void *procmon_); #endif @@ -232,7 +232,8 @@ tor_process_monitor_new(struct event_base *base, /** Libevent callback to poll for the existence of the process * monitored by <b>procmon_</b>. */ static void -tor_process_monitor_poll_cb(int unused1, short unused2, void *procmon_) +tor_process_monitor_poll_cb(evutil_socket_t unused1, short unused2, + void *procmon_) { tor_process_monitor_t *procmon = (tor_process_monitor_t *)(procmon_); int its_dead_jim;

1 0

[tor/release-0.2.2] Merge branch 'bug2574' into maint-0.2.1
by arma＠torproject.org 29 May '11

29 May '11

commit ee72557d528a846661d4d1d794c127de8c3ef1eb Merge: 0d94f78 be76850 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat May 28 02:07:48 2011 -0400 Merge branch 'bug2574' into maint-0.2.1 changes/bug2574 | 2 ++ src/or/eventdns.c | 2 +- 2 files changed, 3 insertions(+), 1 deletions(-)

1 0

[tor/release-0.2.2] Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2
by arma＠torproject.org 29 May '11

29 May '11

commit c3199495503930e33e7370d6c364b2b8b35844f4 Merge: a5232e0 ee72557 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sat May 28 02:08:39 2011 -0400 Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2 changes/bug2574 | 2 ++ src/or/eventdns.c | 2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --cc src/or/eventdns.c index b7cc292,1d93ae0..4753429 --- a/src/or/eventdns.c +++ b/src/or/eventdns.c @@@ -2288,10 -2318,9 +2288,10 @@@ _evdns_nameserver_add_impl(const struc if (!ns) return -1; memset(ns, 0, sizeof(struct nameserver)); - ns->timeout_event_deleted = __LINE__; + + evtimer_set(&ns->timeout_event, nameserver_prod_callback, ns); - ns->socket = socket(PF_INET, SOCK_DGRAM, 0); + ns->socket = socket(address->sa_family, SOCK_DGRAM, 0); if (ns->socket < 0) { err = 1; goto out1; } #ifdef WIN32 {

1 0

[tor/release-0.2.2] Merge branch 'feature3049-v2' into maint-0.2.2
by arma＠torproject.org 29 May '11

29 May '11

commit b80a8bba199b9adfb9c893641ba770566fa548e1 Merge: 1ba1bde 1e69c60 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon May 23 01:19:04 2011 -0400 Merge branch 'feature3049-v2' into maint-0.2.2 Conflicts: src/common/Makefile.am changes/exit-policy-default-is-not-a-prefix | 5 + changes/feature3049 | 6 + src/common/Makefile.am | 4 +- src/common/compat.h | 2 +- src/common/compat_libevent.c | 2 +- src/common/log.c | 2 +- src/common/procmon.c | 332 +++++++++++++++++++++++++++ src/common/procmon.h | 30 +++ src/common/torlog.h | 1 - src/common/util.c | 18 +- src/or/config.c | 15 ++ src/or/connection.c | 3 +- src/or/control.c | 138 +++++++++++- src/or/control.h | 4 + src/or/or.h | 10 +- 15 files changed, 554 insertions(+), 18 deletions(-) diff --cc src/common/Makefile.am index 2d009bd,8889245..6952591 --- a/src/common/Makefile.am +++ b/src/common/Makefile.am @@@ -12,11 -12,11 +12,11 @@@ libor_extra_source endif libor_a_SOURCES = address.c log.c util.c compat.c container.c mempool.c \ - memarea.c di_ops.c util_codedigest.c $(libor_extra_source) - memarea.c util_codedigest.c procmon.c $(libor_extra_source) ++ memarea.c di_ops.c procmon.c util_codedigest.c $(libor_extra_source) libor_crypto_a_SOURCES = crypto.c aes.c tortls.c torgzip.c libor_event_a_SOURCES = compat_libevent.c - noinst_HEADERS = address.h torlog.h crypto.h util.h compat.h aes.h torint.h tortls.h strlcpy.c strlcat.c torgzip.h container.h ht.h mempool.h memarea.h ciphers.inc compat_libevent.h tortls_states.h di_ops.h -noinst_HEADERS = address.h torlog.h crypto.h util.h compat.h aes.h torint.h tortls.h strlcpy.c strlcat.c torgzip.h container.h ht.h mempool.h memarea.h procmon.h ciphers.inc compat_libevent.h tortls_states.h ++noinst_HEADERS = address.h torlog.h crypto.h util.h compat.h aes.h torint.h tortls.h strlcpy.c strlcat.c torgzip.h container.h ht.h mempool.h memarea.h ciphers.inc compat_libevent.h tortls_states.h di_ops.h procmon.h common_sha1.i: $(libor_SOURCES) $(libor_crypto_a_SOURCES) $(noinst_HEADERS) if test "@SHA1SUM@" != none; then \

1 0