tor-commits

tor-commits@lists.torproject.org

1 participants
212437 discussions

[tor/master] Another doc tweak on tor_memcmp: b, not .
by nickm＠torproject.org 15 May '11

15 May '11

commit 10d670674aa49ee6764cf93fe7d3f485a3f9ffd8 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun May 15 19:56:05 2011 -0400 Another doc tweak on tor_memcmp: b, not . --- src/common/di_ops.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/common/di_ops.c b/src/common/di_ops.c index 3da033c..b22a58d 100644 --- a/src/common/di_ops.c +++ b/src/common/di_ops.c @@ -10,11 +10,11 @@ #include "di_ops.h" /** - * Timing-safe version of memcmp. As memcmp, compare the sz bytes - * at a with the sz bytes at , and return less than 0 if the - * bytes at a lexically precede those at b, 0 if the byte ranges - * are equal, and greater than zero if the bytes at a lexically follow - * those at . + * Timing-safe version of memcmp. As memcmp, compare the sz bytes at + * a with the sz bytes at b, and return less than 0 if + * the bytes at a lexically precede those at b, 0 if the byte + * ranges are equal, and greater than zero if the bytes at a lexically + * follow those at b. * * This implementation differs from memcmp in that its timing behavior is not * data-dependent: it should return in the same amount of time regardless of @@ -85,7 +85,7 @@ tor_memcmp(const void *a, const void *b, size_t len) /** * Timing-safe memory comparison. Return true if the sz bytes at - * a are the same as the sz bytes at , and 0 otherwise. + * a are the same as the sz bytes at b, and 0 otherwise. * * This implementation differs from !memcmp(a,b,sz) in that its timing * behavior is not data-dependent: it should return in the same amount of time

1 0

[tor/master] minor tweaks to 4b19730c8234d
by nickm＠torproject.org 15 May '11

15 May '11

commit b48f83ab8c27b6a26d4afe5177238a99637a1dc1 Author: Roger Dingledine <arma(a)torproject.org> Date: Sun May 15 19:20:42 2011 -0400 minor tweaks to 4b19730c8234d --- src/common/di_ops.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/di_ops.c b/src/common/di_ops.c index c1e292f..3da033c 100644 --- a/src/common/di_ops.c +++ b/src/common/di_ops.c @@ -3,7 +3,7 @@ /** * \file di_ops.c - * \brief Functions for data-independent operations + * \brief Functions for data-independent operations. **/ #include "orconfig.h" @@ -11,7 +11,7 @@ /** * Timing-safe version of memcmp. As memcmp, compare the sz bytes - * at a with the sz bytes at , and returns less than 0 if the + * at a with the sz bytes at , and return less than 0 if the * bytes at a lexically precede those at b, 0 if the byte ranges * are equal, and greater than zero if the bytes at a lexically follow * those at .

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2
by nickm＠torproject.org 15 May '11

15 May '11

commit d29c2eb9214a82653a18d51e643d637851dcd145 Merge: 69ff26b 10d6706 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun May 15 19:56:27 2011 -0400 Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2 src/common/di_ops.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-)

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.2'
by nickm＠torproject.org 15 May '11

15 May '11

commit ced06a80097d2c4f26b1f44447710ec33b9d2421 Merge: 1f7b9e6 d29c2eb Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun May 15 19:56:40 2011 -0400 Merge remote-tracking branch 'origin/maint-0.2.2' src/common/di_ops.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-)

1 0

[tor/maint-0.2.2] minor tweaks to 4b19730c8234d
by nickm＠torproject.org 15 May '11

15 May '11

1 0

[tor/maint-0.2.2] Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2
by nickm＠torproject.org 15 May '11

15 May '11

1 0

[tor/maint-0.2.2] Another doc tweak on tor_memcmp: b, not .
by nickm＠torproject.org 15 May '11

15 May '11

1 0

[tor/maint-0.2.1] Another doc tweak on tor_memcmp: b, not .
by nickm＠torproject.org 15 May '11

15 May '11

1 0

[tor/maint-0.2.1] minor tweaks to 4b19730c8234d
by arma＠torproject.org 15 May '11

15 May '11

1 0

[tor/master] bug 3026: do not upload our vote to ourself
by nickm＠torproject.org 15 May '11

15 May '11

commit 6b83b3ba2aff4ba815241c76d712d149f13465e1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 12 00:47:00 2011 -0400 bug 3026: do not upload our vote to ourself --- changes/bug3026 | 4 ++++ src/or/directory.c | 5 +++++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/changes/bug3026 b/changes/bug3026 new file mode 100644 index 0000000..c0c0a38 --- /dev/null +++ b/changes/bug3026 @@ -0,0 +1,4 @@ + o Minor bugfixes (directory authority) + - Do not upload our own vote or signature set to ourself. It would + tell us nothing new. Also, as of Tor 0.2.2.24-alpha, we started + to warn about receiving duplicate votes. Resolves bug 3026. diff --git a/src/or/directory.c b/src/or/directory.c index 8c6581a..86dcc8d 100644 --- a/src/or/directory.c +++ b/src/or/directory.c @@ -279,6 +279,8 @@ directory_post_to_dirservers(uint8_t dir_purpose, uint8_t router_purpose, int post_via_tor; smartlist_t *dirservers = router_get_trusted_dir_servers(); int found = 0; + const int exclude_self = (dir_purpose == DIR_PURPOSE_UPLOAD_VOTE || + dir_purpose == DIR_PURPOSE_UPLOAD_SIGNATURES); tor_assert(dirservers); /* This tries dirservers which we believe to be down, but ultimately, that's * harmless, and we may as well err on the side of getting things uploaded. @@ -291,6 +293,9 @@ directory_post_to_dirservers(uint8_t dir_purpose, uint8_t router_purpose, if ((type & ds->type) == 0) continue; + if (exclude_self && router_digest_is_me(ds->digest)) + continue; + if (options->ExcludeNodes && options->StrictNodes && routerset_contains_routerstatus(options->ExcludeNodes, rs)) { log_warn(LD_DIR, "Wanted to contact authority '%s' for %s, but "

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits