- tor-commits - lists.torproject.org

[arm/release] fix: wasn't shutting down daemons after interrupt
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 796b9c0feb9e325177d1b4e42c1e07c3ee748283 Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Jul 1 08:51:37 2011 -0700 fix: wasn't shutting down daemons after interrupt Moving the shutdown of service daemons into finally block so it's done after keyboard interrupts (ie, ctrl+c). Otherwise shutting down this way could cause occasional stacktraces. --- src/cli/controller.py | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/cli/controller.py b/src/cli/controller.py index e771a26..c9ab6e7 100644 --- a/src/cli/controller.py +++ b/src/cli/controller.py @@ -503,6 +503,7 @@ def startTorMonitor(startTime): curses.wrapper(drawTorMonitor, startTime) except KeyboardInterrupt: pass # skip printing stack trace in case of keyboard interrupt + finally: shutdownDaemons() def drawTorMonitor(stdscr, startTime): """ @@ -602,6 +603,4 @@ def drawTorMonitor(stdscr, startTime): for panelImpl in displayPanels: isKeystrokeConsumed = panelImpl.handleKey(key) if isKeystrokeConsumed: break - - shutdownDaemons()

1 0

[arm/release] Input field validation for bridge destinations
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit f3d73e6a80d4798963745c8ebb500eca29bd0c3e Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Jul 1 16:25:23 2011 -0700 Input field validation for bridge destinations --- src/cli/wizard.py | 19 +++++++++++++++++-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/cli/wizard.py b/src/cli/wizard.py index 7c36598..219c6b6 100644 --- a/src/cli/wizard.py +++ b/src/cli/wizard.py @@ -9,7 +9,7 @@ import curses import cli.popups import cli.controller -from util import enum, uiTools +from util import enum, connections, uiTools # basic configuration types we can run as RelayType = enum.Enum("RELAY", "EXIT", "BRIDGE", "CLIENT") @@ -210,6 +210,9 @@ def showWizard(): else: config[option] = ConfigOption(option, "opt", default) # sets input validators + config[Options.BRIDGE1].setValidator(_bridgeDestinationValidator) + config[Options.BRIDGE2].setValidator(_bridgeDestinationValidator) + config[Options.BRIDGE3].setValidator(_bridgeDestinationValidator) # enables custom policies when 'custom' is selected and disables otherwise policyOpt = config[Options.POLICY] @@ -387,7 +390,9 @@ def promptConfigOptions(relayType, config): newValue = popup.getstr(y + selection + 1, 33, options[selection].getValue(), curses.A_STANDOUT | uiTools.getColor(OPTION_COLOR), 23) if newValue: try: options[selection].setValue(newValue.strip()) - except ValueError, exc: cli.popups.showMsg(str(exc), 3) + except ValueError, exc: + cli.popups.showMsg(str(exc), 2) + cli.controller.getController().requestRedraw(True) elif key == 27: selection, key = -1, curses.KEY_ENTER # esc - cancel finally: cli.popups.finalize() @@ -423,3 +428,13 @@ def _toggleEnabledAction(toggleOptions, option, value): for opt in toggleOptions: opt.setEnabled(value) +def _bridgeDestinationValidator(option, value): + if value.count(":") != 1: + raise ValueError("Bridges are of the form '<ip address>:<port>'") + + ipAddr, port = value.split(":", 1) + if not connections.isValidIpAddress(ipAddr): + raise ValueError("'%s' is not a valid ip address" % ipAddr) + elif not port.isdigit() or int(port) < 0 or int(port) > 65535: + raise ValueError("'%s' isn't a valid port number" % port) +

1 0

[arm/release] Filling blank wizard values when helpful
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 36f78676801ee57a4d875bc6114f365e1b324ad2 Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Jul 1 15:46:27 2011 -0700 Filling blank wizard values when helpful Some of the configuration values, like the nickname and bridge entries, can use their desplayed value when blank to indicate what should go there. --- src/cli/wizard.py | 5 ++++- src/settings.cfg | 6 +++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/cli/wizard.py b/src/cli/wizard.py index 79f548e..7c36598 100644 --- a/src/cli/wizard.py +++ b/src/cli/wizard.py @@ -73,6 +73,7 @@ CONFIG = {"wizard.message.role": "", "wizard.toggle": {}, "wizard.suboptions": [], "wizard.default": {}, + "wizard.blankValue": {}, "wizard.label.general": {}, "wizard.label.role": {}, "wizard.label.opt": {}, @@ -113,7 +114,9 @@ class ConfigOption: return self.value def getDisplayValue(self): - return self.value + if not self.value and self.key in CONFIG["wizard.blankValue"]: + return CONFIG["wizard.blankValue"][self.key] + else: return self.value def getDisplayAttr(self): myColor = OPTION_COLOR if self.isEnabled() else DISABLED_COLOR diff --git a/src/settings.cfg b/src/settings.cfg index aacec0a..076299d 100644 --- a/src/settings.cfg +++ b/src/settings.cfg @@ -370,7 +370,6 @@ wizard.suboptions Bridge1 wizard.suboptions Bridge2 wizard.suboptions Bridge3 -wizard.default Nickname => Unnamed wizard.default Notify => true wizard.default Bandwidth => 5 MB/s wizard.default Startup => true @@ -387,6 +386,11 @@ wizard.default Distribute => true wizard.default Bridged => false wizard.default Reuse => 10 minutes +wizard.blankValue Nickname => Unnamed +wizard.blankValue Bridge1 => <ip address>:<port> +wizard.blankValue Bridge2 => <ip address>:<port> +wizard.blankValue Bridge3 => <ip address>:<port> + wizard.label.general Cancel => Cancel wizard.label.general Back => Previous wizard.label.general Next => Next

1 0

[arm/release] fix: missing menu source from installs
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit fe34ca335acc492e06952aad9b8cf924c40cef4b Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Jun 29 19:27:01 2011 -0700 fix: missing menu source from installs Forgot to add the menu to setup.py, causing arm to crash due to missing the resources. --- setup.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/setup.py b/setup.py index 47b9af8..1eec903 100644 --- a/setup.py +++ b/setup.py @@ -76,7 +76,7 @@ if "install" in sys.argv: # When installing we include a bundled copy of TorCtl. However, when creating # a deb we have a dependency on the python-torctl package instead: # http://packages.debian.org/unstable/main/python-torctl -installPackages = ['arm', 'arm.cli', 'arm.cli.graphing', 'arm.cli.connections', 'arm.util'] +installPackages = ['arm', 'arm.cli', 'arm.cli.graphing', 'arm.cli.connections', 'arm.cli.menu', 'arm.util'] if not isDebInstall: installPackages.append('arm.TorCtl') setup(name='arm',

1 0

[arm/release] Config options for client section of the wizard
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 3c2d5cbad683174b22f83619aa8c5046d5544627 Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Jul 1 10:16:00 2011 -0700 Config options for client section of the wizard Client config options include bridging and MaxCircuitDirtiness. It also provides a link for preconfigured tor setups: http://www.atagar.com/torUsageTips/ --- src/cli/wizard.py | 41 +++++++++++++++++++++++++++++------------ src/settings.cfg | 21 +++++++++++++++++++-- 2 files changed, 48 insertions(+), 14 deletions(-) diff --git a/src/cli/wizard.py b/src/cli/wizard.py index c6186e5..79f548e 100644 --- a/src/cli/wizard.py +++ b/src/cli/wizard.py @@ -15,7 +15,7 @@ from util import enum, uiTools RelayType = enum.Enum("RELAY", "EXIT", "BRIDGE", "CLIENT") # all options that can be configured -Options = enum.Enum("DIVIDER", "NICKNAME", "CONTACT", "NOTIFY", "BANDWIDTH", "LIMIT", "CLIENT", "PORTFORWARD", "STARTUP", "NOTICE", "POLICY", "WEBSITES", "EMAIL", "IM", "MISC", "PLAINTEXT", "DISTRIBUTE") +Options = enum.Enum("DIVIDER", "NICKNAME", "CONTACT", "NOTIFY", "BANDWIDTH", "LIMIT", "CLIENT", "PORTFORWARD", "STARTUP", "NOTICE", "POLICY", "WEBSITES", "EMAIL", "IM", "MISC", "PLAINTEXT", "DISTRIBUTE", "BRIDGED", "BRIDGE1", "BRIDGE2", "BRIDGE3", "REUSE") RelayOptions = {RelayType.RELAY: (Options.NICKNAME, Options.CONTACT, Options.NOTIFY, @@ -46,10 +46,16 @@ RelayOptions = {RelayType.RELAY: (Options.NICKNAME, Options.CLIENT, Options.PORTFORWARD, Options.STARTUP - )} + ), + RelayType.CLIENT: (Options.BRIDGED, + Options.BRIDGE1, + Options.BRIDGE2, + Options.BRIDGE3, + Options.REUSE)} -# custom exit policy options +# option sets CUSTOM_POLICIES = (Options.WEBSITES, Options.EMAIL, Options.IM, Options.MISC, Options.PLAINTEXT) +BRIDGE_ENTRIES = (Options.BRIDGE1, Options.BRIDGE2, Options.BRIDGE3) # other options provided in the prompts CANCEL, NEXT, BACK = "Cancel", "Next", "Back" @@ -61,8 +67,9 @@ DISABLED_COLOR = "cyan" CONFIG = {"wizard.message.role": "", "wizard.message.relay": "", - "wizard.message.bridge": "", "wizard.message.exit": "", + "wizard.message.bridge": "", + "wizard.message.client": "", "wizard.toggle": {}, "wizard.suboptions": [], "wizard.default": {}, @@ -203,8 +210,15 @@ def showWizard(): # enables custom policies when 'custom' is selected and disables otherwise policyOpt = config[Options.POLICY] - policyOpt.setValidator(functools.partial(_exitPolicyAction, config)) - _exitPolicyAction(config, policyOpt, policyOpt.getValue()) + customPolicies = [config[opt] for opt in CUSTOM_POLICIES] + policyOpt.setValidator(functools.partial(_toggleEnabledAction, customPolicies)) + _toggleEnabledAction(customPolicies, policyOpt, policyOpt.getValue()) + + # enables bridge entries when "Use Bridges" is set and disables otherwise + useBridgeOpt = config[Options.BRIDGED] + bridgeEntries = [config[opt] for opt in BRIDGE_ENTRIES] + useBridgeOpt.setValidator(functools.partial(_toggleEnabledAction, bridgeEntries)) + _toggleEnabledAction(bridgeEntries, useBridgeOpt, useBridgeOpt.getValue()) # remembers the last selection made on the type prompt page relaySelection = RelayType.RELAY @@ -283,9 +297,6 @@ def promptConfigOptions(relayType, config): Prompts the user for the configuration of an internal relay. """ - # TODO: skipping section if it isn't ready yet - if not relayType in RelayOptions: return NEXT - topContent = _splitStr(CONFIG.get("wizard.message.%s" % relayType.lower(), ""), 54) options = [config[opt] for opt in RelayOptions[relayType]] @@ -395,11 +406,17 @@ def _splitStr(msg, width): return results -def _exitPolicyAction(config, option, value): +def _toggleEnabledAction(toggleOptions, option, value): """ Enables or disables custom exit policy options based on our selection. + + Arguments: + toggleOptions - configuration options to be toggled to match our our + selection (ie, true -> enabled, false -> disabled) + options - our config option + value - the value we're being set to """ - for opt in CUSTOM_POLICIES: - config[opt].setEnabled(not value) + for opt in toggleOptions: + opt.setEnabled(value) diff --git a/src/settings.cfg b/src/settings.cfg index f05dd71..aacec0a 100644 --- a/src/settings.cfg +++ b/src/settings.cfg @@ -345,25 +345,30 @@ wizard.message.role Welcome to the Tor network! This will step you through the c wizard.message.relay Internal relays provide connections within the Tor network. Since you will only be connecting to Tor users and relays this is an easy, hassle free way of helping to make the network better. wizard.message.exit Exits connect between the Tor network and the outside Internet. This is the most vitally important role you can take, but it also needs some forethought. Please read 'http://www.atagar.com/torExitTips/' before proceeding further to avoid any nasty surprises! wizard.message.bridge Bridges are non-public relays used as stepping stones for censored users for accessing the Tor network. +wizard.message.client This will make use of the Tor network without contributing to it. For easy, pre-configured setups that will help you to use Tor safely see 'http://www.atagar.com/torUsageTips/'. wizard.toggle Notify => Yes, No wizard.toggle Client => Enabled, Disabled wizard.toggle Portforward => Enabled, Disabled wizard.toggle Startup => Yes, No wizard.toggle Notice => Yes, No -wizard.toggle Policy => Default, Custom +wizard.toggle Policy => Custom, Default wizard.toggle Websites => Allow, Block wizard.toggle Email => Allow, Block wizard.toggle Im => Allow, Block wizard.toggle Misc => Allow, Block wizard.toggle Plaintext => Allow, Block wizard.toggle Distribute => Automated, Manual +wizard.toggle Bridged => Yes, No wizard.suboptions Websites wizard.suboptions Email wizard.suboptions Im wizard.suboptions Misc wizard.suboptions Plaintext +wizard.suboptions Bridge1 +wizard.suboptions Bridge2 +wizard.suboptions Bridge3 wizard.default Nickname => Unnamed wizard.default Notify => true @@ -372,13 +377,15 @@ wizard.default Startup => true wizard.default Client => false wizard.default Portforward => true wizard.default Notice => true -wizard.default Policy => true +wizard.default Policy => false wizard.default Websites => true wizard.default Email => true wizard.default Im => true wizard.default Misc => true wizard.default Plaintext => true wizard.default Distribute => true +wizard.default Bridged => false +wizard.default Reuse => 10 minutes wizard.label.general Cancel => Cancel wizard.label.general Back => Previous @@ -403,6 +410,11 @@ wizard.label.opt Im => Instant Messaging wizard.label.opt Misc => Other Services wizard.label.opt Plaintext => Unencrypted Traffic wizard.label.opt Distribute => Distribution +wizard.label.opt Bridged => Use Bridges +wizard.label.opt Bridge1 => First Bridge +wizard.label.opt Bridge2 => Second Bridge +wizard.label.opt Bridge3 => Third Bridge +wizard.label.opt Reuse => Circuit Duration wizard.description.general Cancel => Close without starting Tor. wizard.description.role Relay => Provides interconnections with other Tor relays. This is a safe and easy of making the network better. @@ -425,6 +437,11 @@ wizard.description.opt Im => Common instant messaging protocols including Jabber wizard.description.opt Misc => Protocols from the default policy that aren't among the above. wizard.description.opt Plaintext => When blocked the policy will exclude ports that aren't commonly encrypted. wizard.description.opt Distribute => If automated then we'll attempt to get your bridge to censored users (email auto-responders, activist networks, etc). Otherwise it'll be up to you to distribute the bridge address to people who need it. +wizard.description.opt Bridged => If you're being blocked from Tor then bridges provide a stepping stone you can use to connect. To get bridges visit 'https://bridges.torproject.org/' and enter the IP/port into the following entries (for instance "141.201.27.48:443"). +wizard.description.opt Bridge1 => Bridge used to connect to the Tor network. +wizard.description.opt Bridge2 => Fallback bridge used for connecting if the first is unavailable. +wizard.description.opt Bridge3 => Fallback bridge used for connecting if neither of the first two are available. +wizard.description.opt Reuse => Duration that circuits will be reused before replacements are made for new connections. It's good to periodically change the route you use, but making circuits takes a fair bit of work so don't set this to be too low. # some config options are fetched via special values torrc.map HiddenServiceDir => HiddenServiceOptions

1 0

[arm/release] fix: workaround for textpad insert mode issues
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit dd81736d16d638343b3954f2def575378b5ea309 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Jul 3 16:54:53 2011 -0700 fix: workaround for textpad insert mode issues The insert mode of the textpad class has a couple issues: - it's only available in Python 2.6+ - if the text doens't have the default formatting then it doens't work (input is replacement mode instead) This drops usage for the insert mode flag, instead doing it ourselves via arm's textpad validator. This is kinda vital for the wizard since that text has attibutes and not having insert mode there was pretty painful. --- src/util/panel.py | 29 +++++++++++++++++++---------- src/util/uiTools.py | 8 +++++--- 2 files changed, 24 insertions(+), 13 deletions(-) diff --git a/src/util/panel.py b/src/util/panel.py index 59d2b13..1be2306 100644 --- a/src/util/panel.py +++ b/src/util/panel.py @@ -2,11 +2,11 @@ Wrapper for safely working with curses subwindows. """ -import sys import copy import time import traceback import curses +import curses.ascii import curses.textpad from threading import RLock @@ -613,15 +613,9 @@ class Panel(): # Displays the text field, blocking until the user's done. This closes the # text panel and returns userInput to the initial text if the user presses - # escape. Insert mode is available in Python 2.6+, before that the - # constructor only accepted a subwindow argument as per: - # https://trac.torproject.org/projects/tor/ticket/2354 + # escape. - majorVersion, minorVersion = sys.version_info[:2] - if majorVersion == 2 and minorVersion >= 6: - textbox = curses.textpad.Textbox(inputSubwindow, True) - else: - textbox = curses.textpad.Textbox(inputSubwindow) + textbox = curses.textpad.Textbox(inputSubwindow) textbox.win.attron(format) userInput = textbox.edit(lambda key: _textboxValidate(textbox, key)).strip() @@ -738,7 +732,22 @@ def _textboxValidate(textbox, key): """ y, x = textbox.win.getyx() - if key == 27: + + if curses.ascii.isprint(key) and x < textbox.maxx: + # Shifts the existing text forward so input is an insert method rather + # than replacement. The curses.textpad accepts an insert mode flag but + # this has a couple issues... + # - The flag is only available for Python 2.6+, before that the + # constructor only accepted a subwindow argument as per: + # https://trac.torproject.org/projects/tor/ticket/2354 + # - The textpad doesn't shift text that has text attributes. This is + # because keycodes read by textbox.win.inch() includes formatting, + # causing the curses.ascii.isprint() check it does to fail. + + currentInput = textbox.gather() + textbox.win.addstr(y, x + 1, currentInput[x:textbox.maxx - 1]) + textbox.win.move(y, x) # reverts cursor movement during gather call + elif key == 27: # curses.ascii.BEL is a character codes that causes textpad to terminate return curses.ascii.BEL elif key == curses.KEY_HOME: diff --git a/src/util/uiTools.py b/src/util/uiTools.py index 52885de..68b93af 100644 --- a/src/util/uiTools.py +++ b/src/util/uiTools.py @@ -282,15 +282,17 @@ def cropStr(msg, size, minWordLen = 4, minCrop = 0, endType = Ending.ELLIPSE, ge if getRemainder: return (returnMsg, remainder) else: return returnMsg -def padStr(msg, size): +def padStr(msg, size, cropExtra = False): """ Provides the string padded with whitespace to the given length. Arguments: - msg - string to be padded - size - length to be padded to + msg - string to be padded + size - length to be padded to + cropExtra - crops string if it's longer than the size if true """ + if cropExtra: msg = msg[:size] return ("%%-%is" % size) % msg def camelCase(label, divider = "_", joiner = " "):

1 0

[arm/release] fix: correcting some port types and descriptions
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 17fa269873a561b7ba8f843c3030373014277b3a Author: Damian Johnson <atagar(a)torproject.org> Date: Fri Jul 1 15:57:20 2011 -0700 fix: correcting some port types and descriptions Secure mail ports were misclassified, and descriptions for the mail and web policies were missing ports. --- src/settings.cfg | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/settings.cfg b/src/settings.cfg index 076299d..7f2953f 100644 --- a/src/settings.cfg +++ b/src/settings.cfg @@ -435,8 +435,8 @@ wizard.description.opt Portforward => If needed, attempts NAT traversal using UP wizard.description.opt Startup => Runs Tor in the background when the system starts. wizard.description.opt Notice => Provides a disclaimer that this is an exit on port 80 (http://www.atagar.com/exitNotice) wizard.description.opt Policy => Ports allowed to exit from your relay. The default policy allows for common services while limiting the chance of getting a DMCA takedown for torrent traffic (http://www.atagar.com/exitPolicy) -wizard.description.opt Websites => General Internet browsing including HTTP (80) and HTTPS (443). -wizard.description.opt Email => Protocols for receiving, but not sending email. This includes POP3 (110), POP3S (995), IMAP (143), and IMAPS (993). +wizard.description.opt Websites => General Internet browsing including HTTP (80), HTTPS (443), common alternatives (81, 8008), and proxies (3128, 8080) +wizard.description.opt Email => Protocols for receiving, but not sending email. This includes POP3 (110), POP3S (995), IMAP (143, 220), and IMAPS (993). wizard.description.opt Im => Common instant messaging protocols including Jabber, IRC, ICQ, AIM, Yahoo, MSN, SILC, GroupWise, Gadu-Gadu, Sametime, and Zephyr. wizard.description.opt Misc => Protocols from the default policy that aren't among the above. wizard.description.opt Plaintext => When blocked the policy will exclude ports that aren't commonly encrypted. @@ -836,9 +836,9 @@ port.exit.misc 981 # SofaWare Firewall Administration port.exit.misc 989-990 # FTPS port.exit.misc 991 # NAS port.exit.misc 992 # Telnet -port.exit.misc 993 # IMAPS +port.exit.mail 993 # IMAPS port.exit.im 994 # IRC over SSL -port.exit.misc 995 # POP3S +port.exit.mail 995 # POP3S port.exit.misc 1194 # OpenVPN port.exit.misc 1220 # QuickTime port.exit.misc 1293 # PKT-KRB-IPSec @@ -895,6 +895,8 @@ port.encrypted 749 port.encrypted 981 port.encrypted 989 port.encrypted 990 +port.encrypted 993 +port.encrypted 995 port.encrypted 1194 port.encrypted 1293 port.encrypted 1723

1 0

[arm/release] Input field validation for bandwith rates
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 90fba07ce66de9e811aa762b835b769a254c438b Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Jul 3 10:39:51 2011 -0700 Input field validation for bandwith rates --- src/cli/wizard.py | 18 +++++++++++++++++- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/src/cli/wizard.py b/src/cli/wizard.py index 219c6b6..43d107b 100644 --- a/src/cli/wizard.py +++ b/src/cli/wizard.py @@ -210,6 +210,7 @@ def showWizard(): else: config[option] = ConfigOption(option, "opt", default) # sets input validators + config[Options.BANDWIDTH].setValidator(_relayRateValidator) config[Options.BRIDGE1].setValidator(_bridgeDestinationValidator) config[Options.BRIDGE2].setValidator(_bridgeDestinationValidator) config[Options.BRIDGE3].setValidator(_bridgeDestinationValidator) @@ -391,7 +392,7 @@ def promptConfigOptions(relayType, config): if newValue: try: options[selection].setValue(newValue.strip()) except ValueError, exc: - cli.popups.showMsg(str(exc), 2) + cli.popups.showMsg(str(exc), 3) cli.controller.getController().requestRedraw(True) elif key == 27: selection, key = -1, curses.KEY_ENTER # esc - cancel finally: @@ -428,6 +429,21 @@ def _toggleEnabledAction(toggleOptions, option, value): for opt in toggleOptions: opt.setEnabled(value) +def _relayRateValidator(option, value): + if value.count(" ") != 1: + msg = "This should be a measurement followed by the rate (for instance, \"5 MB/s\")" + raise ValueError(msg) + + rate, units = value.split(" ", 1) + acceptedUnits = ("KB/s", "MB/s", "GB/s") + if not rate.isdigit(): + raise ValueError("'%s' isn't an integer" % rate) + elif not units in acceptedUnits: + msg = "'%s' is an invalid rate, options include \"%s\"" % (units, "\", \"".join(acceptedUnits)) + raise ValueError(msg) + elif (int(rate) < 20 and units == "KB/s") or int(rate) < 1: + raise ValueError("To be usable as a relay the rate must be at least 20 KB/s") + def _bridgeDestinationValidator(option, value): if value.count(":") != 1: raise ValueError("Bridges are of the form '<ip address>:<port>'")

1 0

[arm/release] Remove gobject timeout.
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit ae45817503f817f7d97d41358315b516fc4222b8 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Sat Jun 25 15:08:54 2011 +0500 Remove gobject timeout. Gobject timeout works well for graphs but creates issues for selecting log rows. Instead, call fill_log() in constructor of panel and then subsequently on addition of each entry. --- src/gui/logPanel.py | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gui/logPanel.py b/src/gui/logPanel.py index 0a00137..6ac6418 100644 --- a/src/gui/logPanel.py +++ b/src/gui/logPanel.py @@ -62,7 +62,7 @@ class LogPanel: conn.addEventListener(TorEventObserver(self.register_event)) conn.addTorCtlListener(self._register_torctl_event) - gobject.timeout_add(1000, self.fill_log) + self.fill_log() def pack_widgets(self): liststore = self.builder.get_object('liststore_log') @@ -79,10 +79,9 @@ class LogPanel: row = (long(entry.timestamp), timeLabel, entry.type, entry.msg, entry.color) liststore.append(row) - return True - def register_event(self, event): self.msgLog.appendleft(event) + self.fill_log() def _register_arm_event(self, level, msg, eventTime): eventColor = RUNLEVEL_EVENT_COLOR[level]

1 0

[arm/release] Use locking for fixing segfaults, different colors from cli.
by atagar＠torproject.org 17 Jul '11

17 Jul '11

commit 6c3a0d15a346e3b4cdcc0c21fcf9d20883d03061 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Sun Jun 26 02:24:19 2011 +0500 Use locking for fixing segfaults, different colors from cli. msgLog deque was being updated by events while being pushed into liststore which produced inconsistency and generated segfault. Using different colors from cli in order to be readable. Moved logPanel creation before bandwidthStats in order to let controller events reach bandwidthStats. --- src/gui/controller.py | 6 +++--- src/gui/logPanel.py | 29 +++++++++++++++++++++-------- 2 files changed, 24 insertions(+), 11 deletions(-) diff --git a/src/gui/controller.py b/src/gui/controller.py index 1c173af..5f1712c 100644 --- a/src/gui/controller.py +++ b/src/gui/controller.py @@ -18,12 +18,12 @@ class GuiController: self.builder.add_from_file(filename) self.builder.connect_signals(self) - self.bwStats = bandwidthStats.BandwidthStats(self.builder) - self.bwStats.pack_widgets() - self.logPanel = logPanel.LogPanel(self.builder) self.logPanel.pack_widgets() + self.bwStats = bandwidthStats.BandwidthStats(self.builder) + self.bwStats.pack_widgets() + def run(self): window = self.builder.get_object('window_main') diff --git a/src/gui/logPanel.py b/src/gui/logPanel.py index 6ac6418..97a01cc 100644 --- a/src/gui/logPanel.py +++ b/src/gui/logPanel.py @@ -7,6 +7,7 @@ import sys import time from collections import deque +from threading import RLock import gobject import gtk @@ -16,8 +17,10 @@ from util import log, uiTools, torTools from cli.logPanel import (expandEvents, setEventListening, getLogFileEntries, LogEntry, TorEventObserver, - DEFAULT_CONFIG, RUNLEVEL_EVENT_COLOR) + DEFAULT_CONFIG) +RUNLEVEL_EVENT_COLOR = {log.DEBUG: "#C73043", log.INFO: "#762A2A", log.NOTICE: "#222222", + log.WARN: "#AB7814", log.ERR: "#EC131F"} STARTUP_EVENTS = 'N3' class LogPanel: @@ -25,6 +28,7 @@ class LogPanel: self.builder = builder self._config = dict(DEFAULT_CONFIG) + self.lock = RLock() self.msgLog = deque() self.loggedEvents = setEventListening(expandEvents(STARTUP_EVENTS)) @@ -62,7 +66,7 @@ class LogPanel: conn.addEventListener(TorEventObserver(self.register_event)) conn.addTorCtlListener(self._register_torctl_event) - self.fill_log() + gobject.timeout_add(1000, self.fill_log) def pack_widgets(self): liststore = self.builder.get_object('liststore_log') @@ -74,14 +78,23 @@ class LogPanel: liststore = self.builder.get_object('liststore_log') liststore.clear() - for entry in self.msgLog: - timeLabel = time.strftime('%H:%M:%S', time.localtime(entry.timestamp)) - row = (long(entry.timestamp), timeLabel, entry.type, entry.msg, entry.color) - liststore.append(row) + self.lock.acquire() + try: + for entry in self.msgLog: + timeLabel = time.strftime('%H:%M:%S', time.localtime(entry.timestamp)) + row = (long(entry.timestamp), timeLabel, entry.type, entry.msg, entry.color) + liststore.append(row) + finally: + self.lock.release() + + return True def register_event(self, event): - self.msgLog.appendleft(event) - self.fill_log() + self.lock.acquire() + try: + self.msgLog.appendleft(event) + finally: + self.lock.release() def _register_arm_event(self, level, msg, eventTime): eventColor = RUNLEVEL_EVENT_COLOR[level]

1 0