- tor-commits - lists.torproject.org

[torspec/master] update bandwidth guarantee threshold for Fast flag (ticket 4489)
by arma＠torproject.org 23 Nov '11

23 Nov '11

commit 5808b4050545afd0e0ad4fa8222dfc0b3e23dc29 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Nov 23 16:39:48 2011 -0500 update bandwidth guarantee threshold for Fast flag (ticket 4489) --- dir-spec.txt | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dir-spec.txt b/dir-spec.txt index 9a22323..b4db02e 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -1486,11 +1486,12 @@ [XXXX what happens when we have less than 4 days of MTBF info.] "Exit" -- A router is called an 'Exit' iff it allows exits to at - least two of the ports 80, 443, and 6667 and allows exits to at - least one /8 address space. + least two of the ports 80, 443, and 6667 and allows exits to at + least one /8 address space. "Fast" -- A router is 'Fast' if it is active, and its bandwidth is - either in the top 7/8ths for known active routers or at least 20KB/s. + either in the top 7/8ths for known active routers or at least some + minimum (20KB/s until 0.2.3.7-alpha, and 100KB/s after that). "Guard" -- A router is a possible 'Guard' if its Weighted Fractional Uptime is at least the median for "familiar" active routers, and if

1 0

[tor/master] Merge remote-tracking branch 'public/bug4230' into maint-0.2.2
by nickm＠torproject.org 23 Nov '11

23 Nov '11

commit fbf1c5ee79490577ec0b8c68338ba4f872e993b4 Merge: 841247a e1c6431 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Nov 23 16:22:26 2011 -0500 Merge remote-tracking branch 'public/bug4230' into maint-0.2.2 changes/bug4230 | 5 +++++ src/common/container.c | 19 ++++++++++++++----- 2 files changed, 19 insertions(+), 5 deletions(-)

1 0

[tor/master] Correct the handling of overflow behavior in smartlist_ensure_capacity
by nickm＠torproject.org 23 Nov '11

23 Nov '11

commit e1c6431e42bc6b5619c78008cbe92730ead57bbf Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Nov 9 12:08:28 2011 -0500 Correct the handling of overflow behavior in smartlist_ensure_capacity The old behavior was susceptible to the compiler optimizing out our assertion check, *and* could still overflow size_t on 32-bit systems even when it did work. --- changes/bug4230 | 5 +++++ src/common/container.c | 19 ++++++++++++++----- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/changes/bug4230 b/changes/bug4230 new file mode 100644 index 0000000..c1ba584 --- /dev/null +++ b/changes/bug4230 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Resolve an integer overflow bug in smartlist_ensure_capacity. + Fixes bug 4230; bugfix on Tor 0.1.0.1-rc. Based on a patch by + Mansour Moufid. + diff --git a/src/common/container.c b/src/common/container.c index c741eb0..edfcd97 100644 --- a/src/common/container.c +++ b/src/common/container.c @@ -61,13 +61,22 @@ smartlist_clear(smartlist_t *sl) static INLINE void smartlist_ensure_capacity(smartlist_t *sl, int size) { +#if SIZEOF_SIZE_T > SIZEOF_INT +#define MAX_CAPACITY (INT_MAX) +#else +#define MAX_CAPACITY (int)((SIZE_MAX / (sizeof(void*)))) +#endif if (size > sl->capacity) { - int higher = sl->capacity * 2; - while (size > higher) - higher *= 2; - tor_assert(higher > 0); /* detect overflow */ + int higher = sl->capacity; + if (PREDICT_UNLIKELY(size > MAX_CAPACITY/2)) { + tor_assert(size <= MAX_CAPACITY); + higher = MAX_CAPACITY; + } else { + while (size > higher) + higher *= 2; + } sl->capacity = higher; - sl->list = tor_realloc(sl->list, sizeof(void*)*sl->capacity); + sl->list = tor_realloc(sl->list, sizeof(void*)*((size_t)sl->capacity)); } }

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.2'
by nickm＠torproject.org 23 Nov '11

23 Nov '11

commit 3890c81e7c4eaa3350fe569dbc2fbf97e824e4c0 Merge: 281aa2e fbf1c5e Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Nov 23 16:28:18 2011 -0500 Merge remote-tracking branch 'origin/maint-0.2.2' changes/bug4230 | 5 +++++ src/common/container.c | 19 ++++++++++++++----- 2 files changed, 19 insertions(+), 5 deletions(-)

1 0

[tor/maint-0.2.2] Correct the handling of overflow behavior in smartlist_ensure_capacity
by nickm＠torproject.org 23 Nov '11

23 Nov '11

commit e1c6431e42bc6b5619c78008cbe92730ead57bbf Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Nov 9 12:08:28 2011 -0500 Correct the handling of overflow behavior in smartlist_ensure_capacity The old behavior was susceptible to the compiler optimizing out our assertion check, *and* could still overflow size_t on 32-bit systems even when it did work. --- changes/bug4230 | 5 +++++ src/common/container.c | 19 ++++++++++++++----- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/changes/bug4230 b/changes/bug4230 new file mode 100644 index 0000000..c1ba584 --- /dev/null +++ b/changes/bug4230 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Resolve an integer overflow bug in smartlist_ensure_capacity. + Fixes bug 4230; bugfix on Tor 0.1.0.1-rc. Based on a patch by + Mansour Moufid. + diff --git a/src/common/container.c b/src/common/container.c index c741eb0..edfcd97 100644 --- a/src/common/container.c +++ b/src/common/container.c @@ -61,13 +61,22 @@ smartlist_clear(smartlist_t *sl) static INLINE void smartlist_ensure_capacity(smartlist_t *sl, int size) { +#if SIZEOF_SIZE_T > SIZEOF_INT +#define MAX_CAPACITY (INT_MAX) +#else +#define MAX_CAPACITY (int)((SIZE_MAX / (sizeof(void*)))) +#endif if (size > sl->capacity) { - int higher = sl->capacity * 2; - while (size > higher) - higher *= 2; - tor_assert(higher > 0); /* detect overflow */ + int higher = sl->capacity; + if (PREDICT_UNLIKELY(size > MAX_CAPACITY/2)) { + tor_assert(size <= MAX_CAPACITY); + higher = MAX_CAPACITY; + } else { + while (size > higher) + higher *= 2; + } sl->capacity = higher; - sl->list = tor_realloc(sl->list, sizeof(void*)*sl->capacity); + sl->list = tor_realloc(sl->list, sizeof(void*)*((size_t)sl->capacity)); } }

1 0

[tor/maint-0.2.2] Merge remote-tracking branch 'public/bug4230' into maint-0.2.2
by nickm＠torproject.org 23 Nov '11

23 Nov '11

commit fbf1c5ee79490577ec0b8c68338ba4f872e993b4 Merge: 841247a e1c6431 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Nov 23 16:22:26 2011 -0500 Merge remote-tracking branch 'public/bug4230' into maint-0.2.2 changes/bug4230 | 5 +++++ src/common/container.c | 19 ++++++++++++++----- 2 files changed, 19 insertions(+), 5 deletions(-)

1 0

[tor-cloud/master] How to stop/terminate an instance, solves #4540
by runa＠torproject.org 23 Nov '11

23 Nov '11

commit 51f28340f7178c5238126255d8e849efe787109a Author: Runa A. Sandvik <runa.sandvik(a)gmail.com> Date: Wed Nov 23 19:48:29 2011 +0000 How to stop/terminate an instance, solves #4540 --- html/index.html | 19 +++++++++++++------ 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/html/index.html b/html/index.html index 9693034..5645f9e 100644 --- a/html/index.html +++ b/html/index.html @@ -289,26 +289,33 @@ ubuntu as the username if you wish to connect to your server via SSH. - 5. What's in the Tor configuration file? + 5. How do I stop or terminate the instance? + To stop or terminate the instance, log on to the AWS Management + Console, find your instance, right click on it and choose either + "Stop" or "Terminate". "Stop" will just shutdown the instance as + normal and will allow you to start it up again later. "Terminate" + will delete the instance from your AWS account. + + 6. What's in the Tor configuration file? The Tor configuration file that the images have been configured with can be found <a href="https://cloud.torproject.org/torrc.txt">here</a>. - 6. Will the images automatically download and install package updates? + 7. Will the images automatically download and install package updates? Yes, the images have all been configured with the <a href="https://help.ubuntu.com/community/AutomaticSecurityUpdates">unattended-upgrades</a> package. This means that your system will automatically download and install updates. - 7. Will you let me know when you publish new images? + 8. Will you let me know when you publish new images? New cloud images will be announced on <a href="https://twitter.com/torproject">Twitter</a>, <a href="https://identi.ca/torproject">identi.ca</a>, <a href="https://blog.torproject.org">our blog</a> and on the <a href="https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-talk">tor-talk</a> mailing list. - 8. Where do I report a bug I am encountering? + 9. Where do I report a bug I am encountering? If you think the bug you have found is specific to the Tor Cloud images we provide, please <a href="https://trac.torproject.org">file a bug</a> or send an email to help AT rt.torproject.org. - 9. Is there an IRC channel where I can ask about Tor Cloud? + 10. Is there an IRC channel where I can ask about Tor Cloud? Yes, simply join #tor on irc.oftc.net and ask your question. It may take a while before we get back to you, so please be patient. - 10. I have a question that is not answered here, what do I do? + 11. I have a question that is not answered here, what do I do? Please send an email to help AT rt.torproject.org. </div>

1 0

[tor-cloud/master] How to change IP of instance, solves #4542
by runa＠torproject.org 23 Nov '11

23 Nov '11

commit 696b079966b4c68b5dc6a6f53ffedb4281983d55 Author: Runa A. Sandvik <runa.sandvik(a)gmail.com> Date: Wed Nov 23 20:24:45 2011 +0000 How to change IP of instance, solves #4542 --- html/index.html | 19 +++++++++++++------ 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/html/index.html b/html/index.html index 5645f9e..20a9a44 100644 --- a/html/index.html +++ b/html/index.html @@ -296,26 +296,33 @@ normal and will allow you to start it up again later. "Terminate" will delete the instance from your AWS account. - 6. What's in the Tor configuration file? + 6. How do I change the IP address of my instance? + To change the IP address of your instance, log on to the AWS + Management Console, find your instance, right click on it and choose + "Stop". Once the instance has shut down completely, right click on + it again and choose "Start". The instance will be assigned a new IP + address when it starts up again. + + 7. What's in the Tor configuration file? The Tor configuration file that the images have been configured with can be found <a href="https://cloud.torproject.org/torrc.txt">here</a>. - 7. Will the images automatically download and install package updates? + 8. Will the images automatically download and install package updates? Yes, the images have all been configured with the <a href="https://help.ubuntu.com/community/AutomaticSecurityUpdates">unattended-upgrades</a> package. This means that your system will automatically download and install updates. - 8. Will you let me know when you publish new images? + 9. Will you let me know when you publish new images? New cloud images will be announced on <a href="https://twitter.com/torproject">Twitter</a>, <a href="https://identi.ca/torproject">identi.ca</a>, <a href="https://blog.torproject.org">our blog</a> and on the <a href="https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-talk">tor-talk</a> mailing list. - 9. Where do I report a bug I am encountering? + 10. Where do I report a bug I am encountering? If you think the bug you have found is specific to the Tor Cloud images we provide, please <a href="https://trac.torproject.org">file a bug</a> or send an email to help AT rt.torproject.org. - 10. Is there an IRC channel where I can ask about Tor Cloud? + 11. Is there an IRC channel where I can ask about Tor Cloud? Yes, simply join #tor on irc.oftc.net and ask your question. It may take a while before we get back to you, so please be patient. - 11. I have a question that is not answered here, what do I do? + 12. I have a question that is not answered here, what do I do? Please send an email to help AT rt.torproject.org. </div>

1 0

[translation/orbot] Update translations for orbot
by translation＠torproject.org 23 Nov '11

23 Nov '11

commit aa3b52ca0ff732c95a8cf86fb7b33034ead34762 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Nov 23 19:15:03 2011 +0000 Update translations for orbot --- values-it/strings.xml | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/values-it/strings.xml b/values-it/strings.xml index d100f8d..4eb49e8 100644 --- a/values-it/strings.xml +++ b/values-it/strings.xml @@ -13,7 +13,7 @@ <string name="status_shutting_down">Orbot si sta spegnendo</string> <string name="tor_process_starting">Avvio client Tor...</string> <string name="tor_process_complete">completa.</string> - <string name="tor_process_waiting"></string> + <string name="tor_process_waiting">attesa.</string> <string name="not_anonymous_yet">ATTENZIONE: Il traffico non è ancora anonimo! Configura le applicazioni per utilizzare il proxy HTTP 127.0.0.1:8118, SOCKS4A o proxy SOCKS5 127.0.0.1:9050</string> <string name="menu_home">Home</string> <string name="menu_browse">Sfoglia</string> @@ -116,10 +116,10 @@ Visita il nostro sito web https://guardianproject.info/apps/orbot o invia una ma <string name="pref_use_whispercore">Usa WhisperCore</string> <string name="pref_use_whispercore_summary"></string> <string name="pref_proxy_type_title">Tipo proxy</string> - <string name="pref_proxy_type_summary"></string> + <string name="pref_proxy_type_summary">Protocolli da utilizzare per i server proxy: HTTP, HTTPS, Socks4, Socks5</string> <string name="pref_proxy_type_dialog">Inserisci tipo proxy</string> <string name="pref_proxy_host_title">Host proxy</string> - <string name="pref_proxy_host_summary"></string> + <string name="pref_proxy_host_summary">Hostname server proxy</string> <string name="pref_proxy_host_dialog"></string> <string name="pref_proxy_port_title">Porta proxy</string> <string name="pref_proxy_port_summary"></string>

1 0

[stem/master] Nicer logging when receiving controller data
by atagar＠torproject.org 23 Nov '11

23 Nov '11

commit 1c2337a71f9f19e262cd222679bf66eb046a9e73 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Nov 23 06:47:11 2011 -0800 Nicer logging when receiving controller data Changing the logged controller messages a bit. This is a bit less faithful to the raw controller response but it's more readable. --- stem/types.py | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/stem/types.py b/stem/types.py index 4415598..882ca99 100644 --- a/stem/types.py +++ b/stem/types.py @@ -124,7 +124,9 @@ def read_message(control_file): # end of the message, return the message parsed_content.append((status_code, divider, content)) - LOGGER.debug("Received message:\n" + raw_content) + # replacing the \r\n newline endings and the ending newline since it + # leads to more readable log messages + LOGGER.debug("Received message:\n" + raw_content.replace("\r\n", "\n").rstrip()) return ControlMessage(parsed_content, raw_content) elif divider == "+":

1 0