- tor-commits - lists.torproject.org

[tor/master] Coverity 709056: Check return value on fputs in tor-gencert
by nickm＠torproject.org 16 Jul '12

16 Jul '12

commit d32f5081e1c41324a3464c30c487c6ef57a333d1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 16 11:38:39 2012 -0400 Coverity 709056: Check return value on fputs in tor-gencert --- changes/cov709056 | 4 ++++ src/tools/tor-gencert.c | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/changes/cov709056 b/changes/cov709056 new file mode 100644 index 0000000..64a75ad --- /dev/null +++ b/changes/cov709056 @@ -0,0 +1,4 @@ + o Minor bugfixes: + - Check return value of fputs() when writing authority certificate + file. Fixes Coverity issue 709056; bugfix on 0.2.0.1-alpha. + diff --git a/src/tools/tor-gencert.c b/src/tools/tor-gencert.c index a8ffc07..38b2101 100644 --- a/src/tools/tor-gencert.c +++ b/src/tools/tor-gencert.c @@ -497,7 +497,12 @@ generate_certificate(void) return 1; } - fputs(buf, f); + if (fputs(buf, f) < 0) { + log_err(LD_GENERAL, "Couldn't write to %s: %s", + certificate_file, strerror(errno)); + fclose(f); + return 1; + } fclose(f); return 0; }

1 0

[tor/master] Refer to the correct variable in a loop when parsing entry guard state
by nickm＠torproject.org 16 Jul '12

16 Jul '12

commit 93b730175566de2dcf783b1ce4b3fd87a6f7375e Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 16 11:49:45 2012 -0400 Refer to the correct variable in a loop when parsing entry guard state Fixes bug 6397 and coverity issue 709599. Bugfix on 0.2.3.17-beta. --- changes/bug6397 | 4 ++++ src/or/circuitbuild.c | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/changes/bug6397 b/changes/bug6397 new file mode 100644 index 0000000..23d8359 --- /dev/null +++ b/changes/bug6397 @@ -0,0 +1,4 @@ + o Major bugfixes: + - When disabling guards for having too high a proportion of failed + circuits, make sure to look at each guard. Fix for bug 6397; bugfix + on 0.2.3.17-beta. diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 6d1e4e7..714bbca 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -4728,8 +4728,7 @@ entry_guards_parse_state(or_state_t *state, int set, char **msg) } } - SMARTLIST_FOREACH(new_entry_guards, entry_guard_t *, e, - { + SMARTLIST_FOREACH_BEGIN(new_entry_guards, entry_guard_t *, e) { char *sp; char *val = digestmap_get(added_by, e->identity); if (val && (sp = strchr(val, ' '))) { @@ -4747,9 +4746,10 @@ entry_guards_parse_state(or_state_t *state, int set, char **msg) e->chosen_on_date = time(NULL) - crypto_rand_int(3600*24*30); } } - if (node->path_bias_disabled && !node->bad_since) - node->bad_since = time(NULL); - }); + if (e->path_bias_disabled && !e->bad_since) + e->bad_since = time(NULL); + } + SMARTLIST_FOREACH_END(e); if (*msg || !set) { SMARTLIST_FOREACH(new_entry_guards, entry_guard_t *, e,

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.3'
by nickm＠torproject.org 16 Jul '12

16 Jul '12

commit 7ac8a4a037581ab7c47079cc98c9d3496932a8bd Merge: deaf30a 93b7301 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 16 11:50:53 2012 -0400 Merge remote-tracking branch 'origin/maint-0.2.3' changes/bug6397 | 4 ++++ changes/cov709056 | 4 ++++ src/or/circuitbuild.c | 10 +++++----- src/tools/tor-gencert.c | 7 ++++++- 4 files changed, 19 insertions(+), 6 deletions(-)

1 0

[tor/maint-0.2.3] Coverity 709056: Check return value on fputs in tor-gencert
by nickm＠torproject.org 16 Jul '12

16 Jul '12

commit d32f5081e1c41324a3464c30c487c6ef57a333d1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 16 11:38:39 2012 -0400 Coverity 709056: Check return value on fputs in tor-gencert --- changes/cov709056 | 4 ++++ src/tools/tor-gencert.c | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/changes/cov709056 b/changes/cov709056 new file mode 100644 index 0000000..64a75ad --- /dev/null +++ b/changes/cov709056 @@ -0,0 +1,4 @@ + o Minor bugfixes: + - Check return value of fputs() when writing authority certificate + file. Fixes Coverity issue 709056; bugfix on 0.2.0.1-alpha. + diff --git a/src/tools/tor-gencert.c b/src/tools/tor-gencert.c index a8ffc07..38b2101 100644 --- a/src/tools/tor-gencert.c +++ b/src/tools/tor-gencert.c @@ -497,7 +497,12 @@ generate_certificate(void) return 1; } - fputs(buf, f); + if (fputs(buf, f) < 0) { + log_err(LD_GENERAL, "Couldn't write to %s: %s", + certificate_file, strerror(errno)); + fclose(f); + return 1; + } fclose(f); return 0; }

1 0

[tor/maint-0.2.3] Refer to the correct variable in a loop when parsing entry guard state
by nickm＠torproject.org 16 Jul '12

16 Jul '12

commit 93b730175566de2dcf783b1ce4b3fd87a6f7375e Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 16 11:49:45 2012 -0400 Refer to the correct variable in a loop when parsing entry guard state Fixes bug 6397 and coverity issue 709599. Bugfix on 0.2.3.17-beta. --- changes/bug6397 | 4 ++++ src/or/circuitbuild.c | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/changes/bug6397 b/changes/bug6397 new file mode 100644 index 0000000..23d8359 --- /dev/null +++ b/changes/bug6397 @@ -0,0 +1,4 @@ + o Major bugfixes: + - When disabling guards for having too high a proportion of failed + circuits, make sure to look at each guard. Fix for bug 6397; bugfix + on 0.2.3.17-beta. diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 6d1e4e7..714bbca 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -4728,8 +4728,7 @@ entry_guards_parse_state(or_state_t *state, int set, char **msg) } } - SMARTLIST_FOREACH(new_entry_guards, entry_guard_t *, e, - { + SMARTLIST_FOREACH_BEGIN(new_entry_guards, entry_guard_t *, e) { char *sp; char *val = digestmap_get(added_by, e->identity); if (val && (sp = strchr(val, ' '))) { @@ -4747,9 +4746,10 @@ entry_guards_parse_state(or_state_t *state, int set, char **msg) e->chosen_on_date = time(NULL) - crypto_rand_int(3600*24*30); } } - if (node->path_bias_disabled && !node->bad_since) - node->bad_since = time(NULL); - }); + if (e->path_bias_disabled && !e->bad_since) + e->bad_since = time(NULL); + } + SMARTLIST_FOREACH_END(e); if (*msg || !set) { SMARTLIST_FOREACH(new_entry_guards, entry_guard_t *, e,

1 0

[tor/master] Improve Alternate*Authority docs. Bug 6387.
by nickm＠torproject.org 16 Jul '12

16 Jul '12

commit 9ad5b2593004c55d4223d59a150898b48d04737a Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 16 11:21:20 2012 -0400 Improve Alternate*Authority docs. Bug 6387. --- changes/bug6387 | 3 +++ doc/tor.1.txt | 11 +++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/changes/bug6387 b/changes/bug6387 new file mode 100644 index 0000000..73fc4f7 --- /dev/null +++ b/changes/bug6387 @@ -0,0 +1,3 @@ + o Documentation: + - Clarify the documentation for the Alternate*Authority options. + Fixes bug 6387. diff --git a/doc/tor.1.txt b/doc/tor.1.txt index a4a0ed7..78c3487 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -319,11 +319,14 @@ GENERAL OPTIONS **AlternateHSAuthority** [__nickname__] [**flags**] __address__:__port__ __fingerprint__ + **AlternateBridgeAuthority** [__nickname__] [**flags**] __address__:__port__ __ fingerprint__:: - As DirServer, but replaces less of the default directory authorities. Using + These options behave as DirServer, but they replace fewer of the + default directory authorities. Using AlternateDirAuthority replaces the default Tor directory authorities, but - leaves the hidden service authorities and bridge authorities in place. - Similarly, Using AlternateHSAuthority replaces the default hidden service - authorities, but not the directory or bridge authorities. + leaves the default hidden service authorities and bridge authorities in + place. Similarly, AlternateHSAuthority replaces the default hidden + service authorities, but not the directory or bridge authorities; and + AlternateBridgeAuthority replaces the default bridge authority, + but leaves the directory and hidden service authorities alone. **DisableAllSwap** **0**|**1**:: If set to 1, Tor will attempt to lock all current and future memory pages,

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.3'
by nickm＠torproject.org 16 Jul '12

16 Jul '12

commit deaf30a8af331bdb96fae59a6f4a1effcb21e2d6 Merge: 6652477 9ad5b25 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 16 11:22:41 2012 -0400 Merge remote-tracking branch 'origin/maint-0.2.3' changes/bug6387 | 3 +++ doc/tor.1.txt | 11 +++++++---- 2 files changed, 10 insertions(+), 4 deletions(-)

1 0

[tor/maint-0.2.3] Improve Alternate*Authority docs. Bug 6387.
by nickm＠torproject.org 16 Jul '12

16 Jul '12

commit 9ad5b2593004c55d4223d59a150898b48d04737a Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 16 11:21:20 2012 -0400 Improve Alternate*Authority docs. Bug 6387. --- changes/bug6387 | 3 +++ doc/tor.1.txt | 11 +++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/changes/bug6387 b/changes/bug6387 new file mode 100644 index 0000000..73fc4f7 --- /dev/null +++ b/changes/bug6387 @@ -0,0 +1,3 @@ + o Documentation: + - Clarify the documentation for the Alternate*Authority options. + Fixes bug 6387. diff --git a/doc/tor.1.txt b/doc/tor.1.txt index a4a0ed7..78c3487 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -319,11 +319,14 @@ GENERAL OPTIONS **AlternateHSAuthority** [__nickname__] [**flags**] __address__:__port__ __fingerprint__ + **AlternateBridgeAuthority** [__nickname__] [**flags**] __address__:__port__ __ fingerprint__:: - As DirServer, but replaces less of the default directory authorities. Using + These options behave as DirServer, but they replace fewer of the + default directory authorities. Using AlternateDirAuthority replaces the default Tor directory authorities, but - leaves the hidden service authorities and bridge authorities in place. - Similarly, Using AlternateHSAuthority replaces the default hidden service - authorities, but not the directory or bridge authorities. + leaves the default hidden service authorities and bridge authorities in + place. Similarly, AlternateHSAuthority replaces the default hidden + service authorities, but not the directory or bridge authorities; and + AlternateBridgeAuthority replaces the default bridge authority, + but leaves the directory and hidden service authorities alone. **DisableAllSwap** **0**|**1**:: If set to 1, Tor will attempt to lock all current and future memory pages,

1 0

r25714: {website} Add #6329 script to Onionoo's project page. (website/trunk/projects/en)
by Karsten Loesing 16 Jul '12

16 Jul '12

Author: kloesing Date: 2012-07-16 11:06:16 +0000 (Mon, 16 Jul 2012) New Revision: 25714 Modified: website/trunk/projects/en/onionoo.wml Log: Add #6329 script to Onionoo's project page. Modified: website/trunk/projects/en/onionoo.wml =================================================================== --- website/trunk/projects/en/onionoo.wml 2012-07-16 00:49:08 UTC (rev 25713) +++ website/trunk/projects/en/onionoo.wml 2012-07-16 11:06:16 UTC (rev 25714) @@ -27,6 +27,10 @@ Android app that lets you add your relays or bridges to your favorites list and keeps you always informed whether they are running or not.</li> + <li><a href="https://gitweb.torproject.org/metrics-tasks.git/blob_plain/HEAD:/task-6329/…">tor-relays-stats.py</a> + is a simple Python script that extracts consensus weight information + of currently running relays and aggregates weights of relays running + in the same country or same autonomous system.</li> </ul> <h2>Developing Onionoo applications</h2>

1 0

[metrics-web/master] Add link to Walter Kim's metrics graphs page.
by karsten＠torproject.org 16 Jul '12

16 Jul '12

commit 6e653f9dd3be59f639fec89c4c82712d1f560e1a Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Mon Jul 16 11:20:36 2012 +0200 Add link to Walter Kim's metrics graphs page. --- web/WEB-INF/index.jsp | 3 +++ web/WEB-INF/network.jsp | 8 ++++++++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/web/WEB-INF/index.jsp b/web/WEB-INF/index.jsp index 816dae2..a29df15 100644 --- a/web/WEB-INF/index.jsp +++ b/web/WEB-INF/index.jsp @@ -32,6 +32,9 @@ <br> <h3>News</h3> <ul> + <li>July 16, 2012: Added link to <a + href="http://tigerpa.ws/tor_metrics/">interactive graphs</a> of + network statistics.</li> <li>April 30, 2012: Added <a href="papers/bridge-report-usage-stats-2012-04-30.pdf">tech report</a>: "What fraction of our bridges are not reporting diff --git a/web/WEB-INF/network.jsp b/web/WEB-INF/network.jsp index fa7732f..04fffef 100644 --- a/web/WEB-INF/network.jsp +++ b/web/WEB-INF/network.jsp @@ -15,6 +15,14 @@ <div class="main-column"> <h2>Tor Metrics Portal: Network</h2> <br> +<a name="interactive"></a> +<h3><a href="#interactive" class="anchor">Interactive graphs of relays in +the network</a></h3> +<br> +<p>Most of the statistics on this page are also available as +<a href="http://tigerpa.ws/tor_metrics/">interactive graphs</a>.</p> +<br> + <a name="networksize"></a> <h3><a href="#networksize" class="anchor">Relays and bridges in the network</a></h3>

1 0