January 2022 - tor-commits - lists.torproject.org

[torspec/main] params: Deprecate DNS overload parameters
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit 99a5447042820190931f405621ddd7a04c4d9a53 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Dec 13 10:41:23 2021 -0500 params: Deprecate DNS overload parameters Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- param-spec.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/param-spec.txt b/param-spec.txt index 429ec13..bf278ed 100644 --- a/param-spec.txt +++ b/param-spec.txt @@ -197,6 +197,7 @@ Table of Contents represent decimal point. As an example, a value of 1000 means 1%. Min: 0. Max: 100000. Default: 1000. First-appeared: 0.4.6.8 + Deprecated: 0.4.7.3-alpha-dev "overload_dns_timeout_period_secs" -- This value is the period in seconds of the DNS timeout measurements (the N in the @@ -205,6 +206,7 @@ Table of Contents assessment on the overload general signal with regards to DNS timeouts. Min: 0. Max: 2147483647. Default: 600 First-appeared: 0.4.6.8 + Deprecated: 0.4.7.3-alpha-dev 8. V3 onion service parameters

1 0

[torspec/main] Merge branch 'tor-gitlab/mr/56'
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit 4da63977b86f4c17d0e8cf87ed492c72a4c9b2d9 Merge: 617a98c 99a5447 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Jan 19 14:45:11 2022 -0500 Merge branch 'tor-gitlab/mr/56' param-spec.txt | 2 ++ 1 file changed, 2 insertions(+)

1 0

[tor/main] Merge branch 'maint-0.4.6'
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit 8e407e33292ed5e9166303fd69210d603c74f618 Merge: 162c9f1b81 0f9967c945 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Jan 19 13:56:43 2022 -0500 Merge branch 'maint-0.4.6' src/test/test_protover.c | 9 --------- 1 file changed, 9 deletions(-)

1 0

[tor/maint-0.4.5] test: Remove HSv2 protover specific test
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit 986730e82c69d4a29e3b00cde5a7bf7a15a3b94b Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Jan 19 13:36:23 2022 -0500 test: Remove HSv2 protover specific test HSv2 is not advertised as a supported protocol version anymore. This was introduced with the merge-forward of commit 72041c63064b461e which didn't fix the unit test. Fixes #40549 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_protover.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/test/test_protover.c b/src/test/test_protover.c index 44febe0fa6..16f0279871 100644 --- a/src/test/test_protover.c +++ b/src/test/test_protover.c @@ -348,9 +348,6 @@ test_protover_supports_version(void *arg) /* Deprecated HSIntro versions */ #define PROTOVER_HS_INTRO_DEPRECATED_1 1 #define PROTOVER_HS_INTRO_DEPRECATED_2 2 -/* Highest supported HSv2 introduce protocol version. - * It's not clear if we actually support version 2, see #25068. */ -#define PROTOVER_HS_INTRO_V2 3 /* HSv2 Rend and HSDir protocol versions. */ #define PROTOVER_HS_RENDEZVOUS_POINT_V2 1 @@ -433,12 +430,6 @@ test_protover_supported_protocols(void *arg) tt_assert(!protocol_list_supports_protocol(supported_protocols, PRT_HSINTRO, PROTOVER_HS_INTRO_DEPRECATED_2)); - /* We could test legacy HSIntro by calling rend_service_update_descriptor(), - * and checking the protocols field. But that's unlikely to change, so - * we just use a hard-coded value. */ - tt_assert(protocol_list_supports_protocol(supported_protocols, - PRT_HSINTRO, - PROTOVER_HS_INTRO_V2)); /* Test for HSv3 HSIntro */ tt_assert(protocol_list_supports_protocol(supported_protocols, PRT_HSINTRO,

1 0

[tor/main] Merge branch 'maint-0.4.5' into maint-0.4.6
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit 0f9967c9454bee18c5975b13c3e9bb5889e72e9d Merge: 4d60ab8fb7 986730e82c Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Jan 19 13:56:43 2022 -0500 Merge branch 'maint-0.4.5' into maint-0.4.6 src/test/test_protover.c | 9 --------- 1 file changed, 9 deletions(-)

1 0

[tor/main] test: Remove HSv2 protover specific test
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit 986730e82c69d4a29e3b00cde5a7bf7a15a3b94b Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Jan 19 13:36:23 2022 -0500 test: Remove HSv2 protover specific test HSv2 is not advertised as a supported protocol version anymore. This was introduced with the merge-forward of commit 72041c63064b461e which didn't fix the unit test. Fixes #40549 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_protover.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/test/test_protover.c b/src/test/test_protover.c index 44febe0fa6..16f0279871 100644 --- a/src/test/test_protover.c +++ b/src/test/test_protover.c @@ -348,9 +348,6 @@ test_protover_supports_version(void *arg) /* Deprecated HSIntro versions */ #define PROTOVER_HS_INTRO_DEPRECATED_1 1 #define PROTOVER_HS_INTRO_DEPRECATED_2 2 -/* Highest supported HSv2 introduce protocol version. - * It's not clear if we actually support version 2, see #25068. */ -#define PROTOVER_HS_INTRO_V2 3 /* HSv2 Rend and HSDir protocol versions. */ #define PROTOVER_HS_RENDEZVOUS_POINT_V2 1 @@ -433,12 +430,6 @@ test_protover_supported_protocols(void *arg) tt_assert(!protocol_list_supports_protocol(supported_protocols, PRT_HSINTRO, PROTOVER_HS_INTRO_DEPRECATED_2)); - /* We could test legacy HSIntro by calling rend_service_update_descriptor(), - * and checking the protocols field. But that's unlikely to change, so - * we just use a hard-coded value. */ - tt_assert(protocol_list_supports_protocol(supported_protocols, - PRT_HSINTRO, - PROTOVER_HS_INTRO_V2)); /* Test for HSv3 HSIntro */ tt_assert(protocol_list_supports_protocol(supported_protocols, PRT_HSINTRO,

1 0

[tor/maint-0.4.6] test: Remove HSv2 protover specific test
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit 986730e82c69d4a29e3b00cde5a7bf7a15a3b94b Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Jan 19 13:36:23 2022 -0500 test: Remove HSv2 protover specific test HSv2 is not advertised as a supported protocol version anymore. This was introduced with the merge-forward of commit 72041c63064b461e which didn't fix the unit test. Fixes #40549 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_protover.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/test/test_protover.c b/src/test/test_protover.c index 44febe0fa6..16f0279871 100644 --- a/src/test/test_protover.c +++ b/src/test/test_protover.c @@ -348,9 +348,6 @@ test_protover_supports_version(void *arg) /* Deprecated HSIntro versions */ #define PROTOVER_HS_INTRO_DEPRECATED_1 1 #define PROTOVER_HS_INTRO_DEPRECATED_2 2 -/* Highest supported HSv2 introduce protocol version. - * It's not clear if we actually support version 2, see #25068. */ -#define PROTOVER_HS_INTRO_V2 3 /* HSv2 Rend and HSDir protocol versions. */ #define PROTOVER_HS_RENDEZVOUS_POINT_V2 1 @@ -433,12 +430,6 @@ test_protover_supported_protocols(void *arg) tt_assert(!protocol_list_supports_protocol(supported_protocols, PRT_HSINTRO, PROTOVER_HS_INTRO_DEPRECATED_2)); - /* We could test legacy HSIntro by calling rend_service_update_descriptor(), - * and checking the protocols field. But that's unlikely to change, so - * we just use a hard-coded value. */ - tt_assert(protocol_list_supports_protocol(supported_protocols, - PRT_HSINTRO, - PROTOVER_HS_INTRO_V2)); /* Test for HSv3 HSIntro */ tt_assert(protocol_list_supports_protocol(supported_protocols, PRT_HSINTRO,

1 0

[tor/maint-0.4.6] Merge branch 'maint-0.4.5' into maint-0.4.6
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit 0f9967c9454bee18c5975b13c3e9bb5889e72e9d Merge: 4d60ab8fb7 986730e82c Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Jan 19 13:56:43 2022 -0500 Merge branch 'maint-0.4.5' into maint-0.4.6 src/test/test_protover.c | 9 --------- 1 file changed, 9 deletions(-)

1 0

[tor/release-0.4.5] test: Remove HSv2 protover specific test
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit 986730e82c69d4a29e3b00cde5a7bf7a15a3b94b Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Jan 19 13:36:23 2022 -0500 test: Remove HSv2 protover specific test HSv2 is not advertised as a supported protocol version anymore. This was introduced with the merge-forward of commit 72041c63064b461e which didn't fix the unit test. Fixes #40549 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_protover.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/test/test_protover.c b/src/test/test_protover.c index 44febe0fa6..16f0279871 100644 --- a/src/test/test_protover.c +++ b/src/test/test_protover.c @@ -348,9 +348,6 @@ test_protover_supports_version(void *arg) /* Deprecated HSIntro versions */ #define PROTOVER_HS_INTRO_DEPRECATED_1 1 #define PROTOVER_HS_INTRO_DEPRECATED_2 2 -/* Highest supported HSv2 introduce protocol version. - * It's not clear if we actually support version 2, see #25068. */ -#define PROTOVER_HS_INTRO_V2 3 /* HSv2 Rend and HSDir protocol versions. */ #define PROTOVER_HS_RENDEZVOUS_POINT_V2 1 @@ -433,12 +430,6 @@ test_protover_supported_protocols(void *arg) tt_assert(!protocol_list_supports_protocol(supported_protocols, PRT_HSINTRO, PROTOVER_HS_INTRO_DEPRECATED_2)); - /* We could test legacy HSIntro by calling rend_service_update_descriptor(), - * and checking the protocols field. But that's unlikely to change, so - * we just use a hard-coded value. */ - tt_assert(protocol_list_supports_protocol(supported_protocols, - PRT_HSINTRO, - PROTOVER_HS_INTRO_V2)); /* Test for HSv3 HSIntro */ tt_assert(protocol_list_supports_protocol(supported_protocols, PRT_HSINTRO,

1 0

[tor/release-0.4.5] Merge branch 'maint-0.4.5' into release-0.4.5
by dgoulet＠torproject.org 19 Jan '22

19 Jan '22

commit fa9072771b48440cbfb4f2d62635e70d6cceca37 Merge: ae744bb831 986730e82c Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Jan 19 13:56:43 2022 -0500 Merge branch 'maint-0.4.5' into release-0.4.5 src/test/test_protover.c | 9 --------- 1 file changed, 9 deletions(-)

1 0