March 2021 - tor-commits - lists.torproject.org

[translation/communitytpo-contentspot] https://gitweb.torproject.org/translation.git/commit/?h=communitytpo-contentspot
by translation＠torproject.org 11 Mar '21

11 Mar '21

commit d01aff7a3a57d2fbf8a573f53a6f8c5b7105b861 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Mar 11 13:45:12 2021 +0000 https://gitweb.torproject.org/translation.git/commit/?h=communitytpo-conten… --- contents+ja.po | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/contents+ja.po b/contents+ja.po index d4ded5c5f0..9171ca2186 100644 --- a/contents+ja.po +++ b/contents+ja.po @@ -6178,7 +6178,7 @@ msgstr "" #: https//community.torproject.org/relay/setup/post-install/ #: (content/relay-operations/technical-setup/post-install/contents+en.lrpage.body) msgid "* Memory" -msgstr "" +msgstr "* メモリ" #: https//community.torproject.org/relay/setup/post-install/ #: (content/relay-operations/technical-setup/post-install/contents+en.lrpage.body) @@ -6340,7 +6340,7 @@ msgstr "" #: https//community.torproject.org/relay/setup/exit/ #: (content/relay-operations/technical-setup/exit/contents+en.lrpage.body) msgid "## Exit Notice HTML page" -msgstr "" +msgstr "## 出口通知 HTML ページ" #: https//community.torproject.org/relay/setup/exit/ #: (content/relay-operations/technical-setup/exit/contents+en.lrpage.body) @@ -6371,7 +6371,7 @@ msgstr "DirPort 80" #: https//community.torproject.org/relay/setup/exit/ #: (content/relay-operations/technical-setup/exit/contents+en.lrpage.body) msgid "DirPortFrontPage /path/to/html/file" -msgstr "" +msgstr "DirPortFrontPage /path/to/html/file" #: https//community.torproject.org/relay/setup/exit/ #: (content/relay-operations/technical-setup/exit/contents+en.lrpage.body) @@ -7264,7 +7264,7 @@ msgstr "" #: https//community.torproject.org/relay/community-resources/tor-abuse-templates/ #: (content/relay-operations/community-resources/tor-abuse-templates/contents+en.lrpage.body) msgid "http://cd34.com/blog/webserver/ddos-attack-mitigation/" -msgstr "" +msgstr "http://cd34.com/blog/webserver/ddos-attack-mitigation/" #: https//community.torproject.org/relay/community-resources/tor-abuse-templates/ #: (content/relay-operations/community-resources/tor-abuse-templates/contents+en.lrpage.body) @@ -10686,7 +10686,7 @@ msgstr "" #: https//community.torproject.org/relay/community-resources/eff-tor-legal-faq/ #: (content/relay-operations/community-resources/eff-tor-legal-faq/contents+en.lrpage.body) msgid "### Should I run an exit relay from my home?" -msgstr "" +msgstr "### 家で出口リレーを走らせるべきですか?" #: https//community.torproject.org/relay/community-resources/eff-tor-legal-faq/ #: (content/relay-operations/community-resources/eff-tor-legal-faq/contents+en.lrpage.body) @@ -13391,7 +13391,7 @@ msgstr "" #: https//community.torproject.org/relay/setup/guard/netbsd/ #: (content/relay-operations/technical-setup/guard/netbsd/contents+en.lrpage.body) msgid "echo \"tor=YES\" >> /etc/rc.conf" -msgstr "" +msgstr "echo \"tor=YES\" >> /etc/rc.conf" #: https//community.torproject.org/relay/setup/bridge/netbsd/ #: (content/relay-operations/technical-setup/bridge/netbsd/contents+en.lrpage.body) @@ -14873,12 +14873,12 @@ msgstr "" #: https//community.torproject.org/relay/setup/bridge/freebsd/ #: (content/relay-operations/technical-setup/bridge/freebsd/contents+en.lrpage.body) msgid "FreeBSD: { enabled: no }" -msgstr "" +msgstr "FreeBSD: { enabled: no }" #: https//community.torproject.org/relay/setup/bridge/freebsd/ #: (content/relay-operations/technical-setup/bridge/freebsd/contents+en.lrpage.body) msgid "FreeBSDlatest: {" -msgstr "" +msgstr "FreeBSDlatest: {" #: https//community.torproject.org/relay/setup/bridge/freebsd/ #: (content/relay-operations/technical-setup/bridge/freebsd/contents+en.lrpage.body) @@ -14925,7 +14925,7 @@ msgstr "OpenBSD に obfs4 bridge を設定する方法" #: https//community.torproject.org/relay/setup/bridge/openbsd/ #: (content/relay-operations/technical-setup/bridge/openbsd/contents+en.lrpage.body) msgid "pkg_add tor obfs4proxy" -msgstr "" +msgstr "pkg_add tor obfs4proxy" #: https//community.torproject.org/relay/setup/bridge/openbsd/ #: (content/relay-operations/technical-setup/bridge/openbsd/contents+en.lrpage.body) @@ -15494,7 +15494,7 @@ msgstr "" #: https//community.torproject.org/relay/setup/guard/debianubuntu/ #: (content/relay-operations/technical-setup/guard/debianubuntu/contents+en.lrpage.body) msgid "# 3. Package Installation" -msgstr "" +msgstr "# 3. パッケージインストール" #: https//community.torproject.org/relay/setup/guard/debianubuntu/ #: (content/relay-operations/technical-setup/guard/debianubuntu/contents+en.lrpage.body)

1 0

[translation/tpo-web] https://gitweb.torproject.org/translation.git/commit/?h=tpo-web
by translation＠torproject.org 10 Mar '21

10 Mar '21

commit 440d4b7a61c7dfba0b3584086dae7cd360e01548 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Mar 10 23:47:59 2021 +0000 https://gitweb.torproject.org/translation.git/commit/?h=tpo-web --- contents+nl.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contents+nl.po b/contents+nl.po index c0fa1e445b..8c736c5071 100644 --- a/contents+nl.po +++ b/contents+nl.po @@ -1924,7 +1924,7 @@ msgstr "Onderwerp" #: templates/privchat-1.html:19 templates/privchat-2.html:19 msgid "Watch" -msgstr "Let op" +msgstr "Kijk" #: templates/privchat-1.html:43 msgid "Roger Dingledine" @@ -2070,7 +2070,7 @@ msgstr "Lees meer." #: templates/macros/question.html:15 msgid "Suggest Feedback" -msgstr "Feedback voorstellen" +msgstr "Geef ons feedback" #: templates/macros/question.html:16 msgid "Permalink"

1 0

[tor/master] vote: Add "stats" line
by nickm＠torproject.org 10 Mar '21

10 Mar '21

commit 9f9fed3fd167d564ec669ee46d2da923fb887803 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Mar 10 09:51:30 2021 -0500 vote: Add "stats" line Closes #40314 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40314 | 4 ++++ src/feature/nodelist/fmt_routerstatus.c | 13 +++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/changes/ticket40314 b/changes/ticket40314 new file mode 100644 index 0000000000..328687c265 --- /dev/null +++ b/changes/ticket40314 @@ -0,0 +1,4 @@ + o Minor feature (Vote document): + - Add the "stats" line in a directory authority vote in order to report + various statistics that the authority has computed for the relays. This + will help us diagnose better the network. Close ticket 40314. diff --git a/src/feature/nodelist/fmt_routerstatus.c b/src/feature/nodelist/fmt_routerstatus.c index 5c1e9309b9..51f7ee7d95 100644 --- a/src/feature/nodelist/fmt_routerstatus.c +++ b/src/feature/nodelist/fmt_routerstatus.c @@ -15,11 +15,11 @@ #include "feature/nodelist/fmt_routerstatus.h" #include "core/or/policies.h" -#include "feature/nodelist/routerlist.h" #include "feature/dirauth/dirvote.h" - #include "feature/nodelist/routerinfo_st.h" +#include "feature/nodelist/routerlist.h" #include "feature/nodelist/vote_routerstatus_st.h" +#include "feature/stats/rephist.h" #include "lib/crypt_ops/crypto_format.h" @@ -195,6 +195,15 @@ routerstatus_format_entry(const routerstatus_t *rs, const char *version, digest256_to_base64(ed_b64, (const char*)vrs->ed25519_id); smartlist_add_asprintf(chunks, "id ed25519 %s\n", ed_b64); } + + /* We'll add a series of statistics to the vote per relays so we are + * able to assess what each authorities sees and help our health and + * performance work. */ + time_t now = time(NULL); + smartlist_add_asprintf(chunks, "stats wfu=%.6f tk=%lu mtbf=%.0f\n", + rep_hist_get_weighted_fractional_uptime(rs->identity_digest, now), + rep_hist_get_weighted_time_known(rs->identity_digest, now), + rep_hist_get_stability(rs->identity_digest, now)); } }

1 0

[tor/master] Merge remote-tracking branch 'tor-gitlab/mr/336'
by nickm＠torproject.org 10 Mar '21

10 Mar '21

commit 7d9403b42218596108dfa0e614b79f4217912a90 Merge: f98dbdb069 9f9fed3fd1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Mar 10 16:47:46 2021 -0500 Merge remote-tracking branch 'tor-gitlab/mr/336' changes/ticket40314 | 4 ++++ src/feature/nodelist/fmt_routerstatus.c | 13 +++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-)

1 0

[torspec/master] dir-spec: Add "stats" line to a vote
by nickm＠torproject.org 10 Mar '21

10 Mar '21

commit 2169b637dd0ee4fef9bc28f0115349b10ea0b2b4 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Mar 10 09:52:08 2021 -0500 dir-spec: Add "stats" line to a vote Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- dir-spec.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/dir-spec.txt b/dir-spec.txt index 657e95f..d486991 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -2294,6 +2294,24 @@ "id" SP "ed25519" SP "none" NL [vote only, at most once] + "stats" SP [KeyValues] NL + + [At most once. Vote only] + + KeyValue ::= Keyword '=' Number + Number ::= [0-9]+("."[0-9]+)? + KeyValues ::= KeyValue | KeyValues SP KeyValue + + Line containing various statistics that an authority has computed for + this relay. Each stats is represented as a key + value. Reported keys + are: + + "wfu" - Weighted Fractional Uptime + "tk" - Weighted Time Known + "mtbf" - Mean Time Between Failure (stability) + + (As of tor-0.4.6.1-alpha) + The footer section is delineated in all votes and consensuses supporting consensus method 9 and above with the following:

1 0

[tor/master] hs: Remove hamrless BUG() that can happen
by nickm＠torproject.org 10 Mar '21

10 Mar '21

commit f93ccb8d247ad2a601b697ca2ed0004f428fbd15 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Mar 10 09:12:29 2021 -0500 hs: Remove hamrless BUG() that can happen When reloading a service, we can re-register a service and thus end up again in the metrics store initialization code path which is fine. No need to BUG() anymore. Fixes #40334 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40334 | 3 +++ src/feature/hs/hs_metrics.c | 8 +++++--- src/feature/hs/hs_service.c | 4 +++- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/changes/ticket40334 b/changes/ticket40334 new file mode 100644 index 0000000000..c1c34384a0 --- /dev/null +++ b/changes/ticket40334 @@ -0,0 +1,3 @@ + o Minor bugfixes (onion service): + - Remove a harmless BUG() warning when reloading tor configured with onion + services. Fixes bug 40334; bugfix on 0.4.5.1-alpha. diff --git a/src/feature/hs/hs_metrics.c b/src/feature/hs/hs_metrics.c index 67cae8ec0e..e6d3084f26 100644 --- a/src/feature/hs/hs_metrics.c +++ b/src/feature/hs/hs_metrics.c @@ -149,9 +149,11 @@ hs_metrics_service_init(hs_service_t *service) { tor_assert(service); - /* Calling this function twice on a service object is wrong. The caller must - * free the metrics before if so. */ - if (BUG(service->metrics.store)) { + /* This function is called when we register a service and so it could either + * be a new service or a service that was just reloaded through a HUP signal + * for instance. Thus, it is possible that the service has already an + * initialized store. If so, just return. */ + if (service->metrics.store) { return; } diff --git a/src/feature/hs/hs_service.c b/src/feature/hs/hs_service.c index 07e3550986..908ac02044 100644 --- a/src/feature/hs/hs_service.c +++ b/src/feature/hs/hs_service.c @@ -197,7 +197,9 @@ register_service(hs_service_ht *map, hs_service_t *service) if (map == hs_service_map) { hs_service_map_has_changed(); } - /* Setup metrics. */ + /* Setup metrics. This is done here because in order to initialize metrics, + * we require tor to have fully initialized a service so the ports of the + * service can be looked at for instance. */ hs_metrics_service_init(service); return 0;

1 0

[tor/master] Merge remote-tracking branch 'tor-gitlab/mr/335' into maint-0.4.5
by nickm＠torproject.org 10 Mar '21

10 Mar '21

commit e8d224dfb14a73e6b47ab09def56217f66a2ea46 Merge: d382f26914 f93ccb8d24 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Mar 10 15:27:50 2021 -0500 Merge remote-tracking branch 'tor-gitlab/mr/335' into maint-0.4.5 changes/ticket40334 | 3 +++ src/feature/hs/hs_metrics.c | 8 +++++--- src/feature/hs/hs_service.c | 4 +++- 3 files changed, 11 insertions(+), 4 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.4.5'
by nickm＠torproject.org 10 Mar '21

10 Mar '21

commit f98dbdb0693afa7dcbf1f395fa7e97116b59199e Merge: 19e8844622 e8d224dfb1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Mar 10 15:28:14 2021 -0500 Merge branch 'maint-0.4.5' changes/ticket40334 | 3 +++ src/feature/hs/hs_metrics.c | 8 +++++--- src/feature/hs/hs_service.c | 4 +++- 3 files changed, 11 insertions(+), 4 deletions(-)

1 0

[tor/release-0.4.5] Merge remote-tracking branch 'tor-gitlab/mr/335' into maint-0.4.5
by nickm＠torproject.org 10 Mar '21

10 Mar '21

commit e8d224dfb14a73e6b47ab09def56217f66a2ea46 Merge: d382f26914 f93ccb8d24 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Mar 10 15:27:50 2021 -0500 Merge remote-tracking branch 'tor-gitlab/mr/335' into maint-0.4.5 changes/ticket40334 | 3 +++ src/feature/hs/hs_metrics.c | 8 +++++--- src/feature/hs/hs_service.c | 4 +++- 3 files changed, 11 insertions(+), 4 deletions(-)

1 0

[tor/release-0.4.5] hs: Remove hamrless BUG() that can happen
by nickm＠torproject.org 10 Mar '21

10 Mar '21

commit f93ccb8d247ad2a601b697ca2ed0004f428fbd15 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Mar 10 09:12:29 2021 -0500 hs: Remove hamrless BUG() that can happen When reloading a service, we can re-register a service and thus end up again in the metrics store initialization code path which is fine. No need to BUG() anymore. Fixes #40334 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40334 | 3 +++ src/feature/hs/hs_metrics.c | 8 +++++--- src/feature/hs/hs_service.c | 4 +++- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/changes/ticket40334 b/changes/ticket40334 new file mode 100644 index 0000000000..c1c34384a0 --- /dev/null +++ b/changes/ticket40334 @@ -0,0 +1,3 @@ + o Minor bugfixes (onion service): + - Remove a harmless BUG() warning when reloading tor configured with onion + services. Fixes bug 40334; bugfix on 0.4.5.1-alpha. diff --git a/src/feature/hs/hs_metrics.c b/src/feature/hs/hs_metrics.c index 67cae8ec0e..e6d3084f26 100644 --- a/src/feature/hs/hs_metrics.c +++ b/src/feature/hs/hs_metrics.c @@ -149,9 +149,11 @@ hs_metrics_service_init(hs_service_t *service) { tor_assert(service); - /* Calling this function twice on a service object is wrong. The caller must - * free the metrics before if so. */ - if (BUG(service->metrics.store)) { + /* This function is called when we register a service and so it could either + * be a new service or a service that was just reloaded through a HUP signal + * for instance. Thus, it is possible that the service has already an + * initialized store. If so, just return. */ + if (service->metrics.store) { return; } diff --git a/src/feature/hs/hs_service.c b/src/feature/hs/hs_service.c index 07e3550986..908ac02044 100644 --- a/src/feature/hs/hs_service.c +++ b/src/feature/hs/hs_service.c @@ -197,7 +197,9 @@ register_service(hs_service_ht *map, hs_service_t *service) if (map == hs_service_map) { hs_service_map_has_changed(); } - /* Setup metrics. */ + /* Setup metrics. This is done here because in order to initialize metrics, + * we require tor to have fully initialized a service so the ports of the + * service can be looked at for instance. */ hs_metrics_service_init(service); return 0;

1 0