April 2019 - tor-commits - lists.torproject.org

[tor/master] NSS: Log an error message when SSL_ExportKeyingMaterial() fails
by teor＠torproject.org 06 Apr '19

06 Apr '19

commit 680fd3f8fb7157432398a3552ee9c98c72bd7397 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Mar 29 13:38:14 2019 -0400 NSS: Log an error message when SSL_ExportKeyingMaterial() fails Diagnostic for 29241. --- changes/29241_diagnostic | 4 ++++ src/lib/tls/tortls_nss.c | 8 ++++++++ 2 files changed, 12 insertions(+) diff --git a/changes/29241_diagnostic b/changes/29241_diagnostic new file mode 100644 index 000000000..1e3865495 --- /dev/null +++ b/changes/29241_diagnostic @@ -0,0 +1,4 @@ + o Minor features (NSS, diagnostic): + - Try to log an error from NSS (if there is any) and a more useful + description of our situation if we are using NSS and a call to + SSL_ExportKeyingMaterial() fails. Diagnostic for ticket 29241. diff --git a/src/lib/tls/tortls_nss.c b/src/lib/tls/tortls_nss.c index 00c4af0e9..4e107fae7 100644 --- a/src/lib/tls/tortls_nss.c +++ b/src/lib/tls/tortls_nss.c @@ -726,10 +726,18 @@ tor_tls_export_key_material,(tor_tls_t *tls, uint8_t *secrets_out, tor_assert(context_len <= UINT_MAX); SECStatus s; + /* Make sure that the error code is set here, so that we can be sure that + * any error code set after a failure was in fact caused by + * SSL_ExportKeyingMaterial. */ + PR_SetError(PR_UNKNOWN_ERROR, 0); s = SSL_ExportKeyingMaterial(tls->ssl, label, (unsigned)strlen(label), PR_TRUE, context, (unsigned)context_len, secrets_out, DIGEST256_LEN); + if (s != SECSuccess) { + tls_log_errors(tls, LOG_WARN, LD_CRYPTO, + "exporting key material for a TLS handshake"); + } return (s == SECSuccess) ? 0 : -1; }

1 0

[tor/master] changes: Ticket 29241 is actually a bug on NSS in 0.3.5.1-alpha
by teor＠torproject.org 06 Apr '19

06 Apr '19

commit 4dd96f74444b0eeb8b3b2c36f6f129edddd464d4 Author: teor <teor(a)torproject.org> Date: Sat Apr 6 11:07:20 2019 +1000 changes: Ticket 29241 is actually a bug on NSS in 0.3.5.1-alpha --- changes/bug29241 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changes/bug29241 b/changes/bug29241 index 13951d116..7f25e154d 100644 --- a/changes/bug29241 +++ b/changes/bug29241 @@ -3,4 +3,4 @@ for their PRF. Due to an NSS bug, the TLS key exporters for these ciphersuites don't work -- which caused relays to fail to handshake with one another when these ciphersuites were enabled. - Fixes bug 29241; bugfix on 0.4.0.1-alpha. + Fixes bug 29241; bugfix on 0.3.5.1-alpha.

1 0

[tor/master] Merge remote-tracking branch 'tor-github/pr/911' into maint-0.4.0
by teor＠torproject.org 06 Apr '19

06 Apr '19

commit b100c9e9800c1d504c2d69d556642189c39d099d Merge: 8b3b605a1 4dd96f744 Author: teor <teor(a)torproject.org> Date: Sat Apr 6 12:15:41 2019 +1000 Merge remote-tracking branch 'tor-github/pr/911' into maint-0.4.0 changes/29241_diagnostic | 4 ++++ changes/bug29241 | 6 ++++++ src/lib/tls/tortls_nss.c | 40 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 50 insertions(+)

1 0

[tor/master] Merge branch 'maint-0.4.0'
by teor＠torproject.org 06 Apr '19

06 Apr '19

commit 4cffc7fe9cfff03a122ddecc3447136f8a82387b Merge: f213a35b2 b100c9e98 Author: teor <teor(a)torproject.org> Date: Sat Apr 6 12:23:25 2019 +1000 Merge branch 'maint-0.4.0' changes/29241_diagnostic | 4 ++++ changes/bug29241 | 6 ++++++ src/lib/tls/tortls_nss.c | 40 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 50 insertions(+)

1 0

[tor/master] NSS: disable TLS1.2 SHA-384 ciphersuites.
by teor＠torproject.org 06 Apr '19

06 Apr '19

commit 5cb94cbf9d89804ea37a2f1e68d354a86edb223e Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Mar 29 13:38:48 2019 -0400 NSS: disable TLS1.2 SHA-384 ciphersuites. In current NSS versions, these ciphersuites don't work with SSL_ExportKeyingMaterial(), which was causing relays to fail when they tried to negotiate the v3 link protocol authentication. Fixes bug 29241; bugfix on 0.4.0.1-alpha. --- changes/bug29241 | 6 ++++++ src/lib/tls/tortls_nss.c | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/changes/bug29241 b/changes/bug29241 new file mode 100644 index 000000000..13951d116 --- /dev/null +++ b/changes/bug29241 @@ -0,0 +1,6 @@ + o Major bugfixes (NSS, relay): + - When running with NSS, disable TLS 1.2 ciphersuites that use SHA384 + for their PRF. Due to an NSS bug, the TLS key exporters for these + ciphersuites don't work -- which caused relays to fail to handshake + with one another when these ciphersuites were enabled. + Fixes bug 29241; bugfix on 0.4.0.1-alpha. diff --git a/src/lib/tls/tortls_nss.c b/src/lib/tls/tortls_nss.c index 4e107fae7..3c62e98df 100644 --- a/src/lib/tls/tortls_nss.c +++ b/src/lib/tls/tortls_nss.c @@ -152,6 +152,32 @@ we_like_auth_type(SSLAuthType at) } } +/** + * Return true iff this ciphersuite will be hit by a mozilla bug 1312976, + * which makes TLS key exporters not work with TLS 1.2 non-SHA256 + * ciphersuites. + **/ +static bool +ciphersuite_has_nss_export_bug(const SSLCipherSuiteInfo *info) +{ + /* For more information on the bug, see + https://bugzilla.mozilla.org/show_bug.cgi?id=1312976 */ + + /* This bug only exists in TLS 1.2. */ + if (info->authType == ssl_auth_tls13_any) + return false; + + /* Sadly, there's no way to get this information from the + * CipherSuiteInfo object itself other than by looking at the + * name. */ + if (strstr(info->cipherSuiteName, "_SHA384") || + strstr(info->cipherSuiteName, "_SHA512")) { + return true; + } + + return false; +} + tor_tls_context_t * tor_tls_context_new(crypto_pk_t *identity, unsigned int key_lifetime, unsigned flags, int is_client) @@ -256,6 +282,12 @@ tor_tls_context_new(crypto_pk_t *identity, !we_like_mac_algorithm(info.macAlgorithm) || !we_like_auth_type(info.authType)/* Requires NSS 3.24 */; + if (ciphersuite_has_nss_export_bug(&info)) { + /* SSL_ExportKeyingMaterial will fail; we can't use this cipher. + */ + disable = 1; + } + s = SSL_CipherPrefSet(ctx->ctx, ciphers[i], disable ? PR_FALSE : PR_TRUE); if (s != SECSuccess)

1 0

[translation/tpo-web_completed] Update translations for tpo-web_completed
by translation＠torproject.org 06 Apr '19

06 Apr '19

commit 349db56422c61c4495ceea2235dd6df93ec9d3bb Author: Translation commit bot <translation(a)torproject.org> Date: Sat Apr 6 00:50:41 2019 +0000 Update translations for tpo-web_completed --- contents+pt-BR.po | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/contents+pt-BR.po b/contents+pt-BR.po index 4f8357300..a622e2522 100644 --- a/contents+pt-BR.po +++ b/contents+pt-BR.po @@ -2,7 +2,6 @@ # Danton Medrado, 2019 # Joeffison Silvério de Andrade <joeffison(a)gmail.com>, 2019 # Gutem <gutemhc(a)gmail.com>, 2019 -# Eduardo Addad de Oliveira <eduardoaddad(a)hotmail.com>, 2019 # erinm, 2019 # Greg Strider <gboufleur(a)gmail.com>, 2019 # Hildeberto Abreu Magalhães <hildeberto(a)gmail.com>, 2019 @@ -11,6 +10,7 @@ # Communia <ameaneantie(a)riseup.net>, 2019 # Danihells <dcdcampos75(a)gmail.com>, 2019 # Emma Peel, 2019 +# Eduardo Addad de Oliveira <eduardoaddad(a)hotmail.com>, 2019 # msgid "" msgstr "" @@ -18,7 +18,7 @@ msgstr "" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2019-04-02 10:45+CET\n" "PO-Revision-Date: 2019-03-09 10:41+0000\n" -"Last-Translator: Emma Peel, 2019\n" +"Last-Translator: Eduardo Addad de Oliveira <eduardoaddad(a)hotmail.com>, 2019\n" "Language-Team: Portuguese (Brazil) (https://www.transifex.com/otf/teams/1519/pt_BR/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -869,7 +869,7 @@ msgstr "Opções Avançadas de Instalação" #: templates/hero-download.html:42 msgid "Download Source Tarball" -msgstr "" +msgstr "Baixar Source Tarball" #: templates/hero-download.html:45 msgid "Read the latest release announcements" @@ -938,6 +938,9 @@ msgid "" "Tor Browser aims to make all users look the same making it difficult for you" " to be fingerprinted based on your browser and device information." msgstr "" +"O Navegador Tor visa fazer com que todos os usuários tenham a mesma " +"aparência, dificultando a impressão digital com base nas informações do " +"navegador e do dispositivo." #: templates/home.html:58 msgid "Multi-layered Encryption" @@ -998,7 +1001,7 @@ msgstr "" #: templates/meta.html:11 msgid "The Tor Project | Privacy & Freedom Online" -msgstr "" +msgstr "O Projeto Tor | Privacidade e Liberdade Online" #: templates/meta.html:17 msgid "Tor Project"

1 0

[translation/tpo-web] Update translations for tpo-web
by translation＠torproject.org 06 Apr '19

06 Apr '19

commit dfd9987e017741be678fc6f1fdda1368aeafd4f0 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Apr 6 00:50:35 2019 +0000 Update translations for tpo-web --- contents+pt-BR.po | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/contents+pt-BR.po b/contents+pt-BR.po index 4f8357300..a622e2522 100644 --- a/contents+pt-BR.po +++ b/contents+pt-BR.po @@ -2,7 +2,6 @@ # Danton Medrado, 2019 # Joeffison Silvério de Andrade <joeffison(a)gmail.com>, 2019 # Gutem <gutemhc(a)gmail.com>, 2019 -# Eduardo Addad de Oliveira <eduardoaddad(a)hotmail.com>, 2019 # erinm, 2019 # Greg Strider <gboufleur(a)gmail.com>, 2019 # Hildeberto Abreu Magalhães <hildeberto(a)gmail.com>, 2019 @@ -11,6 +10,7 @@ # Communia <ameaneantie(a)riseup.net>, 2019 # Danihells <dcdcampos75(a)gmail.com>, 2019 # Emma Peel, 2019 +# Eduardo Addad de Oliveira <eduardoaddad(a)hotmail.com>, 2019 # msgid "" msgstr "" @@ -18,7 +18,7 @@ msgstr "" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2019-04-02 10:45+CET\n" "PO-Revision-Date: 2019-03-09 10:41+0000\n" -"Last-Translator: Emma Peel, 2019\n" +"Last-Translator: Eduardo Addad de Oliveira <eduardoaddad(a)hotmail.com>, 2019\n" "Language-Team: Portuguese (Brazil) (https://www.transifex.com/otf/teams/1519/pt_BR/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -869,7 +869,7 @@ msgstr "Opções Avançadas de Instalação" #: templates/hero-download.html:42 msgid "Download Source Tarball" -msgstr "" +msgstr "Baixar Source Tarball" #: templates/hero-download.html:45 msgid "Read the latest release announcements" @@ -938,6 +938,9 @@ msgid "" "Tor Browser aims to make all users look the same making it difficult for you" " to be fingerprinted based on your browser and device information." msgstr "" +"O Navegador Tor visa fazer com que todos os usuários tenham a mesma " +"aparência, dificultando a impressão digital com base nas informações do " +"navegador e do dispositivo." #: templates/home.html:58 msgid "Multi-layered Encryption" @@ -998,7 +1001,7 @@ msgstr "" #: templates/meta.html:11 msgid "The Tor Project | Privacy & Freedom Online" -msgstr "" +msgstr "O Projeto Tor | Privacidade e Liberdade Online" #: templates/meta.html:17 msgid "Tor Project"

1 0

[translation/torbutton-browseronboardingproperties_completed] Update translations for torbutton-browseronboardingproperties_completed
by translation＠torproject.org 06 Apr '19

06 Apr '19

commit 393259eddae82abac859f6edd211767ddc629854 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Apr 6 00:49:42 2019 +0000 Update translations for torbutton-browseronboardingproperties_completed --- pt-BR/browserOnboarding.properties | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pt-BR/browserOnboarding.properties b/pt-BR/browserOnboarding.properties index 8614cb033..6b76ab493 100644 --- a/pt-BR/browserOnboarding.properties +++ b/pt-BR/browserOnboarding.properties @@ -41,6 +41,18 @@ onboarding.tour-tor-onion-services.description=Serviços Onion são sites que te onboarding.tour-tor-onion-services.button=Visitar um endereço Onion onboarding.tour-tor-onion-services.next-button=Feito +onboarding.overlay-icon-tooltip-updated2=Veja o que é novo\nem %S +onboarding.tour-tor-update.prefix-new=Novo +onboarding.tour-tor-update.prefix-updated=Atualizado + +onboarding.tour-tor-toolbar=Barra de ferramentas +onboarding.tour-tor-toolbar-update-8.5.title=Layout da barra de ferramentas +onboarding.tour-tor-toolbar-update-8.5.description=Melhoramos o layout da barra de ferramentas do navegador. Movemos o ícone do Torbutton após a barra de URL e adicionamos um ícone de nível de segurança ao lado dele. +onboarding.tour-tor-toolbar-update-8.5.next-button=Vá para segurança + +onboarding.tour-tor-security-update-8.5.title=Experiência de nível de segurança +onboarding.tour-tor-security-update-8.5.description=Melhoramos a maneira de ver e definir seu nível de segurança. Substituímos o controle deslizante de segurança por um ícone da barra de ferramentas que torna seu nível atual visível o tempo todo. Clique para ver os detalhes do seu nível atual ou para alterar suas configurações de segurança. + # Circuit Display onboarding. onboarding.tor-circuit-display.next=Próximo onboarding.tor-circuit-display.done=Feito

1 0

[translation/torbutton-browseronboardingproperties] Update translations for torbutton-browseronboardingproperties
by translation＠torproject.org 06 Apr '19

06 Apr '19

commit 88d2cc4a81b2ff28b0dae2ee0aa075e1af572f25 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Apr 6 00:49:34 2019 +0000 Update translations for torbutton-browseronboardingproperties --- pt-BR/browserOnboarding.properties | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pt-BR/browserOnboarding.properties b/pt-BR/browserOnboarding.properties index f2d95ca22..6b76ab493 100644 --- a/pt-BR/browserOnboarding.properties +++ b/pt-BR/browserOnboarding.properties @@ -41,17 +41,17 @@ onboarding.tour-tor-onion-services.description=Serviços Onion são sites que te onboarding.tour-tor-onion-services.button=Visitar um endereço Onion onboarding.tour-tor-onion-services.next-button=Feito -onboarding.overlay-icon-tooltip-updated2=See what's new\nin %S +onboarding.overlay-icon-tooltip-updated2=Veja o que é novo\nem %S onboarding.tour-tor-update.prefix-new=Novo onboarding.tour-tor-update.prefix-updated=Atualizado -onboarding.tour-tor-toolbar=Toolbar -onboarding.tour-tor-toolbar-update-8.5.title=Toolbar layout -onboarding.tour-tor-toolbar-update-8.5.description=We improved the browser toolbar layout. We moved the Torbutton icon after the URL bar, and we added a security level icon next to it. +onboarding.tour-tor-toolbar=Barra de ferramentas +onboarding.tour-tor-toolbar-update-8.5.title=Layout da barra de ferramentas +onboarding.tour-tor-toolbar-update-8.5.description=Melhoramos o layout da barra de ferramentas do navegador. Movemos o ícone do Torbutton após a barra de URL e adicionamos um ícone de nível de segurança ao lado dele. onboarding.tour-tor-toolbar-update-8.5.next-button=Vá para segurança -onboarding.tour-tor-security-update-8.5.title=Security level experience -onboarding.tour-tor-security-update-8.5.description=We improved how you see and set your security level. We replaced the security slider with a toolbar icon that makes your current level visible at all times. Click it to view details about your current level or to change your security settings. +onboarding.tour-tor-security-update-8.5.title=Experiência de nível de segurança +onboarding.tour-tor-security-update-8.5.description=Melhoramos a maneira de ver e definir seu nível de segurança. Substituímos o controle deslizante de segurança por um ícone da barra de ferramentas que torna seu nível atual visível o tempo todo. Clique para ver os detalhes do seu nível atual ou para alterar suas configurações de segurança. # Circuit Display onboarding. onboarding.tor-circuit-display.next=Próximo

1 0

[translation/bridgedb_completed] Update translations for bridgedb_completed
by translation＠torproject.org 06 Apr '19

06 Apr '19

commit 393f8231c8167b73b3f9339eb01d4c2ed6d96d98 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Apr 6 00:15:23 2019 +0000 Update translations for bridgedb_completed --- uk/LC_MESSAGES/bridgedb.po | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/uk/LC_MESSAGES/bridgedb.po b/uk/LC_MESSAGES/bridgedb.po index aa604ea8e..7edd38e2a 100644 --- a/uk/LC_MESSAGES/bridgedb.po +++ b/uk/LC_MESSAGES/bridgedb.po @@ -3,20 +3,21 @@ # This file is distributed under the same license as the BridgeDB project. # # Translators: +# Bogdan Kulynych <bogdan.kulynych(a)gmail.com>, 2019 # Eugene ghostishev, 2014 # LinuxChata, 2014-2015 # Oleksii Golub <sclub2018(a)yandex.ua>, 2015 # Oleksii Golub <sclub2018(a)yandex.ua>, 2013 # Vira Motorko <ato4ka(a)i.ua>, 2017 -# Yasha, 2015 +# f5a88f9e30127107e3f9ea67ac1be70b, 2015 # Андрій Бандура <andriykopanytsia(a)gmail.com>, 2014 msgid "" msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: 'https://trac.torproject.org/projects/tor/newticket?component=BridgeDB&keywo…'\n" "POT-Creation-Date: 2015-07-25 03:40+0000\n" -"PO-Revision-Date: 2019-01-15 12:20+0000\n" -"Last-Translator: erinm\n" +"PO-Revision-Date: 2019-04-05 23:58+0000\n" +"Last-Translator: Bogdan Kulynych <bogdan.kulynych(a)gmail.com>\n" "Language-Team: Ukrainian (http://www.transifex.com/otf/torproject/language/uk/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -75,21 +76,21 @@ msgstr "QR-код для адрес ретрансляторів" #: bridgedb/https/templates/bridges.html:67 #: bridgedb/https/templates/bridges.html:125 msgid "Uh oh, spaghettios!" -msgstr "Ой-ой, spaghettios!" +msgstr "Отакої!" #: bridgedb/https/templates/bridges.html:68 msgid "It seems there was an error getting your QRCode." -msgstr "Здається, було помилкою отримання вашого QR-код." +msgstr "Здається, що сталася помилка при отриманні вашого QR-коду." #: bridgedb/https/templates/bridges.html:73 msgid "" "This QRCode contains your bridge lines. Scan it with a QRCode reader to copy" " your bridge lines onto mobile and other devices." -msgstr "Це QR-код містить адреси Ваших ретрансляторів. Відскануйте його пристроєм для зчитування QR-кодів, щоб скопіювати адреси Ваших ретрансляторів на мобільні та інші пристрої." +msgstr "Цей QR-код містить адреси Ваших ретрансляторів. Відскануйте його пристроєм для зчитування QR-кодів, щоб скопіювати адреси Ваших ретрансляторів на мобільні та інші пристрої." #: bridgedb/https/templates/bridges.html:131 msgid "There currently aren't any bridges available..." -msgstr "В даний час немає доступних мостів ..." +msgstr "В даний час немає доступних мостів..." #: bridgedb/https/templates/bridges.html:132 #, python-format

1 0