February 2019 - tor-commits - lists.torproject.org

[tor/release-0.2.9] test/shared-random: Stop leaking shared random state in the unit tests
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 4d9eb4dd0e67190f8e3bf5300e85611d8605400c Author: teor <teor(a)torproject.org> Date: Tue Feb 26 22:14:30 2019 +1000 test/shared-random: Stop leaking shared random state in the unit tests Stop leaking parts of the shared random state in the shared-random unit tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha. --- changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/changes/bug29599 b/changes/bug29599 new file mode 100644 index 000000000..14e2f5d07 --- /dev/null +++ b/changes/bug29599 @@ -0,0 +1,3 @@ + o Minor bugfixes (memory management, testing): + - Stop leaking parts of the shared random state in the shared-random unit + tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha. diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c index 6a8c1abaf..cebe772d9 100644 --- a/src/test/test_shared_random.c +++ b/src/test/test_shared_random.c @@ -594,8 +594,8 @@ test_vote(void *arg) } done: - sr_commit_free(our_commit); UNMOCK(trusteddirserver_get_by_v3_auth_digest); + sr_state_free(); } static const char *sr_state_str = "Version 1\n" @@ -829,6 +829,7 @@ test_sr_compute_srv(void *arg) done: UNMOCK(trusteddirserver_get_by_v3_auth_digest); + sr_state_free(); } /** Return a minimal vote document with a current SRV value set to @@ -1094,7 +1095,7 @@ test_state_transition(void *arg) } done: - return; + sr_state_free(); } static void

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.4' into release-0.3.4
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 5bbba3c9488c2184f822b270d6527a7ea898b16a Merge: 6a930b442 524731503 Author: teor <teor(a)torproject.org> Date: Thu Feb 28 10:45:52 2019 +1000 Merge branch 'maint-0.3.4' into release-0.3.4 changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.3] test/shared-random: Stop leaking shared random state in the unit tests
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 4d9eb4dd0e67190f8e3bf5300e85611d8605400c Author: teor <teor(a)torproject.org> Date: Tue Feb 26 22:14:30 2019 +1000 test/shared-random: Stop leaking shared random state in the unit tests Stop leaking parts of the shared random state in the shared-random unit tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha. --- changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/changes/bug29599 b/changes/bug29599 new file mode 100644 index 000000000..14e2f5d07 --- /dev/null +++ b/changes/bug29599 @@ -0,0 +1,3 @@ + o Minor bugfixes (memory management, testing): + - Stop leaking parts of the shared random state in the shared-random unit + tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha. diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c index 6a8c1abaf..cebe772d9 100644 --- a/src/test/test_shared_random.c +++ b/src/test/test_shared_random.c @@ -594,8 +594,8 @@ test_vote(void *arg) } done: - sr_commit_free(our_commit); UNMOCK(trusteddirserver_get_by_v3_auth_digest); + sr_state_free(); } static const char *sr_state_str = "Version 1\n" @@ -829,6 +829,7 @@ test_sr_compute_srv(void *arg) done: UNMOCK(trusteddirserver_get_by_v3_auth_digest); + sr_state_free(); } /** Return a minimal vote document with a current SRV value set to @@ -1094,7 +1095,7 @@ test_state_transition(void *arg) } done: - return; + sr_state_free(); } static void

1 0

[tor/release-0.3.4] Merge branch 'maint-0.2.9' into maint-0.3.3
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 3313444ef08b891d344b1965a7776260c02f27ab Merge: 6c966b894 4d9eb4dd0 Author: teor <teor(a)torproject.org> Date: Thu Feb 28 10:45:30 2019 +1000 Merge branch 'maint-0.2.9' into maint-0.3.3 changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.4] test/shared-random: Stop leaking shared random state in the unit tests
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 4d9eb4dd0e67190f8e3bf5300e85611d8605400c Author: teor <teor(a)torproject.org> Date: Tue Feb 26 22:14:30 2019 +1000 test/shared-random: Stop leaking shared random state in the unit tests Stop leaking parts of the shared random state in the shared-random unit tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha. --- changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/changes/bug29599 b/changes/bug29599 new file mode 100644 index 000000000..14e2f5d07 --- /dev/null +++ b/changes/bug29599 @@ -0,0 +1,3 @@ + o Minor bugfixes (memory management, testing): + - Stop leaking parts of the shared random state in the shared-random unit + tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha. diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c index 6a8c1abaf..cebe772d9 100644 --- a/src/test/test_shared_random.c +++ b/src/test/test_shared_random.c @@ -594,8 +594,8 @@ test_vote(void *arg) } done: - sr_commit_free(our_commit); UNMOCK(trusteddirserver_get_by_v3_auth_digest); + sr_state_free(); } static const char *sr_state_str = "Version 1\n" @@ -829,6 +829,7 @@ test_sr_compute_srv(void *arg) done: UNMOCK(trusteddirserver_get_by_v3_auth_digest); + sr_state_free(); } /** Return a minimal vote document with a current SRV value set to @@ -1094,7 +1095,7 @@ test_state_transition(void *arg) } done: - return; + sr_state_free(); } static void

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.3' into release-0.3.3
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 6f3f8bb1e4d117ace4d6d8b77077f4a9d6b41ce6 Merge: 3ecfb68bd 3313444ef Author: teor <teor(a)torproject.org> Date: Thu Feb 28 10:45:37 2019 +1000 Merge branch 'maint-0.3.3' into release-0.3.3 changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.3' into maint-0.3.4
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 524731503e0a885ab2dbb778831aa79875f8edae Merge: 1a194beb2 3313444ef Author: teor <teor(a)torproject.org> Date: Thu Feb 28 10:45:44 2019 +1000 Merge branch 'maint-0.3.3' into maint-0.3.4 changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.3] Merge branch 'maint-0.2.9' into maint-0.3.3
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 3313444ef08b891d344b1965a7776260c02f27ab Merge: 6c966b894 4d9eb4dd0 Author: teor <teor(a)torproject.org> Date: Thu Feb 28 10:45:30 2019 +1000 Merge branch 'maint-0.2.9' into maint-0.3.3 changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.5] Merge branch 'maint-0.2.9' into maint-0.3.3
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 3313444ef08b891d344b1965a7776260c02f27ab Merge: 6c966b894 4d9eb4dd0 Author: teor <teor(a)torproject.org> Date: Thu Feb 28 10:45:30 2019 +1000 Merge branch 'maint-0.2.9' into maint-0.3.3 changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/release-0.3.5] test/shared-random: Stop leaking shared random state in the unit tests
by teor＠torproject.org 27 Feb '19

27 Feb '19

commit 4d9eb4dd0e67190f8e3bf5300e85611d8605400c Author: teor <teor(a)torproject.org> Date: Tue Feb 26 22:14:30 2019 +1000 test/shared-random: Stop leaking shared random state in the unit tests Stop leaking parts of the shared random state in the shared-random unit tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha. --- changes/bug29599 | 3 +++ src/test/test_shared_random.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/changes/bug29599 b/changes/bug29599 new file mode 100644 index 000000000..14e2f5d07 --- /dev/null +++ b/changes/bug29599 @@ -0,0 +1,3 @@ + o Minor bugfixes (memory management, testing): + - Stop leaking parts of the shared random state in the shared-random unit + tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha. diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c index 6a8c1abaf..cebe772d9 100644 --- a/src/test/test_shared_random.c +++ b/src/test/test_shared_random.c @@ -594,8 +594,8 @@ test_vote(void *arg) } done: - sr_commit_free(our_commit); UNMOCK(trusteddirserver_get_by_v3_auth_digest); + sr_state_free(); } static const char *sr_state_str = "Version 1\n" @@ -829,6 +829,7 @@ test_sr_compute_srv(void *arg) done: UNMOCK(trusteddirserver_get_by_v3_auth_digest); + sr_state_free(); } /** Return a minimal vote document with a current SRV value set to @@ -1094,7 +1095,7 @@ test_state_transition(void *arg) } done: - return; + sr_state_free(); } static void

1 0