December 2019 - tor-commits - lists.torproject.org

[tor/release-0.4.1] backtrace: Always set a backtrace Tor version
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit e2a7d08aa7c51fa903d5294628612a13b4c0d6e0 Author: teor <teor(a)torproject.org> Date: Fri Aug 30 21:12:52 2019 +1000 backtrace: Always set a backtrace Tor version We want to report the tor version, even on platforms that don't have backtrace support (like Android). This commit stores the backtrace Tor version, regardless of USE_BACKTRACE. Preparation for 31571. --- src/lib/err/backtrace.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 … [View More]

1 0

[tor/release-0.4.1] Handle errors from execve() in the Unix process backend more gracefully.
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit 9915b8f0bc3e6a1b6c8413fbb87c41137ea89104 Author: Alexander Færøy <ahf(a)torproject.org> Date: Thu Oct 17 16:39:05 2019 +0200 Handle errors from execve() in the Unix process backend more gracefully. This patch removes a call to tor_assert_unreached() after execve() failed. This assertion leads to the child process emitting a stack trace on its standard output, which makes the error harder for the user to demystify, since they think it is an internal error … [View More]

1 0

[tor/release-0.4.1] torerr: Try harder to flush raw assert messages before process termination
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit c55591825fedb0fe1db92fab7b654ccc15ad50d3 Author: teor <teor(a)torproject.org> Date: Fri Aug 30 21:17:56 2019 +1000 torerr: Try harder to flush raw assert messages before process termination Some platforms (macOS, maybe others?) can swallow the last write before an abort. This issue is probably caused by a race condition between write buffer cache flushing, and process termination. So we write an extra newline, to make sure that the message always gets … [View More]

1 0

[tor/release-0.4.1] Merge remote-tracking branch 'tor-github/pr/1424' into maint-0.4.0
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit 46057ec5ae5ecc183fb7ed5060b8ba07ad235fb3 Merge: febbc236d ee8db8a2e Author: teor <teor(a)torproject.org> Date: Thu Dec 5 10:13:15 2019 +1000 Merge remote-tracking branch 'tor-github/pr/1424' into maint-0.4.0 changes/bug31810 | 4 ++++ src/lib/process/process_unix.c | 9 +-------- src/lib/process/process_win32.c | 18 ++++++++++++++++++ src/test/test_process_slow.c | 30 ++++++++++++++++++++++++++++++ 4 files changed, 53 insertions(+), 8 deletions(-)

1 0

[tor/release-0.4.1] backtrace: Log the Tor backtrace version whenever we log a backtrace
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit 743bc0028be46e92a46b3b5e38f1e50ee69ff284 Author: teor <teor(a)torproject.org> Date: Fri Aug 30 21:15:54 2019 +1000 backtrace: Log the Tor backtrace version whenever we log a backtrace Previously, we just logged it in the crash handler. Part of 31571. --- src/lib/err/backtrace.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lib/err/backtrace.c b/src/lib/err/backtrace.c index 8cca3c37e..c34eb6dfa 100644 --- a/src/lib/err/… [View More]

1 0

[tor/release-0.4.0] Merge remote-tracking branch 'tor-github/pr/1424' into maint-0.4.0
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit 46057ec5ae5ecc183fb7ed5060b8ba07ad235fb3 Merge: febbc236d ee8db8a2e Author: teor <teor(a)torproject.org> Date: Thu Dec 5 10:13:15 2019 +1000 Merge remote-tracking branch 'tor-github/pr/1424' into maint-0.4.0 changes/bug31810 | 4 ++++ src/lib/process/process_unix.c | 9 +-------- src/lib/process/process_win32.c | 18 ++++++++++++++++++ src/test/test_process_slow.c | 30 ++++++++++++++++++++++++++++++ 4 files changed, 53 insertions(+), 8 deletions(-)

1 0

[tor/release-0.4.1] backtrace: Check the return values of snprintf() and strncpy()
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit f311d0676caad1c61a4dbf8fffbeb79003866903 Author: teor <teor(a)torproject.org> Date: Tue Sep 3 15:50:37 2019 +1000 backtrace: Check the return values of snprintf() and strncpy() We can't use strlcat() or strlcpy() in torerr, because they are defined in string/compat_string.h on some platforms, and string uses torerr. Part of 31571. --- src/lib/err/backtrace.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/lib/… [View More]

1 0

[tor/release-0.4.1] torerr: Log the Tor backtrace version when a raw assertion fails
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit 65a1d86491d56c77048d01e0b4fc6b933a13795c Author: teor <teor(a)torproject.org> Date: Fri Aug 30 21:17:07 2019 +1000 torerr: Log the Tor backtrace version when a raw assertion fails Part of 31571. --- src/lib/err/backtrace.c | 8 ++++++++ src/lib/err/backtrace.h | 1 + src/lib/err/torerr.c | 3 ++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/lib/err/backtrace.c b/src/lib/err/backtrace.c index c34eb6dfa..a4d8269c6 100644 --- a/src/lib/err/… [View More]

1 0

[tor/release-0.4.0] Merge branch 'maint-0.4.0' into release-0.4.0
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit aa47cb6e0f6edb2adeb357d2da1b090a11430f96 Merge: 03dc0e19a 92fb09906 Author: teor <teor(a)torproject.org> Date: Thu Dec 5 10:13:57 2019 +1000 Merge branch 'maint-0.4.0' into release-0.4.0 changes/bug31571 | 7 +++++++ changes/bug31810 | 4 ++++ src/lib/err/backtrace.c | 42 ++++++++++++++++++++++++++++++----------- src/lib/err/backtrace.h | 1 + src/lib/err/torerr.c | 11 +++++++++-- src/lib/process/process_unix.c … [View More]

1 0

[tor/release-0.4.0] Merge remote-tracking branch 'tor-github/pr/1277' into maint-0.3.5
by teor＠torproject.org 05 Dec '19

05 Dec '19

commit aee966cb06711a413980b8cf7fa359e69d62dd05 Merge: 62cf12a8b f311d0676 Author: teor <teor(a)torproject.org> Date: Thu Dec 5 10:11:18 2019 +1000 Merge remote-tracking branch 'tor-github/pr/1277' into maint-0.3.5 changes/bug31571 | 7 +++++++ src/lib/err/backtrace.c | 42 +++++++++++++++++++++++++++++++----------- src/lib/err/backtrace.h | 1 + src/lib/err/torerr.c | 11 +++++++++-- 4 files changed, 48 insertions(+), 13 deletions(-)

1 0