November 2019 - tor-commits - lists.torproject.org

[dev/master] Update lego
by hiro＠torproject.org 26 Nov '19

26 Nov '19

commit b90e50e266c66f738a671e251930271c6e156527 Author: hiro <hiro(a)torproject.org> Date: Mon Nov 25 18:14:54 2019 +0100 Update lego --- lego | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lego b/lego index c77ce2b..7f196bc 160000 --- a/lego +++ b/lego @@ -1 +1 @@ -Subproject commit c77ce2bfb2262e87a00566184a7193bf491445f5 +Subproject commit 7f196bc35e6bc2555e9a13ee024f322840433954

1 0

[community/master] Update lego
by hiro＠torproject.org 26 Nov '19

26 Nov '19

commit 3275b534bbe477311c74f7e2ddd58884e5d7c3d3 Author: hiro <hiro(a)torproject.org> Date: Mon Nov 25 18:14:46 2019 +0100 Update lego --- lego | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lego b/lego index c77ce2b..7f196bc 160000 --- a/lego +++ b/lego @@ -1 +1 @@ -Subproject commit c77ce2bfb2262e87a00566184a7193bf491445f5 +Subproject commit 7f196bc35e6bc2555e9a13ee024f322840433954

1 0

[lego/master] Update footer template
by hiro＠torproject.org 26 Nov '19

26 Nov '19

commit 7f196bc35e6bc2555e9a13ee024f322840433954 Author: hiro <hiro(a)torproject.org> Date: Mon Nov 25 18:11:44 2019 +0100 Update footer template --- databags/links.ini | 3 +++ templates/footer.html | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/databags/links.ini b/databags/links.ini index c6c5d77..8d977e9 100644 --- a/databags/links.ini +++ b/databags/links.ini @@ -140,3 +140,6 @@ press = https://www.torproject.org/tr/press/ about = https://www.torproject.org/zh-CN/about/history/ support = https://support.torproject.org/zh-CN donate = https://donate.torproject.org/zh-CN +jobs = https://www.torproject.org/zh-CN/about/jobs/ +contact = https://www.torproject.org/zh-CN/contact/ +press = https://www.torproject.org/zh-CN/press/ diff --git a/templates/footer.html b/templates/footer.html index 646e073..9fadec2 100644 --- a/templates/footer.html +++ b/templates/footer.html @@ -36,9 +36,9 @@ {% if link %} <a class="nav-link text-light" href="{{ item.path|url(alt=this.alt) }}"> {% else %} - {% set link = bag('links', this.alt, id) %} - {% if link %} - <a class="nav-link text-light" href="{{ link }}"> + {% set local = bag('links', this.alt, id) %} + {% if local %} + <a class="nav-link text-light" href="{{ local }}"> {% else %} <a class="nav-link text-light" href="{{ item.path }}"> {% endif %}

1 0

[lego/master] Update links databag
by hiro＠torproject.org 26 Nov '19

26 Nov '19

1 0

[torspec/master] Prop 121: convert to utf-8
by nickm＠torproject.org 26 Nov '19

26 Nov '19

commit 7b8c6efbbea7d44d58599bd5557d5a42bf92b12a Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 25 11:59:50 2019 -0500 Prop 121: convert to utf-8 --- proposals/121-hidden-service-authentication.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proposals/121-hidden-service-authentication.txt b/proposals/121-hidden-service-authentication.txt index 8dd59e9..404ca57 100644 --- a/proposals/121-hidden-service-authentication.txt +++ b/proposals/121-hidden-service-authentication.txt @@ -81,7 +81,7 @@ Motivation: (2) Better protection of service location: Unauthorized clients could not force Bob to create circuits to their rendezvous points, thus preventing - the attack described by Øverlier and Syverson in their paper "Locating + the attack described by Ãverlier and Syverson in their paper "Locating Hidden Servers" even without the need for guards. (3) Hiding activity: Apart from performing the actual authorization, a

1 0

[torspec/master] Add proposal 310 from Florentin Rochet, Aaron Johnson et al
by nickm＠torproject.org 26 Nov '19

26 Nov '19

commit 42339301d427e831498ba592a41473afc12f8900 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 25 12:00:37 2019 -0500 Add proposal 310 from Florentin Rochet, Aaron Johnson et al --- proposals/000-index.txt | 2 + proposals/310-bandaid-on-guard-selection.txt | 95 ++++++++++++++++++++++++++++ 2 files changed, 97 insertions(+) diff --git a/proposals/000-index.txt b/proposals/000-index.txt index 44de59f..50cd921 100644 --- a/proposals/000-index.txt +++ b/proposals/000-index.txt @@ -230,6 +230,7 @@ Proposals by number: 307 Onion Balance Support for Onion Service v3 [DRAFT] 308 Counter Galois Onion: A New Proposal for Forward-Secure Relay Cryptography [DRAFT] 309 Optimistic SOCKS Data [DRAFT] +310 Towards load-balancing in Prop 271 [OPEN] Proposals by status: @@ -267,6 +268,7 @@ Proposals by status: 296 Have Directory Authorities expose raw bandwidth list files 299 Preferring IPv4 or IPv6 based on IP Version Failure Count 306 A Tor Implementation of IPv6 Happy Eyeballs + 310 Towards load-balancing in Prop 271 ACCEPTED: 188 Bridge Guards and other anti-enumeration defenses 249 Allow CREATE cells with >505 bytes of handshake data diff --git a/proposals/310-bandaid-on-guard-selection.txt b/proposals/310-bandaid-on-guard-selection.txt new file mode 100644 index 0000000..642d90f --- /dev/null +++ b/proposals/310-bandaid-on-guard-selection.txt @@ -0,0 +1,95 @@ +Filename: 310-bandaid-on-guard-selection.txt +Title: Towards load-balancing in Prop 271 +Author: Florentin Rochet, Aaron Johnson et al. +Created: 2019-10-27 +Supersedes: 271 +Status: Open + +1. Motivation and Context + + Prop 271 causes guards to be selected with probabilities different than their + weights due to the way it samples many guards and then chooses primary guards + from that sample. We are suggesting a straightforward fix to the problem, which + is, roughly speaking, to choose primary guards in the order in which they were + sampled. + + In more detail, Prop 271 chooses guards via a multi-step process: + 1. It chooses 20 distinct guards (and sometimes more) by sampling without + replacement with probability proportional to consensus weight. + 2. It produces two subsets of the sample: (1) "filtered" guards, which are + guards that satisfy various torrc constraints and path bias, and (2) + "confirmed" guards, which are guards through which a circuit has been + constructed. + 3. The "primary" guards (i.e. the actual guards used for circuits) are + chosen from the confirmed and/or filtered subsets. I'm ignoring the + additional "usable" subsets for clarity. This description is based on + Section 4.6 of the specification + (https://gitweb.torproject.org/torspec.git/tree/guard-spec.txt) + + +1.1 Picturing the problem when Tor starts the first time + + The primary guards are selected *uniformly at random* from the filtered guards + when no confirmed guards exist. No confirmed guards appear to exist until some + primary guards have been selected, and so when Tor is started the first time + the primary guards always come only from the filtered set. The uniformly-random + selection causes a bias in primary-guard selection away from consensus weights + and towards a more uniform selection of guards. As just an example of the + problem, if there were only 20 guards in the network, the sampled set would be + all guards and primary guard selection would be entirely uniformly random, + ignoring weights entirely. This bias is worse the larger the sampled set is + relative to the entire set of guards, and it has a significant effect on Tor + simulations in Shadow, which are typically on smaller networks. + +2. Solution Design + + We propose a solution that fits well within the existing guard-selection + algorithm. Our solution is to select primary guards in the order they were + sampled. This ordering should be applied after the filtering and/or confirmed + guard sets are constructed as normal. That is, primary guards should be + selected from the filtered guards (if no guards are both confirmed and + filtered) or from the set of confirmed and filtered guards (if such guards + exist) in the order they were initially sampled. This solution guarantees that + each primary guard is selected (without replacement) from all guards with a + probability that is proportional to its consensus weight. + +2.1 Performance implications + + This proposal is a straightforward fix to the unbalanced network that may arise + from the uniform selection of sampled relays. It solves the performance + correctness in Shadow for which simulations live on a small timeframe. However, + it does not solve all the load-balancing problems of Proposal 271. One other + load-balancing issue comes when we choose our guards on a date but then make + decisions about them on a different date. Building a sampled list of relays at + day 0 that we intend to use in a long time for most of them is taking the risk + to slowly make the network unbalanced. + +2.2 Security implications + + This proposal solves the following problems: Prop271 reduces Tor's security by + increasing the number of clients that an adversary running small relays can + observe. In addition, an adversary has to wait less time than it should after + it starts a malicious guard to be chosen by a client. This weakness occurs + because the malicious guard only needs to enter the sampled list to have a + chance to be chosen as primary, rather than having to wait until all + previously-sampled guards have already expired. + +2.3 Implementation notes + + The code used for ordering the confirmed list by confirmed idx should be + removed, and a sampled order should be applied throughout the various lists. + The next sampled idx should be recalculed from the state file, and the + sampled_idx values should be recalculated to be a dense array when we save the + state. + +3. Going Further -- Let's not choose our History (future work) + + A deeper refactoring of Prop 271 would try to solve the load balancing problem + of choosing guards on a date but then making decisions about them on a + different date. One suggestion is to remove the sampled list, which we can + picture as a "forward history" and to have instead a real history of previously + sampled guards. When moving to the next guard, we could consider *current* + weights and make the decision. The history should resist attacks that try to + force clients onto compromised guards, using relays that are part of the + history if they're still available (in sampled order), and by tracking its + size. This should maintain the initial goals of Prop 271.

1 0

[torspec/master] reindex.py: convert to python3
by nickm＠torproject.org 26 Nov '19

26 Nov '19

commit f370c4abc0e87b0787ec0f70d47f44bb8881f661 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 25 11:59:23 2019 -0500 reindex.py: convert to python3 --- proposals/reindex.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/proposals/reindex.py b/proposals/reindex.py index 990016f..2023271 100755 --- a/proposals/reindex.py +++ b/proposals/reindex.py @@ -23,6 +23,7 @@ def indexed(seq): def readProposal(fn): fields = { } + print(fn) f = open(fn, 'r') lastField = None try: @@ -69,10 +70,9 @@ def checkProposal(fn, fields): need_fields.remove("Ticket") for f in need_fields: - if not fields.has_key(f): + if f not in fields: raise Error("%s has no %s field"%(fn, f)) if fn != fields['Filename']: - print `fn`, `fields['Filename']` raise Error("Mismatched Filename field in %s"%fn) if fields['Title'][-1] == '.': fields['Title'] = fields['Title'][:-1] @@ -82,7 +82,7 @@ def checkProposal(fn, fields): raise Error("I've never heard of status %s in %s"%(status,fn)) if status in [ "SUPERSEDED", "DEAD" ]: for f in [ 'Implemented-In', 'Target' ]: - if fields.has_key(f): del fields[f] + if f in fields: del fields[f] def readProposals(): res = [] @@ -121,9 +121,9 @@ def writeIndexFile(proposals): for prop in proposals: if s == prop['Status']: out.write(" %(num)s %(Title)s"%prop) - if prop.has_key('Target'): + if "Target" in prop: out.write(" [for %(Target)s]"%prop) - if prop.has_key('Implemented-In'): + if "Implemented-In" in prop: out.write(" [in %(Implemented-In)s]"%prop) out.write("\n") out.close()

1 0

[torspec/master] fixup! reindex.py: convert to python3
by nickm＠torproject.org 26 Nov '19

26 Nov '19

commit 666ca5ebf31a5cd946ff79fd98ef90e680fccb2c Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 25 12:00:27 2019 -0500 fixup! reindex.py: convert to python3 --- proposals/reindex.py | 1 - 1 file changed, 1 deletion(-) diff --git a/proposals/reindex.py b/proposals/reindex.py index 2023271..74efaf4 100755 --- a/proposals/reindex.py +++ b/proposals/reindex.py @@ -23,7 +23,6 @@ def indexed(seq): def readProposal(fn): fields = { } - print(fn) f = open(fn, 'r') lastField = None try:

1 0

[lego/master] Localize all links in the footer
by hiro＠torproject.org 26 Nov '19

26 Nov '19

commit dc998ccf3170970f3d232f621f323c3c9e8eabeb Author: hiro <hiro(a)torproject.org> Date: Mon Nov 25 17:58:46 2019 +0100 Localize all links in the footer --- templates/footer.html | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/templates/footer.html b/templates/footer.html index 246c133..646e073 100644 --- a/templates/footer.html +++ b/templates/footer.html @@ -36,7 +36,12 @@ {% if link %} <a class="nav-link text-light" href="{{ item.path|url(alt=this.alt) }}"> {% else %} - <a class="nav-link text-light" href="{{ item.path }}"> + {% set link = bag('links', this.alt, id) %} + {% if link %} + <a class="nav-link text-light" href="{{ link }}"> + {% else %} + <a class="nav-link text-light" href="{{ item.path }}"> + {% endif %} {% endif %} {{ _(item.label) }} {% if this.is_child_of(item.path) %}

1 0

[lego/master] Localize donate button everywhere
by hiro＠torproject.org 26 Nov '19

26 Nov '19

commit ae416478e7bd9df03e7f14fc1ee97000d2261fdb Author: hiro <hiro(a)torproject.org> Date: Mon Nov 25 17:52:27 2019 +0100 Localize donate button everywhere --- templates/banner.html | 7 ++++++- templates/footer.html | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/templates/banner.html b/templates/banner.html index 3d2647c..37d49be 100644 --- a/templates/banner.html +++ b/templates/banner.html @@ -15,7 +15,12 @@ </h2> </div> <div class="row"> - <a class="btn-lg rectangle mb-3 mr-3" href="https://torproject.org/donate/donate-tbi-hp1">{{ _('DONATE NOW') }}</a> + {% set link = bag('links', this.alt, 'donate') %} + {% if link %} + <a class="btn-lg rectangle mb-3 mr-3" href="{{ link }}">{{ _('DONATE NOW') }}</a> + {% else %} + <a class="btn-lg rectangle mb-3 mr-3" href="https://torproject.org/donate/donate-tbi-hp1">{{ _('DONATE NOW') }}</a> + {% endif %} <p class="give-today-and-mozi">{{ _('Give today, and Mozilla will match your donation.') }}</p> </div> </div> diff --git a/templates/footer.html b/templates/footer.html index 897e736..246c133 100644 --- a/templates/footer.html +++ b/templates/footer.html @@ -46,7 +46,12 @@ </li> {% endfor %} </ul> - <a href="https://www.torproject.org/donate/{{ this.alt }}" title="{{ _("Donate") }}"><h5><span class="badge badge-warning p-2 mt-2">{{ _("Donate Now") }}</span></h5></a> + {% set link = bag('links', this.alt, 'donate') %} + {% if link %} + <a href="{{ link }}" title="{{ _("Donate") }}"><h5><span class="badge badge-warning p-2 mt-2">{{ _("Donate Now") }}</span></h5></a> + {% else %} + <a href="https://www.torproject.org/donate/{{ this.alt }}" title="{{ _("Donate") }}"><h4><span class="badge badge-warning p-2">{{ _("Donate Now") }}</span></h4></a> + {% endif %} </div> </div> <div class="col-12 d-flex justify-content-center border">

1 0