January 2019 - tor-commits - lists.torproject.org

[tor/maint-0.3.4] hs-v3: Do not close RP circuits when deleting an ephemeral service
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit d37dbb09c2e8867cf2b87dc45e8646351754e94a Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Nov 26 14:40:22 2018 -0500 hs-v3: Do not close RP circuits when deleting an ephemeral service Bug reported on tor-dev@ and here is the detail explanation of the issue: https://lists.torproject.org/pipermail/tor-dev/2018-November/013558.html Fixes bug #28619 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug28619 | 6 ++++++ src/or/hs_service.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/changes/bug28619 b/changes/bug28619 new file mode 100644 index 000000000..86be8cb2f --- /dev/null +++ b/changes/bug28619 @@ -0,0 +1,6 @@ + o Minor bugfixes (hidden service v3): + - When deleting an ephemeral onion service (DEL_ONION), do not close any + rendezvous circuits in order to let the existing client connections + finish by themselves or closed by the application. The HS v2 is doing + that already so now we have the same behavior for all versions. Fixes + bug 28619; bugfix on 0.3.3.1-alpha. diff --git a/src/or/hs_service.c b/src/or/hs_service.c index 4c67aff42..3273705ae 100644 --- a/src/or/hs_service.c +++ b/src/or/hs_service.c @@ -3105,8 +3105,10 @@ hs_service_del_ephemeral(const char *address) goto err; } - /* Close circuits, remove from map and finally free. */ - close_service_circuits(service); + /* Close introduction circuits, remove from map and finally free. Notice + * that the rendezvous circuits aren't closed in order for any existing + * connections to finish. We let the application terminate them. */ + close_service_intro_circuits(service); remove_service(hs_service_map, service); hs_service_free(service);

1 0

[tor/maint-0.3.5] Merge branch 'maint-0.3.3' into maint-0.3.4
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit fe3331b84554c6d6e2e633d77de02453b9a73f88 Merge: d47c9276d bf8bb9c52 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jan 4 14:57:06 2019 -0500 Merge branch 'maint-0.3.3' into maint-0.3.4 changes/bug28619 | 6 ++++++ src/or/hs_service.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.3.5] Merge branch 'maint-0.3.4' into maint-0.3.5
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit 16deb1f5f2112bf19e5a8387cb4ebe7b04b5b360 Merge: fa05efdf8 fe3331b84 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jan 4 14:57:06 2019 -0500 Merge branch 'maint-0.3.4' into maint-0.3.5

1 0

[tor/maint-0.3.5] Merge remote-tracking branch 'dgoulet/ticket28619_033_01' into maint-0.3.3
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit bf8bb9c526a7dc99ab56b6e4786737f4617bb4ed Merge: 1ea312718 d37dbb09c Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jan 4 14:49:16 2019 -0500 Merge remote-tracking branch 'dgoulet/ticket28619_033_01' into maint-0.3.3 changes/bug28619 | 6 ++++++ src/or/hs_service.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge remote-tracking branch 'dgoulet/ticket28619_033_01' into maint-0.3.3
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit bf8bb9c526a7dc99ab56b6e4786737f4617bb4ed Merge: 1ea312718 d37dbb09c Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jan 4 14:49:16 2019 -0500 Merge remote-tracking branch 'dgoulet/ticket28619_033_01' into maint-0.3.3 changes/bug28619 | 6 ++++++ src/or/hs_service.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.3.3' into maint-0.3.4
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit fe3331b84554c6d6e2e633d77de02453b9a73f88 Merge: d47c9276d bf8bb9c52 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jan 4 14:57:06 2019 -0500 Merge branch 'maint-0.3.3' into maint-0.3.4 changes/bug28619 | 6 ++++++ src/or/hs_service.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.3.4' into maint-0.3.5
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit 16deb1f5f2112bf19e5a8387cb4ebe7b04b5b360 Merge: fa05efdf8 fe3331b84 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jan 4 14:57:06 2019 -0500 Merge branch 'maint-0.3.4' into maint-0.3.5

1 0

[tor/release-0.3.3] hs-v3: Do not close RP circuits when deleting an ephemeral service
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit d37dbb09c2e8867cf2b87dc45e8646351754e94a Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Nov 26 14:40:22 2018 -0500 hs-v3: Do not close RP circuits when deleting an ephemeral service Bug reported on tor-dev@ and here is the detail explanation of the issue: https://lists.torproject.org/pipermail/tor-dev/2018-November/013558.html Fixes bug #28619 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug28619 | 6 ++++++ src/or/hs_service.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/changes/bug28619 b/changes/bug28619 new file mode 100644 index 000000000..86be8cb2f --- /dev/null +++ b/changes/bug28619 @@ -0,0 +1,6 @@ + o Minor bugfixes (hidden service v3): + - When deleting an ephemeral onion service (DEL_ONION), do not close any + rendezvous circuits in order to let the existing client connections + finish by themselves or closed by the application. The HS v2 is doing + that already so now we have the same behavior for all versions. Fixes + bug 28619; bugfix on 0.3.3.1-alpha. diff --git a/src/or/hs_service.c b/src/or/hs_service.c index 4c67aff42..3273705ae 100644 --- a/src/or/hs_service.c +++ b/src/or/hs_service.c @@ -3105,8 +3105,10 @@ hs_service_del_ephemeral(const char *address) goto err; } - /* Close circuits, remove from map and finally free. */ - close_service_circuits(service); + /* Close introduction circuits, remove from map and finally free. Notice + * that the rendezvous circuits aren't closed in order for any existing + * connections to finish. We let the application terminate them. */ + close_service_intro_circuits(service); remove_service(hs_service_map, service); hs_service_free(service);

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.3' into release-0.3.3
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit dbef7af12c68965b68cf2157e4fc18fd6fc7acf6 Merge: d6552a7a2 bf8bb9c52 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jan 4 14:57:06 2019 -0500 Merge branch 'maint-0.3.3' into release-0.3.3 changes/bug28619 | 6 ++++++ src/or/hs_service.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.3.5'
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit a9c783098256add3e72fe0ead41a9f9afd903551 Merge: 94cab0d0b 16deb1f5f Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jan 4 14:57:06 2019 -0500 Merge branch 'maint-0.3.5'

1 0