July 2018 - tor-commits - lists.torproject.org

[tor-browser-build/master] Bug 26773: Add --verbose to the ./mach build flag for firefox for better debugging via log files.
by boklm＠torproject.org 12 Jul '18

12 Jul '18

commit dad9578655af92b3405d4f09891847da4c208f92 Author: Tom Ritter <tom(a)ritter.vg> Date: Thu Jul 12 13:44:31 2018 -0500 Bug 26773: Add --verbose to the ./mach build flag for firefox for better debugging via log files. Does not affect the console output, will use more disk space in log files. --- projects/firefox/build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/firefox/build b/projects/firefox/build index 1921f53..da1e71b 100644 --- a/projects/firefox/build +++ b/projects/firefox/build @@ -142,7 +142,7 @@ rm -f configure rm -f js/src/configure ./mach configure --with-tor-browser-version=[% c("var/torbrowser_version") %] --with-distribution-id=org.torproject --enable-update-channel=[% c("var/torbrowser_update_channel") %] --enable-bundled-fonts -./mach build +./mach build --verbose ./mach build stage-package [% IF c("var/osx") %]

1 0

[stem/master] Refactor existing "ignore 'unused' content" CertsCell test case into test data
by atagar＠torproject.org 12 Jul '18

12 Jul '18

commit 3619331ad6545063df966bab5d855bdb463ed715 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Wed Jul 11 18:54:29 2018 +0000 Refactor existing "ignore 'unused' content" CertsCell test case into test data By refactoring this check into test data, and with the logic set up in previous commits, the commit also ensures more test coverage for this case. Also clean up the comments for context. --- test/unit/client/cell.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/test/unit/client/cell.py b/test/unit/client/cell.py index 4caf13ba..2e5c498a 100644 --- a/test/unit/client/cell.py +++ b/test/unit/client/cell.py @@ -78,6 +78,7 @@ CERTS_CELLS = { b'\x00\x00\x81\x00\x01\x00': ([], b'', 2), b'\x00\x00\x81\x00\x04\x01\x01\x00\x00': ([Certificate(1, b'')], b'', 2), b'\x00\x00\x81\x00\x05\x01\x01\x00\x01\x08': ([Certificate(1, b'\x08')], b'', 2), + b'\x00\x00\x81\x00\x07\x01\x01\x00\x01\x08\x06\x04': ([Certificate(1, '\x08')], b'\x06\x04', 2), } AUTH_CHALLENGE_CELLS = { @@ -321,11 +322,7 @@ class TestCell(unittest.TestCase): self.assertEqual(unused, cell.unused) self.assertEqual(cell_bytes, cell.pack(link_protocol)) - # extra bytes after the last certificate should be ignored - - self.assertEqual([Certificate(1, '\x08')], Cell.pop(b'\x00\x00\x81\x00\x07\x01\x01\x00\x01\x08\x06\x04', 2)[0].certificates) - - # ... but truncated or missing certificates should error + # truncated or missing certificates should error self.assertRaisesRegexp(ValueError, 'CERTS cell should have a certificate with 3 bytes, but only had 1 remaining', Cell.pop, b'\x00\x00\x81\x00\x05\x01\x01\x00\x03\x08', 2) self.assertRaisesRegexp(ValueError, 'CERTS cell indicates it should have 2 certificates, but only contained 1', Cell.pop, b'\x00\x00\x81\x00\x05\x02\x01\x00\x01\x08', 2)

1 0

[stem/master] Explicitly test constructing and packing cells with 'unused' content
by atagar＠torproject.org 12 Jul '18

12 Jul '18

commit 205536e63269de39fe2d878fefdf81c4bec786f4 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Wed Jul 11 23:33:14 2018 +0000 Explicitly test constructing and packing cells with 'unused' content This is the other logical thing to do (the complement of the previous commit) with the test cases. Note that just because the logic is in the tests now doesn't necessarily mean that there's test cases that use it yet. --- test/unit/client/cell.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/test/unit/client/cell.py b/test/unit/client/cell.py index ad9bb0f0..4caf13ba 100644 --- a/test/unit/client/cell.py +++ b/test/unit/client/cell.py @@ -188,6 +188,9 @@ class TestCell(unittest.TestCase): if not unused.strip(ZERO): self.assertEqual(cell_bytes, RelayCell(circ_id, command, data, digest, stream_id).pack(link_protocol)) self.assertEqual(cell_bytes, RelayCell(circ_id, command_int, data, digest, stream_id).pack(link_protocol)) + else: + self.assertEqual(cell_bytes, RelayCell(circ_id, command, data, digest, stream_id, unused = unused).pack(link_protocol)) + self.assertEqual(cell_bytes, RelayCell(circ_id, command_int, data, digest, stream_id, unused = unused).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(circ_id, cell.circ_id) @@ -224,6 +227,9 @@ class TestCell(unittest.TestCase): if not unused.strip(ZERO): self.assertEqual(cell_bytes, DestroyCell(circ_id, reason).pack(link_protocol)) self.assertEqual(cell_bytes, DestroyCell(circ_id, reason_int).pack(link_protocol)) + else: + self.assertEqual(cell_bytes, DestroyCell(circ_id, reason, unused = unused).pack(link_protocol)) + self.assertEqual(cell_bytes, DestroyCell(circ_id, reason_int, unused = unused).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(circ_id, cell.circ_id) @@ -236,6 +242,8 @@ class TestCell(unittest.TestCase): for cell_bytes, (circ_id, key_material, unused, link_protocol) in CREATE_FAST_CELLS.items(): if not unused.strip(ZERO): self.assertEqual(cell_bytes, CreateFastCell(circ_id, key_material).pack(link_protocol)) + else: + self.assertEqual(cell_bytes, CreateFastCell(circ_id, key_material, unused = unused).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(circ_id, cell.circ_id) @@ -249,6 +257,8 @@ class TestCell(unittest.TestCase): for cell_bytes, (circ_id, key_material, derivative_key, unused, link_protocol) in CREATED_FAST_CELLS.items(): if not unused.strip(ZERO): self.assertEqual(cell_bytes, CreatedFastCell(circ_id, derivative_key, key_material).pack(link_protocol)) + else: + self.assertEqual(cell_bytes, CreatedFastCell(circ_id, derivative_key, key_material, unused = unused).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(circ_id, cell.circ_id) @@ -272,6 +282,8 @@ class TestCell(unittest.TestCase): for cell_bytes, (timestamp, receiver_address, sender_addresses, unused, link_protocol) in NETINFO_CELLS.items(): if not unused.strip(ZERO): self.assertEqual(cell_bytes, NetinfoCell(receiver_address, sender_addresses, timestamp).pack(link_protocol)) + else: + self.assertEqual(cell_bytes, NetinfoCell(receiver_address, sender_addresses, timestamp, unused = unused).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(timestamp, cell.timestamp) @@ -301,6 +313,8 @@ class TestCell(unittest.TestCase): for cell_bytes, (certs, unused, link_protocol) in CERTS_CELLS.items(): if not unused.strip(ZERO): self.assertEqual(cell_bytes, CertsCell(certs).pack(link_protocol)) + else: + self.assertEqual(cell_bytes, CertsCell(certs, unused = unused).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(certs, cell.certificates) @@ -320,6 +334,8 @@ class TestCell(unittest.TestCase): for cell_bytes, (challenge, methods, unused, link_protocol) in AUTH_CHALLENGE_CELLS.items(): if not unused.strip(ZERO): self.assertEqual(cell_bytes, AuthChallengeCell(methods, challenge).pack(link_protocol)) + else: + self.assertEqual(cell_bytes, AuthChallengeCell(methods, challenge, unused = unused).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(challenge, cell.challenge)

1 0

[stem/master] Fix py3 compatibility issue with code moved in previous commit
by atagar＠torproject.org 12 Jul '18

12 Jul '18

commit 429304650d2f942514240e9e446db16054c93984 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Wed Jul 11 18:56:56 2018 +0000 Fix py3 compatibility issue with code moved in previous commit This could've been directly fixed in the previous commit, but it was such a minor change that doing so might've hidden it, so it's been separated out for clarity. --- test/unit/client/cell.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/client/cell.py b/test/unit/client/cell.py index 2e5c498a..e42d7e7a 100644 --- a/test/unit/client/cell.py +++ b/test/unit/client/cell.py @@ -78,7 +78,7 @@ CERTS_CELLS = { b'\x00\x00\x81\x00\x01\x00': ([], b'', 2), b'\x00\x00\x81\x00\x04\x01\x01\x00\x00': ([Certificate(1, b'')], b'', 2), b'\x00\x00\x81\x00\x05\x01\x01\x00\x01\x08': ([Certificate(1, b'\x08')], b'', 2), - b'\x00\x00\x81\x00\x07\x01\x01\x00\x01\x08\x06\x04': ([Certificate(1, '\x08')], b'\x06\x04', 2), + b'\x00\x00\x81\x00\x07\x01\x01\x00\x01\x08\x06\x04': ([Certificate(1, b'\x08')], b'\x06\x04', 2), } AUTH_CHALLENGE_CELLS = {

1 0

[stem/master] Style edit: make 'unused' content in bytes definition easier to pick out
by atagar＠torproject.org 12 Jul '18

12 Jul '18

commit 18831a53a36cec3ca063395cae57447e65bedc4e Author: Dave Rolek <dmr-x(a)riseup.net> Date: Thu Jul 12 02:33:11 2018 +0000 Style edit: make 'unused' content in bytes definition easier to pick out This could've also been done inline in the earlier commit, but wasn't so that it would be easier to identify the moved content therein. --- test/unit/client/cell.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/client/cell.py b/test/unit/client/cell.py index e42d7e7a..433eab57 100644 --- a/test/unit/client/cell.py +++ b/test/unit/client/cell.py @@ -78,7 +78,7 @@ CERTS_CELLS = { b'\x00\x00\x81\x00\x01\x00': ([], b'', 2), b'\x00\x00\x81\x00\x04\x01\x01\x00\x00': ([Certificate(1, b'')], b'', 2), b'\x00\x00\x81\x00\x05\x01\x01\x00\x01\x08': ([Certificate(1, b'\x08')], b'', 2), - b'\x00\x00\x81\x00\x07\x01\x01\x00\x01\x08\x06\x04': ([Certificate(1, b'\x08')], b'\x06\x04', 2), + b'\x00\x00\x81\x00\x07\x01\x01\x00\x01\x08' + b'\x06\x04': ([Certificate(1, b'\x08')], b'\x06\x04', 2), } AUTH_CHALLENGE_CELLS = {

1 0

[stem/master] Don't try to test cell packing with non-blank, non-ZERO 'unused' content without specifying it in constructor
by atagar＠torproject.org 12 Jul '18

12 Jul '18

commit dbb648f43fe8803637d1a66d988dd995ac3af2b8 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Wed Jul 11 23:17:30 2018 +0000 Don't try to test cell packing with non-blank,non-ZERO 'unused' content without specifying it in constructor The test for DestroyCell already did this, so apply this structure to tests of all other cell types that may have 'unused' content. And since this is now such a common pattern in the test file, having a comment for it is less necessary, so also removing that. --- test/unit/client/cell.py | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/test/unit/client/cell.py b/test/unit/client/cell.py index d45886f8..ad9bb0f0 100644 --- a/test/unit/client/cell.py +++ b/test/unit/client/cell.py @@ -185,8 +185,9 @@ class TestCell(unittest.TestCase): def test_relay_cell(self): for cell_bytes, (command, command_int, circ_id, stream_id, data, digest, unused, link_protocol) in RELAY_CELLS.items(): - self.assertEqual(cell_bytes, RelayCell(circ_id, command, data, digest, stream_id).pack(link_protocol)) - self.assertEqual(cell_bytes, RelayCell(circ_id, command_int, data, digest, stream_id).pack(link_protocol)) + if not unused.strip(ZERO): + self.assertEqual(cell_bytes, RelayCell(circ_id, command, data, digest, stream_id).pack(link_protocol)) + self.assertEqual(cell_bytes, RelayCell(circ_id, command_int, data, digest, stream_id).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(circ_id, cell.circ_id) @@ -220,9 +221,6 @@ class TestCell(unittest.TestCase): def test_destroy_cell(self): for cell_bytes, (circ_id, reason, reason_int, unused, link_protocol) in DESTROY_CELLS.items(): - # Packed cells always pad with zeros, so if we're testing something with - # non-zero padding then skip this check. - if not unused.strip(ZERO): self.assertEqual(cell_bytes, DestroyCell(circ_id, reason).pack(link_protocol)) self.assertEqual(cell_bytes, DestroyCell(circ_id, reason_int).pack(link_protocol)) @@ -236,7 +234,8 @@ class TestCell(unittest.TestCase): def test_create_fast_cell(self): for cell_bytes, (circ_id, key_material, unused, link_protocol) in CREATE_FAST_CELLS.items(): - self.assertEqual(cell_bytes, CreateFastCell(circ_id, key_material).pack(link_protocol)) + if not unused.strip(ZERO): + self.assertEqual(cell_bytes, CreateFastCell(circ_id, key_material).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(circ_id, cell.circ_id) @@ -248,7 +247,8 @@ class TestCell(unittest.TestCase): def test_created_fast_cell(self): for cell_bytes, (circ_id, key_material, derivative_key, unused, link_protocol) in CREATED_FAST_CELLS.items(): - self.assertEqual(cell_bytes, CreatedFastCell(circ_id, derivative_key, key_material).pack(link_protocol)) + if not unused.strip(ZERO): + self.assertEqual(cell_bytes, CreatedFastCell(circ_id, derivative_key, key_material).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(circ_id, cell.circ_id) @@ -270,7 +270,8 @@ class TestCell(unittest.TestCase): def test_netinfo_cell(self): for cell_bytes, (timestamp, receiver_address, sender_addresses, unused, link_protocol) in NETINFO_CELLS.items(): - self.assertEqual(cell_bytes, NetinfoCell(receiver_address, sender_addresses, timestamp).pack(link_protocol)) + if not unused.strip(ZERO): + self.assertEqual(cell_bytes, NetinfoCell(receiver_address, sender_addresses, timestamp).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(timestamp, cell.timestamp) @@ -298,7 +299,8 @@ class TestCell(unittest.TestCase): def test_certs_cell(self): for cell_bytes, (certs, unused, link_protocol) in CERTS_CELLS.items(): - self.assertEqual(cell_bytes, CertsCell(certs).pack(link_protocol)) + if not unused.strip(ZERO): + self.assertEqual(cell_bytes, CertsCell(certs).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(certs, cell.certificates) @@ -316,7 +318,8 @@ class TestCell(unittest.TestCase): def test_auth_challenge_cell(self): for cell_bytes, (challenge, methods, unused, link_protocol) in AUTH_CHALLENGE_CELLS.items(): - self.assertEqual(cell_bytes, AuthChallengeCell(methods, challenge).pack(link_protocol)) + if not unused.strip(ZERO): + self.assertEqual(cell_bytes, AuthChallengeCell(methods, challenge).pack(link_protocol)) cell = Cell.pop(cell_bytes, link_protocol)[0] self.assertEqual(challenge, cell.challenge)

1 0

[stem/master] Style edit: make payload length easier to read (ascii -> hex)
by atagar＠torproject.org 12 Jul '18

12 Jul '18

commit 8a292395bb86ed6519aaec2a5c4848f2099fc908 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Thu Jul 12 02:26:24 2018 +0000 Style edit: make payload length easier to read (ascii -> hex) Especially with the test case added just below the line this commit changes, it becomes easier to identify the bytes that specify the payload length and see it change line-to-line. --- test/unit/client/cell.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/client/cell.py b/test/unit/client/cell.py index 1a07fc71..9be0f73b 100644 --- a/test/unit/client/cell.py +++ b/test/unit/client/cell.py @@ -86,7 +86,7 @@ CERTS_CELLS = { } AUTH_CHALLENGE_CELLS = { - b'\x00\x00\x82\x00&' + CHALLENGE + b'\x00\x02\x00\x01\x00\x03': (CHALLENGE, [1, 3], b'', 2), + b'\x00\x00\x82\x00\x26' + CHALLENGE + b'\x00\x02\x00\x01\x00\x03': (CHALLENGE, [1, 3], b'', 2), b'\x00\x00\x82\x00\x28' + CHALLENGE + b'\x00\x02\x00\x01\x00\x03' + b'\x01\x02': (CHALLENGE, [1, 3], b'\x01\x02', 2), }

1 0

[stem/master] Add a test case with non-ZERO 'unused' content for each pertinent cell type
by atagar＠torproject.org 12 Jul '18

12 Jul '18

commit 05ddc71784a196bdbc6e02d60eae453d5a32c6ad Author: Dave Rolek <dmr-x(a)riseup.net> Date: Wed Jul 11 23:52:14 2018 +0000 Add a test case with non-ZERO 'unused' content for each pertinent cell type All implemented cell types that may have 'unused' content now have a test case that checks it. --- test/unit/client/cell.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/unit/client/cell.py b/test/unit/client/cell.py index 433eab57..1a07fc71 100644 --- a/test/unit/client/cell.py +++ b/test/unit/client/cell.py @@ -36,6 +36,7 @@ PADDING_CELLS = { RELAY_CELLS = { b'\x00\x01\x03\r\x00\x00\x00\x01!\xa3?\xec\x00\x00' + ZERO * 498: ('RELAY_BEGIN_DIR', 13, 1, 1, b'', 564346860, ZERO * 498, 2), b'\x00\x01\x03\x02\x00\x00\x00\x01\x15:m\xe0\x00&GET /tor/server/authority HTTP/1.0\r\n\r\n' + ZERO * 460: ('RELAY_DATA', 2, 1, 1, b'GET /tor/server/authority HTTP/1.0\r\n\r\n', 356150752, ZERO * 460, 2), + b'\x00\x01\x03\x02\x00\x00\x00\x01\x15:m\xe0\x00&GET /tor/server/authority HTTP/1.0\r\n\r\n' + b'\x01' + ZERO * 459: ('RELAY_DATA', 2, 1, 1, b'GET /tor/server/authority HTTP/1.0\r\n\r\n', 356150752, b'\x01' + ZERO * 459, 2), } DESTROY_CELLS = { @@ -47,11 +48,13 @@ DESTROY_CELLS = { CREATE_FAST_CELLS = { (b'\x80\x00\x00\x00\x05\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\xce' + ZERO * 489): (2147483648, b'\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\xce', ZERO * 489, 5), (b'\x80\x00\x00\x00\x05\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\x00' + ZERO * 489): (2147483648, b'\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\x00', ZERO * 489, 5), + (b'\x80\x00\x00\x00\x05\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\x00' + b'\x01' + ZERO * 488): (2147483648, b'\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\x00', b'\x01' + ZERO * 488, 5), } CREATED_FAST_CELLS = { (b'\x80\x00\x00\x00\x06\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\xce\x13Z\x99\xb2\x1e\xb6\x05\x85\x17\xfc\x1c\x00{\xa9\xae\x83^K\x99\xb2' + ZERO * 469): (2147483648, b'\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\xce', b'\x13Z\x99\xb2\x1e\xb6\x05\x85\x17\xfc\x1c\x00{\xa9\xae\x83^K\x99\xb2', ZERO * 469, 5), (b'\x80\x00\x00\x00\x06\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\xce\x13Z\x99\xb2\x1e\xb6\x05\x85\x17\xfc\x1c\x00{\xa9\xae\x83^K\x99\x00' + ZERO * 469): (2147483648, b'\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\xce', b'\x13Z\x99\xb2\x1e\xb6\x05\x85\x17\xfc\x1c\x00{\xa9\xae\x83^K\x99\x00', ZERO * 469, 5), + (b'\x80\x00\x00\x00\x06\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\xce\x13Z\x99\xb2\x1e\xb6\x05\x85\x17\xfc\x1c\x00{\xa9\xae\x83^K\x99\x00' + b'\x01' + ZERO * 468): (2147483648, b'\x92O\x0c\xcb\xa8\xac\xfb\xc9\x7f\xd0\rz\x1a\x03u\x91\xceas\xce', b'\x13Z\x99\xb2\x1e\xb6\x05\x85\x17\xfc\x1c\x00{\xa9\xae\x83^K\x99\x00', b'\x01' + ZERO * 468, 5), } VERSIONS_CELLS = { @@ -63,6 +66,7 @@ VERSIONS_CELLS = { NETINFO_CELLS = { b'\x00\x00\x08ZZ\xb6\x90\x04\x04\x7f\x00\x00\x01\x01\x04\x04aq\x0f\x02' + ZERO * (FIXED_PAYLOAD_LEN - 17): (datetime.datetime(2018, 1, 14, 1, 46, 56), Address('127.0.0.1'), [Address('97.113.15.2')], ZERO * 492, 2), + b'\x00\x00\x08ZZ\xb6\x90\x04\x04\x7f\x00\x00\x01\x01\x04\x04aq\x0f\x02' + b'\x01' + ZERO * (FIXED_PAYLOAD_LEN - 18): (datetime.datetime(2018, 1, 14, 1, 46, 56), Address('127.0.0.1'), [Address('97.113.15.2')], b'\x01' + ZERO * 491, 2), } VPADDING_CELL_EMPTY_PACKED = b'\x00\x00\x80\x00\x00' @@ -83,6 +87,7 @@ CERTS_CELLS = { AUTH_CHALLENGE_CELLS = { b'\x00\x00\x82\x00&' + CHALLENGE + b'\x00\x02\x00\x01\x00\x03': (CHALLENGE, [1, 3], b'', 2), + b'\x00\x00\x82\x00\x28' + CHALLENGE + b'\x00\x02\x00\x01\x00\x03' + b'\x01\x02': (CHALLENGE, [1, 3], b'\x01\x02', 2), }

1 0

[stem/master] Repack 'unused' Cell content and various testing improvements
by atagar＠torproject.org 12 Jul '18

12 Jul '18

commit 775bc60fb6497872b8ae00a5a8b5c3e29305d7d0 Merge: 6c677b6a 8a292395 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Thu Jul 12 04:13:55 2018 +0000 Repack 'unused' Cell content and various testing improvements Previously, unpacking would popular the 'unused' attribute with any remainder content, but it would never be used by anything. This also has various testing improvements to make the Cell tests more data-driven. https://trac.torproject.org/projects/tor/ticket/26766 stem/client/cell.py | 26 ++++--- test/unit/client/cell.py | 171 +++++++++++++++++++++++++++++------------------ 2 files changed, 124 insertions(+), 73 deletions(-)

1 0

[stem/master] Update manual cache
by atagar＠torproject.org 12 Jul '18

12 Jul '18

commit 1e56dcc53858e04488ecb2248c64d0e6cc24f724 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Jul 11 10:40:21 2018 -0700 Update manual cache Resyncing our manual information from tor to pick up new torrc options. --- stem/cached_manual.sqlite | Bin 238592 -> 240640 bytes stem/manual.py | 2 +- stem/settings.cfg | 20 +++++++++++--------- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/stem/cached_manual.sqlite b/stem/cached_manual.sqlite index 6b17f4da..06d3dcd2 100644 Binary files a/stem/cached_manual.sqlite and b/stem/cached_manual.sqlite differ diff --git a/stem/manual.py b/stem/manual.py index 47c16d42..573542da 100644 --- a/stem/manual.py +++ b/stem/manual.py @@ -135,7 +135,7 @@ def query(query, *param): >>> import stem.manual >>> print(stem.manual.query('SELECT description FROM torrc WHERE key=?', 'CONTROLSOCKET').fetchone()[0]) - Like ControlPort, but listens on a Unix domain socket, rather than a TCP socket. 0 disables ControlSocket (Unix and Unix-like systems only.) + Like ControlPort, but listens on a Unix domain socket, rather than a TCP socket. 0 disables ControlSocket. (Unix and Unix-like systems only.) (Default: 0) .. versionadded:: 1.6.0 diff --git a/stem/settings.cfg b/stem/settings.cfg index 7e84210c..12ffe8b4 100644 --- a/stem/settings.cfg +++ b/stem/settings.cfg @@ -167,6 +167,7 @@ manual.summary.UseEntryGuards Use guard relays for first hop manual.summary.GuardfractionFile File containing information with duration of our guards manual.summary.UseGuardFraction Take guardfraction into account for path selection manual.summary.NumEntryGuards Pool size of guard relays we'll select from +manual.summary.NumPrimaryGuards Pool size of strongly preferred guard relays we'll select from manual.summary.NumDirectoryGuards Pool size of directory guards we'll select from manual.summary.GuardLifetime Minimum time to keep entry guards manual.summary.SafeSocks Toggles rejecting unsafe variants of the socks protocol @@ -207,9 +208,10 @@ manual.summary.ClientUseIPv6 Allow IPv6 connections to guards and fetching conse manual.summary.ClientPreferIPv6DirPort Perfer relays with IPv6 when fetching consensus manual.summary.ClientPreferIPv6ORPort Prefer a guard's IPv6 rather than IPv4 endpoint manual.summary.PathsNeededToBuildCircuits Portion of relays to require information for before making circuits -manual.summary.ClientBootstrapConsensusAuthorityDownloadSchedule Schedule when bootstrapping for when to download resources from authorities -manual.summary.ClientBootstrapConsensusFallbackDownloadSchedule Schedule when bootstrapping for when to download resources from fallback authorities -manual.summary.ClientBootstrapConsensusAuthorityOnlyDownloadSchedule Schedule when bootstrapping for when to download resources from authorities when fallbacks unavailable +manual.summary.ClientBootstrapConsensusAuthorityDownloadInitialDelay Delay when bootstrapping before downloading descriptors from authorities +manual.summary.ClientBootstrapConsensusFallbackDownloadInitialDelay Delay when bootstrapping before downloading descriptors from fallbacks +manual.summary.ClientBootstrapConsensusAuthorityOnlyDownloadInitialDelay Delay when bootstrapping before downloading descriptors from authorities if fallbacks disabled +manual.summary.ClientBootstrapConsensusMaxInProgressTries Descriptor documents that can be downloaded in parallel manual.summary.ClientBootstrapConsensusMaxInProgressTries Number of consensus download requests to allow in-flight at once # Server Config Options @@ -349,12 +351,12 @@ manual.summary.TestingV3AuthVotingStartOffset Offset for the point at which the manual.summary.TestingAuthDirTimeToLearnReachability Delay until opinions are given about which relays are running or not manual.summary.TestingEstimatedDescriptorPropagationTime Delay before clients attempt to fetch descriptors from directory caches manual.summary.TestingMinFastFlagThreshold Minimum value for the Fast flag -manual.summary.TestingServerDownloadSchedule Schedule for when we should download resources as a relay -manual.summary.TestingClientDownloadSchedule Schedule for when we should download resources as a client -manual.summary.TestingServerConsensusDownloadSchedule Schedule for when we should download the consensus as a relay -manual.summary.TestingClientConsensusDownloadSchedule Schedule for when we should download the consensus as a client -manual.summary.TestingBridgeDownloadSchedule Schedule for when we should download bridge descriptors -manual.summary.TestingBridgeBootstrapDownloadSchedule Schedule for downloading bridge descriptors when started +manual.summary.TestingServerDownloadInitialDelay Delay before downloading resources for relaying +manual.summary.TestingClientDownloadInitialDelay Delay before downloading resources for client usage +manual.summary.TestingServerConsensusDownloadInitialDelay Delay before downloading descriptors for relaying +manual.summary.TestingClientConsensusDownloadInitialDelay Delay before downloading descriptors for client usage +manual.summary.TestingBridgeDownloadInitialDelay Delay before downloading bridge descriptors +manual.summary.TestingBridgeBootstrapDownloadInitialDelay Delay before downloading bridge descriptors when first started manual.summary.TestingClientMaxIntervalWithoutRequest Maximum time to wait to batch requests for missing descriptors manual.summary.TestingDirConnectionMaxStall Duration to let directory connections stall before timing out manual.summary.TestingDirAuthVoteExit Relays to give the Exit flag to

1 0