June 2018 - tor-commits - lists.torproject.org

[translation/support-faq] Update translations for support-faq
by translation＠torproject.org 26 Jun '18

26 Jun '18

commit b02eef8f86b10d99c0149a7e5401d5234673351a Author: Translation commit bot <translation(a)torproject.org> Date: Tue Jun 26 20:49:06 2018 +0000 Update translations for support-faq --- sv.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sv.json b/sv.json index bf9c2b27a..8aa9e6eaa 100644 --- a/sv.json +++ b/sv.json @@ -2,7 +2,7 @@ "faq-1": { "id": "#faq-1", "control": "faq-1", - "title": "When I use Tor Browser, will anyone be able to tell which websites I visit?", + "title": "När jag använder Tor Browser, kommer någon se vilka hemsidor jag besöker?", "description": "Tor Browser prevents people from knowing the websites you visit. Some entities, such as your Internet Service Provider (ISP), may be able to see that you're using Tor." }, "faq-2": {

1 0

[translation/support-connecting] Update translations for support-connecting
by translation＠torproject.org 26 Jun '18

26 Jun '18

commit a0b5f918f52c170f26f500591245156d5e0edfde Author: Translation commit bot <translation(a)torproject.org> Date: Tue Jun 26 20:48:57 2018 +0000 Update translations for support-connecting --- sv.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sv.json b/sv.json index 9f5a678cf..faf82a45b 100644 --- a/sv.json +++ b/sv.json @@ -2,8 +2,8 @@ "connecting-1": { "id": "#connecting-1", "control": "connecting-1", - "title": "Tor Browser won't connect, but it doesn’t seem to be an issue with censorship.", - "description": "One of the most common issues that causes connection errors in Tor Browser is an incorrect system clock. Please make sure your system clock and timezone are set accurately. If this doesn't fix the problem, see the Troubleshooting page on the <a href=\"https://tb-manual.torproject.org/en-US/bridges.html\">Tor Browser manual</a>." + "title": "Tor Browser ansluter inte men det verkar inte vara på grund av censur.", + "description": "En av de vanligaste problemen som orsakar anslutningsproblem till Tor Browser är en felaktig system klocka. Vänligen se till att system klockan och tidszonen är korrekt inställda. Om det inte löser problemet, se Troubleshooting sidan i Tor Browser Manual .<a href=\"https://tb-manual.torproject.org/en-US/bridges.html\"></a> " }, "connecting-2": { "id": "#connecting-2",

1 0

[tor-browser-build/master] Bug 26489: fix .app directory name in tools/dmg2mar
by gk＠torproject.org 26 Jun '18

26 Jun '18

commit 1633185de3336351f47cb66b99903ef70b04d6ff Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Jun 25 14:41:39 2018 +0200 Bug 26489: fix .app directory name in tools/dmg2mar Add the whitespace in "Tor Browser.app". --- tools/dmg2mar | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/dmg2mar b/tools/dmg2mar index 51d6acb..9b98956 100755 --- a/tools/dmg2mar +++ b/tools/dmg2mar @@ -36,9 +36,10 @@ use Parallel::ForkManager; use Cwd; # If the application is not TorBrowser (for instance, TorMessenger) -# set the application name in the TOR_APPNAME_BUNDLE_OSX and in -# the TOR_APPNAME_MARFILE environment variables -my $appname = $ENV{TOR_APPNAME_BUNDLE_OSX} // 'TorBrowser'; +# set the application name in the TOR_APPNAME_BUNDLE_OSX, +# TOR_APPNAME_DMGFILE and TOR_APPNAME_MARFILE environment variables +my $appname = $ENV{TOR_APPNAME_BUNDLE_OSX} // 'Tor Browser'; +my $appname_dmg = $ENV{TOR_APPNAME_DMGFILE} // 'TorBrowser'; my $appname_mar = $ENV{TOR_APPNAME_MARFILE} // 'tor-browser'; sub exit_error { @@ -95,7 +96,7 @@ sub get_dmg_files_from_sha256sums { foreach my $line (read_file('sha256sums-unsigned-build.txt')) { my (undef, $filename) = split ' ', $line; chomp $filename; - next unless $filename =~ m/^$appname-(.+)-osx64_(.+)\.dmg$/; + next unless $filename =~ m/^$appname_dmg-(.+)-osx64_(.+)\.dmg$/; push @files, { filename => $filename, version => $1, lang => $2 }; } return @files;

1 0

[tor-browser-build/master] Merge remote-tracking branch 'boklm/bug_26489'
by gk＠torproject.org 26 Jun '18

26 Jun '18

commit 5d5401f7a0831702d913d5e469f70954c5796edb Merge: ce2f13c 1633185 Author: Georg Koppen <gk(a)torproject.org> Date: Tue Jun 26 19:30:03 2018 +0000 Merge remote-tracking branch 'boklm/bug_26489' tools/dmg2mar | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)

1 0

[stem/master] Remove redundant content-length checks
by atagar＠torproject.org 26 Jun '18

26 Jun '18

commit 3d3e68c05fbe84f7cf0eff45e376480ec50b48c3 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Sun Jun 3 19:32:57 2018 +0000 Remove redundant content-length checks The Size pop calls() following where the respective checks were will raise an exception if the content isn't large enough for that Size. Additionally, for the NetinfoCell payload unpacking, the removed check exception was actually unreachable unless NetinfoCell._unpack() were called directly, instead of through Cell.pop(), since it is a fixed-sized cell. --- stem/client/cell.py | 3 --- stem/client/datatype.py | 5 ----- 2 files changed, 8 deletions(-) diff --git a/stem/client/cell.py b/stem/client/cell.py index 57ccc1ab..0f9ae59e 100644 --- a/stem/client/cell.py +++ b/stem/client/cell.py @@ -555,9 +555,6 @@ class NetinfoCell(Cell): @classmethod def _unpack(cls, content, circ_id, link_protocol): - if len(content) < Size.LONG.size: - raise ValueError('NETINFO cell expected to start with a timestamp') - timestamp, content = Size.LONG.pop(content) receiver_address, content = Address.pop(content) diff --git a/stem/client/datatype.py b/stem/client/datatype.py index db9d461a..2ee624cb 100644 --- a/stem/client/datatype.py +++ b/stem/client/datatype.py @@ -420,11 +420,6 @@ class Address(Field): @staticmethod def pop(content): - if not content: - raise ValueError('Payload empty where an address was expected') - elif len(content) < 2: - raise ValueError('Insuffient data for address headers') - addr_type, content = Size.CHAR.pop(content) addr_length, content = Size.CHAR.pop(content)

1 0

[webwml/master] Add new Tor Browser version: 7.5.6
by boklm＠torproject.org 26 Jun '18

26 Jun '18

commit a56a6b5900f6f2019c5ae3d0d4af7fa7d8d94261 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Tue Jun 26 18:41:14 2018 +0200 Add new Tor Browser version: 7.5.6 --- include/versions.wmi | 6 +++--- projects/torbrowser/RecommendedTBBVersions | 4 ++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/versions.wmi b/include/versions.wmi index 2e159841..32fdd152 100644 --- a/include/versions.wmi +++ b/include/versions.wmi @@ -4,9 +4,9 @@ <define-tag version-torbrowserdevelopbranch whitespace=delete>maint-7.5</define-tag> # *** tor browser stable *** -<define-tag version-torbrowserbundle-all whitespace=delete>7.5.5</define-tag> -<define-tag releasedate-torbrowserbundle-all whitespace=delete>2018-06-09</define-tag> -<define-tag version-win32-stable whitespace=delete>0.3.2.10</define-tag> +<define-tag version-torbrowserbundle-all whitespace=delete>7.5.6</define-tag> +<define-tag releasedate-torbrowserbundle-all whitespace=delete>2018-06-26</define-tag> +<define-tag version-win32-stable whitespace=delete>0.3.3.7</define-tag> # If all platforms are on the same version, you only need to update # version-torbrowserbundle-all and releasedate-torbrowserbundle-all diff --git a/projects/torbrowser/RecommendedTBBVersions b/projects/torbrowser/RecommendedTBBVersions index b6dd3202..a66a1e87 100644 --- a/projects/torbrowser/RecommendedTBBVersions +++ b/projects/torbrowser/RecommendedTBBVersions @@ -3,6 +3,10 @@ "7.5.5-MacOS", "7.5.5-Linux", "7.5.5-Windows", +"7.5.6", +"7.5.6-MacOS", +"7.5.6-Linux", +"7.5.6-Windows", "8.0a8", "8.0a8-MacOS", "8.0a8-Linux",

1 0

[tor/master] Remove some accidentally committed code in checkIncludes.py
by nickm＠torproject.org 26 Jun '18

26 Jun '18

commit 860b9a991879c5be2b32cf98766adf5fdd349d41 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jun 26 12:04:24 2018 -0400 Remove some accidentally committed code in checkIncludes.py --- scripts/maint/checkIncludes.py | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/scripts/maint/checkIncludes.py b/scripts/maint/checkIncludes.py index cb3354abf..3c611675e 100755 --- a/scripts/maint/checkIncludes.py +++ b/scripts/maint/checkIncludes.py @@ -58,21 +58,12 @@ def load_include_rules(fname): result.addPattern(line) return result -MDD = "--mdd" in sys.argv[1:] - -if MDD: - print( - for dirpath, dirnames, fnames in os.walk("src"): if ".may_include" in fnames: rules = load_include_rules(os.path.join(dirpath, RULES_FNAME)) - if MDD: - dp = dirpath.replace("src/","") - rules.dump_mdd(dp) - else: - for fname in fnames: - if fname_is_c(fname): - rules.applyToFile(os.path.join(dirpath,fname)) + for fname in fnames: + if fname_is_c(fname): + rules.applyToFile(os.path.join(dirpath,fname)) if trouble: err(

1 0

[sbws/master] Some integration tests for measuring relays (probably will fail)
by pastly＠torproject.org 26 Jun '18

26 Jun '18

commit c6c7ed1a6c5db840a8ca59ede892874ae41e6d6d Author: Matt Traudt <sirmatt(a)ksu.edu> Date: Tue Jun 19 22:19:53 2018 -0400 Some integration tests for measuring relays (probably will fail) --- tests/integration/core/test_scanner.py | 87 ++++++++++++++++++++++++++++++++++ 1 file changed, 87 insertions(+) diff --git a/tests/integration/core/test_scanner.py b/tests/integration/core/test_scanner.py new file mode 100644 index 0000000..9f5bb8c --- /dev/null +++ b/tests/integration/core/test_scanner.py @@ -0,0 +1,87 @@ +from sbws.core.scanner import measure_relay +from sbws.lib.circuitbuilder import GapsCircuitBuilder as CB +from sbws.util.config import get_config +from sbws.lib.relaylist import RelayList +from sbws.lib.destination import DestinationList +from sbws.lib.resultdump import ResultSuccess + + +def assert_within(value, target, radius): + ''' + Assert that **value** is within **radius** of **target** + + If target is 10 and radius is 2, value can be anywhere between 8 and 12 + inclusive + ''' + assert target - radius < value, 'Value is too small. {} is not within '\ + '{} of {}'.format(value, radius, target) + assert target + radius > value, 'Value is too big. {} is not within '\ + '{} of {}'.format(value, radius, target) + + +def get_everything_to_measure(dotsbws, cont, parser): + args = parser.parse_args( + '-d {} --log-level DEBUG scanner'.format(dotsbws).split()) + conf = get_config(args) + conf['destinations']['foo'] = 'on' + conf['destinations.foo'] = {} + conf['destinations.foo']['url'] = 'http://127.0.0.1:28888/sbws.bin' + rl = RelayList(args, conf, cont) + cb = CB(args, conf, cont) + dests, error_msg = DestinationList.from_config(conf, cb, rl, cont) + assert dests, error_msg + return { + 'args': args, + 'conf': conf, + 'rl': rl, + 'cb': cb, + 'dests': dests + } + + +def test_measure_relay_with_maxadvertisedbandwidth( + persistent_launch_tor, parser, persistent_empty_dotsbws): + cont = persistent_launch_tor + dotsbws = persistent_empty_dotsbws.name + d = get_everything_to_measure(dotsbws, cont, parser) + args = d['args'] + conf = d['conf'] + rl = d['rl'] + dests = d['dests'] + cb = d['cb'] + # 117A456C911114076BEB4E757AC48B16CC0CCC5F is relay1mbyteMAB + relay = [r for r in rl.relays + if r.nickname == 'relay1mbyteMAB'][0] + result = measure_relay(args, conf, dests, cb, rl, relay) + assert len(result) == 1 + result = result[0] + assert isinstance(result, ResultSuccess) + one_mbyte = 1 * 1024 * 1024 + allowed_error = 5 # bytes per second + dls = result.downloads + for dl in dls: + assert_within(dl['amount'] / dl['duration'], one_mbyte, allowed_error) + + +def test_measure_relay_with_relaybandwidthrate( + persistent_launch_tor, parser, persistent_empty_dotsbws): + cont = persistent_launch_tor + dotsbws = persistent_empty_dotsbws.name + d = get_everything_to_measure(dotsbws, cont, parser) + args = d['args'] + conf = d['conf'] + rl = d['rl'] + dests = d['dests'] + cb = d['cb'] + # relay1mbyteRBR 934E06F38A391CB71DF83ECDE05DFF5CDE3AC49D + relay = [r for r in rl.relays + if r.nickname == 'relay1mbyteRBR'][0] + result = measure_relay(args, conf, dests, cb, rl, relay) + assert len(result) == 1 + result = result[0] + assert isinstance(result, ResultSuccess) + one_mbyte = 1 * 1024 * 1024 + allowed_error = 5 # bytes per second + dls = result.downloads + for dl in dls: + assert_within(dl['amount'] / dl['duration'], one_mbyte, allowed_error)

1 0

[sbws/master] Return trimmed results only when arg is True
by pastly＠torproject.org 26 Jun '18

26 Jun '18

commit b2c60d0d6d4a37a75a864e8127e8761835b3f41a Author: juga0 <juga(a)riseup.net> Date: Wed Jun 20 07:53:19 2018 +0000 Return trimmed results only when arg is True --- sbws/lib/resultdump.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbws/lib/resultdump.py b/sbws/lib/resultdump.py index 31a8926..aab27e7 100644 --- a/sbws/lib/resultdump.py +++ b/sbws/lib/resultdump.py @@ -96,7 +96,6 @@ def trim_results_ip_changed(result_dict, on_changed_ipv4=False, :returns: a new results dictionary """ assert isinstance(result_dict, dict) - assert on_changed_ipv4 is True or on_changed_ipv6 is True new_results_dict = {} if on_changed_ipv4 is True: for fp in result_dict.keys(): @@ -115,10 +114,11 @@ def trim_results_ip_changed(result_dict, on_changed_ipv4=False, new_results_dict[fp] = last_ip_results else: new_results_dict[fp] = results + return new_results_dict if on_changed_ipv6 is True: log.warn("Reseting bandwidth results when IPv6 changes," " is not yet implemented.") - return new_results_dict + return result_dict def load_recent_results_in_datadir(fresh_days, datadir, success_only=False,

1 0

[sbws/master] Add relay1mbyteRBR to integration testnet
by pastly＠torproject.org 26 Jun '18

26 Jun '18

commit 35acd72a487f31efe495acfe2bc64e34b0ff7967 Author: Matt Traudt <sirmatt(a)ksu.edu> Date: Tue Jun 19 22:19:00 2018 -0400 Add relay1mbyteRBR to integration testnet Has 'RelayBandwidthRate 1 MByte' set --- tests/integration/net.tar | Bin 204800 -> 215040 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/integration/net.tar b/tests/integration/net.tar index cde1f17..2870690 100644 Binary files a/tests/integration/net.tar and b/tests/integration/net.tar differ

1 0