June 2018 - tor-commits - lists.torproject.org

[torspec/master] Change interval of time for bandwidth changes
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit e4cf6865bb7a8743f92f687f27febe29eb060954 Author: juga0 <juga(a)riseup.net> Date: Mon Jun 4 21:07:43 2018 +0000 Change interval of time for bandwidth changes Paragraph on events required to update descriptor were not reflecting changes made in #23856 where the bandwidth changes need to happen in a time interval of 3h instead of 20min. --- dir-spec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dir-spec.txt b/dir-spec.txt index e44052f..fd7d67c 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -354,7 +354,7 @@ - Its uptime is less than 24h and bandwidth has changed by a factor of 2 from the last time a descriptor was generated, and at least a given - interval of time (20 mins by default) has passed since then. + interval of time (3 hours by default) has passed since then. - Its uptime has been reset (by restarting).

1 0

[torspec/master] Merge remote-tracking branch 'juga/bug26301'
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit 4ead6e1e53566d13246f2323276ee6d3ded8cf7f Merge: 6533c85 e4cf686 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Jun 17 19:30:33 2018 -0400 Merge remote-tracking branch 'juga/bug26301' dir-spec.txt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)

1 0

[tor/master] Improve openssl_version tests with better messages
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit 8483241b4e2538e9adb75c7ffed2787afd361df6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon May 21 15:06:45 2018 -0400 Improve openssl_version tests with better messages These tests would report errors, but wouldn't report the offending strings. --- changes/bug26152 | 4 ++++ src/test/test_crypto.c | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/changes/bug26152 b/changes/bug26152 new file mode 100644 index 000000000..34fda09b2 --- /dev/null +++ b/changes/bug26152 @@ -0,0 +1,4 @@ + o Minor bugfixes (testing): + - When logging a version mismatch in our openssl_version tests, + report the actual offending version strings. Fixes bug 26152; bugfix on + 0.2.9.1-alpha. diff --git a/src/test/test_crypto.c b/src/test/test_crypto.c index 24eef156b..e3a41412f 100644 --- a/src/test/test_crypto.c +++ b/src/test/test_crypto.c @@ -152,8 +152,13 @@ test_crypto_openssl_version(void *arg) const char *h_version = crypto_openssl_get_header_version_str(); tt_assert(version); tt_assert(h_version); - tt_assert(!strcmpstart(version, h_version)); /* "-fips" suffix, etc */ - tt_assert(!strstr(version, "OpenSSL")); + if (strcmpstart(version, h_version)) { /* "-fips" suffix, etc */ + TT_DIE(("OpenSSL library version %s did not begin with header version %s.", + version, h_version)); + } + if (strstr(version, "OpenSSL")) { + TT_DIE(("assertion failed: !strstr(\"%s\", \"OpenSSL\")", version)); + } int a=-1,b=-1,c=-1; if (!strcmpstart(version, "LibreSSL") || !strcmpstart(version, "BoringSSL")) return;

1 0

[tor/master] Merge remote-tracking branch 'github/bug26152_035'
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit 987174cc6fb4915299236fd76e3bb6c893e78653 Merge: 4e439cd40 8483241b4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Jun 17 19:28:59 2018 -0400 Merge remote-tracking branch 'github/bug26152_035' changes/bug26152 | 4 ++++ src/test/test_crypto.c | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-)

1 0

[torspec/master] Add bandwidth-file line to vote documents
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit 84591df1c20856d07411af7b487710e97d76a60e Author: juga0 <juga(a)riseup.net> Date: Wed May 30 21:52:47 2018 +0000 Add bandwidth-file line to vote documents --- dir-spec.txt | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/dir-spec.txt b/dir-spec.txt index 5f2a713..2253ec6 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -2084,6 +2084,31 @@ Value is the actual shared random value encoded in base64. NumReveals is the number of commits used to generate this SRV. + "bandwidth-file" SP KeyValues NL + + [At most once] + + Value ::= any printing ASCII character except NL and SP. + KeyValue ::= Keyword '=' Value + KeyValues ::= KeyValue | KeyValues SP KeyValue + + The Bandwidth List headers KeyValue pairs of the Bandwidth List file + specified in bandwith-file-spec.txt, used to obtain the Bandwidth + RelayLines, also called bandwidth measurements. + + Current Keywords: + "timestamp" -- the Unix Epoch time in seconds when the latest generator + result was obtained. + "version" -- the Bandwidth List format document specification version. + "software" -- the name of the software that created the document. + "software_version" -- the version of the software that created the + document. + "generator_started" -- the date and time timestamp in ISO 8601 format + and UTC time zone when the generator started. + "earliest_bandwidth" -- the date and time timestamp in ISO 8601 format + and UTC time zone when the first relay bandwidth was obtained. + First-appeared: Tor 0.3.5 + The authority section of a vote contains the following items, followed in turn by the authority's current key certificate:

1 0

[torspec/master] Rephrase bandwidth-file line description
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit d7f9766ee2e974c12e47f8cfd2bbd0232b323678 Author: juga0 <juga(a)riseup.net> Date: Thu May 31 18:15:30 2018 +0000 Rephrase bandwidth-file line description also change version of Tor where 1st appeared. --- dir-spec.txt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/dir-spec.txt b/dir-spec.txt index 2253ec6..233e174 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -2092,9 +2092,8 @@ KeyValue ::= Keyword '=' Value KeyValues ::= KeyValue | KeyValues SP KeyValue - The Bandwidth List headers KeyValue pairs of the Bandwidth List file - specified in bandwith-file-spec.txt, used to obtain the Bandwidth - RelayLines, also called bandwidth measurements. + The headers from the bandwidth file used to generate this vote. + The bandwidth file headers are described in bandwith-file-spec.txt. Current Keywords: "timestamp" -- the Unix Epoch time in seconds when the latest generator @@ -2107,7 +2106,7 @@ and UTC time zone when the generator started. "earliest_bandwidth" -- the date and time timestamp in ISO 8601 format and UTC time zone when the first relay bandwidth was obtained. - First-appeared: Tor 0.3.5 + First-appeared: Tor 0.3.5.1-alpha. The authority section of a vote contains the following items, followed in turn by the authority's current key certificate:

1 0

[torspec/master] Merge remote-tracking branch 'juga/ticket26222'
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit 6533c852328f5b18bd36c249ba7bb8f9b66ab1c2 Merge: 419ba0c b36cc50 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Jun 17 19:27:52 2018 -0400 Merge remote-tracking branch 'juga/ticket26222' dir-spec.txt | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)

1 0

[torspec/master] Fix typo
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit b36cc500b886f104732f214573f02a98a1b4e443 Author: juga0 <juga(a)riseup.net> Date: Thu May 31 18:59:47 2018 +0000 Fix typo --- dir-spec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dir-spec.txt b/dir-spec.txt index 233e174..2987a18 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -2093,7 +2093,7 @@ KeyValues ::= KeyValue | KeyValues SP KeyValue The headers from the bandwidth file used to generate this vote. - The bandwidth file headers are described in bandwith-file-spec.txt. + The bandwidth file headers are described in bandwidth-file-spec.txt. Current Keywords: "timestamp" -- the Unix Epoch time in seconds when the latest generator

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.2' into maint-0.3.3
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit a360bf287d8220ec2e4899c57ed47a2a91e3bcb9 Merge: ccf1eb316 6107a2127 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Jun 17 19:24:48 2018 -0400 Merge branch 'maint-0.3.2' into maint-0.3.3 .editorconfig | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)

1 0

[tor/release-0.3.4] Add .editorconfig to follow coding standards style
by nickm＠torproject.org 17 Jun '18

17 Jun '18

commit dd69e74e3f0f25f76107f9ef0aaacbea85271316 Author: juga0 <juga(a)riseup.net> Date: Sun Jun 3 10:44:02 2018 +0000 Add .editorconfig to follow coding standards style --- .editorconfig | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 000000000..27ed90faf --- /dev/null +++ b/.editorconfig @@ -0,0 +1,33 @@ +# this should work for all editors that support .editorconfig! +# +# on debian, emacs users should install elpa-editorconfig and vim +# users should install vim-editorconfig. + +root = true + +[*] +indent_style = space +# this remove final newline in some editors, instead of inserting it +# insert_final_newline = true +trim_trailing_whitespace = true +end_of_line = lf +charset = utf-8 +max_line_length = 79 + +[*.py] +indent_size = 4 +# to do not have final newline in python code +insert_final_newline = true + +[*.c, *.h] +# done in tests and other cases do not use 2 spaces identations, so this +# should be commented on those cases +indent_size = 2 +trim_trailing_whitespace = true + +[Makefile, *.am] +indent_style = tab + +[*-spec.txt] +# specs seem to have 76 chars max per lines as RFCs +max_line_length = 76 \ No newline at end of file

1 0