tor-commits June 2018

tor-commits@lists.torproject.org

16 participants
2190 discussions

[tor/maint-0.3.4] Merge branch 'maint-0.3.3' into maint-0.3.4
by nickm＠torproject.org 21 Jun '18

21 Jun '18

commit c389c4129252b49f7e5bd77e1be342cddbe388fb Merge: 46dca2732 7b1a3c516 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 21 08:36:48 2018 -0400 Merge branch 'maint-0.3.3' into maint-0.3.4 changes/bug26435 | 5 +++++ src/or/protover.c | 9 ++++++--- 2 files changed, 11 insertions(+), 3 deletions(-)

1 0

[tor/maint-0.3.4] fix memory leak in protover.c
by nickm＠torproject.org 21 Jun '18

21 Jun '18

commit 7b1a3c51644891c4548ccdfd4e8d444cd91b91b0 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Jun 20 19:43:58 2018 -0400 fix memory leak in protover.c Fix a memory leak where directory authorities would leak a chunk of memory for every router descriptor every time they considered voting. This bug was taking down directory authorities in the live network due to out-of-memory issues. Fixes bug 26435; bugfix on 0.3.3.6. --- changes/bug26435 | 5 +++++ src/or/protover.c | 9 ++++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/changes/bug26435 b/changes/bug26435 new file mode 100644 index 000000000..c28194934 --- /dev/null +++ b/changes/bug26435 @@ -0,0 +1,5 @@ + o Major bugfixes: + - Fix a memory leak where directory authorities would leak a chunk + of memory for every router descriptor every time they considered + voting. This bug was taking down directory authorities due to + out-of-memory issues. Fixes bug 26435; bugfix on 0.3.3.6. diff --git a/src/or/protover.c b/src/or/protover.c index b2ec3372c..5145881ba 100644 --- a/src/or/protover.c +++ b/src/or/protover.c @@ -283,9 +283,12 @@ parse_protocol_list(const char *s) bool protover_contains_long_protocol_names(const char *s) { - if (!parse_protocol_list(s)) - return true; - return false; + smartlist_t *list = parse_protocol_list(s); + if (!list) + return true; /* yes, has a dangerous name */ + SMARTLIST_FOREACH(list, proto_entry_t *, ent, proto_entry_free(ent)); + smartlist_free(list); + return false; /* no, looks fine */ } /**

1 0

[tor/master] Merge branch 'maint-0.3.3' into maint-0.3.4
by nickm＠torproject.org 21 Jun '18

21 Jun '18

1 0

[tor/master] fix memory leak in protover.c
by nickm＠torproject.org 21 Jun '18

21 Jun '18

1 0

[tor/release-0.3.3] fix memory leak in protover.c
by nickm＠torproject.org 21 Jun '18

21 Jun '18

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.3' into release-0.3.3
by nickm＠torproject.org 21 Jun '18

21 Jun '18

commit 156e9723bfda28b9cddbc081e80adc75a4c3423e Merge: 8a6e2d5da 7b1a3c516 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 21 08:36:48 2018 -0400 Merge branch 'maint-0.3.3' into release-0.3.3 changes/bug26435 | 5 +++++ src/or/protover.c | 9 ++++++--- 2 files changed, 11 insertions(+), 3 deletions(-)

1 0

[tor/release-0.3.4] fix memory leak in protover.c
by nickm＠torproject.org 21 Jun '18

21 Jun '18

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.3' into maint-0.3.4
by nickm＠torproject.org 21 Jun '18

21 Jun '18

1 0

[tor/master] Merge branch 'maint-0.3.4'
by nickm＠torproject.org 21 Jun '18

21 Jun '18

commit 683776bfab21ec48d967d8589412f81c6b39afe6 Merge: 599b53f04 c389c4129 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 21 08:36:48 2018 -0400 Merge branch 'maint-0.3.4' changes/bug26435 | 5 +++++ src/or/protover.c | 9 ++++++--- 2 files changed, 11 insertions(+), 3 deletions(-)

1 0

[tor/master] add a bn.h include to crypto_dh.c
by nickm＠torproject.org 21 Jun '18

21 Jun '18

commit 599b53f0469e477275d56715ded46b749f5dd06b Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jun 21 08:34:27 2018 -0400 add a bn.h include to crypto_dh.c --- src/common/crypto_dh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/common/crypto_dh.c b/src/common/crypto_dh.c index 4c6b03cee..a9bd348ff 100644 --- a/src/common/crypto_dh.c +++ b/src/common/crypto_dh.c @@ -21,6 +21,8 @@ DISABLE_GCC_WARNING(redundant-decls) ENABLE_GCC_WARNING(redundant-decls) +#include <openssl/bn.h> + #include "common/torlog.h" /** A structure to hold the first half (x, g^x) of a Diffie-Hellman handshake @@ -506,4 +508,3 @@ crypto_dh_free_all(void) dh_param_p = dh_param_p_tls = dh_param_g = NULL; } -

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits June 2018