April 2018 - tor-commits - lists.torproject.org

[tor/master] Merge remote-tracking branch 'fristonio/ticket-25645'
by nickm＠torproject.org 04 Apr '18

04 Apr '18

commit 218b1746baea65c06551f7e2736d382e6a01a49d Merge: 21c81348a 2680a8b5b Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Apr 3 19:19:02 2018 -0400 Merge remote-tracking branch 'fristonio/ticket-25645' changes/ticket25645 | 4 ++++ src/or/channel.c | 4 +--- 2 files changed, 5 insertions(+), 3 deletions(-)

1 0

[tor/release-0.3.3] Bug 21394 touchup: Increase DNS attempts to 3
by nickm＠torproject.org 04 Apr '18

04 Apr '18

commit 06484eb5e19081f478c0c5569e2de6fcfb8d3531 Author: Dhalgren <dhalgren.tor(a)gmail.com> Date: Sun Apr 1 05:01:51 2018 +0000 Bug 21394 touchup: Increase DNS attempts to 3 Also don't give up on a resolver as quickly if multiple are configured. --- changes/bug21394.2 | 7 +++++++ src/or/dns.c | 19 +++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/changes/bug21394.2 b/changes/bug21394.2 new file mode 100644 index 000000000..b580d2a78 --- /dev/null +++ b/changes/bug21394.2 @@ -0,0 +1,7 @@ + o Minor bugfix (Exit node DNS retries): + - Re-attempt timed-out DNS queries 3 times before failure, since our + timeout is 5 seconds for them, but clients wait 10-15. Also allow + slightly more timeouts per resolver before giving up on it in the + case where an exit has multiple resolvers configured. Fixes bug 21394; + bugfix on 0.3.1.9. + diff --git a/src/or/dns.c b/src/or/dns.c index c1e3c3256..33628373d 100644 --- a/src/or/dns.c +++ b/src/or/dns.c @@ -1428,27 +1428,30 @@ configure_nameservers(int force) // If we only have one nameserver, it does not make sense to back off // from it for a timeout. Unfortunately, the value for max-timeouts is // currently clamped by libevent to 255, but it does not hurt to set - // it higher in case libevent gets a patch for this. - // Reducing attempts in the case of just one name server too, because - // it is very likely to be a local one where a network connectivity - // issue should not cause an attempt to fail. + // it higher in case libevent gets a patch for this. Higher-than- + // default maximum of 3 with multiple nameservers to avoid spuriously + // marking one down on bursts of timeouts resulting from scans/attacks + // against non-responding authoritative DNS servers. if (evdns_base_count_nameservers(the_evdns_base) == 1) { SET("max-timeouts:", "1000000"); - SET("attempts:", "1"); } else { - SET("max-timeouts:", "3"); + SET("max-timeouts:", "10"); } // Elongate the queue of maximum inflight dns requests, so if a bunch - // time out at the resolver (happens commonly with unbound) we won't + // remain pending at the resolver (happens commonly with Unbound) we won't // stall every other DNS request. This potentially means some wasted // CPU as there's a walk over a linear queue involved, but this is a // much better tradeoff compared to just failing DNS requests because // of a full queue. SET("max-inflight:", "8192"); - // Time out after 5 seconds if no reply. + // Two retries at 5 and 10 seconds for bind9/named which relies on + // clients to handle retries. Second retry for retried circuits with + // extended 15 second timeout. Superfluous with local-system Unbound + // instance--has its own elaborate retry scheme. SET("timeout:", "5"); + SET("attempts:","3"); if (options->ServerDNSRandomizeCase) SET("randomize-case:", "1");

1 0

[tor/master] Merge branch 'bug21394_029_redux' into maint-0.3.3
by nickm＠torproject.org 04 Apr '18

04 Apr '18

commit ec8ee541296f3ca494421cd8c8f9903e848823ec Merge: 7ccb1c5a8 06484eb5e Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 4 08:55:37 2018 -0400 Merge branch 'bug21394_029_redux' into maint-0.3.3 changes/bug21394.2 | 7 +++++++ src/or/dns.c | 19 +++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-)

1 0

[tor/release-0.3.3] Merge branch 'bug21394_029_redux' into maint-0.3.3
by nickm＠torproject.org 04 Apr '18

04 Apr '18

commit ec8ee541296f3ca494421cd8c8f9903e848823ec Merge: 7ccb1c5a8 06484eb5e Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 4 08:55:37 2018 -0400 Merge branch 'bug21394_029_redux' into maint-0.3.3 changes/bug21394.2 | 7 +++++++ src/or/dns.c | 19 +++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.3.3'
by nickm＠torproject.org 04 Apr '18

04 Apr '18

commit 52846f728d92b44cda1a7cab1bfa53b2450a29b9 Merge: 218b1746b ec8ee5412 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 4 08:57:24 2018 -0400 Merge branch 'maint-0.3.3' changes/bug21394.2 | 7 +++++++ src/or/dns.c | 19 +++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-)

1 0

[tor/release-0.3.3] Merge branch 'maint-0.3.3' into release-0.3.3
by nickm＠torproject.org 04 Apr '18

04 Apr '18

commit 01037c106d3a00614646db0d45a07a925121a07f Merge: 753840a8a ec8ee5412 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Apr 4 08:57:24 2018 -0400 Merge branch 'maint-0.3.3' into release-0.3.3 changes/bug21394.2 | 7 +++++++ src/or/dns.c | 19 +++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-)

1 0

[translation/https_everywhere_completed] Update translations for https_everywhere_completed
by translation＠torproject.org 04 Apr '18

04 Apr '18

commit 7f1fce639974d3cc635ec1e2e7edea64363f65e3 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Apr 4 10:15:52 2018 +0000 Update translations for https_everywhere_completed --- es/https-everywhere.dtd | 2 ++ 1 file changed, 2 insertions(+) diff --git a/es/https-everywhere.dtd b/es/https-everywhere.dtd index 9f8223632..89fb77528 100644 --- a/es/https-everywhere.dtd +++ b/es/https-everywhere.dtd @@ -2,6 +2,7 @@ <!ENTITY https-everywhere.about.ext_name "HTTPS Everywhere"> <!ENTITY https-everywhere.about.ext_description "¡Cifre la Web! Utilice automáticamente la seguridad HTTPS en muchos sitios."> <!ENTITY https-everywhere.about.version "Versión"> +<!ENTITY https-everywhere.about.rulesets_version "Versión de reglas para "> <!ENTITY https-everywhere.about.add_new_rule "Añadir nueva regla"> <!ENTITY https-everywhere.menu.donate_eff_imperative "Donar a EFF"> @@ -14,6 +15,7 @@ <!ENTITY https-everywhere.options.generalSettings "Configuración general"> <!ENTITY https-everywhere.options.importSettings "Importar configuraciones"> <!ENTITY https-everywhere.options.import "Importar"> +<!ENTITY https-everywhere.options.autoUpdateRulesets "Reglas de actualización automática"> <!ENTITY https-everywhere.options.imported "Se ha importado tu configuración"> <!ENTITY https-everywhere.prefs.export_settings "Exportar configuración">

1 0

[translation/https_everywhere] Update translations for https_everywhere
by translation＠torproject.org 04 Apr '18

04 Apr '18

commit 4e81fdc42e3ab9ef29ed77211694fb9c800e3bd6 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Apr 4 10:15:41 2018 +0000 Update translations for https_everywhere --- es/https-everywhere.dtd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/es/https-everywhere.dtd b/es/https-everywhere.dtd index a409b3b4e..89fb77528 100644 --- a/es/https-everywhere.dtd +++ b/es/https-everywhere.dtd @@ -2,7 +2,7 @@ <!ENTITY https-everywhere.about.ext_name "HTTPS Everywhere"> <!ENTITY https-everywhere.about.ext_description "¡Cifre la Web! Utilice automáticamente la seguridad HTTPS en muchos sitios."> <!ENTITY https-everywhere.about.version "Versión"> -<!ENTITY https-everywhere.about.rulesets_version "Rulesets version for "> +<!ENTITY https-everywhere.about.rulesets_version "Versión de reglas para "> <!ENTITY https-everywhere.about.add_new_rule "Añadir nueva regla"> <!ENTITY https-everywhere.menu.donate_eff_imperative "Donar a EFF"> @@ -15,7 +15,7 @@ <!ENTITY https-everywhere.options.generalSettings "Configuración general"> <!ENTITY https-everywhere.options.importSettings "Importar configuraciones"> <!ENTITY https-everywhere.options.import "Importar"> -<!ENTITY https-everywhere.options.autoUpdateRulesets "Auto-update rulesets"> +<!ENTITY https-everywhere.options.autoUpdateRulesets "Reglas de actualización automática"> <!ENTITY https-everywhere.options.imported "Se ha importado tu configuración"> <!ENTITY https-everywhere.prefs.export_settings "Exportar configuración">

1 0

[translation/https_everywhere_completed] Update translations for https_everywhere_completed
by translation＠torproject.org 04 Apr '18

04 Apr '18

commit 6d1f1b0d185a4c775f76a23fba8756d5b4e2769f Author: Translation commit bot <translation(a)torproject.org> Date: Wed Apr 4 09:45:47 2018 +0000 Update translations for https_everywhere_completed --- de/https-everywhere.dtd | 2 ++ 1 file changed, 2 insertions(+) diff --git a/de/https-everywhere.dtd b/de/https-everywhere.dtd index a7532db45..116675bab 100644 --- a/de/https-everywhere.dtd +++ b/de/https-everywhere.dtd @@ -2,6 +2,7 @@ <!ENTITY https-everywhere.about.ext_name "HTTPS Everywhere"> <!ENTITY https-everywhere.about.ext_description "Verschlüsselt das Internet! Nutzen Sie HTTPS-Sicherheit automatisch auf vielen Webseiten."> <!ENTITY https-everywhere.about.version "Version"> +<!ENTITY https-everywhere.about.rulesets_version "Regelsatz Version für"> <!ENTITY https-everywhere.about.add_new_rule "Neue Regel hinzufügen"> <!ENTITY https-everywhere.menu.donate_eff_imperative "Spende an EFF"> @@ -14,6 +15,7 @@ <!ENTITY https-everywhere.options.generalSettings "Allgemeine Einstellungen"> <!ENTITY https-everywhere.options.importSettings "Importeinstellungen"> <!ENTITY https-everywhere.options.import "Import"> +<!ENTITY https-everywhere.options.autoUpdateRulesets "Auto-update Regelsatz"> <!ENTITY https-everywhere.options.imported "Ihre Einstellungen wurden importiert."> <!ENTITY https-everywhere.prefs.export_settings "Einstellungen exportieren">

1 0

[translation/https_everywhere] Update translations for https_everywhere
by translation＠torproject.org 04 Apr '18

04 Apr '18

commit 21b7b88223cd637c31e4cd3d423831272941340f Author: Translation commit bot <translation(a)torproject.org> Date: Wed Apr 4 09:45:38 2018 +0000 Update translations for https_everywhere --- de/https-everywhere.dtd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/de/https-everywhere.dtd b/de/https-everywhere.dtd index 4afdbf5f3..116675bab 100644 --- a/de/https-everywhere.dtd +++ b/de/https-everywhere.dtd @@ -2,7 +2,7 @@ <!ENTITY https-everywhere.about.ext_name "HTTPS Everywhere"> <!ENTITY https-everywhere.about.ext_description "Verschlüsselt das Internet! Nutzen Sie HTTPS-Sicherheit automatisch auf vielen Webseiten."> <!ENTITY https-everywhere.about.version "Version"> -<!ENTITY https-everywhere.about.rulesets_version "Rulesets version for "> +<!ENTITY https-everywhere.about.rulesets_version "Regelsatz Version für"> <!ENTITY https-everywhere.about.add_new_rule "Neue Regel hinzufügen"> <!ENTITY https-everywhere.menu.donate_eff_imperative "Spende an EFF"> @@ -15,7 +15,7 @@ <!ENTITY https-everywhere.options.generalSettings "Allgemeine Einstellungen"> <!ENTITY https-everywhere.options.importSettings "Importeinstellungen"> <!ENTITY https-everywhere.options.import "Import"> -<!ENTITY https-everywhere.options.autoUpdateRulesets "Auto-update rulesets"> +<!ENTITY https-everywhere.options.autoUpdateRulesets "Auto-update Regelsatz"> <!ENTITY https-everywhere.options.imported "Ihre Einstellungen wurden importiert."> <!ENTITY https-everywhere.prefs.export_settings "Einstellungen exportieren">

1 0