tor-commits March 2018

tor-commits@lists.torproject.org

15 participants
1430 discussions

[rbm/master] Bug 25422: Give more details in "Cannot checkout" errors
by gk＠torproject.org 06 Mar '18

06 Mar '18

commit b4c8c38e12d11eb232305949c5d42d5df5e8f5c8 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Mar 5 14:47:03 2018 +0100 Bug 25422: Give more details in "Cannot checkout" errors Print stderr from the git/hg command if the checkout failed. --- lib/RBM.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/RBM.pm b/lib/RBM.pm index 3b19ca9..f987130 100644 --- a/lib/RBM.pm +++ b/lib/RBM.pm @@ -472,7 +472,7 @@ sub execute { git_clone_fetch_chdir($project, $options); my ($stdout, $stderr, $success, $exit_code) = capture_exec('git', 'checkout', $git_hash); - exit_error "Cannot checkout $git_hash" unless $success; + exit_error "Cannot checkout $git_hash:\n$stderr" unless $success; if (project_config($project, 'git_submodule', $options)) { ($stdout, $stderr, $success, $exit_code) = capture_exec('git', 'submodule', 'update', '--init'); @@ -485,7 +485,7 @@ sub execute { hg_clone_fetch_chdir($project, $options); my ($stdout, $stderr, $success, $exit_code) = capture_exec('hg', 'update', '-C', $hg_hash); - exit_error "Cannot checkout $hg_hash" unless $success; + exit_error "Cannot checkout $hg_hash:\n$stderr" unless $success; } my ($stdout, $stderr, $success, $exit_code) = run_script($project, $cmd, \&capture_exec);

1 0

[translation/torbutton-brandproperties] Update translations for torbutton-brandproperties
by translation＠torproject.org 06 Mar '18

06 Mar '18

commit f6682d01f6ffdcf15b72bed79f324bcefe952a28 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 6 12:17:28 2018 +0000 Update translations for torbutton-brandproperties --- mr/brand.properties | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mr/brand.properties b/mr/brand.properties index 732c15741..5c2953446 100644 --- a/mr/brand.properties +++ b/mr/brand.properties @@ -8,9 +8,9 @@ brandFullName=Tor Browser vendorShortName=Tor Project homePageSingleStartMain=Firefox Start, a fast home page with built-in search -homePageImport=Import your home page from %S +homePageImport=% S वरून आपले मुख्यपृष्ठ आयात करा -homePageMigrationPageTitle=Home Page Selection +homePageMigrationPageTitle=मुख्य पृष्ठ निवड homePageMigrationDescription=Please select the home page you wish to use: syncBrandShortName=Sync

1 0

[translation/https_everywhere] Update translations for https_everywhere
by translation＠torproject.org 06 Mar '18

06 Mar '18

commit 2f2da22ecb46a1b85108cd2d9e8cf9b51257efa5 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 6 12:15:38 2018 +0000 Update translations for https_everywhere --- mr/https-everywhere.properties | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mr/https-everywhere.properties b/mr/https-everywhere.properties index c12fb3e37..d6288704c 100644 --- a/mr/https-everywhere.properties +++ b/mr/https-everywhere.properties @@ -1,8 +1,8 @@ https-everywhere.menu.globalEnable = सर्वत्र HTTPS सक्षम करा https-everywhere.menu.globalDisable = सर्वत्र HTTPS अक्षम करा -https-everywhere.menu.enableDisable = Enable / Disable Rules -https-everywhere.menu.noRules = (No Rules for This Page) -https-everywhere.menu.unknownRules = (Rules for This Page Unknown) +https-everywhere.menu.enableDisable = सक्षम / अक्षम करण्याचे नियम +https-everywhere.menu.noRules = (या पृष्ठासाठी कोणतेही नियम नाहीत) +https-everywhere.menu.unknownRules = (या पृष्ठासाठीचे नियम अज्ञात) https-everywhere.toolbar.hint = HTTPS Everywhere is now active. You can toggle it on a site-by-site basis by clicking the icon in the address bar. https-everywhere.migration.notification0 = In order to implement a crucial fix, this update resets your HTTPS Everywhere rule preferences to their default values. -https-everywhere.menu.ruleset-tests = Run HTTPS Everywhere Ruleset Tests +https-everywhere.menu.ruleset-tests = HTTPS ने सर्वत्र नियमपत्रे चालवा

1 0

[snowflake/master] Use Manager.HTTPHandler for automatic TLS support in the server.
by dcf＠torproject.org 06 Mar '18

06 Mar '18

commit d0686b1c8df037413f32bef891ef90638b75a080 Author: David Fifield <david(a)bamsoftware.com> Date: Mon Mar 5 15:25:48 2018 -0800 Use Manager.HTTPHandler for automatic TLS support in the server. As with commit fcc274ac68dcb9063ca631fac9e8905e90088660 for the broker, we need to start using the HTTP-01 challenge type in the Snowflake websocket server transport plugin. https://bugs.torproject.org/25346 --- server/README.md | 13 ++++++------- server/server.go | 41 ++++++++++++++++++----------------------- 2 files changed, 24 insertions(+), 30 deletions(-) diff --git a/server/README.md b/server/README.md index d0fd91d..312a506 100644 --- a/server/README.md +++ b/server/README.md @@ -7,10 +7,10 @@ and the proxy connects to the server (this program) using WebSocket. # Setup -The server needs to be able to listen on port 443 +The server needs to be able to listen on port 80 in order to generate its TLS certificates. On Linux, use the `setcap` program to enable -the server to listen on port 443 without running as root: +the server to listen on port 80 without running as root: ``` setcap 'cap_net_bind_service=+ep' /usr/local/bin/snowflake-server ``` @@ -48,12 +48,11 @@ The server will cache TLS certificate data in the directory `pt_state/snowflake-certificate-cache` inside the tor state directory. In order to fetch certificates automatically, -the server needs to listen on port 443. +the server needs to listen on port 80, +in addition to whatever ports it is listening on +for WebSocket connections. This is a requirement of the ACME protocol used by Let's Encrypt. -If your `ServerTransportListenAddr` is not on port 443, -the server will open an listener on port 443 in addition -to the port you requested. -The program will exit if it can't bind to port 443. +The program will exit if it can't bind to port 80. On Linux, you can use the `setcap` program, part of libcap2, to enable the server to bind to low-numbered ports without having to run as root: diff --git a/server/server.go b/server/server.go index a0ddb3e..5ec3ff9 100644 --- a/server/server.go +++ b/server/server.go @@ -41,8 +41,8 @@ func usage() { WebSocket server pluggable transport for Snowflake. Works only as a managed proxy. Uses TLS with ACME (Let's Encrypt) by default. Set the certificate hostnames with the --acme-hostnames option. Use ServerTransportListenAddr in -torrc to choose the listening port. When using TLS, if the port is not 443, this -program will open an additional listening port on 443 to work with ACME. +torrc to choose the listening port. When using TLS, this program will open an +additional HTTP listener on port 80 to work with ACME. `, os.Args[0]) flag.PrintDefaults() @@ -297,19 +297,11 @@ func main() { } } - // The ACME responder only works when it is running on port 443. In case - // there is not already going to be a TLS listener on port 443, we need - // to open an additional one. The port is actually opened in the loop - // below, so that any errors can be reported in the SMETHOD-ERROR of - // another bindaddr. - // https://letsencrypt.github.io/acme-spec/#domain-validation-with-server-name… - need443Listener := !disableTLS - for _, bindaddr := range ptInfo.Bindaddrs { - if !disableTLS && bindaddr.Addr.Port == 443 { - need443Listener = false - break - } - } + // The ACME HTTP-01 responder only works when it is running on port 80. + // We actually open the port in the loop below, so that any errors can + // be reported in the SMETHOD-ERROR of some bindaddr. + // https://github.com/ietf-wg-acme/acme/blob/master/draft-ietf-acme-acme.md#ht… + needHTTP01Listener := !disableTLS listeners := make([]net.Listener, 0) for _, bindaddr := range ptInfo.Bindaddrs { @@ -318,18 +310,21 @@ func main() { continue } - if need443Listener { + if needHTTP01Listener { addr := *bindaddr.Addr - addr.Port = 443 - log.Printf("opening additional ACME listener on %s", addr.String()) - ln443, err := startListenerTLS("tcp", &addr, certManager) + addr.Port = 80 + log.Printf("Starting HTTP-01 ACME listener") + lnHTTP01, err := net.ListenTCP("tcp", &addr) if err != nil { - log.Printf("error opening ACME listener: %s", err) - pt.SmethodError(bindaddr.MethodName, "ACME listener: "+err.Error()) + log.Printf("error opening HTTP-01 ACME listener: %s", err) + pt.SmethodError(bindaddr.MethodName, "HTTP-01 ACME listener: "+err.Error()) continue } - listeners = append(listeners, ln443) - need443Listener = false + go func() { + log.Fatal(http.Serve(lnHTTP01, certManager.HTTPHandler(nil))) + }() + listeners = append(listeners, lnHTTP01) + needHTTP01Listener = false } var ln net.Listener

1 0

[snowflake/master] Freeze jasmine until tests are updated for newer version
by arlo＠torproject.org 06 Mar '18

06 Mar '18

commit c62111c50792e474ed6ddb7df499d81d79c3f5c5 Author: Arlo Breault <arlolra(a)gmail.com> Date: Mon Mar 5 20:40:21 2018 -0500 Freeze jasmine until tests are updated for newer version --- proxy/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxy/package.json b/proxy/package.json index bdf3bf7..276adcf 100644 --- a/proxy/package.json +++ b/proxy/package.json @@ -22,7 +22,7 @@ "license": "BSD-3-Clause", "devDependencies": { "coffeelint": "^1.16.0", - "jasmine": "^2.5.2", + "jasmine": "2.5.2", "modernizr": "^3.3.1" }, "dependencies": {

1 0

[snowflake/master] Appease go fmt after fcc274a
by arlo＠torproject.org 06 Mar '18

06 Mar '18

commit 10ad59fc9d26900ded6456f50ea6adf4cb58be9d Author: Arlo Breault <arlolra(a)gmail.com> Date: Mon Mar 5 19:34:43 2018 -0500 Appease go fmt after fcc274a --- broker/broker.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/broker/broker.go b/broker/broker.go index a799f29..a41aadb 100644 --- a/broker/broker.go +++ b/broker/broker.go @@ -262,7 +262,7 @@ func main() { } go func() { log.Printf("Starting HTTP-01 listener") - log.Fatal(http.ListenAndServe(":80", certManager.HTTPHandler(nil))) + log.Fatal(http.ListenAndServe(":80", certManager.HTTPHandler(nil))) }() server.TLSConfig = &tls.Config{GetCertificate: certManager.GetCertificate}

1 0

[snowflake/master] Call explicit frees in client
by arlo＠torproject.org 06 Mar '18

06 Mar '18

commit f6301197cc154781cfa96a5255c47c9977887f02 Author: Arlo Breault <arlolra(a)gmail.com> Date: Thu Mar 1 00:14:59 2018 -0500 Call explicit frees in client --- client/webrtc.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/client/webrtc.go b/client/webrtc.go index 0f80678..e35c47d 100644 --- a/client/webrtc.go +++ b/client/webrtc.go @@ -147,7 +147,7 @@ func (c *WebRTCPeer) Connect() error { // Create and prepare callbacks on a new WebRTC PeerConnection. func (c *WebRTCPeer) preparePeerConnection() error { if nil != c.pc { - c.pc.Close() + c.pc.Destroy() c.pc = nil } pc, err := webrtc.NewPeerConnection(c.config) @@ -230,6 +230,7 @@ func (c *WebRTCPeer) establishDataChannel() error { // Disable the DataChannel as a write destination. log.Println("WebRTC: DataChannel.OnClose [remotely]") c.transport = nil + c.pc.DeleteDataChannel(dc) c.Close() } dc.OnMessage = func(msg []byte) { @@ -326,11 +327,14 @@ func (c *WebRTCPeer) cleanup() { // Setting transport to nil *before* dc Close indicates to OnClose that // this was locally triggered. c.transport = nil - dataChannel.Close() + if c.pc == nil { + panic("DataChannel w/o PeerConnection, not good.") + } + c.pc.DeleteDataChannel(dataChannel.(*webrtc.DataChannel)) } if nil != c.pc { log.Printf("WebRTC: closing PeerConnection") - err := c.pc.Close() + err := c.pc.Destroy() if nil != err { log.Printf("Error closing peerconnection...") }

1 0

[translation/tails-greeter-2] Update translations for tails-greeter-2
by translation＠torproject.org 05 Mar '18

05 Mar '18

commit 019099de67ed75a06913ad1c4241c55dd753a84f Author: Translation commit bot <translation(a)torproject.org> Date: Mon Mar 5 23:50:32 2018 +0000 Update translations for tails-greeter-2 --- ti/ti.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ti/ti.po b/ti/ti.po index cc683d19e..f80c2f07c 100644 --- a/ti/ti.po +++ b/ti/ti.po @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2018-01-22 14:15+0100\n" +"POT-Creation-Date: 2018-03-01 20:26+0100\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: Tewelde Tesfagabir <ttesfag(a)voanews.com>, 2018\n" "Language-Team: Tigrinya (https://www.transifex.com/otf/teams/1519/ti/)\n" @@ -35,7 +35,7 @@ msgstr "" #: ../data/greeter.ui.h:4 msgid "Confirm" -msgstr "" +msgstr "ኣረጋግጽ" #: ../data/greeter.ui.h:5 msgid "Confirm your administration password"

1 0

[translation/tor-messenger-fingerdtd] Update translations for tor-messenger-fingerdtd
by translation＠torproject.org 05 Mar '18

05 Mar '18

commit 4f53f396144ef10d3b324ece8f71a50a0bcaf8a8 Author: Translation commit bot <translation(a)torproject.org> Date: Mon Mar 5 23:49:36 2018 +0000 Update translations for tor-messenger-fingerdtd --- ti/finger.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ti/finger.dtd b/ti/finger.dtd index 0595933e2..9701af720 100644 --- a/ti/finger.dtd +++ b/ti/finger.dtd @@ -4,7 +4,7 @@ <!ENTITY finger.verified "Verified"> <!ENTITY finger.fingerprint "Fingerprint"> <!ENTITY finger.account "Account"> -<!ENTITY finger.protocol "Protocol"> +<!ENTITY finger.protocol "ፕሮቶኮል"> <!ENTITY finger.verify "Verify"> <!ENTITY finger.remove "Remove"> <!ENTITY finger.intro "Manage the list of fingerprints you've seen.">

1 0

[translation/tails-misc] Update translations for tails-misc
by translation＠torproject.org 05 Mar '18

05 Mar '18

commit c4c99ed4885e4aa604fc31d59db1e4f5b29c6122 Author: Translation commit bot <translation(a)torproject.org> Date: Mon Mar 5 23:47:05 2018 +0000 Update translations for tails-misc --- ti.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ti.po b/ti.po index f55f9c9a2..a7c2b79a4 100644 --- a/ti.po +++ b/ti.po @@ -8,8 +8,8 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2018-03-01 16:34+0100\n" -"PO-Revision-Date: 2018-03-02 01:37+0000\n" -"Last-Translator: carolyn <carolyn(a)anhalt.org>\n" +"PO-Revision-Date: 2018-03-05 23:32+0000\n" +"Last-Translator: Tewelde Tesfagabir <ttesfag(a)voanews.com>\n" "Language-Team: Tigrinya (http://www.transifex.com/otf/torproject/language/ti/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -205,7 +205,7 @@ msgstr "መሕለፊ" #: config/chroot_local-includes/usr/local/bin/tails-screen-locker:122 msgid "Confirm" -msgstr "" +msgstr "ኣረጋግጽ" #: config/chroot_local-includes/usr/local/bin/tails-screen-locker:155 #: config/chroot_local-includes/usr/local/bin/tor-browser:46

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits March 2018