November 2018 - tor-commits - lists.torproject.org

[tor/master] Test netstatus.c tracking of user participation status
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit 55512ef022de39770e0787e9dfc2e29e762652ae Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 19 15:35:55 2018 -0500 Test netstatus.c tracking of user participation status --- src/core/mainloop/mainloop.c | 4 ++-- src/core/mainloop/mainloop.h | 2 +- src/test/test_mainloop.c | 57 +++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 59 insertions(+), 4 deletions(-) diff --git a/src/core/mainloop/mainloop.c b/src/core/mainloop/mainloop.c index 1bd186d85..331f7021a 100644 --- a/src/core/mainloop/mainloop.c +++ b/src/core/mainloop/mainloop.c @@ -1608,8 +1608,8 @@ rescan_periodic_events_cb(mainloop_event_t *event, void *arg) /** * Schedule an event that will rescan which periodic events should run. **/ -void -schedule_rescan_periodic_events(void) +MOCK_IMPL(void, +schedule_rescan_periodic_events,(void)) { if (!rescan_periodic_events_ev) { rescan_periodic_events_ev = diff --git a/src/core/mainloop/mainloop.h b/src/core/mainloop/mainloop.h index 7f27ef9a5..e5e730fc8 100644 --- a/src/core/mainloop/mainloop.h +++ b/src/core/mainloop/mainloop.h @@ -65,7 +65,7 @@ void reschedule_or_state_save(void); void reschedule_dirvote(const or_options_t *options); void mainloop_schedule_postloop_cleanup(void); void rescan_periodic_events(const or_options_t *options); -void schedule_rescan_periodic_events(void); +MOCK_DECL(void, schedule_rescan_periodic_events,(void)); void update_current_time(time_t now); diff --git a/src/test/test_mainloop.c b/src/test/test_mainloop.c index 92ce2e991..94b684fb3 100644 --- a/src/test/test_mainloop.c +++ b/src/test/test_mainloop.c @@ -11,6 +11,7 @@ #include "core/or/or.h" #include "core/mainloop/mainloop.h" +#include "core/mainloop/netstatus.h" static const uint64_t BILLION = 1000000000; @@ -131,12 +132,66 @@ test_mainloop_update_time_jumps(void *arg) monotime_disable_test_mocking(); } +static int schedule_rescan_called = 0; +static void +mock_schedule_rescan_periodic_events(void) +{ + ++schedule_rescan_called; +} + +static void +test_mainloop_user_activity(void *arg) +{ + (void)arg; + const time_t start = 1542658829; + update_approx_time(start); + + MOCK(schedule_rescan_periodic_events, mock_schedule_rescan_periodic_events); + + reset_user_activity(start); + tt_i64_op(get_last_user_activity_time(), OP_EQ, start); + + set_network_participation(false); + + // reset can move backwards and forwards, but does not change network + // participation. + reset_user_activity(start-10); + tt_i64_op(get_last_user_activity_time(), OP_EQ, start-10); + reset_user_activity(start+10); + tt_i64_op(get_last_user_activity_time(), OP_EQ, start+10); + + tt_int_op(schedule_rescan_called, OP_EQ, 0); + tt_int_op(false, OP_EQ, is_participating_on_network()); + + // "note" can only move forward. Calling it from a non-participating + // state makes us rescan the periodic callbacks and set participation. + note_user_activity(start+20); + tt_i64_op(get_last_user_activity_time(), OP_EQ, start+20); + tt_int_op(true, OP_EQ, is_participating_on_network()); + tt_int_op(schedule_rescan_called, OP_EQ, 1); + + // Calling it again will move us forward, but not call rescan again. + note_user_activity(start+25); + tt_i64_op(get_last_user_activity_time(), OP_EQ, start+25); + tt_int_op(true, OP_EQ, is_participating_on_network()); + tt_int_op(schedule_rescan_called, OP_EQ, 1); + + // We won't move backwards. + note_user_activity(start+20); + tt_i64_op(get_last_user_activity_time(), OP_EQ, start+25); + tt_int_op(true, OP_EQ, is_participating_on_network()); + tt_int_op(schedule_rescan_called, OP_EQ, 1); + + done: + UNMOCK(schedule_rescan_periodic_events); +} + #define MAINLOOP_TEST(name) \ { #name, test_mainloop_## name , TT_FORK, NULL, NULL } struct testcase_t mainloop_tests[] = { MAINLOOP_TEST(update_time_normal), MAINLOOP_TEST(update_time_jumps), + MAINLOOP_TEST(user_activity), END_OF_TESTCASES }; -

1 0

[tor/master] Add options to control dormant-client feature.
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit 3743f7969587079a2f2bb03d0b7e5038557fd64a Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Nov 15 13:16:58 2018 -0500 Add options to control dormant-client feature. The DormantClientTimeout option controls how long Tor will wait before going dormant. It also provides a way to disable the feature by setting DormantClientTimeout to e.g. "50 years". The DormantTimeoutDisabledByIdleStreams option controls whether open but inactive streams count as "client activity". To implement it, I had to make it so that reading or writing on a client stream *always* counts as activity. Closes ticket 28429. --- doc/tor.1.txt | 13 +++++++++++++ src/app/config/config.c | 6 ++++++ src/app/config/or_options_st.h | 10 ++++++++++ src/core/mainloop/mainloop.c | 19 ++++++++++--------- src/core/or/connection_edge.c | 11 +++++++++++ src/test/test_options.c | 1 + 6 files changed, 51 insertions(+), 9 deletions(-) diff --git a/doc/tor.1.txt b/doc/tor.1.txt index b147ad68a..47bddea09 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -1789,6 +1789,19 @@ The following options are useful only for clients (that is, if Try this many simultaneous connections to download a consensus before waiting for one to complete, timeout, or error out. (Default: 3) +[[DormantClientTimeout]] **DormantClientTimeout** __N__ **minutes**|**hours**|**days**|**weeks**:: + If Tor spends this much time without any client activity, + enter a dormant state where automatic circuits are not built, and + directory information is not fetched. + Does not affect servers or onion services. Must be at least 10 minutes. + (Default: 24 hours) + +[[DormantTimeoutDisabledByIdleStreams]] **DormantTimeoutDisabledByIdleStreams **0**|**1**:: + If true, then any open client stream (even one not reading or writing) + counts as client activity for the purpose of DormantClientTimeout. + If false, then only network activity counts. (Default: 1) + + SERVER OPTIONS -------------- diff --git a/src/app/config/config.c b/src/app/config/config.c index 8aa0c1f4b..90eae50fd 100644 --- a/src/app/config/config.c +++ b/src/app/config/config.c @@ -389,6 +389,8 @@ static config_var_t option_vars_[] = { OBSOLETE("DynamicDHGroups"), VPORT(DNSPort), OBSOLETE("DNSListenAddress"), + V(DormantClientTimeout, INTERVAL, "24 hours"), + V(DormantTimeoutDisabledByIdleStreams, BOOL, "1"), /* DoS circuit creation options. */ V(DoSCircuitCreationEnabled, AUTOBOOL, "auto"), V(DoSCircuitCreationMinConnections, UINT, "0"), @@ -3836,6 +3838,10 @@ options_validate(or_options_t *old_options, or_options_t *options, "default."); } + if (options->DormantClientTimeout < 10*60 && !options->TestingTorNetwork) { + REJECT("DormantClientTimeout is too low. It must be at least 10 minutes."); + } + if (options->PathBiasNoticeRate > 1.0) { tor_asprintf(msg, "PathBiasNoticeRate is too high. " diff --git a/src/app/config/or_options_st.h b/src/app/config/or_options_st.h index 3524b99b5..6cbc86ec1 100644 --- a/src/app/config/or_options_st.h +++ b/src/app/config/or_options_st.h @@ -1072,6 +1072,16 @@ struct or_options_t { /** Autobool: Do we refuse single hop client rendezvous? */ int DoSRefuseSingleHopClientRendezvous; + + /** Interval: how long without activity does it take for a client + * to become dormant? + **/ + int DormantClientTimeout; + + /** Boolean: true if having an idle stream is sufficient to prevent a client + * from becoming dormant. + **/ + int DormantTimeoutDisabledByIdleStreams; }; #endif diff --git a/src/core/mainloop/mainloop.c b/src/core/mainloop/mainloop.c index 2d12e2648..1bd186d85 100644 --- a/src/core/mainloop/mainloop.c +++ b/src/core/mainloop/mainloop.c @@ -2018,24 +2018,25 @@ check_network_participation_callback(time_t now, const or_options_t *options) goto found_activity; } - /* XXXX Add an option to never become dormant. */ - /* If we have any currently open entry streams other than "linked" * connections used for directory requests, those count as user activity. */ - /* XXXX make this configurable? */ - if (connection_get_by_type_nonlinked(CONN_TYPE_AP) != NULL) { - goto found_activity; + if (options->DormantTimeoutDisabledByIdleStreams) { + if (connection_get_by_type_nonlinked(CONN_TYPE_AP) != NULL) { + goto found_activity; + } } /* XXXX Make this configurable? */ /** How often do we check whether we have had network activity? */ #define CHECK_PARTICIPATION_INTERVAL (5*60) - /** Become dormant if there has been no user activity in this long. */ - /* XXXX make this configurable! */ -#define BECOME_DORMANT_AFTER_INACTIVITY (24*60*60) - if (get_last_user_activity_time() + BECOME_DORMANT_AFTER_INACTIVITY >= now) { + /* Become dormant if there has been no user activity in a long time. + * (The funny checks below are in order to prevent overflow.) */ + time_t time_since_last_activity = 0; + if (get_last_user_activity_time() < now) + time_since_last_activity = now - get_last_user_activity_time(); + if (time_since_last_activity >= options->DormantClientTimeout) { log_notice(LD_GENERAL, "No user activity in a long time: becoming" " dormant."); set_network_participation(false); diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index 58aefcf8f..7b51313e8 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -62,6 +62,7 @@ #include "app/config/config.h" #include "core/mainloop/connection.h" #include "core/mainloop/mainloop.h" +#include "core/mainloop/netstatus.h" #include "core/or/channel.h" #include "core/or/circuitbuild.h" #include "core/or/circuitlist.h" @@ -297,6 +298,11 @@ connection_edge_process_inbuf(edge_connection_t *conn, int package_partial) } return 0; case AP_CONN_STATE_OPEN: + if (! conn->base_.linked) { + note_user_activity(approx_time()); + } + + /* falls through. */ case EXIT_CONN_STATE_OPEN: if (connection_edge_package_raw_inbuf(conn, package_partial, NULL) < 0) { /* (We already sent an end cell if possible) */ @@ -751,6 +757,11 @@ connection_edge_flushed_some(edge_connection_t *conn) { switch (conn->base_.state) { case AP_CONN_STATE_OPEN: + if (! conn->base_.linked) { + note_user_activity(approx_time()); + } + + /* falls through. */ case EXIT_CONN_STATE_OPEN: connection_edge_consider_sending_sendme(conn); break; diff --git a/src/test/test_options.c b/src/test/test_options.c index f14e620ee..376d77626 100644 --- a/src/test/test_options.c +++ b/src/test/test_options.c @@ -425,6 +425,7 @@ get_options_test_data(const char *conf) // with options_init(), but about a dozen tests break when I do that. // Being kinda lame and just fixing the immedate breakage for now.. result->opt->ConnectionPadding = -1; // default must be "auto" + result->opt->DormantClientTimeout = 1800; // must be over 600. rv = config_get_lines(conf, &cl, 1); tt_int_op(rv, OP_EQ, 0);

1 0

[stem/master] Use newer cached microdescriptors if available
by atagar＠torproject.org 26 Nov '18

26 Nov '18

commit ddb1a360dac0a22c084e884f10c1bc7327cf7f7d Author: Damian Johnson <atagar(a)torproject.org> Date: Mon Nov 26 13:04:23 2018 -0800 Use newer cached microdescriptors if available Our data directory has up to two microdescriptor files: cached-microdescs and cached-microdescs.new. If the former is unavailable but the later is present we should use it... https://trac.torproject.org/projects/tor/ticket/28508 Maybe more important, when looking into this I realized that our attempt to get tor's data directory stacktraces if not explicitly present in the torrc... >>> list(controller.get_microdescriptors()) Traceback (most recent call last): File "<console>", line 1, in <module> File "/home/atagar/Desktop/stem/stem/control.py", line 490, in wrapped for val in func(self, *args, **kwargs): File "/home/atagar/Desktop/stem/stem/control.py", line 1791, in get_microdescriptors if not os.path.exists(data_directory): File "/usr/lib/python2.7/genericpath.py", line 26, in exists os.stat(path) TypeError: coercing to Unicode: need string or buffer, NoneType found Changed it so we'll instead provide a generic exception saying we were unable to determine the data directory. Fortunatley this whole thing is a fallback, so eventually we'll be able to remove it. --- stem/control.py | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/stem/control.py b/stem/control.py index 68873d76..6d926ff0 100644 --- a/stem/control.py +++ b/stem/control.py @@ -1783,27 +1783,34 @@ class Controller(BaseController): else: # TODO: remove when tor versions that require this are obsolete - try: - data_directory = self.get_conf('DataDirectory') - except stem.ControllerError as exc: - raise stem.OperationFailed(message = 'Unable to determine the data directory (%s)' % exc) + data_directory = self.get_conf('DataDirectory', None) - cached_descriptor_path = os.path.join(data_directory, 'cached-microdescs') + if data_directory is None: + raise stem.OperationFailed(message = "Unable to determine tor's data directory") if not os.path.exists(data_directory): raise stem.OperationFailed(message = "Data directory reported by tor doesn't exist (%s)" % data_directory) - elif not os.path.exists(cached_descriptor_path): - raise stem.OperationFailed(message = "Data directory doesn't contain cached microdescriptors (%s)" % cached_descriptor_path) - with stem.descriptor.reader.DescriptorReader([cached_descriptor_path]) as reader: - for desc in reader: - # It shouldn't be possible for these to be something other than - # microdescriptors but as the saying goes: trust but verify. + microdescriptor_file = None + + for filename in ('cached-microdescs', 'cached-microdescs.new'): + cached_descriptors = os.path.join(data_directory, filename) + + if os.path.exists(cached_descriptors): + microdescriptor_file = cached_descriptors + break + + if microdescriptor_file is None: + raise stem.OperationFailed(message = "Data directory doesn't contain cached microdescriptors (%s)" % data_directory) - if not isinstance(desc, stem.descriptor.microdescriptor.Microdescriptor): - raise stem.OperationFailed(message = 'BUG: Descriptor reader provided non-microdescriptor content (%s)' % type(desc)) + for desc in stem.descriptor.parse_file(microdescriptor_file): + # It shouldn't be possible for these to be something other than + # microdescriptors but as the saying goes: trust but verify. - yield desc + if not isinstance(desc, stem.descriptor.microdescriptor.Microdescriptor): + raise stem.OperationFailed(message = 'BUG: Descriptor reader provided non-microdescriptor content (%s)' % type(desc)) + + yield desc @with_default() def get_server_descriptor(self, relay = None, default = UNDEFINED):

1 0

[translation/donatepages-messagespot] Update translations for donatepages-messagespot
by translation＠torproject.org 26 Nov '18

26 Nov '18

commit f38b487d512e1b702d039ccbe73af1061c09035e Author: Translation commit bot <translation(a)torproject.org> Date: Mon Nov 26 20:45:21 2018 +0000 Update translations for donatepages-messagespot --- locale/fr/LC_MESSAGES/messages.po | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/locale/fr/LC_MESSAGES/messages.po b/locale/fr/LC_MESSAGES/messages.po index 5f2ae5ebc..2a1cf5b0d 100644 --- a/locale/fr/LC_MESSAGES/messages.po +++ b/locale/fr/LC_MESSAGES/messages.po @@ -264,8 +264,8 @@ msgid "" "This page requires Javascript to do PayPal or credit card\n" " donations, but it appears you have Javascript disabled." msgstr "" -"Cette page nécessite Javascript pour faire PayPal ou carte de crédit\n" -"mais il semble que vous ayez désactivé Javascript." +"JavaScript est exigé par cette page pour les dons par PayPal\n" +" ou par carte de crédit, mais il semble que JavaScript est désactivé." #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:106 msgid "" @@ -273,9 +273,9 @@ msgid "" " <a href=\"https://www.torproject.org/donate/donate-options.html.en\">other " "donations options page</a>." msgstr "" -"Si vous souhaitez faire un don sans activer Javascript, veuillez jeter un " -"coup d’oeil à notre <a href=\"https://www.torproject.org/donate/donate-" -"options.html.en\">page d’autres options de dons</a>." +"Si vous souhaitez faire un don sans activer JavaScript, veuillez consulter " +"notre <a href=\"https://www.torproject.org/donate/donate-" +"options.html.en\">page sur les autres options de don</a>." #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:123 msgid "Number of Donations" @@ -287,7 +287,7 @@ msgstr "Total des dons" #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:155 msgid "Total Raised with Mozilla's Match" -msgstr "Total élevé avec le Match de Mozilla" +msgstr "Total accumulé avec l’équivalence de don de Mozilla" #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:163 #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:169 @@ -305,23 +305,24 @@ msgstr "mensuel" #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:178 #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:331 msgid "Want to donate Bitcoin, Stock, or via snail mail?" -msgstr "Vous voulez faire un don de Bitcoin, Stock, ou par la poste ?" +msgstr "" +"Voulez-vous faire un don en bitcoins, en actions, ou par courrier escargot ?" #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:193 msgid "invalid amount" -msgstr "montant non valide" +msgstr "le montant est invalide" #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:197 msgid "$2 minimum donation" -msgstr "Don minimum de 2 $." +msgstr "Don minimal de 2 $" #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:201 msgid "$ other" -msgstr "autres ($)" +msgstr "Autre montant" #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:208 msgid "Choose your gift as a token of our thanks." -msgstr "Choisissez votre cadeau en guise de remerciement." +msgstr "Choisissez votre cadeau, en témoignage de notre reconnaissance." #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:215 msgid "No thanks, I don't want a gift."

1 0

[translation/donatepages-messagespot] Update translations for donatepages-messagespot
by translation＠torproject.org 26 Nov '18

26 Nov '18

commit 5a807961362be9fa1640f4b53a899f06fc8f81b2 Author: Translation commit bot <translation(a)torproject.org> Date: Mon Nov 26 20:15:22 2018 +0000 Update translations for donatepages-messagespot --- locale/fr/LC_MESSAGES/messages.po | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/locale/fr/LC_MESSAGES/messages.po b/locale/fr/LC_MESSAGES/messages.po index 5bcb9bd34..5f2ae5ebc 100644 --- a/locale/fr/LC_MESSAGES/messages.po +++ b/locale/fr/LC_MESSAGES/messages.po @@ -178,8 +178,8 @@ msgid "" "The European shirt fits run a little small so you might want to consider " "sizing up." msgstr "" -"La chemise européenne est un peu petite, vous devriez donc envisager de la " -"mettre à votre taille." +"Le tee-shirt européen taille un peu petit. Vous pourriez donc envisager une " +"taille plus grande qu’habituellement." #: tmp/cache_locale/ce/ce708c1cd991748e8c1c29f932e6ddbd1be5be1b4cc2c5b49b607cae1df80432.php:36 msgid "Fit" @@ -187,15 +187,15 @@ msgstr "Taille" #: tmp/cache_locale/ce/ce708c1cd991748e8c1c29f932e6ddbd1be5be1b4cc2c5b49b607cae1df80432.php:40 msgid "Select Fit" -msgstr "Choisissez la taille" +msgstr "Choisir l’ajustement" #: tmp/cache_locale/ce/ce708c1cd991748e8c1c29f932e6ddbd1be5be1b4cc2c5b49b607cae1df80432.php:44 msgid "Slim" -msgstr "Slim" +msgstr "Ajusté" #: tmp/cache_locale/ce/ce708c1cd991748e8c1c29f932e6ddbd1be5be1b4cc2c5b49b607cae1df80432.php:48 msgid "Classic" -msgstr "Classic" +msgstr "Classique" #: tmp/cache_locale/ce/ce708c1cd991748e8c1c29f932e6ddbd1be5be1b4cc2c5b49b607cae1df80432.php:56 msgid "European" @@ -253,7 +253,7 @@ msgstr "L’anonymat est contagieux." #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:63 msgid "summary_large_image" -msgstr "summary_large_image" +msgstr "résumé_grande_image" #: tmp/cache_locale/c7/c763c19bb6abb9330294c550c8241bb3874e3b4e17fb6e7b15db26c60df8d5fe.php:67 msgid "@torproject"

1 0

[tor/maint-0.3.5] Merge remote-tracking branch 'dgoulet/ticket28128_035_01' into maint-0.3.5
by dgoulet＠torproject.org 26 Nov '18

26 Nov '18

commit 056ffdec4cd10aac964ca354115ef806869afe81 Merge: a9820f072 f41bec129 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Nov 26 14:59:10 2018 -0500 Merge remote-tracking branch 'dgoulet/ticket28128_035_01' into maint-0.3.5 changes/ticket28128 | 4 ++++ doc/tor.1.txt | 1 + 2 files changed, 5 insertions(+)

1 0

[tor/master] man: ClientOnionAuthDir can't be reloaded with Sandbox 1
by dgoulet＠torproject.org 26 Nov '18

26 Nov '18

commit f41bec12904d429c17c64eafeb7a3a92a81e614e Author: David Goulet <dgoulet(a)torproject.org> Date: Thu Nov 15 14:36:39 2018 -0500 man: ClientOnionAuthDir can't be reloaded with Sandbox 1 By adding a file to the ClientOnionAuthDir and sending a HUP signal, tor would load the new file and use it. However, that doesn't work with the Sandbox since post initilization, nothing can be changed. Document in the manpage that limitation within the Sandbox description. Closes #28128 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket28128 | 4 ++++ doc/tor.1.txt | 1 + 2 files changed, 5 insertions(+) diff --git a/changes/ticket28128 b/changes/ticket28128 new file mode 100644 index 000000000..6d08c7424 --- /dev/null +++ b/changes/ticket28128 @@ -0,0 +1,4 @@ + o Documentation (hidden service manpage, sandbox): + - Document in the man page that changing ClientOnionAuthDir value or + adding a new file in the directory will not work at runtime upon sending + a HUP if Sandbox 1. Closes ticket 28128. diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 019c8af75..097db065b 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -611,6 +611,7 @@ GENERAL OPTIONS ServerDNSResolvConfFile Tor must remain in client or server mode (some changes to ClientOnly and ORPort are not allowed). + ClientOnionAuthDir and any files in it won't reload on HUP signal. (Default: 0) [[Socks4Proxy]] **Socks4Proxy** __host__[:__port__]::

1 0

[tor/maint-0.3.5] man: ClientOnionAuthDir can't be reloaded with Sandbox 1
by dgoulet＠torproject.org 26 Nov '18

26 Nov '18

commit f41bec12904d429c17c64eafeb7a3a92a81e614e Author: David Goulet <dgoulet(a)torproject.org> Date: Thu Nov 15 14:36:39 2018 -0500 man: ClientOnionAuthDir can't be reloaded with Sandbox 1 By adding a file to the ClientOnionAuthDir and sending a HUP signal, tor would load the new file and use it. However, that doesn't work with the Sandbox since post initilization, nothing can be changed. Document in the manpage that limitation within the Sandbox description. Closes #28128 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket28128 | 4 ++++ doc/tor.1.txt | 1 + 2 files changed, 5 insertions(+) diff --git a/changes/ticket28128 b/changes/ticket28128 new file mode 100644 index 000000000..6d08c7424 --- /dev/null +++ b/changes/ticket28128 @@ -0,0 +1,4 @@ + o Documentation (hidden service manpage, sandbox): + - Document in the man page that changing ClientOnionAuthDir value or + adding a new file in the directory will not work at runtime upon sending + a HUP if Sandbox 1. Closes ticket 28128. diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 019c8af75..097db065b 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -611,6 +611,7 @@ GENERAL OPTIONS ServerDNSResolvConfFile Tor must remain in client or server mode (some changes to ClientOnly and ORPort are not allowed). + ClientOnionAuthDir and any files in it won't reload on HUP signal. (Default: 0) [[Socks4Proxy]] **Socks4Proxy** __host__[:__port__]::

1 0

[tor/master] Merge branch 'maint-0.3.5'
by dgoulet＠torproject.org 26 Nov '18

26 Nov '18

commit 2b9a907bdccc588203d2110866d4e7bb72a25773 Merge: 3741f9e52 056ffdec4 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Nov 26 14:59:24 2018 -0500 Merge branch 'maint-0.3.5' changes/ticket28128 | 4 ++++ doc/tor.1.txt | 1 + 2 files changed, 5 insertions(+)

1 0

[tor/master] Merge remote-tracking branch 'dgoulet/ticket28128_035_01' into maint-0.3.5
by dgoulet＠torproject.org 26 Nov '18

26 Nov '18

commit 056ffdec4cd10aac964ca354115ef806869afe81 Merge: a9820f072 f41bec129 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Nov 26 14:59:10 2018 -0500 Merge remote-tracking branch 'dgoulet/ticket28128_035_01' into maint-0.3.5 changes/ticket28128 | 4 ++++ doc/tor.1.txt | 1 + 2 files changed, 5 insertions(+)

1 0